From nobody Sun Feb 8 23:26:47 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1762857173; cv=none; d=zohomail.com; s=zohoarc; b=NUySCMVMK9lda+Fx21O5oNnyaPSjuKsq2nhwtGPSMXm0GAc2VSPLHAIS35wHcsx1kgKCzTBtBiriByAUNSztmNYtZEs18+bksb8ZrMDU1BhDT1n9gHiEuCD2r8mYVFsBNtuK4jeJn12Nttao5CCHM7aDjw+6H1XedBdxH80vl0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762857173; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=a2R3zKrQT8zFcXqdr8zmnfkYZDb9c7Kd8HiPSpJXcco=; b=fTURQi4y/D/4ouM0Fdve2c4IG+Asa4RuWG8FesmyaVQVnKkPkXpaMt68iPACUjuEZYpaH1f0GLeD+uVxJcTVmJrWW+KU5XlyfvhulBd6HdI/Fb26x+Q0cb96V/meKc2KlIjKJCZAxGxcBcp0XoHM/uJ6Am9lohK9dt6tn6OMvoI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176285717386179.45504838797376; Tue, 11 Nov 2025 02:32:53 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIlci-0008Ow-7q; Tue, 11 Nov 2025 05:29:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIlcL-0007dD-Hb for qemu-devel@nongnu.org; Tue, 11 Nov 2025 05:28:53 -0500 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vIlcH-0000HZ-4Q for qemu-devel@nongnu.org; Tue, 11 Nov 2025 05:28:52 -0500 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-b73161849e1so328359766b.2 for ; Tue, 11 Nov 2025 02:28:46 -0800 (PST) Received: from PC-DA2D10.beckhoff.com ([2001:9e8:dc12:ce00:ae91:a1ff:fe8b:15a7]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b72bdbd1ecfsm1290619366b.10.2025.11.11.02.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Nov 2025 02:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762856925; x=1763461725; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a2R3zKrQT8zFcXqdr8zmnfkYZDb9c7Kd8HiPSpJXcco=; b=cjaDFLIRMQTtdcakvbCXnTNix97XOywezGK3hBpuokwl5bm/GgfJCDHacxqarSnsIO CUeO12DUidZcWzRCkEkTSXRJ3Y0IcU27ZEZA1q80hdTnAe5HVnpWSysZdCuebZxP4Wt2 er9HiG+cxBNJQ9om+fTllyq4ZFgVu5NtIqJcstIZ2t0K8KmZOYK3xT98grJHLpjoNc/Y KVFIwWjmm/IhBRT9uOqTE6Sw8pBhkqMuiwKBqln+4MwQfZgIaaJFhCX3PczXvYtLz+3w VLN8W0Leq/CIeDOkb1M/HMDIb8SKX/vVKVhBYlGEdWSsxieIo+pFEKBAy6E95bjef14i 7dNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762856925; x=1763461725; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=a2R3zKrQT8zFcXqdr8zmnfkYZDb9c7Kd8HiPSpJXcco=; b=wzfh76aO1KGoBD0h+E8Q+q3GRAobeG/suUKCoUpnuXmK2LEab9bmDey2U04Tv2em8A 7sW4AVHf/clGk/cpHg4y20DrFgl9iIywJWB6xf7DpGYSetYg8rLPL5iyle4jh8b4kged BApxKLBCLj2ErQ72DU9AH27D/+WDD7b7UHapQMl/2O5EIrdszOIRRZ9uiFWkEDkFU+3K 2kZmcjXZwmQ5ppzlVCdNwBIx6nrzS0xAT41uW0ZeAqRCcJPoQTtaVjQxkm+C4PjpsB3p 6mrCNlr5gwWMrlm8snNtd9uZ7xt6AvXnRrY8VEiBYKgbiSin6sla76PgD83mmtmd7X36 0zkw== X-Gm-Message-State: AOJu0YyJfoKIvqo8fXLjjAAK50zXB0P9WEBxis7pFVeZYykrlyd/e9R0 RTOoJue6hfLjWaPXsYIymXEjnv9tHJGVHhKZ0M8/Ad+QnMI+myDF60u3OauJZM4Y X-Gm-Gg: ASbGncv3SALXVfLXPC2f9gUrCDaGUD3DBpwkJwvtYFepnaZ0KnV3k0XPM9BL6iUdItE 6Ub5wwhoEL0zTZDlGtLOAErcG1D2CwtartZ3lfPFW7gYT9a+AIB1QT35pcEtzt8N3b4tNqWgqZD aeW1mKsTBUHs76WfpTXuEd8cP2XjPFqoHq0lsnFHF8re324mKnXhusYUXdM1ouj6Sji5DFC5yHl wsWdBxhGrXHf0lgG7YgZXfdQFVdSt0IpEk0+QismxL8ex63kaQRFaNHbF9t4nWAUtOjEjQ6T4kX jhR9vsFxGSS+r6h+DaToYuCgJZlXmhjXXiTcmKloiqvelIBgxnqopS9HXRKN6prUIHzXXvhAItF zhNce9SPg3ff/8bBRyMSbJ1bnA0g0JTiaSpvNXsTNy1JEz3XyuPaQpQuAkHZtpzj8EGio6uH6cx HKYyUMPu0+anSPGYTLNpNHEw== X-Google-Smtp-Source: AGHT+IFo8fxqj1exL4ue3grGneT6lvsp7VEqKFt+Cv/hUix1gwdWzS9XnInAcAemmSZKksNl7CXiRg== X-Received: by 2002:a17:906:f590:b0:b71:cec2:d54 with SMTP id a640c23a62f3a-b72e04e4ebemr1208186166b.57.1762856925194; Tue, 11 Nov 2025 02:28:45 -0800 (PST) From: =?UTF-8?q?Corvin=20K=C3=B6hne?= To: qemu-devel@nongnu.org Cc: Peter Maydell , =?UTF-8?q?Yannick=20Vo=C3=9Fen?= , qemu-block@nongnu.org, Paolo Bonzini , Hanna Reitz , Alistair Francis , qemu-arm@nongnu.org, =?UTF-8?q?Corvin=20K=C3=B6hne?= , Kevin Wolf , "Edgar E. Iglesias" , YannickV , "Edgar E. Iglesias" Subject: [PATCH v4 08/15] hw/dma/zynq-devcfg: Fix register memory Date: Tue, 11 Nov 2025 11:28:29 +0100 Message-ID: <20251111102836.212535-9-corvin.koehne@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251111102836.212535-1-corvin.koehne@gmail.com> References: <20251111102836.212535-1-corvin.koehne@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62c; envelope-from=corvin.koehne@gmail.com; helo=mail-ej1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1762857176622153000 Content-Type: text/plain; charset="utf-8" From: YannickV Registers are always 32 bit aligned. R_MAX is not the maximum register address, it is the maximum register number. The memory size can be determined by 4 * R_MAX. Currently every register with an offset bigger than 0x40 will be ignored, because the memory size is set wrong. This effects the MCTRL register and makes it useless. This commit restores the correct behaviour. Signed-off-by: YannickV Reviewed-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/dma/xlnx-zynq-devcfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c index 512a33b066..abb8c419d9 100644 --- a/hw/dma/xlnx-zynq-devcfg.c +++ b/hw/dma/xlnx-zynq-devcfg.c @@ -393,7 +393,7 @@ static void xlnx_zynq_devcfg_init(Object *obj) s->regs_info, s->regs, &xlnx_zynq_devcfg_reg_ops, XLNX_ZYNQ_DEVCFG_ERR_DEBUG, - XLNX_ZYNQ_DEVCFG_R_MAX); + XLNX_ZYNQ_DEVCFG_R_MAX * 4); memory_region_add_subregion(&s->iomem, A_CTRL, ®_array->mem); --=20 2.47.3