From nobody Sun Dec 14 06:40:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1762774337; cv=none; d=zohomail.com; s=zohoarc; b=RaD+NGOemxbbJy9vwdN5C9SzM8jm1tOYc87t818rxxFzLnctXdns/oBrJz4mIcbPcjFzmcvuaDh3KYoU4whh/UHqbCiR5hBsqYvPQdLc2v2BiCdY7+6IR62g96uk3yvtRM1stqm/khUudp2PFRZTnc4+AokTE/1Rbe3R7MPyuiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762774337; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7YLfkVi5M5AkSw/2s5VwSvjNTs56k54sKTHppQSSpW4=; b=g3jvlJnn9TIXCU2FrqAXfUDMt77bbWnP7HDcdmG7yzUIE1REcAD50kgEIivWKqBo/8PAEQiHNtHz0R/xptNRwmp1hvGG+nO/y71qIHZjw+SJNFK9udax1KqmhtvAwQNkNYN9UsAUFaE5f2k6nS1PrzZeLRAs/h9IkiF+LxiLgAQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762774337369613.9383999426168; Mon, 10 Nov 2025 03:32:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIQ7u-0003Mi-St; Mon, 10 Nov 2025 06:32:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIPnU-0004uR-Qf for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:10:57 -0500 Received: from mail-oi1-x235.google.com ([2607:f8b0:4864:20::235]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vIPnT-0004KH-A4 for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:10:56 -0500 Received: by mail-oi1-x235.google.com with SMTP id 5614622812f47-44fff8c46bbso413232b6e.1 for ; Mon, 10 Nov 2025 03:10:54 -0800 (PST) Received: from stoup.. ([172.58.183.226]) by smtp.gmail.com with ESMTPSA id 5614622812f47-450426be56dsm1603412b6e.18.2025.11.10.03.10.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 03:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762773053; x=1763377853; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7YLfkVi5M5AkSw/2s5VwSvjNTs56k54sKTHppQSSpW4=; b=o4U3DV/04E2/VFk2cSRKuFFplR8C/n4LZLMZaZdykKqM1S0P1lXTPRl2TcCROKLREQ XeAi3+ikNKfMd1hJbKSt2E7c3mv6k639rxoT0nCt+df6ESufOXWGaCBIP3ay0zUYGcsg R2xlWKbyW7Rysyba03U79O07sohMUU9UO0jOQqy3P7+FizQiiCf12jkuYqlZ2MxHQ5cz NlqZAzhOw5Zu45oKZlz/9qtkkQJR89DDuvBIobpBm+wLwLkRQOqn1mYYjclTtMgS/UcT xuUM678UGHiKqkgK+OlHm9G4EZ2RvUBHeLpzJJDv/hYTpeyy8ZESQpPl9wotfBGBI8E9 tJrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762773053; x=1763377853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7YLfkVi5M5AkSw/2s5VwSvjNTs56k54sKTHppQSSpW4=; b=i+J5QkdvwIhQ+aJMMgqN7VqcTW7Ks0VtsgItP8nmjE4BHyfP/w4AeD4HyrMTLGuMfU OEOQohbWsIx6MsrCYHNXkEcdSCqafEuriUn3JBxCv4C+EsxJZS87sKp1wNO8g+9+F450 ehMidFnAsAYrXboAfT3CR015+Rq5mrObGIZwQWHAbsurriqNdeTE3UD01BDY2t97q0qB DQDTjcCCRoKDxcg9PtVAGd0FFXB5jkFzzKojWxCE4uAqTOVVL9DW9obIFrzfg4/gHwWG h1cAiBnBScxy+iVkXy2RaOriyalpvFr0HPfntc41xz3sQsDQjughWcRxNVCgDOHx5pW0 Ykog== X-Gm-Message-State: AOJu0YwbpqR0vtpA4NZjb8LkU0sdM7rsXVsdW1QAKa5od1qKGpydq/t8 FSlxeGFPh1n0QgHCVpalYTmwV64/zkAyvvhHJovtHH3QXknK2YnRqa1N/0wkAp5bSy5+MX4B8f8 eoLmg X-Gm-Gg: ASbGncu46uRe1wLwjm90B958AqpR0oQNwLs2XGp5xlhxNL0nLeRrySNE92wYapV+hCu B/MDjQKBuG9kPeMzv+DaxLRsYhn0yieEi42YyryDdiy1laxgwvvDw/0uF36aEjmzcYfCSJNLWOG MjbCnAi34hN4WbmDeZW/6d2PpzhItev54J6KSVygfIYMXM8VMAx9WEMhoYI13r+KIz6s2+B9nu5 lMkZOyFzFJ/Q++EV1NLGibtueiJTIqORhxWqJEI3Yaon4iDXpmOThVjnRqQTwO+FCzBzFxKy9jQ MHoPZCT1enFHy6KlfYnDVcFllGHtMqRurVIchub2qDrWWAp5l3l14RbfowJx1xzc+we45Kcx0ss mVgw37B3WZDC0xDwiqW272dDH2PdPBI266ulkprYBxwSX1qHaTe4J39NBXSWo4hmCQlzXyhLL+P CT3RddVG1iS3YPfbAczi/VKnJp7qmPeKnNMFo+Q0vZ X-Google-Smtp-Source: AGHT+IHJTHqqDs6gAZkp/H7tVSfQgyc7YXYWYgk5BXE+cncyGjPZC9+A4yuioWzf6iFsip4WuHNZbg== X-Received: by 2002:a05:6808:1587:b0:450:b3a:539e with SMTP id 5614622812f47-4502a2046admr3513985b6e.28.1762773053645; Mon, 10 Nov 2025 03:10:53 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 1/5] accel/tcg: Trace tb_flush() calls Date: Mon, 10 Nov 2025 12:10:41 +0100 Message-ID: <20251110111046.33990-2-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251110111046.33990-1-richard.henderson@linaro.org> References: <20251110111046.33990-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::235; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x235.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1762774338445158500 From: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson Message-ID: <20250925035610.80605-2-philmd@linaro.org> Reviewed-by: Richard Henderson --- accel/tcg/tb-maint.c | 3 ++- accel/tcg/trace-events | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/accel/tcg/tb-maint.c b/accel/tcg/tb-maint.c index 5a8d0784e7..cd7c32361b 100644 --- a/accel/tcg/tb-maint.c +++ b/accel/tcg/tb-maint.c @@ -40,7 +40,7 @@ #else #include "system/runstate.h" #endif - +#include "trace.h" =20 /* List iterators for lists of tagged pointers in TranslationBlock. */ #define TB_FOR_EACH_TAGGED(head, tb, n, field) \ @@ -771,6 +771,7 @@ void tb_flush__exclusive_or_serial(void) { CPUState *cpu; =20 + trace_tb_flush(); assert(tcg_enabled()); /* Note that cpu_in_serial_context checks cpu_in_exclusive_context. */ assert(!runstate_is_running() || diff --git a/accel/tcg/trace-events b/accel/tcg/trace-events index 14f638810c..121d6b5081 100644 --- a/accel/tcg/trace-events +++ b/accel/tcg/trace-events @@ -24,3 +24,6 @@ store_atom2_fallback(uint32_t memop, uintptr_t ra) "mop:0= x%"PRIx32", ra:0x%"PRIx store_atom4_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x= %"PRIxPTR"" store_atom8_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x= %"PRIxPTR"" store_atom16_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0= x%"PRIxPTR"" + +# tb-maint.c +tb_flush(void) "" --=20 2.43.0 From nobody Sun Dec 14 06:40:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1762774173; cv=none; d=zohomail.com; s=zohoarc; b=NM84gJe3NsLt8UvKZ7UAXETH69j8oU0VeeWlZcziJIYJPLVeABSmC/6TOJsF1IJj16GcUx2oSNiHr4THaPV4pw9kCmB/JXsCP0GPoLB4AQaDZILm+ooJ6IxhLQKDcdBRjpVib0t2mJ0BfQt8+gMTH+HJGTQ3AZDZ2C0aMXKxsYc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762774173; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WuF/v0yXtrg33Qqyg428lUouMv/b84r+E+BBuSI4+Io=; b=DgI0saaRG/suEphglkVKgoqGnJHGGqdljcXlH7YeOv3cFYjL0iYCXaHw/j2OhA/eXKjYwiyTR35qIcPJ6xrNZSZDoLRSqHMyzNIoJmAUsv31uPiauY8EAFXpLw9lrjZlTYC2525L17xcHK0FBU5iAxE/pNCg6MALWFm1e8REW8c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762774172973793.6846206101242; Mon, 10 Nov 2025 03:29:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIQ4r-00087e-DG; Mon, 10 Nov 2025 06:28:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIPnW-0004vx-7g for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:11:11 -0500 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vIPnU-0004KZ-Oq for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:10:57 -0500 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-7c6cc366884so822216a34.1 for ; Mon, 10 Nov 2025 03:10:56 -0800 (PST) Received: from stoup.. ([172.58.183.226]) by smtp.gmail.com with ESMTPSA id 5614622812f47-450426be56dsm1603412b6e.18.2025.11.10.03.10.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 03:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762773055; x=1763377855; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WuF/v0yXtrg33Qqyg428lUouMv/b84r+E+BBuSI4+Io=; b=QjAfFNM8BmU6598I2uaaeASd5JX4vWmVJnqwJTiAs8/iG7Ktk3QCcE2Fye3TEh/SQd Ao2N9M6liB39VoGvQf2Nr877S65Z85YivOAKqYZ0gwwisJtdaQFPehjBJ1VNl+m3jTtG TaZcOHZrWIypUrHLI8NMcveG9lejDEwvWrZ0xcVCALiwjcRxNy0BpRfJJyYgdW5IEns8 rO9XPY9IB4JQ3W7OYrIbgxgdUVU3KLj2tn1qqUV25s8BAiHVgqnMa+qjf4lKusCpgmwc FpMu+7JNEpisDx/D/FrFGr1fqEP+ppIG3kLgM3KMagx/G+A1Jrju0jlvkYVnUgVkcYGT AKLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762773055; x=1763377855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WuF/v0yXtrg33Qqyg428lUouMv/b84r+E+BBuSI4+Io=; b=v03qpIMYsJBHlVrV2jS2HIRhl522Dnz4eyWQacQkIW/rEhmuD57hyNqfcvnOOSmo0v sfKQ341CWS0xOSeXYuzawZVVxlDpEsPbC0h7eAoztwXvvOHWtUdvMB8ubuXewrnDDGVq k54vx+wqfqGS6PmlukxBUwgCtOwSxBtRjto4ALpIEVIkEelROCD9yP/xAWDhoYMkhEOI adf9vU8lL/dkh6PntRsbLZKH2oa9kLS5X2xqSBkksTlJPjuh40dZMeE3wd0C1WAE3J3r 5W65HbnBWEWy/Je0kkd5gXbNFZFbXf274mBq/1tDjOBZYUWjxb4niDCkzNYsbGjITDyj v99A== X-Gm-Message-State: AOJu0Yx8TvRbhcKlfuvw4kSNdwnUM1ue0D0KYL7K6sMUmZqW7HoSxj8Z a1D1YFTl9VwrJBEnjVUzKx65SBzQWhY6S24feVrqpb2L71GhSSq+4O7biWlMZqUE6jXh60XC/2Z B7J2u X-Gm-Gg: ASbGncuwUXHPqG6HGegGXZ2EhrgVi4691Z5DvqQUl5H6jeLc01qWxSPRalcf1eFGeOB 0filbmhK+daY503qVN0elRzEHeWK66Ztvbv/ero0pFeByBX9RANEIIzJag3dxnt3iYtrCRZ0HsQ W9MNrW2BfPKjKZLbx9yROtHm9DhHNN07FcExHdV6UBmrE8h7ELk365betd+hETEdvoyPLTyqX1B Im8pRr7nODtuWJap/qgMCJ4+5B+AFhwopYHUpz+6GuHC/VDKSIuxX2LBuoC/xQGYmIqR2ilYZOR fxuL1XbETXusdTORGBZzNjSoUnB8gq4uFmb2k0c0D88pzs/w46kByO/i7S4oVRcWf6yMplLAsjg Fhd0ik/rMPtZkyrIQquEhV5aCNfv8B+5burH6P9TkHNoAJZ/W1FYbIwjF2CmOeH0nJwHo85OYSi SrM6imD8T/NkjkWO4ntQXZW+oH1MEy7w== X-Google-Smtp-Source: AGHT+IFI3niuUwJ7IV2mY1l9nlRes14sbUXJiT5G24UKroXwdiibnIQIjJohSfUXrcbMl5WAN0mceA== X-Received: by 2002:a05:6808:f06:b0:450:4e1:47a3 with SMTP id 5614622812f47-4502a361af1mr5005166b6e.35.1762773055561; Mon, 10 Nov 2025 03:10:55 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 2/5] accel/tcg: Trace tb_gen_code() buffer overflow Date: Mon, 10 Nov 2025 12:10:42 +0100 Message-ID: <20251110111046.33990-3-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251110111046.33990-1-richard.henderson@linaro.org> References: <20251110111046.33990-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::332; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1762774173539158501 From: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Richard Henderson Message-ID: <20250925035610.80605-3-philmd@linaro.org> Reviewed-by: Richard Henderson --- accel/tcg/translate-all.c | 3 +++ accel/tcg/trace-events | 1 + 2 files changed, 4 insertions(+) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index da9d7f1675..fba4e9dc21 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -290,6 +290,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu, TCGTBCPUSt= ate s) if (unlikely(!tb)) { /* flush must be done */ if (cpu_in_serial_context(cpu)) { + trace_tb_gen_code_buffer_overflow("tcg_tb_alloc"); tb_flush__exclusive_or_serial(); goto buffer_overflow; } @@ -325,6 +326,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu, TCGTBCPUSt= ate s) if (unlikely(gen_code_size < 0)) { switch (gen_code_size) { case -1: + trace_tb_gen_code_buffer_overflow("setjmp_gen_code"); /* * Overflow of code_gen_buffer, or the current slice of it. * @@ -389,6 +391,7 @@ TranslationBlock *tb_gen_code(CPUState *cpu, TCGTBCPUSt= ate s) =20 search_size =3D encode_search(tb, (void *)gen_code_buf + gen_code_size= ); if (unlikely(search_size < 0)) { + trace_tb_gen_code_buffer_overflow("encode_search"); tb_unlock_pages(tb); goto buffer_overflow; } diff --git a/accel/tcg/trace-events b/accel/tcg/trace-events index 121d6b5081..0816cafd33 100644 --- a/accel/tcg/trace-events +++ b/accel/tcg/trace-events @@ -12,6 +12,7 @@ memory_notdirty_set_dirty(uint64_t vaddr) "0x%" PRIx64 =20 # translate-all.c translate_block(void *tb, uintptr_t pc, const void *tb_code) "tb:%p, pc:0x= %"PRIxPTR", tb_code:%p" +tb_gen_code_buffer_overflow(const char *reason) "reason: %s" =20 # ldst_atomicity load_atom2_fallback(uint32_t memop, uintptr_t ra) "mop:0x%"PRIx32", ra:0x%= "PRIxPTR"" --=20 2.43.0 From nobody Sun Dec 14 06:40:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1762774337; cv=none; d=zohomail.com; s=zohoarc; b=AqhCP0NdYeDLTSl5W4qRpog4RZ9Q3z4ZqYequu3ofURtfPz8tf1TNUT9y3tMyE/EMRZPt9VejLJpROZ1vUzXtZa9YMjj3e6PDAnDHTjxtt7erfKaJlEbyy0HuSTJ+hK0V4eLLWuT4EiI3cq3Tl9s13ko3t798PkQsj1G/Z8cSGA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762774337; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8PDJij+lprVMROFEDVhRUxnDiwgjAkm1Tbin3Q0oIJM=; b=VOqz2iY/IElQPfT299b1cE5gam6x9W55KzvSugSuy54IP6iWXbv5MYLpcFdHCcjZhsueonAlJopYWVXVSSHQMyccJVIpidiSQ1MJE4fm4Vd/HivJcGNix0YEvEazyehoF9clyls1ZIlW7Ozp38NZNvdemqbjGeWKzKO2TdGxR0U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762774337368719.127900576748; Mon, 10 Nov 2025 03:32:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIQ7y-0003TD-BK; Mon, 10 Nov 2025 06:32:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIPnb-0004yS-2c for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:11:15 -0500 Received: from mail-ot1-x32e.google.com ([2607:f8b0:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vIPnX-0004Kq-A2 for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:11:02 -0500 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-7c7060a2a53so329805a34.0 for ; Mon, 10 Nov 2025 03:10:58 -0800 (PST) Received: from stoup.. ([172.58.183.226]) by smtp.gmail.com with ESMTPSA id 5614622812f47-450426be56dsm1603412b6e.18.2025.11.10.03.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 03:10:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762773058; x=1763377858; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8PDJij+lprVMROFEDVhRUxnDiwgjAkm1Tbin3Q0oIJM=; b=BHYVpHKN1371/q4DpNwwclZlsBAGnh3f6Cz5eOE/sDFwf9ODzwagEGk9jXtG+IYw1q fyTa3v4pAMFn5cM/mhD/RGUZR003KenP7qpUTk/hUQa6zUVlkL3O7ZSh3OnML9CF/qBv 0j6newGBTWLqIhHzIFyyVhGTD3dO9vb+64gRqmmvj3uJD4AgJZD45bGB9kftZQ9TDZ7T WK4Odr9wozIfw41Kb5CteUGmtdU6Wj2mSEcNkONn/p/MHUJA9P1v1ZUvV2qLC7WdniB6 dJblUNGLuATlyKm/X+CIX5T1gV8dtchVnyBS4okcM42EJU2w/7HYxpxwHXVMriK9J4gb A7eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762773058; x=1763377858; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8PDJij+lprVMROFEDVhRUxnDiwgjAkm1Tbin3Q0oIJM=; b=VQ0HBNTAhZt2vlH3c54E4wHe5YyLBKIkeMDoCc4Imer+E3EQp29kZNs/xWiUdhGYmS XOT36Bl6rUdLI9ISEPTphF+KP8uryDh9IKpFFOGF3OvLA1DFFxvQcySJGUkHT4xljLJW LuiBmjYGd3JIudoVH2oSJyRs6kDjq+Lx0c02wC7kQy0Z1ZefhtA1/DVX2ahjdZn0MZTf m3AC+nbM2IEPqCaQwIJWBzo5d2vNpgdZ28s3U0AKo6aeSPzm0YAv9P86kTPotKFFff2n 8o/KM2WZCEJm5+vBhpUS4NHOHuWr/Zam0joaUqbwEdH9kNUhBos86EJe0VD6ybi+PaIH VXdw== X-Gm-Message-State: AOJu0YyJ/m1EkmlJxitCIw40hbP/SZGP9LUJ3u23CHG9wf8gC9TWFC95 aPH4VKgSeAn9vz3U4/LP3kYKi1JPmNQFonfRYi0Joe2TCejWnlhY4dWMtJ7WEMPC0X9QAGROsDy rDbyu X-Gm-Gg: ASbGnctrawON+ny3UmuDFZxC/o9fq4vNpf9afp5var5DvZdti/vQZh3K/CTCtWJNaXI jocMtMhS45z+Dnh08gC+nrT+wimUDsnuWdkT8WLEDz6DXJmJiu9xqSe15xzUw0+PK3A9iqa/ywm DtVtCzwqCu+UGOFnv5BOGCFZfWvZbk30d5HgE7Q1gesL/vV4AgJia+V2EToinjWeV8e7gULGcEy TNgx6cmiMZhPlgscbfWOXl6imJViZ0lUNPCtlzCpP6NKeVJjJPjXn5kDsbrSxORfCYi/hFkQlY+ KC7R1F05HJjxo0eC8gL8pDf8GV6IIGJNt3aUvBp988TWW923S8GcfttLpWtdgEUO5qyZg6EEgmf mnTYod6yRHNGVw47efFyw0NOL9SUR4o3pnCj2YqhwJ/nVqmu2u+OcMsqIaLbvOdsB5Yqpg/SzVz 2uGioud4sNZ8E5qd5tn+vsfZ4hn7ZJlXYYloXjzXuYjn98BKGucHQ= X-Google-Smtp-Source: AGHT+IGAghpgLGQscYtdjsAwKnv7bFpYppTdkeAOsStGcNge5i7ssxg4grAYqHxl71vvSAOZtGseyw== X-Received: by 2002:a05:6808:6f91:b0:44d:b8b7:fbcf with SMTP id 5614622812f47-4502a1bef92mr3955598b6e.21.1762773057998; Mon, 10 Nov 2025 03:10:57 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Markus Armbruster , Vladimir Sementsov-Ogievskiy Subject: [PULL 3/5] qapi/parser: Mollify mypy Date: Mon, 10 Nov 2025 12:10:43 +0100 Message-ID: <20251110111046.33990-4-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251110111046.33990-1-richard.henderson@linaro.org> References: <20251110111046.33990-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::32e; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1762774340404158500 Content-Type: text/plain; charset="utf-8" From: Markus Armbruster re.match(r'^ *', ...) can't fail, but mypy doesn't know that and complains: scripts/qapi/parser.py:444: error: Item "None" of "Match[str] | None" h= as no attribute "end" [union-attr] Work around by using must_match() instead. Fixes: 8107ba47fd78 (qapi: Add documentation format validation) Signed-off-by: Markus Armbruster Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Richard Henderson Message-ID: <20251105152219.311154-1-armbru@redhat.com> --- scripts/qapi/parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py index 1bb1af7051..c3cf33904e 100644 --- a/scripts/qapi/parser.py +++ b/scripts/qapi/parser.py @@ -441,7 +441,7 @@ def get_doc_line(self) -> Optional[str]: self._literal_mode =3D True self._literal_mode_indent =3D 0 elif self._literal_mode and line: - indent =3D re.match(r'^ *', line).end() + indent =3D must_match(r'\s*', line).end() if self._literal_mode_indent =3D=3D 0: self._literal_mode_indent =3D indent elif indent < self._literal_mode_indent: --=20 2.43.0 From nobody Sun Dec 14 06:40:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1762774217; cv=none; d=zohomail.com; s=zohoarc; b=TVXNnYa2DQXCaHRaPgfYdFr8+lv3/DMPO6PmjNKLCLzsI6CML/z+mTJPioOuQCjDdD2kB1TYiuJeWCm7nf91eB2vqkjRX4CtMpGX5h7zEnPnrgmNPcDING+w0edZ0Bc3GOYSBXelHEi4rhev1dqIdI3STxFwk2ypVWXqHk/jETw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762774217; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lvsOBqCyaXq+KZ7HS8bgLDho+xbN9ehkciU1Z30bu94=; b=gi+eVkxNAXNW8Qbh22o2TxHsHfVV85ePMcBjq0tb+qaWqklujkJZV//bCmNXLrvLVpIujT27IOWdVgFniUy9t1C5PpP7aYPJqdoTwHEyi6Y5G15odOgrrNNJCnDoQjxDJAnTc4LdofksjQz1gkR4ldejSYE1XkFX6zVlxlO74FM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762774217179838.5922831094917; Mon, 10 Nov 2025 03:30:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIQ65-00010N-GY; Mon, 10 Nov 2025 06:30:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIPnb-0004yT-2s for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:11:15 -0500 Received: from mail-ot1-x32a.google.com ([2607:f8b0:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vIPnY-0004Kv-Sr for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:11:02 -0500 Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-7c69476dd8cso1664242a34.2 for ; Mon, 10 Nov 2025 03:11:00 -0800 (PST) Received: from stoup.. ([172.58.183.226]) by smtp.gmail.com with ESMTPSA id 5614622812f47-450426be56dsm1603412b6e.18.2025.11.10.03.10.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 03:10:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762773059; x=1763377859; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lvsOBqCyaXq+KZ7HS8bgLDho+xbN9ehkciU1Z30bu94=; b=KlgB0P3Ahlm/hTNSiQxwUZPd0/VjUSFyjTv1RsYUcg6eI21//GB01gz+v0wlmVCxT3 bMWhCOKGZxAv69mr5bj8k6agQPRSRizMP0Cd6AaKaziDAjpPzaiift465hs0vhsUHCw/ nH3Oa0DYGn27tmAxulWeXiiC1R6E6iLUaS59QbjYWjkNZV8tAvhwPY+nSbJqbEdJOyXg T4MZJ6wPf5sDxkRFzqekSWYuoYnSwb9/McZ0KDSpd7Ro56h8t094cDX/QPKrm1Yb9LeJ aNIgvAAJABeHP2YW0vN/REv9X8v97YlOBBsGwY3nJUxKK1iB8aSM7PHv/GyWNdtrqsiP g1ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762773059; x=1763377859; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lvsOBqCyaXq+KZ7HS8bgLDho+xbN9ehkciU1Z30bu94=; b=JuoGHAHzvDVOqqUByIWIpPiUolnjunMWe4BFHk92BTFIYs2hr6y31x1KTdjD0ILW1i 8x7oSb4fenrR9yUzOOZUg5q/LTnJhEfdTqAo7mJSj7fbjaUWhzIR/+bCTIt28bIUcJ5R yJ/3jE1sJSyL+nOiTe1NhrdRJUA9eQbi42sKvrDeDveuWHArWZZzFMTySwXM6WMQjCXD Bd3nWvkIP/2qaoCi5nIBlcgpz9iNltbV0OONe8V/eM/mfG7lohJq2mJ+f2SRXa6JGUB3 HPDIwD7G/j901l1TXmO4lz16WpfcV4XGnKZLbHm2ns2YGMWCEPgpWU52gR/3mkO4MyOg Gvsg== X-Gm-Message-State: AOJu0YzSkzMzj0O4hE4t2yLYUyfemqMqG/2PYL/+wecA41h96VUbrotS q4MfXHx/Npt0niW1olhAffVuB5L94gorJieAOUYzYkoGCVZ94k6cnr5dD1IqTkl2zcAFX/MalRf sfkvw X-Gm-Gg: ASbGncs/+mOqlwWUE9WAUc/pLQFkPtwZNhn8wV3onJZUlSK5syDkvDZ2PFYpMUSQl8u KrExhaTAIqmolbg6V++ZJweZPv2zggOdunlnzxxp4tYHdn8D7zF+WDIrGDnHrGTUHuNF3dYPi6n htnnomBLIst8K+TkUNSh3zLrQD7bZ3pD9x26gDc+2UNeopb3f2uH1nlVZpPqh8Nz/lDW8GynsWK 23FYO8aPLmjc7ChLAb9hVTSdUBdGNk7sM5GzK/Bhhg4vU4zPvOeVFx8eAQ8CW47F2e4JDF9amSg ouDf65p/UcOh6ie2kPrbTmWFM9enZER46iqjbz5RATWMQeGl+/C68wc+gfF9sYpL6e+ybWxKwgy 0+X7N6Ymfnv0mIER6u3dp71h5xdB7aSUuO+fbHNeCVJNx4F0wT2w26g49nCkEZ5bH+YFNKL8+CB lMMTH2Zhm8Eo8VxMZsCtK7EYxXv8+lR59p2Nw1157/KNwG5+bvdfE= X-Google-Smtp-Source: AGHT+IHF88HkT2jwJom7SfDisN674Csk560vQZ/Dpnb1Zgc+ulvOjwULMHhLu1uM17bmaMnRQIY8Tg== X-Received: by 2002:a05:6808:1803:b0:450:47fc:f21f with SMTP id 5614622812f47-45047fcf6e3mr1778338b6e.37.1762773059594; Mon, 10 Nov 2025 03:10:59 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 4/5] tests/functional: Mark another MIPS replay test as flaky Date: Mon, 10 Nov 2025 12:10:44 +0100 Message-ID: <20251110111046.33990-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251110111046.33990-1-richard.henderson@linaro.org> References: <20251110111046.33990-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::32a; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1762774218335158500 From: Philippe Mathieu-Daud=C3=A9 When disabling MIPS tests on commit 1c11aa18071 ("tests/functional: Mark the MIPS replay tests as flaky") we missed the 5KEc test. Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20251104145955.84091-1-philmd@linaro.org> --- tests/functional/mips64el/test_replay.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/functional/mips64el/test_replay.py b/tests/functional/mi= ps64el/test_replay.py index 05cc585f85..e9318448fa 100755 --- a/tests/functional/mips64el/test_replay.py +++ b/tests/functional/mips64el/test_replay.py @@ -40,6 +40,7 @@ def test_replay_mips64el_malta(self): '75ba10cd35fb44e32948eeb26974f061b703c81c4ba2fab1ebcacf1d1bec3b61') =20 @skipUntrustedTest() + @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/2013") def test_replay_mips64el_malta_5KEc_cpio(self): self.set_machine('malta') self.cpu =3D '5KEc' --=20 2.43.0 From nobody Sun Dec 14 06:40:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1762774189; cv=none; d=zohomail.com; s=zohoarc; b=RNNL5T0dwKq1AmRFJaSBflsmSt8ETNeuL8c5zs2E0SuqGjRPXBigKdTTKFM6tE2dZoApcFvjTD/k3vfKTzDSYbEcCm3L64k1ImFz8HAOJ60eoIDF3wHEU0Q/eZOvkO4G9/NE2WKfwX644LFow0UmJ/312rDM+UOw3rJpwddj7r4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762774189; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DHao9ZBgFmJVV7PunBlOeozDZldx+WvW4UpohKz1KQo=; b=SkkWCr43Hz+e0ipPWxS0DVrQjwqY7nEZmmA9ysYIk5/zZ6yv/4o3SGLdDx9Go0V+foYic7vJCoyGotxbKLZzVCr0Gj1amAOXZ4z8N4gMhvArAgmOXz8u9AO4NvdHB/vyhFLcJUuolYQSnKMxABZkmlBjQ5vd7t3dDSU2g1Ym/pY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762774189406581.0508860748533; Mon, 10 Nov 2025 03:29:49 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vIQ59-0000Pf-UG; Mon, 10 Nov 2025 06:29:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vIPne-0004zN-UW for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:11:15 -0500 Received: from mail-oo1-xc34.google.com ([2607:f8b0:4864:20::c34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vIPnc-0004LA-C2 for qemu-devel@nongnu.org; Mon, 10 Nov 2025 06:11:06 -0500 Received: by mail-oo1-xc34.google.com with SMTP id 006d021491bc7-653652a4256so1270562eaf.0 for ; Mon, 10 Nov 2025 03:11:02 -0800 (PST) Received: from stoup.. ([172.58.183.226]) by smtp.gmail.com with ESMTPSA id 5614622812f47-450426be56dsm1603412b6e.18.2025.11.10.03.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Nov 2025 03:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762773062; x=1763377862; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DHao9ZBgFmJVV7PunBlOeozDZldx+WvW4UpohKz1KQo=; b=F+JomiChUQN95CVxY2gPuhxx51qvkT+EO15kkDXs5loR8+oFn1rup2l0kYEvdGKPIB i89Qfhxz18xm5NlO6t1nNYi918Bh6BriOAj5Zpyoj2GRwhbsIxbzX1sw1ETmzzU2Tdk9 SQHoTbfmoAqG6vJ0S1N6l/bKA6j/g1qhV0TjFOKiPfRKuii5DbClp75vIpC/V32lD7Pn 6ddSDyEChfIf8gn8wc1sCIgwDQE823OA7+aCGQT/mi4ZFJhAy7H9lYjuRg5U0N4h+NkM qvaOXU2pU+iUUtnKfDRAPXEm7JS8HsBkhtZp2+71N5DboBDUdylP3xI+zZ1j+/HjOpD6 hHoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762773062; x=1763377862; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DHao9ZBgFmJVV7PunBlOeozDZldx+WvW4UpohKz1KQo=; b=ki2feTO5bDeGh1Mi+fcCLnWX4h1qNUf1QjYEy/Jg5bnCw4N7dmZn8GT/POzv76wVhc v8S/iR/48aKfekn1dpHcn+M0ilc8LEHEEoGtAST9j7WY30FSrcwTkURz8UHSULMIe2fM /O0NKBfNqEO2dsHhNwB0iTVK/3/Y8m+izDAPzKbUXNU1lsodqQpMKQzEfDfnfDhkxtbs 4HVPyIT6ObIIUmwe1ZoKfIROBYbU5FKWwsWvZ6bOshusKW5Yo60znX8OAjyJ0xa8bIm7 HwpU8IWvCJk9GeGJBtCeFAQGoU9nKYnRFvsdjExbEa5eoV0E61LSuocpIF0hG+pKQrAt KStQ== X-Gm-Message-State: AOJu0Yx18P+Bvx/66B+Sid8+DaLFKPpjCpZ41ilp6bL2/jwu1EBislwR BiL6HurUfLGlmbceme1AioS/qskG22TxMUavh+yZCk70Qj/NL87191EmuiRBdURkObhKKQ0SDOd U3hjL X-Gm-Gg: ASbGncsfUniB+JtN74ygYW4IBrKNpVh0t45jvYuH2tlT0jVwt7885fVVLIWImRLVbLd 7Hp91wKNR+QbK12Q729Zz/A3OSkReVQmIfl77K14OhqDPFLXi3w6EoNu6aQ7DBPsLIIK7qW+kJ/ dXHb/6RxZ17hHCsuXkXhYG7iaOhSRFTtSbXE6LmKaPzwAn0GP8kBXLdK6Hw+Fe0HtV7hIincgSU IE+4S78x9AlmYawtSqp4+VcOw10OccQSnad6nWqfGJ4IUJJuyqFYME/i7BPrYVQZK5227jHcFz5 xLFHIomXXi7wS+HPqt7NMtyNeAUeIN3jVxWmTu6maHUe4oYGn0JCkzL8THDXX1g+7l24P+pB8J8 X5Aw9mkO/HPcWTlm8vW+KWSfQfFAxvQ4VZ/B74PNA6+7wQ+v0HGud63NoeiOyf57oM+YMR566Vz mQHzooUvLIy7J+h2IMnti4QcMbeiwdEQ== X-Google-Smtp-Source: AGHT+IEO1yibSeEEWE/tgqVbTFPKhY3z26+xK5EBB3HueJ1BWi/VUAoRI1GtPCADQCHGgwDLmAFWSg== X-Received: by 2002:a05:6808:220c:b0:43f:61b6:2ab9 with SMTP id 5614622812f47-4502a1cb1edmr4069511b6e.15.1762773061688; Mon, 10 Nov 2025 03:11:01 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-stable@nongnu.org Subject: [PULL 5/5] target/x86: Correctly handle invalid 0x0f 0xc7 0xxx insns Date: Mon, 10 Nov 2025 12:10:45 +0100 Message-ID: <20251110111046.33990-6-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251110111046.33990-1-richard.henderson@linaro.org> References: <20251110111046.33990-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::c34; envelope-from=richard.henderson@linaro.org; helo=mail-oo1-xc34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1762774189829158500 Content-Type: text/plain; charset="utf-8" From: Peter Maydell In the decode_group9() function, if we don't recognise the insn as one that we should handle, we leave the 'entry' pointer unaltered. Because the X86OpEntry struct has a union for the gen and decode pointers, this means that the top level code will call decode.e.gen() which tries to use the decode function pointer (still set to decode_group9) as a gen function pointer. This is undefined behaviour, but seems to be mostly harmless in practice (we call decode_group9() again with bogus arguments and it does nothing). If you have CFI enabled then it will trip the CFI check: ../target/i386/tcg/decode-new.c.inc:2862:9: runtime error: control flow int= egrity check for type 'void (struct DisasContext *, struct X86DecodedInsn *= )' failed during indirect function call Set *entry to UNKNOWN_OPCODE to provoke the #UD exception, as we do in decode_group1A() and decode_group11() for similar situations. Thanks to the bug reporter for the clear description and analysis of the bug and the simple reproducer. Cc: qemu-stable@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3172 Fixes: fcd16539ebfe2 ("target/i386: convert CMPXCHG8B/CMPXCHG16B to new dec= oder") Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson Message-ID: <20251021173152.1695997-1-peter.maydell@linaro.org> --- target/i386/tcg/decode-new.c.inc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.= c.inc index a50f57dbaa..f4192f1006 100644 --- a/target/i386/tcg/decode-new.c.inc +++ b/target/i386/tcg/decode-new.c.inc @@ -335,6 +335,8 @@ static void decode_group9(DisasContext *s, CPUX86State = *env, X86OpEntry *entry, *entry =3D group9_reg; } else if (op =3D=3D 1) { *entry =3D REX_W(s) ? cmpxchg16b : cmpxchg8b; + } else { + *entry =3D UNKNOWN_OPCODE; } } =20 --=20 2.43.0