From nobody Fri Nov 14 17:03:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1762458152; cv=none; d=zohomail.com; s=zohoarc; b=GxSCk4ZXjjAh2sasBZtXH0rlvMdGZ/kg+QknSulYvSfDQUQz73hLXK3WvKfkUmfCbRUNed1GFXfv6NZrN4dhnKgfdMQhqzIuScvtsJkEf7PfSsnwL4lkjVKGqw/EPxgiCuRmGEJ/dzvsPA9OsSa3MoD3YbL4g4HNVYAM5GBDXhU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762458152; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WRSWwJjugz5gbC1LAoiahIUfa+K65oR/zZ3p/rr4nL4=; b=cGopohwN9vbMWIPGsk6ybXdQ8Fq6V/KUvCfejFBoTrrVRpqU6npursm9PuXovNYDdqUzVlA0Vxju7nCY7zdOQty121q3hDWW1NW4UgDPXdKDocLD607Qvw69DNx73sP9Q5pw1tcyhdo9vFVT7F8BHHWljBgt+hCt2A5VjDnE8yc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762458151622789.6095049421706; Thu, 6 Nov 2025 11:42:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vH5rX-0003m5-N7; Thu, 06 Nov 2025 14:41:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vH5rU-0003kS-TR for qemu-devel@nongnu.org; Thu, 06 Nov 2025 14:41:36 -0500 Received: from forwardcorp1a.mail.yandex.net ([2a02:6b8:c0e:500:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vH5rR-0005bL-6j for qemu-devel@nongnu.org; Thu, 06 Nov 2025 14:41:36 -0500 Received: from mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1a8f:0:640:2fa2:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id D2505C01A6; Thu, 06 Nov 2025 22:41:30 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:95c::1:2]) by mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id RfspdL0FKeA0-qSZWJnck; Thu, 06 Nov 2025 22:41:30 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1762458090; bh=WRSWwJjugz5gbC1LAoiahIUfa+K65oR/zZ3p/rr4nL4=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=A3lP6SK7TQgyiB95kDepnCkg7DujRsEaorW2Bg3uDudRuy4XVQWS4lk9gEaZ47ilL kVRE5y300moLl8Ab3tVFddUEMXnLFpe5kYdmqXUtNnO4HpfPRHEN1TMYSYtZdfKXTA 5fuT4LR+jYXlz6grLE2HtsAAC5VeExoakVYKwGcM= Authentication-Results: mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: stefanb@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, peterx@redhat.com, Vladimir Sementsov-Ogievskiy Subject: [PATCH 3/3] tpm_emulator: tpm_emulator_set_state_blobs(): move to boolean return Date: Thu, 6 Nov 2025 22:41:26 +0300 Message-ID: <20251106194126.569037-4-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251106194126.569037-1-vsementsov@yandex-team.ru> References: <20251106194126.569037-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c0e:500:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1762458155853158500 Content-Type: text/plain; charset="utf-8" The returned error is only used to check for success, so no reason to use specific errno values. Also, this is the only function with -errno contract in the file, so converting it simplifies the whole file from three types of contract (0/-1, 0/-errno, true/false) to only two (0/-1, true/false). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger --- backends/tpm/tpm_emulator.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index 79f3e6b1f2..3c62bfa3ed 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -885,10 +885,8 @@ static int tpm_emulator_set_state_blob(TPMEmulator *tp= m_emu, =20 /* * Set all the TPM state blobs. - * - * Returns a negative errno code in case of error. */ -static int tpm_emulator_set_state_blobs(TPMBackend *tb, Error **errp) +static bool tpm_emulator_set_state_blobs(TPMBackend *tb, Error **errp) { TPMEmulator *tpm_emu =3D TPM_EMULATOR(tb); TPMBlobBuffers *state_blobs =3D &tpm_emu->state_blobs; @@ -897,7 +895,7 @@ static int tpm_emulator_set_state_blobs(TPMBackend *tb,= Error **errp) =20 if (tpm_emulator_stop_tpm(tb, errp) < 0) { trace_tpm_emulator_set_state_blobs_error("Could not stop TPM"); - return -EIO; + return false; } =20 if (tpm_emulator_set_state_blob(tpm_emu, PTM_BLOB_TYPE_PERMANENT, @@ -909,12 +907,12 @@ static int tpm_emulator_set_state_blobs(TPMBackend *t= b, Error **errp) tpm_emulator_set_state_blob(tpm_emu, PTM_BLOB_TYPE_SAVESTATE, &state_blobs->savestate, state_blobs->savestate_flags, errp) < = 0) { - return -EIO; + return false; } =20 trace_tpm_emulator_set_state_blobs_done(); =20 - return 0; + return true; } =20 static int tpm_emulator_pre_save(void *opaque) @@ -959,8 +957,7 @@ static bool tpm_emulator_post_load(void *opaque, int ve= rsion_id, Error **errp) TPMBackend *tb =3D opaque; int ret; =20 - ret =3D tpm_emulator_set_state_blobs(tb, errp); - if (ret < 0) { + if (!tpm_emulator_set_state_blobs(tb, errp)) { return false; } =20 --=20 2.48.1