From nobody Fri Nov 14 17:03:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1762458138; cv=none; d=zohomail.com; s=zohoarc; b=kfbl8aBlO7tQpnoFdQ4NNzrVDWoTmc7deh0SrVaRY+DNO+icAqdA5D15sJ/U9/oF/G9xn+D+9E9XKxeouYz8EGRd255DBsCXO+lj+BgNolm2LSrcNQ1dB8Tgax9zpFQVrQ+7PmMOzNk6kJ39InRjl5u2pd3V5j3RrUW4DMuZhjo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762458138; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aIRM3K7hrDbUqO+by7P6KHpZ+7hD8y8j3fymeYTlzFA=; b=h/VnLSIt4ZojOV4iB0IMOxCZR3gRXJa3e7AvrMfuUESJNrb6CmTDDq2pCfORPUxcZBzujnznkssOi15NO/NXIzeay5wWGtAoja9yyFOQs6zx/lxqXPcQMBqOT/BilswrP02rwvqq3xpvyrNyiXDFcjf0erGLOemi+1vMdp2/HY4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762458137742563.0144848430415; Thu, 6 Nov 2025 11:42:17 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vH5rU-0003kM-Nw; Thu, 06 Nov 2025 14:41:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vH5rT-0003k4-NX for qemu-devel@nongnu.org; Thu, 06 Nov 2025 14:41:35 -0500 Received: from forwardcorp1d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vH5rR-0005b0-6i for qemu-devel@nongnu.org; Thu, 06 Nov 2025 14:41:35 -0500 Received: from mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net [IPv6:2a02:6b8:c0c:1a8f:0:640:2fa2:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 8B6CC80940; Thu, 06 Nov 2025 22:41:29 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:95c::1:2]) by mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id RfspdL0FKeA0-DjWY94PE; Thu, 06 Nov 2025 22:41:29 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1762458089; bh=aIRM3K7hrDbUqO+by7P6KHpZ+7hD8y8j3fymeYTlzFA=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=1uAw1mO12CwllDuoCmhB+9yizzCgaXtys0uE5Y1AtFBVRhBiHkb+hhl6ZNZ6U7i05 1rav9Qk9HsglDrBQf4qvzdJQydV9TjqfkWw/mQUW0iFLbg1e52IbaHYwnGxjMF4jE6 3sz0J7kq4b1aEiUHUao3CwaN4pCLJYMgedLOSRso= Authentication-Results: mail-nwsmtp-smtp-corp-main-66.iva.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: stefanb@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, armbru@redhat.com, peterx@redhat.com, Vladimir Sementsov-Ogievskiy Subject: [PATCH 1/3] tpm_emulator: print error on error-ignore path Date: Thu, 6 Nov 2025 22:41:24 +0300 Message-ID: <20251106194126.569037-2-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251106194126.569037-1-vsementsov@yandex-team.ru> References: <20251106194126.569037-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1762458143042154100 Content-Type: text/plain; charset="utf-8" Commit 3469a56fa3dc985 introduced errp passthrough for many errors in the file. But in this specific case in tpm_emulator_get_buffer_size(), it simply used errp=3DNULL, so we lose printed error. Let's bring it back Note also, that 3469a56fa3dc985 was fixing another commit, 42e556fa3f7a "backends/tpm: Propagate vTPM error on migration failure" and didn't mention it. Fixes: 3469a56fa3dc985 "tmp_emulator: improve and fix use of errp" Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Stefan Berger --- backends/tpm/tpm_emulator.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index f10b9074fb..24aa18302e 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -560,8 +560,10 @@ static TPMVersion tpm_emulator_get_tpm_version(TPMBack= end *tb) static size_t tpm_emulator_get_buffer_size(TPMBackend *tb) { size_t actual_size; + Error *local_err =3D NULL; =20 - if (tpm_emulator_set_buffer_size(tb, 0, &actual_size, NULL) < 0) { + if (tpm_emulator_set_buffer_size(tb, 0, &actual_size, &local_err) < 0)= { + error_report_err(local_err); return 4096; } =20 --=20 2.48.1