From nobody Fri Nov 14 17:01:16 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762343324; cv=none; d=zohomail.com; s=zohoarc; b=XJp58NxyYocOdWFWGRTakag0ZU4TjoUSzEYJjX2NSYgyxfim4Z9LfbwphIWbNwPYftOEeUzS8W1EOkQaSlMJQe0L42L7OptQ/cIjXE2YMW+yqF9NkzNmPGY8BpBqwaA6pDIcLcE4+R8pGx37ilXBnxEmNdOEp7BG7x0X8OHor5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762343324; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vaAaP1W1mqUaZG5PCtjNhroyXMv30+g98uX5rmpOrV0=; b=eSQ6ujis7BV/+wOpWAVRhBkMdXJugpS5HxJz8F4mnXJrZcZk+lW5A5sHZu+xmQxjJu7bIxI+e3GbTsjyaIzUne9SLC+dhnbcX0S8SSHsH27GUKGuFr8AAoaItEfmXaaA1FznBbD6rwBcOBGK0nxaCDeJm7iBc/usPDON70VnxBE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762343324206999.5105832512836; Wed, 5 Nov 2025 03:48:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vGbyq-0006Fe-FM; Wed, 05 Nov 2025 06:47:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vGbyM-0005qQ-9V for qemu-devel@nongnu.org; Wed, 05 Nov 2025 06:46:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vGbyI-0003Gp-DL for qemu-devel@nongnu.org; Wed, 05 Nov 2025 06:46:40 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-577-5zXy3BC_N_qrfwirtoMu5Q-1; Wed, 05 Nov 2025 06:46:33 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 35D0F1800343; Wed, 5 Nov 2025 11:46:32 +0000 (UTC) Received: from gshan-thinkpadx1nanogen2.rmtau.csb (unknown [10.64.136.5]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7BFB11800451; Wed, 5 Nov 2025 11:46:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762343197; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vaAaP1W1mqUaZG5PCtjNhroyXMv30+g98uX5rmpOrV0=; b=F1QyWidMdqqKRvz2BGdNxuEUDzT6VFB1rK90CCdMpbboY2doR0UoAnLO6TQQYnCk89wsO/ NaRW2YehfO/kWecvXOgmN8LinWIofK0vAttlRO8a7b8p8HLTVqYNoIjIkz1HJUQfsyjlQy v9iNa7Pxa4W9pTF7E+Yi1/D1YVcptuc= X-MC-Unique: 5zXy3BC_N_qrfwirtoMu5Q-1 X-Mimecast-MFC-AGG-ID: 5zXy3BC_N_qrfwirtoMu5Q_1762343192 From: Gavin Shan To: qemu-arm@nongnu.org Cc: qemu-devel@nongnu.org, jonathan.cameron@huawei.com, mchehab+huawei@kernel.org, gengdongjiu1@gmail.com, mst@redhat.com, imammedo@redhat.com, anisinha@redhat.com, peter.maydell@linaro.org, pbonzini@redhat.com, shan.gavin@gmail.com Subject: [PATCH v3 5/8] acpi/ghes: Bail early on error from get_ghes_source_offsets() Date: Wed, 5 Nov 2025 21:44:50 +1000 Message-ID: <20251105114453.2164073-6-gshan@redhat.com> In-Reply-To: <20251105114453.2164073-1-gshan@redhat.com> References: <20251105114453.2164073-1-gshan@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.517, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762343336774158500 Content-Type: text/plain; charset="utf-8" For one particular error (Error), we can't call error_setg() for twice. Otherwise, the assert(*errp =3D=3D NULL) will be triggered unexpectedly in error_setv(). In ghes_record_cper_errors(), get_ghes_source_offsets() can return a error initialized by error_setg(). Without bailing on this error, it can call into the second error_setg() due to the unexpected value from the read acknowledgement register. Bail early in ghes_record_cper_errors() when error is received from get_ghes_source_offsets() to avoid the exception. Signed-off-by: Gavin Shan Reviewed-by: Igor Mammedov Reviewed-by: Jonathan Cameron --- hw/acpi/ghes.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 527b85c8d8..055e5d719a 100644 --- a/hw/acpi/ghes.c +++ b/hw/acpi/ghes.c @@ -513,6 +513,9 @@ void ghes_record_cper_errors(AcpiGhesState *ags, const = void *cper, size_t len, } else { get_ghes_source_offsets(source_id, le64_to_cpu(ags->hest_addr_le), &cper_addr, &read_ack_register_addr, errp); + if (*errp) { + return; + } } =20 cpu_physical_memory_read(read_ack_register_addr, --=20 2.51.0