From nobody Fri Nov 14 18:19:16 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762223512; cv=none; d=zohomail.com; s=zohoarc; b=MvlFeVu/c0U4xZlC/h41Xrgh4SCqcM574p0GFXdc8jAbLo+o20rji4kcCLd4rNc4e9eAPevi0xc3sAkGs3ruwdMh7AuumSljDiNTyPMfMl4tVhoNC179t7kruhIu3p27mBsiKQng3zNYh+siSa5a7WhlQ7Jh/eGxo8S2mi4D0R0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762223512; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y2JCHupFaVO7tOSin3L/1pVR3971dfXU4ZutFj6ncWg=; b=l2xmtiuN9E0Xot+6xrofpRpxaTqdlCBV0jX/G2TVPbuCbxPPdNY3w7WUKzL2JGaptMpMahID0BDf4aNH42k3qBK87dy9pAcAzCoe/XSaow/C+/XHxiqjDy0QTkjRs7t7VfChDoBER31Apmvt0SbsnTIFUQPGSQVwV9jUwQ7/QOU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762223512347808.7691429987121; Mon, 3 Nov 2025 18:31:52 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vG6p1-0007NW-CH; Mon, 03 Nov 2025 21:31:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vG6oJ-00079H-S1 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 21:30:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vG6oH-0004CS-Te for qemu-devel@nongnu.org; Mon, 03 Nov 2025 21:30:15 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-78-WRKcxxu5N9SFQo3XGwksEg-1; Mon, 03 Nov 2025 21:30:09 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1B4571808981; Tue, 4 Nov 2025 02:30:08 +0000 (UTC) Received: from localhost (unknown [10.2.16.6]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 586A430001A1; Tue, 4 Nov 2025 02:30:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762223413; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y2JCHupFaVO7tOSin3L/1pVR3971dfXU4ZutFj6ncWg=; b=Jim/qnJOmcUCeBeEk5jIb+Y+xDRocGUg4UiDrZgp3FeKpUEG6sz/q0liAGl1M2LT3UTBeE etr5dMhsO707HggDOOzmev6i/1s8uVjTeWSZaaI1nk6X0WMr65tD3oWt5fOVpG4ZH+CU1R GMnBKRPbTa6oSgZA7TTkZvh0EqqyMUc= X-MC-Unique: WRKcxxu5N9SFQo3XGwksEg-1 X-Mimecast-MFC-AGG-ID: WRKcxxu5N9SFQo3XGwksEg_1762223408 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , Kevin Wolf , eblake@redhat.com, Hanna Czenczek , qemu-block@nongnu.org, Paolo Bonzini , Fam Zheng , hibriansong@gmail.com Subject: [PATCH v6 12/15] aio-posix: add fdmon_ops->dispatch() Date: Mon, 3 Nov 2025 21:29:30 -0500 Message-ID: <20251104022933.618123-13-stefanha@redhat.com> In-Reply-To: <20251104022933.618123-1-stefanha@redhat.com> References: <20251104022933.618123-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762223527033158500 Content-Type: text/plain; charset="utf-8" The ppoll and epoll file descriptor monitoring implementations rely on the event loop's generic file descriptor, timer, and BH dispatch code to invoke user callbacks. The io_uring file descriptor monitoring implementation will need io_uring-specific dispatch logic for CQE handlers for custom SQEs. Introduce a new FDMonOps ->dispatch() callback that allows file descriptor monitoring implementations to invoke user callbacks. The next patch will use this new callback. Signed-off-by: Stefan Hajnoczi --- v5: - Add patch to introduce FDMonOps->dispatch() callback [Kevin] --- include/block/aio.h | 19 +++++++++++++++++++ util/aio-posix.c | 9 +++++++++ 2 files changed, 28 insertions(+) diff --git a/include/block/aio.h b/include/block/aio.h index 9562733fa7..b266daa58f 100644 --- a/include/block/aio.h +++ b/include/block/aio.h @@ -107,6 +107,25 @@ typedef struct { */ bool (*need_wait)(AioContext *ctx); =20 + /* + * dispatch: + * @ctx: the AioContext + * + * Dispatch any work that is specific to this file descriptor monitori= ng + * implementation. Usually the event loop's generic file descriptor + * monitoring, BH, and timer dispatching code is sufficient, but file + * descriptor monitoring implementations offering additional functiona= lity + * may need to implement this function for custom behavior. Called at a + * point in the event loop when it is safe to invoke user-defined + * callbacks. + * + * This function is optional and may be NULL. + * + * Returns: true if progress was made (see aio_poll()'s return value), + * false otherwise. + */ + bool (*dispatch)(AioContext *ctx); + /* * gsource_prepare: * @ctx: the AioContext diff --git a/util/aio-posix.c b/util/aio-posix.c index c0285a26a3..6ff36b6e51 100644 --- a/util/aio-posix.c +++ b/util/aio-posix.c @@ -385,10 +385,15 @@ void aio_dispatch(AioContext *ctx) AioHandlerList ready_list =3D QLIST_HEAD_INITIALIZER(ready_list); =20 qemu_lockcnt_inc(&ctx->list_lock); + aio_bh_poll(ctx); =20 ctx->fdmon_ops->gsource_dispatch(ctx, &ready_list); =20 + if (ctx->fdmon_ops->dispatch) { + ctx->fdmon_ops->dispatch(ctx); + } + /* block_ns is 0 because polling is disabled in the glib event loop */ aio_dispatch_ready_handlers(ctx, &ready_list, 0); =20 @@ -707,6 +712,10 @@ bool aio_poll(AioContext *ctx, bool blocking) block_ns =3D qemu_clock_get_ns(QEMU_CLOCK_REALTIME) - start; } =20 + if (ctx->fdmon_ops->dispatch) { + progress |=3D ctx->fdmon_ops->dispatch(ctx); + } + progress |=3D aio_bh_poll(ctx); progress |=3D aio_dispatch_ready_handlers(ctx, &ready_list, block_ns); =20 --=20 2.51.1