From nobody Sun Nov 16 01:11:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762197954; cv=none; d=zohomail.com; s=zohoarc; b=AuHp6sCnR+DI5HurhmiL2oNkU+/1GrHOQKFuG5xXy4/r1/CSFQax+K5TyN2ZcRRmWDBkQCxd15AHm7lmw1klVyeCLDpSOYutn3EotISmuE8291vBWb3sgpyAa6Eu02LolfwmSb6TVeU3uZRj/MLIvFQxdojLckfTrCoZXrwDEnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762197954; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vqkKS9JGlo1RMbnwYGCV3TMVsvl0JFJzFF2uWZFBSuc=; b=H3sr0tsQSFZZM2okf1ldVRpjgtTReFBiB6YiMk+kTS6SBURVmsWKLIcuUNJfrWaBOLI1tP0XUVAwVHW31h0kdAUUwqck02ovrTg5bdd3e31zIfmBO7hqJG9MqxjXN/+Opd4CnIqCFNFGXup/nU/9/z2pXqJCJ46OX9aLLv4bE3o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176219795490148.801466549910174; Mon, 3 Nov 2025 11:25:54 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vG0Aq-0001a3-Og; Mon, 03 Nov 2025 14:25:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vG0Ao-0001ZT-R2 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 14:25:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vG0Af-0001o3-Ua for qemu-devel@nongnu.org; Mon, 03 Nov 2025 14:25:00 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-612-N2hCKHLlMGKjrn542TD6Dg-1; Mon, 03 Nov 2025 14:24:43 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 06C4B1956066; Mon, 3 Nov 2025 19:24:42 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.45.224.94]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 783D018004D8; Mon, 3 Nov 2025 19:24:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762197888; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=vqkKS9JGlo1RMbnwYGCV3TMVsvl0JFJzFF2uWZFBSuc=; b=FjzSpXF/TkiTLE6Cqy0Aucv9uE9MJrHTOQMfAgfXkAcc3uwIlrMVPNsgMF66+iiO4+39g9 coU1NLpQ55beZuHEspp2PJLNV3UD3lohGXpyDHB++hq48YvwDWY6TFBWBYmCf0su3MZVxO lvhz9IykixItHLSRU9n5kWLN+vlnUF4= X-MC-Unique: N2hCKHLlMGKjrn542TD6Dg-1 X-Mimecast-MFC-AGG-ID: N2hCKHLlMGKjrn542TD6Dg_1762197882 From: Thomas Huth To: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , qemu-devel@nongnu.org Cc: Aurelien Jarno , Paolo Bonzini , =?UTF-8?q?Alex=20Benn=C3=A9e?= , qemu-trivial@nongnu.org, Thomas Huth Subject: [PATCH] tests/functional/mips64el: Silence issues reported by pylint Date: Mon, 3 Nov 2025 20:24:30 +0100 Message-ID: <20251103192430.63278-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762197966810158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Drop unused imports, annotate imports that are not at the top, but done on purpose in other locations, use f-strings where it makes sense, etc. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/mips64el/test_malta.py | 15 ++++++++------- tests/functional/mips64el/test_replay.py | 4 ++-- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/tests/functional/mips64el/test_malta.py b/tests/functional/mip= s64el/test_malta.py index e37463dc291..bc750cb7ad6 100755 --- a/tests/functional/mips64el/test_malta.py +++ b/tests/functional/mips64el/test_malta.py @@ -10,7 +10,6 @@ # SPDX-License-Identifier: GPL-2.0-or-later =20 import os -import logging =20 from qemu_test import LinuxKernelTest, Asset from qemu_test import exec_command_and_wait_for_pattern @@ -50,7 +49,7 @@ def test_mips64el_malta(self): self.vm.add_args('-kernel', kernel_path, '-append', kernel_command_line) self.vm.launch() - console_pattern =3D 'Kernel command line: %s' % kernel_command_line + console_pattern =3D f'Kernel command line: {kernel_command_line}' self.wait_for_console_pattern(console_pattern) =20 ASSET_KERNEL_3_19_3 =3D Asset( @@ -66,7 +65,7 @@ def test_mips64el_malta(self): '75ba10cd35fb44e32948eeb26974f061b703c81c4ba2fab1ebcacf1d1bec3b61') =20 @skipUntrustedTest() - def test_mips64el_malta_5KEc_cpio(self): + def test_mips64el_malta_5kec_cpio(self): kernel_path =3D self.ASSET_KERNEL_3_19_3.fetch() initrd_path =3D self.uncompress(self.ASSET_CPIO_R1) =20 @@ -134,8 +133,8 @@ def do_test_i6400_framebuffer_logo(self, cpu_cores_coun= t): Boot Linux kernel and check Tux logo is displayed on the framebuff= er. """ =20 - import numpy as np - import cv2 + import numpy as np # pylint: disable=3Dimport-outside-toplevel + import cv2 # pylint: disable=3Dimport-outside-toplevel =20 screendump_path =3D self.scratch_file('screendump.pbm') =20 @@ -149,7 +148,7 @@ def do_test_i6400_framebuffer_logo(self, cpu_cores_coun= t): 'clocksource=3DGIC console=3Dtty0 console= =3DttyS0') self.vm.add_args('-kernel', kernel_path, '-cpu', 'I6400', - '-smp', '%u' % cpu_cores_count, + '-smp', str(cpu_cores_count), '-vga', 'std', '-append', kernel_command_line) self.vm.launch() @@ -157,7 +156,7 @@ def do_test_i6400_framebuffer_logo(self, cpu_cores_coun= t): self.wait_for_console_pattern(framebuffer_ready) self.vm.cmd('human-monitor-command', command_line=3D'stop') res =3D self.vm.cmd('human-monitor-command', - command_line=3D'screendump %s' % screendump_path) + command_line=3Df'screendump {screendump_path}') if 'unknown command' in res: self.skipTest('screendump not available') =20 @@ -191,6 +190,8 @@ def test_mips_malta_i6400_framebuffer_logo_8cores(self): self.do_test_i6400_framebuffer_logo(8) =20 =20 +# Add the tests from the 32-bit mipsel file here, too. +# pylint: disable=3Dunused-import,wrong-import-position from mipsel.test_malta import MaltaMachineYAMON =20 if __name__ =3D=3D '__main__': diff --git a/tests/functional/mips64el/test_replay.py b/tests/functional/mi= ps64el/test_replay.py index 05cc585f854..ce8dd28d722 100755 --- a/tests/functional/mips64el/test_replay.py +++ b/tests/functional/mips64el/test_replay.py @@ -23,7 +23,7 @@ def test_replay_mips64el_malta(self): kernel_path =3D self.archive_extract(self.ASSET_KERNEL_2_63_2, member=3D'boot/vmlinux-2.6.32-5-5kc-ma= lta') kernel_command_line =3D self.KERNEL_COMMON_COMMAND_LINE + 'console= =3DttyS0' - console_pattern =3D 'Kernel command line: %s' % kernel_command_line + console_pattern =3D f'Kernel command line: {kernel_command_line}' self.run_rr(kernel_path, kernel_command_line, console_pattern, shi= ft=3D5) =20 =20 @@ -40,7 +40,7 @@ def test_replay_mips64el_malta(self): '75ba10cd35fb44e32948eeb26974f061b703c81c4ba2fab1ebcacf1d1bec3b61') =20 @skipUntrustedTest() - def test_replay_mips64el_malta_5KEc_cpio(self): + def test_replay_mips64el_malta_5kec_cpio(self): self.set_machine('malta') self.cpu =3D '5KEc' kernel_path =3D self.ASSET_KERNEL_3_19_3.fetch() --=20 2.51.0