From nobody Sun Feb 8 17:20:32 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167688; cv=none; d=zohomail.com; s=zohoarc; b=MP48rkbJhvz2S0B7hktRj6IBXN9k4v31jJ7RaAJCvsOldxWZ8LioWZNTcCZGbFfyfdgqW9vKeO+skaAOXN3aFtAt6S+q6MMTcI9nQTg/RVZmvA8EZ8e92gbePcVM/sWe/TXc2F7Prx+Uv+E84P2c/bAb/bHwS4LpfY1EPru37vQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167688; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=F5abZUPq5OvZhrg8KiZ3sPDIKPaAPgPQiaHApqNdmC8=; b=EW/CpTIBlkNBmMQF7s2wZvLI0Mob5AKkzjyofdiIUJQRyAhm9mVEY+BEeyy4LDPY7KF3/DUchoBmE53Xj5dRpsvU9h0e9kn/njTIChcE59wX5IYvcGPWnY1KLMnhtEaWFQlfySGeFPePDW90T5P5BFAtFSMd1yzd2jlzz2cbj8M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167688001361.47870568655446; Mon, 3 Nov 2025 03:01:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHI-0003xi-OT; Mon, 03 Nov 2025 05:59:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHC-0003ro-1J for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsH6-0004UA-TX for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:05 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-qcSEqZuOMEOpnOxYCSQVKA-1; Mon, 03 Nov 2025 05:58:56 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 54B5419541B5; Mon, 3 Nov 2025 10:58:55 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 954E630001A8; Mon, 3 Nov 2025 10:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F5abZUPq5OvZhrg8KiZ3sPDIKPaAPgPQiaHApqNdmC8=; b=V0UqNQsWwcccxsjTu216v204CqV+6eYpUeAsU829tBMxehDhO7fqiphZ64RQ8ggXqxMrfW 2zPGnIK/+Q4lRMk8JZ5xzjKVuvkrNqIA2n9TP20lCH10/H4yaouqEGdk0MHP1rZbhe4YEp YxfQAC/GHvQAitGrGHZAtkpEyz6Cg2U= X-MC-Unique: qcSEqZuOMEOpnOxYCSQVKA-1 X-Mimecast-MFC-AGG-ID: qcSEqZuOMEOpnOxYCSQVKA_1762167535 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Zhao Liu Subject: [PULL 13/22] tests/functional/x86_64/test_acpi_bits: Silence warnings reported by pylint Date: Mon, 3 Nov 2025 11:58:10 +0100 Message-ID: <20251103105824.322039-14-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167696315158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complains about too many positional arguments for the __init__ function of the QEMUBitsMachine class, use a "*" to enforce argument passing by names instead (which the calling sites are doing here already). Second, use lazy logging when calling self.log.info() with a "%s" format string, and drop a superfluous "else:" that is not necessary after a "raise" statement. Reviewed-by: Zhao Liu Signed-off-by: Thomas Huth Message-ID: <20251029081514.60802-1-thuth@redhat.com> --- tests/functional/x86_64/test_acpi_bits.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/x86_64/test_acpi_bits.py b/tests/functional/x= 86_64/test_acpi_bits.py index 9a2816533d6..ec716d643bf 100755 --- a/tests/functional/x86_64/test_acpi_bits.py +++ b/tests/functional/x86_64/test_acpi_bits.py @@ -57,6 +57,7 @@ class QEMUBitsMachine(QEMUMachine): # pylint: disable=3Dt= oo-few-public-methods """ def __init__(self, binary: str, + *, args: Sequence[str] =3D (), wrapper: Sequence[str] =3D (), name: Optional[str] =3D None, @@ -225,7 +226,7 @@ def generate_bits_iso(self): stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.STDOUT, check=3DTrue) - self.log.info("grub-mkrescue output %s" % proc.stdout) + self.log.info("grub-mkrescue output %s", proc.stdout) else: subprocess.check_call([mkrescue_script, '-o', iso_file, bits_dir], @@ -287,9 +288,8 @@ def parse_log(self): except AssertionError as e: self._print_log(log) raise e - else: - if os.getenv('V') or os.getenv('BITS_DEBUG'): - self._print_log(log) + if os.getenv('V') or os.getenv('BITS_DEBUG'): + self._print_log(log) =20 def tearDown(self): """ --=20 2.51.0