From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167550; cv=none; d=zohomail.com; s=zohoarc; b=PA0eW2qTkhjB08Tu3lLn+OX2Co0jURRZmiMql+JApCMHgycvEN/EmhtQR/K2tV+Zude9oECZlHOh8hrubnYYA2FWlIc1beV87lfFrqYAhiwCIFEmTkIyazSCFit8qxBfWlgOhlh8NhJ/abWjXkBLrbe64yTurqwkWr/iAvkNN4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167550; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KZt4It060wiUM4xdxwGuZ8z/rMYt9kE4MDsI7rVARRs=; b=Kxw2y32MXHtez2HH/XPFgPFmNJXx5m5xV7eB38KQZnvXizMB/kxqu6n2iPFaxtVxcbf9tC7QT/J3FWhTalz6E1vzT8r4o5lATlU0r1LlG44adBUzQ8HuwoG+p0QTNHb06WSJfmJEpEPkIiLbYH9DfYxan/Mc705La4uf1EDLYZU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167550553855.7262866755683; Mon, 3 Nov 2025 02:59:10 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsGk-0003jG-QH; Mon, 03 Nov 2025 05:58:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGj-0003j6-GW for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:37 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGg-00041W-TW for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:37 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-aPO3pXgkOlSb5i2ITEsUYw-1; Mon, 03 Nov 2025 05:58:30 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5C05C180A227; Mon, 3 Nov 2025 10:58:29 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D53D230001A1; Mon, 3 Nov 2025 10:58:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167511; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KZt4It060wiUM4xdxwGuZ8z/rMYt9kE4MDsI7rVARRs=; b=FmJy7RiFMrHC5zGR5B9wMMNCppA9ZuNlIfQ7d6lK6VyUJ0zbFOYcdSrRzrnIQciLKvZGKa CPbjmbSss2GuVMX0tBXOlPTpmluORawHkFDSlgUeadlp6v6RwH9Zq1wv5Qf8bWip4q0KDh iDBskRKltj4UrM9qGbN7071pTuMGLDE= X-MC-Unique: aPO3pXgkOlSb5i2ITEsUYw-1 X-Mimecast-MFC-AGG-ID: aPO3pXgkOlSb5i2ITEsUYw_1762167509 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , John Snow Subject: [PULL 01/22] scripts/device-crash-test: fix spurious EOFError messages Date: Mon, 3 Nov 2025 11:57:58 +0100 Message-ID: <20251103105824.322039-2-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167552871154100 Content-Type: text/plain; charset="utf-8" From: John Snow When the QMP library was updated to match the standalone repository in 094ded52, I neglected to update the logging filter(s) in device-crash-test, which allowed the spurious messages to leak through. Update the log filter to re-suppress these messages. Fixes: 094ded52 Reported-by: Thomas Huth Signed-off-by: John Snow Message-ID: <20251022213109.395149-1-jsnow@redhat.com> Signed-off-by: Thomas Huth --- scripts/device-crash-test | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/device-crash-test b/scripts/device-crash-test index 1ecb9663ae8..c1576e8b966 100755 --- a/scripts/device-crash-test +++ b/scripts/device-crash-test @@ -527,7 +527,7 @@ def main(): # Async QMP, when in use, is chatty about connection failures. # This script knowingly generates a ton of connection errors. # Silence this logger. - logging.getLogger('qemu.qmp.qmp_client').setLevel(logging.CRITICAL) + logging.getLogger('qemu.qmp.protocol').setLevel(logging.CRITICAL) =20 fatal_failures =3D [] wl_stats =3D {} --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167562; cv=none; d=zohomail.com; s=zohoarc; b=aOjWzAkfsUcXe2wLM/HD7N7l0FGBTNmfhQouEjjW6k9pzCKdTQp6tW3ilS866AMsSGjYfzTUudjp+pIgBXDgiSmDPJCfPPjpEAW5BwTDlmU3fuxmgWY8rMVyrF0TWoly0QigX/o7Ipa/k5BCXQaYiQp2PiP6/yaFGXqWxA96/Zc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167562; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8TA3kpc+YHMk0qkvoJlY74Sz5ck9Tnfwg9efSklIJdY=; b=BO+fGj8BeBGhCiyENMZcTgFxBMAEg/PjlZUeQuUEKSSGaHUY5IZmXUTgCPoqriS0MSurIi9aa/dRsD01bPjxOVza9FTRMeyf60g5hpwlCeiUqneWrXutWg0t+Vi2Q0qeGbLUwyYIvJIrGuo7WTBScEfRxZZ9uq8+5S1ZPiRlonI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176216756236546.914687345382845; Mon, 3 Nov 2025 02:59:22 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsGs-0003lp-LK; Mon, 03 Nov 2025 05:58:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGq-0003lS-WB for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGk-00047q-J0 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:44 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-HPWkvdp0OjSYB0k_fXocgw-1; Mon, 03 Nov 2025 05:58:32 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2C7F01800D87; Mon, 3 Nov 2025 10:58:31 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E864C30001A1; Mon, 3 Nov 2025 10:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8TA3kpc+YHMk0qkvoJlY74Sz5ck9Tnfwg9efSklIJdY=; b=FtfRZ9CVTiUfmVhKPYEivOoJ6Jvtjk23ziztkT+KiqhCxOVmTxHU+loFmzZf5wZjRf3NPl VWKnGM5EQzJKib7UTP0SGecTGYq/IQaZs597oQxMzYXTpjP5G4HrTXmTSbBZxN4kob2siY KA47bGoppxZqYq/03E9/ujSewAriQkc= X-MC-Unique: HPWkvdp0OjSYB0k_fXocgw-1 X-Mimecast-MFC-AGG-ID: HPWkvdp0OjSYB0k_fXocgw_1762167511 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 02/22] tests/functional: Fix problems in asset.py reported by pylint Date: Mon, 3 Nov 2025 11:57:59 +0100 Message-ID: <20251103105824.322039-3-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167564868154101 Content-Type: text/plain; charset="utf-8" From: Thomas Huth The "raise" without an Exception was a real problem, the other spots are rather cosmetics. Signed-off-by: Thomas Huth Message-ID: <20251015095454.1575318-2-thuth@redhat.com> --- tests/functional/qemu_test/asset.py | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/tests/functional/qemu_test/asset.py b/tests/functional/qemu_te= st/asset.py index ab3a7bb591d..bae40765ce4 100644 --- a/tests/functional/qemu_test/asset.py +++ b/tests/functional/qemu_test/asset.py @@ -112,7 +112,7 @@ def _wait_for_other_download(self, tmp_cache_file): return False =20 self.log.debug("Time out while waiting for %s!", tmp_cache_file) - raise + raise TimeoutError(f"Time out while waiting for {tmp_cache_file}") =20 def _save_time_stamp(self): ''' @@ -141,7 +141,7 @@ def fetch(self): self.log.info("Downloading %s to %s...", self.url, self.cache_file) tmp_cache_file =3D self.cache_file.with_suffix(".download") =20 - for retries in range(3): + for _retries in range(3): try: with tmp_cache_file.open("xb") as dst: with urllib.request.urlopen(self.url) as resp: @@ -181,7 +181,7 @@ def fetch(self): # server or networking problem if e.code =3D=3D 404: raise AssetError(self, "Unable to download: " - "HTTP error %d" % e.code) + "HTTP error %d" % e.code) from e continue except URLError as e: # This is typically a network/service level error @@ -190,7 +190,7 @@ def fetch(self): self.log.error("Unable to download %s: URL error %s", self.url, e.reason) raise AssetError(self, "Unable to download: URL error %s" % - e.reason, transient=3DTrue) + e.reason, transient=3DTrue) from e except ConnectionError as e: # A socket connection failure, such as dropped conn # or refused conn @@ -201,7 +201,7 @@ def fetch(self): except Exception as e: tmp_cache_file.unlink() raise AssetError(self, "Unable to download: %s" % e, - transient=3DTrue) + transient=3DTrue) from e =20 if not os.path.exists(tmp_cache_file): raise AssetError(self, "Download retries exceeded", transient= =3DTrue) @@ -214,7 +214,6 @@ def fetch(self): self.hash.encode('utf8')) except Exception as e: self.log.debug("Unable to set xattr on %s: %s", tmp_cache_file= , e) - pass =20 if not self._check(tmp_cache_file): tmp_cache_file.unlink() @@ -224,9 +223,10 @@ def fetch(self): # Remove write perms to stop tests accidentally modifying them os.chmod(self.cache_file, stat.S_IRUSR | stat.S_IRGRP) =20 - self.log.info("Cached %s at %s" % (self.url, self.cache_file)) + self.log.info("Cached %s at %s", self.url, self.cache_file) return str(self.cache_file) =20 + @staticmethod def precache_test(test): log =3D logging.getLogger('qemu-test') log.setLevel(logging.DEBUG) @@ -237,16 +237,17 @@ def precache_test(test): handler.setFormatter(formatter) log.addHandler(handler) for name, asset in vars(test.__class__).items(): - if name.startswith("ASSET_") and type(asset) =3D=3D Asset: + if name.startswith("ASSET_") and isinstance(asset, Asset): try: asset.fetch() except AssetError as e: if not e.transient: raise - log.error("%s: skipping asset precache" % e) + log.error("%s: skipping asset precache", e) =20 log.removeHandler(handler) =20 + @staticmethod def precache_suite(suite): for test in suite: if isinstance(test, unittest.TestSuite): @@ -254,9 +255,10 @@ def precache_suite(suite): elif isinstance(test, unittest.TestCase): Asset.precache_test(test) =20 - def precache_suites(path, cacheTstamp): + @staticmethod + def precache_suites(path, cache_tstamp): loader =3D unittest.loader.defaultTestLoader tests =3D loader.loadTestsFromNames([path], None) =20 - with open(cacheTstamp, "w") as fh: + with open(cache_tstamp, "w", encoding=3D'utf-8'): Asset.precache_suite(tests) --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167855; cv=none; d=zohomail.com; s=zohoarc; b=m00pdjnV0hUaminP8QCyBFcn5QQX0WvgjJ5At8fQtirtL4AwgUTV/KpVOjuBF82SOaPwgZmuGWQF7GRChFzJJD/ZhTLK/JpiSRrKG+Sq43rXTCyyXLTlKPXlsVGc0kNUZaHu6DFXbmjafO6FAUvhok8UHlLj5kljT0JUvkqv1n8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167855; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WgK7d3BIEFcYpQw9mKYN0KzotxKf5QOsInjiFYzG/0E=; b=DBrqNrhmbRenpYDgzvRmwv7AQrVg/uy6p29AkuOwRgfIM1yTPN149IXl+RvABfs2u4gKlDGX/rq0rl4iM5V6MQzOMrVhmKpUE0hZ0a07gnu3L5rNU8sRv9boKNh1llIlNNROqblqGkukGrqDW+0Do2EW1bSmvFGu7hEs4TQYR1k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17621678555911003.5784636957426; Mon, 3 Nov 2025 03:04:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsGq-0003l8-AC; Mon, 03 Nov 2025 05:58:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGn-0003kL-Le for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGl-0004B6-1y for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:41 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-g0P2mG6CPqyWaxcSf_rq9Q-1; Mon, 03 Nov 2025 05:58:34 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6A4B7180A221; Mon, 3 Nov 2025 10:58:33 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D83D430001A1; Mon, 3 Nov 2025 10:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WgK7d3BIEFcYpQw9mKYN0KzotxKf5QOsInjiFYzG/0E=; b=AL494f4O5/E5BlsFKvq/Qow9CgyHy4Hz7/YaPSY8Azvsy8oGiHlNTOQYwSSqLddNH356oT 0AsYVWEEDj0IGgG3vFyGela2hSyllyG0Bb1N9jmJEILH7BaScxZYw6d64zF4QIKeBhrq5X TVfw6tidUtyvIAmmcjt1W706BXbudeI= X-MC-Unique: g0P2mG6CPqyWaxcSf_rq9Q-1 X-Mimecast-MFC-AGG-ID: g0P2mG6CPqyWaxcSf_rq9Q_1762167513 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 03/22] tests/functional: Fix problems in decorators.py reported by pylint Date: Mon, 3 Nov 2025 11:58:00 +0100 Message-ID: <20251103105824.322039-4-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167857686158500 From: Thomas Huth The documentation strings should follow the function definition lines, not precede them. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth Message-ID: <20251015095454.1575318-3-thuth@redhat.com> --- tests/functional/qemu_test/decorators.py | 176 +++++++++++------------ 1 file changed, 87 insertions(+), 89 deletions(-) diff --git a/tests/functional/qemu_test/decorators.py b/tests/functional/qe= mu_test/decorators.py index b2392958041..807418359ab 100644 --- a/tests/functional/qemu_test/decorators.py +++ b/tests/functional/qemu_test/decorators.py @@ -10,136 +10,134 @@ =20 from .cmd import which =20 -''' -Decorator to skip execution of a test if the provided -environment variables are not set. -Example: =20 - @skipIfMissingEnv("QEMU_ENV_VAR0", "QEMU_ENV_VAR1") -''' def skipIfMissingEnv(*vars_): + ''' + Decorator to skip execution of a test if the provided + environment variables are not set. + Example: + + @skipIfMissingEnv("QEMU_ENV_VAR0", "QEMU_ENV_VAR1") + ''' missing_vars =3D [] for var in vars_: - if os.getenv(var) =3D=3D None: + if os.getenv(var) is None: missing_vars.append(var) =20 - has_vars =3D True if len(missing_vars) =3D=3D 0 else False + has_vars =3D len(missing_vars) =3D=3D 0 =20 return skipUnless(has_vars, f"Missing env var(s): {', '.join(missing_v= ars)}") =20 -''' - -Decorator to skip execution of a test if the list -of command binaries is not available in $PATH. -Example: - - @skipIfMissingCommands("mkisofs", "losetup") -''' def skipIfMissingCommands(*args): + ''' + Decorator to skip execution of a test if the list + of command binaries is not available in $PATH. + Example: + + @skipIfMissingCommands("mkisofs", "losetup") + ''' has_cmds =3D True for cmd in args: - if not which(cmd): - has_cmds =3D False - break + if not which(cmd): + has_cmds =3D False + break =20 return skipUnless(has_cmds, 'required command(s) "%s" not installed' % ", ".join(args)) =20 -''' -Decorator to skip execution of a test if the current -host operating system does match one of the prohibited -ones. -Example - - @skipIfOperatingSystem("Linux", "Darwin") -''' def skipIfOperatingSystem(*args): + ''' + Decorator to skip execution of a test if the current host + operating system does match one of the prohibited ones. + Example: + + @skipIfOperatingSystem("Linux", "Darwin") + ''' return skipIf(platform.system() in args, 'running on an OS (%s) that is not able to run this test= ' % ", ".join(args)) =20 -''' -Decorator to skip execution of a test if the current -host machine does not match one of the permitted -machines. -Example - - @skipIfNotMachine("x86_64", "aarch64") -''' def skipIfNotMachine(*args): + ''' + Decorator to skip execution of a test if the current + host machine does not match one of the permitted machines. + Example: + + @skipIfNotMachine("x86_64", "aarch64") + ''' return skipUnless(platform.machine() in args, 'not running on one of the required machine(s) "%s"'= % ", ".join(args)) =20 -''' -Decorator to skip execution of flaky tests, unless -the $QEMU_TEST_FLAKY_TESTS environment variable is set. -A bug URL must be provided that documents the observed -failure behaviour, so it can be tracked & re-evaluated -in future. +def skipFlakyTest(bug_url): + ''' + Decorator to skip execution of flaky tests, unless + the $QEMU_TEST_FLAKY_TESTS environment variable is set. + A bug URL must be provided that documents the observed + failure behaviour, so it can be tracked & re-evaluated + in future. =20 -Historical tests may be providing "None" as the bug_url -but this should not be done for new test. + Historical tests may be providing "None" as the bug_url + but this should not be done for new test. =20 -Example: + Example: =20 - @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/NNN") -''' -def skipFlakyTest(bug_url): + @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/NNN") + ''' if bug_url is None: bug_url =3D "FIXME: reproduce flaky test and file bug report or re= move" return skipUnless(os.getenv('QEMU_TEST_FLAKY_TESTS'), f'Test is unstable: {bug_url}') =20 -''' -Decorator to skip execution of tests which are likely -to execute untrusted commands on the host, or commands -which process untrusted code, unless the -$QEMU_TEST_ALLOW_UNTRUSTED_CODE env var is set. -Example: - - @skipUntrustedTest() -''' def skipUntrustedTest(): + ''' + Decorator to skip execution of tests which are likely + to execute untrusted commands on the host, or commands + which process untrusted code, unless the + $QEMU_TEST_ALLOW_UNTRUSTED_CODE env var is set. + Example: + + @skipUntrustedTest() + ''' return skipUnless(os.getenv('QEMU_TEST_ALLOW_UNTRUSTED_CODE'), 'Test runs untrusted code / processes untrusted data= ') =20 -''' -Decorator to skip execution of tests which need large -data storage (over around 500MB-1GB mark) on the host, -unless the $QEMU_TEST_ALLOW_LARGE_STORAGE environment -variable is set +def skipBigDataTest(): + ''' + Decorator to skip execution of tests which need large + data storage (over around 500MB-1GB mark) on the host, + unless the $QEMU_TEST_ALLOW_LARGE_STORAGE environment + variable is set =20 -Example: + Example: =20 - @skipBigDataTest() -''' -def skipBigDataTest(): + @skipBigDataTest() + ''' return skipUnless(os.getenv('QEMU_TEST_ALLOW_LARGE_STORAGE'), 'Test requires large host storage space') =20 -''' -Decorator to skip execution of tests which have a really long -runtime (and might e.g. time out if QEMU has been compiled with -debugging enabled) unless the $QEMU_TEST_ALLOW_SLOW -environment variable is set +def skipSlowTest(): + ''' + Decorator to skip execution of tests which have a really long + runtime (and might e.g. time out if QEMU has been compiled with + debugging enabled) unless the $QEMU_TEST_ALLOW_SLOW + environment variable is set =20 -Example: + Example: =20 - @skipSlowTest() -''' -def skipSlowTest(): + @skipSlowTest() + ''' return skipUnless(os.getenv('QEMU_TEST_ALLOW_SLOW'), 'Test has a very long runtime and might time out') =20 -''' -Decorator to skip execution of a test if the list -of python imports is not available. -Example: - - @skipIfMissingImports("numpy", "cv2") -''' def skipIfMissingImports(*args): + ''' + Decorator to skip execution of a test if the list + of python imports is not available. + Example: + + @skipIfMissingImports("numpy", "cv2") + ''' has_imports =3D True for impname in args: try: @@ -151,15 +149,15 @@ def skipIfMissingImports(*args): return skipUnless(has_imports, 'required import(s) "%s" not installed'= % ", ".join(args)) =20 -''' -Decorator to skip execution of a test if the system's -locked memory limit is below the required threshold. -Takes required locked memory threshold in kB. -Example: - - @skipLockedMemoryTest(2_097_152) -''' def skipLockedMemoryTest(locked_memory): + ''' + Decorator to skip execution of a test if the system's + locked memory limit is below the required threshold. + Takes required locked memory threshold in kB. + Example: + + @skipLockedMemoryTest(2_097_152) + ''' # get memlock hard limit in bytes _, ulimit_memory =3D resource.getrlimit(resource.RLIMIT_MEMLOCK) =20 --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167553; cv=none; d=zohomail.com; s=zohoarc; b=HYDrpddyVGYFHxPk8xPTY2qj58QI/n6rf7EL3exLAfB4Wil1vzXjO2wlz1dxCY8tzdpYHpy5Yv3dgexmXMPNXLOQvw5X+eR+R0liz3Hctxw8mBMnhZh4CKEbeXlUH9gt/QXl1NfWiXep9vgZ4s2fTBfzqT7pb8Y2/aNjWzH+/5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167553; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=suGlebXjfpwU4ew/WoQhKWZaxDwTD1m5Q6djyhTs2o4=; b=Aak85rSzaJ4b4Q4h4esAu1s4thu1YMyYkBKVANDFgGr5FYzIMMW3mflpKFD1yz7kbN45ZQMT3rk5JDhPZnNnak5+na0lU+0bwujcW2S6BSKsjPjLAhRVYOmc/f//AfKS9bE4UfHGGRVoCUse/nLpIalTbB0uG2DJjwmOilsgsws= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167553959244.24226842243957; Mon, 3 Nov 2025 02:59:13 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsGp-0003l3-TI; Mon, 03 Nov 2025 05:58:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGn-0003kE-Dg for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGl-0004CA-CL for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:41 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-aYvT7xT5PBef2HAwG4zD0Q-1; Mon, 03 Nov 2025 05:58:36 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AAD211955F2D; Mon, 3 Nov 2025 10:58:35 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0D00930001A8; Mon, 3 Nov 2025 10:58:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=suGlebXjfpwU4ew/WoQhKWZaxDwTD1m5Q6djyhTs2o4=; b=EMNxR28ebwr+/p68p0+zTUGAcGjze0e9zS5GAXaDHt1DQsHilp0OYSCRsvRPqowdV0BWyx ei5qTC4kqwYE6NeKy53CO90BM7yHoboTh7fHDFBX4Gbf3jF20+p3K8dt0oLVTIO8V/vNDc FHk/Jc1iUHIwwzT+EUu5h6xFUEX+QOw= X-MC-Unique: aYvT7xT5PBef2HAwG4zD0Q-1 X-Mimecast-MFC-AGG-ID: aYvT7xT5PBef2HAwG4zD0Q_1762167515 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson Subject: [PULL 04/22] tests/functional: Fix problems in linuxkernel.py reported by pylint Date: Mon, 3 Nov 2025 11:58:01 +0100 Message-ID: <20251103105824.322039-5-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167556847154100 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Use proper indentation here. Message-ID: <20251015095454.1575318-3-thuth@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/qemu_test/linuxkernel.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/functional/qemu_test/linuxkernel.py b/tests/functional/q= emu_test/linuxkernel.py index c4767527daf..eb10a813353 100644 --- a/tests/functional/qemu_test/linuxkernel.py +++ b/tests/functional/qemu_test/linuxkernel.py @@ -83,12 +83,12 @@ def launch_kernel(self, kernel, initrd=3DNone, dtb=3DNo= ne, console_index=3D0, self.vm.set_console(console_index=3Dconsole_index) self.vm.add_args('-kernel', kernel) if initrd: - self.vm.add_args('-initrd', initrd) + self.vm.add_args('-initrd', initrd) if dtb: - self.vm.add_args('-dtb', dtb) + self.vm.add_args('-dtb', dtb) self.vm.launch() if wait_for: - self.wait_for_console_pattern(wait_for) + self.wait_for_console_pattern(wait_for) =20 def check_http_download(self, filename, hashsum, guestport=3D8080, pythoncmd=3D'python3 -m http.server'): --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167667; cv=none; d=zohomail.com; s=zohoarc; b=mZUwsTv1NvMFR6A3M5ZGPbU+HIO53nYHgZBiLBwss2F8IdAYPc2DzdtRt8mx7WKmFL23EBl3PPCPG6NEXOhcDqvmGn1QcZ30hljqzIS9BUf3TpPr9qSgOKsV2GH3yr3dj/Y/BJUGasFDJqy5uJxjYMMKEN/A5jrpmmC/REWWm4w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167667; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Nf/Ytz5jJvKyHbVoMjGBTl6EhhVsR9/n9UTpq1uWonY=; b=WlVLQTlXRUzgNTg+FAXI7cKIjoVlHlhFSwTkqUpReL90/3N3BKx//Rsa5GxkjtM3LL7AWE6hSRn9MceAm9wpOa2JaenD24r5D9iNkyExDXDXP5Xg5hb/HjiDY7PN6HyZOgYBLqXjAjyyzpCScj2DW4DHgjf+Jg7i4SryHJfmTa8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167667708111.07309927830852; Mon, 3 Nov 2025 03:01:07 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsGt-0003mO-P9; Mon, 03 Nov 2025 05:58:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGs-0003lt-VO for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:46 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGp-0004FY-O5 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:46 -0500 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-p3HTJpmQPG-vCyS6CHf88g-1; Mon, 03 Nov 2025 05:58:38 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 99B141955E85; Mon, 3 Nov 2025 10:58:37 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 33C5030001A1; Mon, 3 Nov 2025 10:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167521; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Nf/Ytz5jJvKyHbVoMjGBTl6EhhVsR9/n9UTpq1uWonY=; b=aLCji00SvnO00v3+xJgv01e/JiS/HBIYCaGXd43f+6THv6zW0WzZ5Pp2ThGqfAtNfXNsmb kkDvrKT2iqPA2ERhA33AqtY0becRKG1WxPdGAzUVZfuHboegXJHVyISaAK5ROwdr4wPn6W a+dk/AiBn3Z9j/AmuSoWHK4ZMpd25+U= X-MC-Unique: p3HTJpmQPG-vCyS6CHf88g-1 X-Mimecast-MFC-AGG-ID: p3HTJpmQPG-vCyS6CHf88g_1762167517 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 05/22] tests/functional: Fix problems in uncompress.py reported by pylint Date: Mon, 3 Nov 2025 11:58:02 +0100 Message-ID: <20251103105824.322039-6-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167684259158500 From: Thomas Huth - put the doc strings in the right locations (after the "def" line) - use isinstance() instead of checking via type() Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth Message-ID: <20251015095454.1575318-6-thuth@redhat.com> --- tests/functional/qemu_test/uncompress.py | 40 ++++++++++++------------ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/tests/functional/qemu_test/uncompress.py b/tests/functional/qe= mu_test/uncompress.py index b7ef8f759b7..5bbdf8fe323 100644 --- a/tests/functional/qemu_test/uncompress.py +++ b/tests/functional/qemu_test/uncompress.py @@ -58,20 +58,20 @@ def zstd_uncompress(zstd_path, output_path): os.chmod(output_path, stat.S_IRUSR | stat.S_IWUSR) =20 =20 -''' -@params compressed: filename, Asset, or file-like object to uncompress -@params uncompressed: filename to uncompress into -@params format: optional compression format (gzip, lzma) +def uncompress(compressed, uncompressed, format=3DNone): + ''' + @params compressed: filename, Asset, or file-like object to uncompress + @params uncompressed: filename to uncompress into + @params format: optional compression format (gzip, lzma) =20 -Uncompresses @compressed into @uncompressed + Uncompresses @compressed into @uncompressed =20 -If @format is None, heuristics will be applied to guess the format -from the filename or Asset URL. @format must be non-None if @uncompressed -is a file-like object. + If @format is None, heuristics will be applied to guess the + format from the filename or Asset URL. @format must be non-None + if @uncompressed is a file-like object. =20 -Returns the fully qualified path to the uncompessed file -''' -def uncompress(compressed, uncompressed, format=3DNone): + Returns the fully qualified path to the uncompessed file + ''' if format is None: format =3D guess_uncompress_format(compressed) =20 @@ -84,19 +84,19 @@ def uncompress(compressed, uncompressed, format=3DNone): else: raise Exception(f"Unknown compression format {format}") =20 -''' -@params compressed: filename, Asset, or file-like object to guess - -Guess the format of @compressed, raising an exception if -no format can be determined -''' def guess_uncompress_format(compressed): - if type(compressed) =3D=3D Asset: + ''' + @params compressed: filename, Asset, or file-like object to guess + + Guess the format of @compressed, raising an exception if + no format can be determined + ''' + if isinstance(compressed, Asset): compressed =3D urlparse(compressed.url).path - elif type(compressed) !=3D str: + elif not isinstance(compressed, str): raise Exception(f"Unable to guess compression cformat for {compres= sed}") =20 - (name, ext) =3D os.path.splitext(compressed) + (_name, ext) =3D os.path.splitext(compressed) if ext =3D=3D ".xz": return "xz" elif ext =3D=3D ".gz": --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167632; cv=none; d=zohomail.com; s=zohoarc; b=ngRsn8tRb1vzx3za8NR1yr0MWkGl8t2oarPzqPYOPiJ+PEnLBigLQT6IGkviq5feqzdhLv24N+bJRKFckYBcXM51LtC5+nvXYDbsb3URdM1ohZdmHZLoB+W2zYKcJ2slehzqFZOGf3JA+xaFILNeFbDfl/Bq5oQuhf5qJa8odN4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167632; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4skMTA8q4CKiXos5Nlm3GfRuvfkktXGVS7jbmmBo9qg=; b=KUWAfcLJ6yxyu7QZxeZ1AHrrXNRW4muqIwR6HGRYVZdUIqD+ABU4PbKUnITp3RCfuXgzv9OWC9upBWCrto/m3xUAGcaEtWxrlWkzHsbTrorslqTYn91VcD6tGJr9e+7TGKL5BoLWMaEjnB7ViCJvgxiMtJwPmlw/qukE0eXws94= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167632660439.8022156504833; Mon, 3 Nov 2025 03:00:32 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsH0-0003oB-87; Mon, 03 Nov 2025 05:58:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGy-0003nq-Po for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:52 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGs-0004Hc-Ag for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:52 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-HjJ8z68ZOwKzpv97_5xSGg-1; Mon, 03 Nov 2025 05:58:40 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C0B9C180A236; Mon, 3 Nov 2025 10:58:39 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 44E1030001A1; Mon, 3 Nov 2025 10:58:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4skMTA8q4CKiXos5Nlm3GfRuvfkktXGVS7jbmmBo9qg=; b=hSUJ16usVXHA1R3EDBcQONFScN4Iv2kmOwHnEcFXYfnTnsUeli73GGSYnlYxHpP3vieUzw JpNRg1QtWE/C0mdMaBTtJljGqxCzNls7wtwPIhEFa2gfTlb+R7qj0EReHvHX6soLu6cc3S qao6A1hIJ0sJP3s3G6FSJ2yJP9ZAKKI= X-MC-Unique: HjJ8z68ZOwKzpv97_5xSGg-1 X-Mimecast-MFC-AGG-ID: HjJ8z68ZOwKzpv97_5xSGg_1762167519 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 06/22] tests/functional: Fix problems in utils.py reported by pylint Date: Mon, 3 Nov 2025 11:58:03 +0100 Message-ID: <20251103105824.322039-7-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167638960154100 From: Thomas Huth - put the doc strings in the right locations (after the "def" line) - use the right indentation (4 spaces) Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth Message-ID: <20251015095454.1575318-7-thuth@redhat.com> --- tests/functional/qemu_test/utils.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tests/functional/qemu_test/utils.py b/tests/functional/qemu_te= st/utils.py index e7c8de81654..826c267785b 100644 --- a/tests/functional/qemu_test/utils.py +++ b/tests/functional/qemu_test/utils.py @@ -17,10 +17,10 @@ def get_usernet_hostfwd_port(vm): res =3D vm.cmd('human-monitor-command', command_line=3D'info usernet') return get_info_usernet_hostfwd_port(res) =20 -""" -Round up to next power of 2 -""" def pow2ceil(x): + """ + Round up to next power of 2 + """ return 1 if x =3D=3D 0 else 2**(x - 1).bit_length() =20 def file_truncate(path, size): @@ -28,12 +28,12 @@ def file_truncate(path, size): with open(path, 'ab+') as fd: fd.truncate(size) =20 -""" -Expand file size to next power of 2 -""" def image_pow2ceil_expand(path): - size =3D os.path.getsize(path) - size_aligned =3D pow2ceil(size) - if size !=3D size_aligned: - with open(path, 'ab+') as fd: - fd.truncate(size_aligned) + """ + Expand file size to next power of 2 + """ + size =3D os.path.getsize(path) + size_aligned =3D pow2ceil(size) + if size !=3D size_aligned: + with open(path, 'ab+') as fd: + fd.truncate(size_aligned) --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167777; cv=none; d=zohomail.com; s=zohoarc; b=neeIVYbCAVGS1xVBNdQX+iPA0IvB37etlj5jXw800H5Plq8iJH3BGQmCC6qqQG0mCclbYGYFeildGHk2oa9g1u24eBEJOj+HYJjjZmBG4pLfQM3iS0cBzr8VTt1sw6ikcxfCOMBREEGKriOCfMTTuZ/OHMTkmdaHixEwlh1N1l4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167777; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hSBy+vv/JAIqO/yYed8i7OebcPCRF9mzIK2GU6wFWj0=; b=mQ+J4PndRVC0ekVbSgyNn9K8DxFvu3o6ggWFDloK4+XrsKIuYF7+5KoUliqIwyPAcRihmSX03AujqxsTJGj7lA8f2Qr4HBWVKHa26aydbtH3r2Ga8P1qiQ6O7EqGr1PEmGgIEZ8W6Y74jzc5Ugzaj9Cp+RcgV1ZICp/XVn5IuK0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167777897451.8420272723919; Mon, 3 Nov 2025 03:02:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsGv-0003mp-Fs; Mon, 03 Nov 2025 05:58:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGt-0003mL-K3 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:47 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGr-0004HK-JF for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:47 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-cjQXnXeBN6iuR526oS5Q5Q-1; Mon, 03 Nov 2025 05:58:42 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 11D751955F06; Mon, 3 Nov 2025 10:58:42 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5BA6C30001A1; Mon, 3 Nov 2025 10:58:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hSBy+vv/JAIqO/yYed8i7OebcPCRF9mzIK2GU6wFWj0=; b=CCcC/KgReb3n8IPTFyXrGTlHHAUt7xUbwjHIXqzXnuBMv8aVHpTC6U+JNZB4nOtzOonUVW HV3PluBkMNGd4Y5jRR4NFkwPI79qBUMhDvJu4+Wf+4Rg49ZS1hzxSlUySBvKVIRzZZzLGu ytI7InPve8PSwghQG6AOHIo1cBfpS6M= X-MC-Unique: cjQXnXeBN6iuR526oS5Q5Q-1 X-Mimecast-MFC-AGG-ID: cjQXnXeBN6iuR526oS5Q5Q_1762167522 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= Subject: [PULL 07/22] tests/functional/arm/test_aspeed_ast1030: Remove unused import Date: Mon, 3 Nov 2025 11:58:04 +0100 Message-ID: <20251103105824.322039-8-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167780654154100 From: Thomas Huth This file does not use LinuxKernelTest directly (but AspeedTest), so we can remove this unnecessary import here. Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Thomas Huth Message-ID: <20251024124016.799687-1-thuth@redhat.com> --- tests/functional/arm/test_aspeed_ast1030.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/functional/arm/test_aspeed_ast1030.py b/tests/functional= /arm/test_aspeed_ast1030.py index 60e2b0251c6..d1822edd8f1 100755 --- a/tests/functional/arm/test_aspeed_ast1030.py +++ b/tests/functional/arm/test_aspeed_ast1030.py @@ -6,9 +6,8 @@ # # SPDX-License-Identifier: GPL-2.0-or-later =20 -from qemu_test import LinuxKernelTest, Asset from aspeed import AspeedTest -from qemu_test import exec_command_and_wait_for_pattern +from qemu_test import Asset, exec_command_and_wait_for_pattern =20 =20 class AST1030Machine(AspeedTest): --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167782; cv=none; d=zohomail.com; s=zohoarc; b=js9saXtKCyy9jzjuMFAcsG4gNX4bSZqO+zQ7L9iNhE6dWD8zIwAGKakBiH100Isz3pg3b7mNT8oMFvbELlkNHFVtNGO+WiIsy+jirDWOvUW9ppdzfO0ZGjF9iR9k69Em+9PKzXT0UC+TwhyIyYAxpLGuNYp5EUyzToNzAT//PsM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167782; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RUKN2jl1ZyAKFU991n52ujfJQ7mv2tkxp1xJ6e+OQIM=; b=CRIn82L6+GqNwx11aMoFzsLb2zMgJ4YShweTwFOkD3AX7QBqv1dJGTV0dFYLRO5aqBUHVvPLumHSwxeLuz++KIiATS5DuJ5FBosikIvMuSai7cUb7L9p9gXYFROI7lXDp90OWDwV6PYQj0M6G3AGdeRZZSevz/ZWI656E7hrJGc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167782472366.22138811666275; Mon, 3 Nov 2025 03:03:02 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsGy-0003nc-8A; Mon, 03 Nov 2025 05:58:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGw-0003n8-HB for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGu-0004Jo-AR for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:50 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-1alp3uAqMm6_nsDY07sOfA-1; Mon, 03 Nov 2025 05:58:45 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 76ADF1955F79; Mon, 3 Nov 2025 10:58:44 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8F32130001A1; Mon, 3 Nov 2025 10:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RUKN2jl1ZyAKFU991n52ujfJQ7mv2tkxp1xJ6e+OQIM=; b=iSmEKucTv0li7UZRlNvMofqCAANu8cH5TlBg2B3VV3uQjcun81e/z2r3szZ7qdwrqGRcxN tulrsAY8V7C3o1e6nqnbp6eaEq+CfEh72NIMdYdcAzc7VVaL60vjdzwQ8pZCoUDtgZueRH ScQkLROwSVopNr8/Py9VSnDLc6JvGz8= X-MC-Unique: 1alp3uAqMm6_nsDY07sOfA-1 X-Mimecast-MFC-AGG-ID: 1alp3uAqMm6_nsDY07sOfA_1762167524 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Vladimir Sementsov-Ogievskiy Subject: [PULL 08/22] tests/functional/.../testcase.py: better socketdir cleanup Date: Mon, 3 Nov 2025 11:58:05 +0100 Message-ID: <20251103105824.322039-9-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167784883154100 Content-Type: text/plain; charset="utf-8" From: Vladimir Sementsov-Ogievskiy TemporaryDirectory prefer explicit call to .cleanup() (or use context manager). Otherwise it may produce a warning like: /usr/lib/python3.10/tempfile.py:1008: \ ResourceWarning: Implicitly cleaning up \ Currently, the only test using socket_dir() is tests/functional/x86_64/test_vfio_user_client.py, and it does print this warning, at least with python 3.10.12. With this commit, the warning disappears. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Thomas Huth Message-ID: <20251025165809.930670-2-vsementsov@yandex-team.ru> Signed-off-by: Thomas Huth --- tests/functional/qemu_test/testcase.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu= _test/testcase.py index 2c0abde3957..a122acb5609 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -233,7 +233,7 @@ def tearDown(self): if "QEMU_TEST_KEEP_SCRATCH" not in os.environ: shutil.rmtree(self.workdir) if self.socketdir is not None: - shutil.rmtree(self.socketdir.name) + self.socketdir.cleanup() self.socketdir =3D None self.machinelog.removeHandler(self._log_fh) self.log.removeHandler(self._log_fh) --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167619; cv=none; d=zohomail.com; s=zohoarc; b=Ake6tIkmLQOZgpNulECstiKFX6cXG+3GTu7to6IICcPiO9EOkODXfwIGr8g4+WK96Uw/XlwvaJPk6kCGK1Uc6XQWyhpIQu7XwwQ+V9lTFfY01IarzVg4xRrs1M6WzBu8dMpYgVZ46HqgaX6p+3eT6PIwnLXbliaR91PLZGbtkRQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167619; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3LMhIyRgzgW+wyd5rEWS2BizSkkIZyVD9i9Z7R9alhA=; b=mMUV5epM1vQOjIK8yXq99qQuoEIaBhSDlU4FjyJrIZq6tDfsqyc6gm5hVReEeJ4rFAo6HKbxOBSKWt1Z0J6boW4NmJN8/ZhFXbQqtJL9lJw4AHnUd+2f8eL7mfL67FJ6VcO/seP8g5NZBkUbRJTmFB59uDW6Dk4H/kuPaK2++n4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167619056872.6355969827679; Mon, 3 Nov 2025 03:00:19 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsH3-0003pr-PK; Mon, 03 Nov 2025 05:58:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsH1-0003om-NA for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGz-0004Nm-KT for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:55 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-5cBBm6i6Ncy9ynu6oaGDfg-1; Mon, 03 Nov 2025 05:58:48 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C89B219541B2; Mon, 3 Nov 2025 10:58:46 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 19ED430001A8; Mon, 3 Nov 2025 10:58:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3LMhIyRgzgW+wyd5rEWS2BizSkkIZyVD9i9Z7R9alhA=; b=EDKpb6jj6c1bJVL6WTyNC7+XDMfqWk3nK7eLmMxmEMY6WC4AnNE2SuV3XTTXYDNhm8CGdW 2m4bKLt8AgYCu7s4c45kwnAjY9DrYjXtt4GlqjAq7aDZk7P6Pqu4A7ZJwbp1j0KGzh6Rg4 f2bYV95qPZgtQPFBbI/kotKFMyYMCsM= X-MC-Unique: 5cBBm6i6Ncy9ynu6oaGDfg-1 X-Mimecast-MFC-AGG-ID: 5cBBm6i6Ncy9ynu6oaGDfg_1762167527 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Vladimir Sementsov-Ogievskiy Subject: [PULL 09/22] MAINTAINERS: fix functional tests section Date: Mon, 3 Nov 2025 11:58:06 +0100 Message-ID: <20251103105824.322039-10-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167619831158500 From: Vladimir Sementsov-Ogievskiy Without "S: Maintained", ./scripts/get_maintainer.pl shows "unknown" role instead of "maintainer" for "M: " entry, it's confusing. I really hope that functional tests are maintained:) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Thomas Huth Message-ID: <20251025165809.930670-3-vsementsov@yandex-team.ru> Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a6a1d36f52d..71c86ee8ce2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4412,6 +4412,7 @@ Functional testing framework M: Thomas Huth R: Philippe Mathieu-Daud=C3=A9 R: Daniel P. Berrange +S: Maintained F: docs/devel/testing/functional.rst F: scripts/clean_functional_cache.py F: tests/functional/qemu_test/ --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167563; cv=none; d=zohomail.com; s=zohoarc; b=Vrguesw0e6KgZllq8tWxcgKfzQTJNOkkDgNgMFyUok9x0uL/wsZoEGO4aWS0KtEL1PlIc6mkhaZ8d9IWfid3wf3i03ymzKPb6S7kue4G+liCHbrqKKugBoAlXHim0ABaM4GYhT9zTN3jHj17bWutbkoqgo6cHlULnOGgZrya9f4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167563; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/c91D2IhVYFYL/D/3jHAKa8Lh0bpHjFspI9JM4yXLr4=; b=RGDPNkWFnC+tXmcyf8MLvYwYgdeVK0UJxNtrEjuSrxp9RxpW2BhtzhMJNHfPENbojQ2LR73YBfBJ8+KljsnKYNSaODh+GZoKVe3Nfo26mhKFA13NB9sNF6pHR5ST3aBh/uaJvB74Ioxy0W6kHbH44pUb27UXJ51P6DPzwOOJa2Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167563744998.4861831044255; Mon, 3 Nov 2025 02:59:23 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsH1-0003oo-QT; Mon, 03 Nov 2025 05:58:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsH0-0003oN-PP for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:54 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsGy-0004No-Qo for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:54 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-K0PWMBQ1OKyRe6PR4BN1tQ-1; Mon, 03 Nov 2025 05:58:49 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D0F4E19540E8; Mon, 3 Nov 2025 10:58:48 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3462A30001A1; Mon, 3 Nov 2025 10:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167531; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/c91D2IhVYFYL/D/3jHAKa8Lh0bpHjFspI9JM4yXLr4=; b=fq6nF3N9JJLroMJTiBisnWnrUYJCDlFFbEQF6quf3oOju14IuBMfTgWOnlSDVNgDaRp5aE NC+Jg3fFyUVOGyyPD/sXPJU+ymRu/34R5pTc6dquHHTYPuIP2rwvWa2Ciy4UFBNXXm/cFV 9sprvNR4ekqPQ0LSAMo64/Yhc75djMs= X-MC-Unique: K0PWMBQ1OKyRe6PR4BN1tQ-1 X-Mimecast-MFC-AGG-ID: K0PWMBQ1OKyRe6PR4BN1tQ_1762167529 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 10/22] tests/functional/migration: Fix bad indentation Date: Mon, 3 Nov 2025 11:58:07 +0100 Message-ID: <20251103105824.322039-11-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167564826154100 From: Thomas Huth pylint complains about bad indentation in two lines. Use 12 spaces instead of 11 spaces to get it right. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Thomas Huth Message-ID: <20251027112347.54190-1-thuth@redhat.com> --- tests/functional/migration.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/functional/migration.py b/tests/functional/migration.py index 07395544832..2bfb1f77901 100644 --- a/tests/functional/migration.py +++ b/tests/functional/migration.py @@ -30,11 +30,11 @@ def assert_migration(self, src_vm, dst_vm): =20 end =3D time.monotonic() + self.timeout while time.monotonic() < end and not self.migration_finished(src_v= m): - time.sleep(0.1) + time.sleep(0.1) =20 end =3D time.monotonic() + self.timeout while time.monotonic() < end and not self.migration_finished(dst_v= m): - time.sleep(0.1) + time.sleep(0.1) =20 self.assertEqual(src_vm.cmd('query-migrate')['status'], 'completed= ') self.assertEqual(dst_vm.cmd('query-migrate')['status'], 'completed= ') --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167618; cv=none; d=zohomail.com; s=zohoarc; b=XdxqYFT6rbQOAmu5jdTIMK81ddV7sANPJgQ7/q0lsI4zxMq62FeHd1pzIdi/20O9YNmWE565pDc0WgfcK9UyUyUeX9KnUGzcrRIy+pdd55y5lpjpxPo4kmh0K8XqfbpQB05lMoaIvMb4VOelfvRFVlsj6pS8gip6Ozr+rm/L3lM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167618; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Hff/k/1RIB4r6If5d41QAniZ0RCrNVZJzbv+PSn88Hw=; b=Rzj/NzjrGLefFEGVE3aL+NEu7vBBjqeHCrXSoRpX91x950Y7Ccr6xJ3/z3R6q+Zgu+LpITIRArnulfr6sSw2caGyQlV69wpmRc3bvV/4SgFBJ1kK4I/XQBIX1Z8ji9IhWEB6/OsTr7JwPg2Cq6R14IO02d8axmuM13sHEMhfQhQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167618669748.871025826727; Mon, 3 Nov 2025 03:00:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHE-0003sT-UW; Mon, 03 Nov 2025 05:59:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHB-0003re-JK for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsH3-0004RH-U9 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:04 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-q_s7PCTeNPWukrpqrIIxHg-1; Mon, 03 Nov 2025 05:58:51 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CE4471800669; Mon, 3 Nov 2025 10:58:50 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5625930001BC; Mon, 3 Nov 2025 10:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hff/k/1RIB4r6If5d41QAniZ0RCrNVZJzbv+PSn88Hw=; b=CAIWQFw5f1ZENgfrKRYkIVPjYVNjtqgVfDE8hZqHs9BzcSjGxMEQ37cDmFwnnw55NdTkkV 3/gf4iSPvIXhrZ3qQgEJSuCk/NtEulrd4oBveKQ2A8/5udAX49QAeVAeXHqmUwCBc+2HC/ DM0M4bGngLQCXyD06lYnK8/XKdvkUd4= X-MC-Unique: q_s7PCTeNPWukrpqrIIxHg-1 X-Mimecast-MFC-AGG-ID: q_s7PCTeNPWukrpqrIIxHg_1762167530 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Manos Pitsidianakis Subject: [PULL 11/22] tests/functional/ppc64/test_mac99: Fix style issues reported by pylint Date: Mon, 3 Nov 2025 11:58:08 +0100 Message-ID: <20251103105824.322039-12-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167639026154100 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complained about lines being too long here, and mac99Test not following the usual CamelCase capitalization. Reviewed-by: Manos Pitsidianakis Signed-off-by: Thomas Huth Message-ID: <20251029080502.52938-1-thuth@redhat.com> --- tests/functional/ppc64/test_mac99.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/functional/ppc64/test_mac99.py b/tests/functional/ppc64/= test_mac99.py index dfd9c01371d..a3261a8330a 100755 --- a/tests/functional/ppc64/test_mac99.py +++ b/tests/functional/ppc64/test_mac99.py @@ -7,14 +7,16 @@ from qemu_test import LinuxKernelTest, Asset from qemu_test import exec_command_and_wait_for_pattern =20 -class mac99Test(LinuxKernelTest): +class Mac99Test(LinuxKernelTest): =20 ASSET_BR2_MAC99_LINUX =3D Asset( - 'https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main/bui= ldroot/qemu_ppc64_mac99-2023.11-8-gdcd9f0f6eb-20240105/vmlinux', + ('https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main' + '/buildroot/qemu_ppc64_mac99-2023.11-8-gdcd9f0f6eb-20240105/vmlin= ux'), 'd59307437e4365f2cced0bbd1b04949f7397b282ef349b7cafd894d74aadfbff') =20 ASSET_BR2_MAC99_ROOTFS =3D Asset( - 'https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main//bu= ildroot/qemu_ppc64_mac99-2023.11-8-gdcd9f0f6eb-20240105/rootfs.ext2', + ('https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main' + '/buildroot/qemu_ppc64_mac99-2023.11-8-gdcd9f0f6eb-20240105/rootf= s.ext2'), 'bbd5fd8af62f580bc4e585f326fe584e22856572633a8333178ea6d4ed4955a4') =20 def test_ppc64_mac99_buildroot(self): --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167651; cv=none; d=zohomail.com; s=zohoarc; b=SQTnPO1oX6dG8E6NKCvGXgGe6PZE5TtEc1cuAy9MDPczVYmuME/EjzcfRgP8LfJguoLT21+OXFEj3x0v0sFUuJqNdsREOqtioNM4uKQFZKHKlZ3AqPYRDuBBZLZ5Mk9x+UdEzZ1itWIscXO0Nk1XjARycsp7yXxKAALZT92EiYI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167651; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y61sGUQ8j9Y2GxmKZ9y4icSR+ggl2UPV90MqL5hxz7c=; b=TfTfteX6PiFBmYw+1RoJRqHdhIc3snAdUyPsjCN+ZaKwyYE3mvdf+dwzV1J1gtzNJj93oGGrrBe8RheRxvgEcT8DXTBnhgwIG7Lj8znsE4fNbckleZV5D88nzdwSxhSssvhbXAlOp8EtIAXmrwEezOcBxwhmv5DUvQ83YDrmgM4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167651784102.89243092454774; Mon, 3 Nov 2025 03:00:51 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsH6-0003qc-DU; Mon, 03 Nov 2025 05:59:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsH5-0003qM-3y for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:59 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsH2-0004RF-Ta for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:58:58 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-iyisHhbyNa-sbqvVCDIfYA-1; Mon, 03 Nov 2025 05:58:53 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 05B8F180136C; Mon, 3 Nov 2025 10:58:53 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 585D630001A1; Mon, 3 Nov 2025 10:58:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Y61sGUQ8j9Y2GxmKZ9y4icSR+ggl2UPV90MqL5hxz7c=; b=gmsNTvum1xrSPlNhNwD/e3PlH1rdDcCxK/qjYi6Bq1FeEOfREB5c2d+bv90R08/AQ0SOJl CmzE9Xi6o2Ky3k0PK6t7nDhAkpKqV7+3WDrq23x+9SWRezrx1x9To0/muCJsdPkcOE/z2+ /9bE+19IEQOCgnRVXpzKiPCxlsDDcNA= X-MC-Unique: iyisHhbyNa-sbqvVCDIfYA-1 X-Mimecast-MFC-AGG-ID: iyisHhbyNa-sbqvVCDIfYA_1762167533 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 12/22] tests/functional/rx/test_gdbsim: Remove unused variables Date: Mon, 3 Nov 2025 11:58:09 +0100 Message-ID: <20251103105824.322039-13-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167653735154100 From: Thomas Huth Remove/comment some unused variables to make pylint happy. Reviewed-by: Daniel P. Berrang=C3=A9 Signed-off-by: Thomas Huth Message-ID: <20251029081805.63147-1-thuth@redhat.com> --- tests/functional/rx/test_gdbsim.py | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/functional/rx/test_gdbsim.py b/tests/functional/rx/test_= gdbsim.py index 49245793e17..d31f9a42d67 100755 --- a/tests/functional/rx/test_gdbsim.py +++ b/tests/functional/rx/test_gdbsim.py @@ -17,9 +17,6 @@ =20 class RxGdbSimMachine(QemuSystemTest): =20 - timeout =3D 30 - KERNEL_COMMON_COMMAND_LINE =3D 'printk.time=3D0 ' - ASSET_UBOOT =3D Asset( ('https://github.com/philmd/qemu-testing-blob/raw/rx-gdbsim/rx/gdb= sim/' 'u-boot.bin'), @@ -47,7 +44,7 @@ def test_uboot(self): self.vm.launch() uboot_version =3D 'U-Boot 2016.05-rc3-23705-ga1ef3c71cb-dirty' wait_for_console_pattern(self, uboot_version) - gcc_version =3D 'rx-unknown-linux-gcc (GCC) 9.0.0 20181105 (experi= mental)' + #gcc_version =3D 'rx-unknown-linux-gcc (GCC) 9.0.0 20181105 (exper= imental)' # FIXME limit baudrate on chardev, else we type too fast # https://gitlab.com/qemu-project/qemu/-/issues/2691 #exec_command_and_wait_for_pattern(self, 'version', gcc_version) @@ -63,7 +60,6 @@ def test_linux_sash(self): kernel_path =3D self.ASSET_KERNEL.fetch() =20 self.vm.set_console() - kernel_command_line =3D self.KERNEL_COMMON_COMMAND_LINE + 'earlyco= n' self.vm.add_args('-kernel', kernel_path, '-dtb', dtb_path, '-no-reboot') --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167688; cv=none; d=zohomail.com; s=zohoarc; b=MP48rkbJhvz2S0B7hktRj6IBXN9k4v31jJ7RaAJCvsOldxWZ8LioWZNTcCZGbFfyfdgqW9vKeO+skaAOXN3aFtAt6S+q6MMTcI9nQTg/RVZmvA8EZ8e92gbePcVM/sWe/TXc2F7Prx+Uv+E84P2c/bAb/bHwS4LpfY1EPru37vQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167688; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=F5abZUPq5OvZhrg8KiZ3sPDIKPaAPgPQiaHApqNdmC8=; b=EW/CpTIBlkNBmMQF7s2wZvLI0Mob5AKkzjyofdiIUJQRyAhm9mVEY+BEeyy4LDPY7KF3/DUchoBmE53Xj5dRpsvU9h0e9kn/njTIChcE59wX5IYvcGPWnY1KLMnhtEaWFQlfySGeFPePDW90T5P5BFAtFSMd1yzd2jlzz2cbj8M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167688001361.47870568655446; Mon, 3 Nov 2025 03:01:28 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHI-0003xi-OT; Mon, 03 Nov 2025 05:59:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHC-0003ro-1J for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsH6-0004UA-TX for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:05 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-312-qcSEqZuOMEOpnOxYCSQVKA-1; Mon, 03 Nov 2025 05:58:56 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 54B5419541B5; Mon, 3 Nov 2025 10:58:55 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 954E630001A8; Mon, 3 Nov 2025 10:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167539; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F5abZUPq5OvZhrg8KiZ3sPDIKPaAPgPQiaHApqNdmC8=; b=V0UqNQsWwcccxsjTu216v204CqV+6eYpUeAsU829tBMxehDhO7fqiphZ64RQ8ggXqxMrfW 2zPGnIK/+Q4lRMk8JZ5xzjKVuvkrNqIA2n9TP20lCH10/H4yaouqEGdk0MHP1rZbhe4YEp YxfQAC/GHvQAitGrGHZAtkpEyz6Cg2U= X-MC-Unique: qcSEqZuOMEOpnOxYCSQVKA-1 X-Mimecast-MFC-AGG-ID: qcSEqZuOMEOpnOxYCSQVKA_1762167535 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Zhao Liu Subject: [PULL 13/22] tests/functional/x86_64/test_acpi_bits: Silence warnings reported by pylint Date: Mon, 3 Nov 2025 11:58:10 +0100 Message-ID: <20251103105824.322039-14-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167696315158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complains about too many positional arguments for the __init__ function of the QEMUBitsMachine class, use a "*" to enforce argument passing by names instead (which the calling sites are doing here already). Second, use lazy logging when calling self.log.info() with a "%s" format string, and drop a superfluous "else:" that is not necessary after a "raise" statement. Reviewed-by: Zhao Liu Signed-off-by: Thomas Huth Message-ID: <20251029081514.60802-1-thuth@redhat.com> --- tests/functional/x86_64/test_acpi_bits.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/x86_64/test_acpi_bits.py b/tests/functional/x= 86_64/test_acpi_bits.py index 9a2816533d6..ec716d643bf 100755 --- a/tests/functional/x86_64/test_acpi_bits.py +++ b/tests/functional/x86_64/test_acpi_bits.py @@ -57,6 +57,7 @@ class QEMUBitsMachine(QEMUMachine): # pylint: disable=3Dt= oo-few-public-methods """ def __init__(self, binary: str, + *, args: Sequence[str] =3D (), wrapper: Sequence[str] =3D (), name: Optional[str] =3D None, @@ -225,7 +226,7 @@ def generate_bits_iso(self): stdout=3Dsubprocess.PIPE, stderr=3Dsubprocess.STDOUT, check=3DTrue) - self.log.info("grub-mkrescue output %s" % proc.stdout) + self.log.info("grub-mkrescue output %s", proc.stdout) else: subprocess.check_call([mkrescue_script, '-o', iso_file, bits_dir], @@ -287,9 +288,8 @@ def parse_log(self): except AssertionError as e: self._print_log(log) raise e - else: - if os.getenv('V') or os.getenv('BITS_DEBUG'): - self._print_log(log) + if os.getenv('V') or os.getenv('BITS_DEBUG'): + self._print_log(log) =20 def tearDown(self): """ --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167571; cv=none; d=zohomail.com; s=zohoarc; b=K9CT0YO658cCYAeLlp03tBCoq3F6BVo9UyUDKGAtJmoiFGPxJj+uW7gcw4jYF+/pjlhpSorK1kUAgb9U8DO8yxR6oWXP8v8HbUo8uAPLYcjg4uUrhjuYgdWCeCGOwvmS3SQyq7JJpRyq3Bi9r6V8PXiw37onA/Ss8LvnGVRYswE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167571; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=HSYsrw2Y919OGidLpK2HDGa8Ib3a619BuATvAZ3gJ8c=; b=TBjnerUTl8/lcSEbE0RNM2HgFJCspPxfi0AqWAu3vhA4MujukI09KmoIAX96qihtt5myh7ddO412HToaf+Enl5lHTZDjzmVOPLSGYghb63sWNimq3Eyd5WdCnyplbi0tIVlmDqcWMzxGC4gm8A2DXM0RhMN5+JlUwNmfMKoNC4Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167571443662.2383335849044; Mon, 3 Nov 2025 02:59:31 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHP-00042i-B2; Mon, 03 Nov 2025 05:59:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHO-00042A-B7 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:18 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHA-0004Vi-29 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:16 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-399-fSwcKSxANw2w69Okp--cPg-1; Mon, 03 Nov 2025 05:58:59 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C8BD1180A22D; Mon, 3 Nov 2025 10:58:57 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ED14B30001A1; Mon, 3 Nov 2025 10:58:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167542; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HSYsrw2Y919OGidLpK2HDGa8Ib3a619BuATvAZ3gJ8c=; b=UOlEoL7Eh8meXiN0l1i0VVuVCwdCSfgfQh0nq/raiqDgTd5EgMk9UZCbTX00QeF7Vbk7p/ roX9ARQtaQv3/rYS3GyOCfVFACkA0FQCB2IzarrPKykfrruQOPcHluQKrniE7xix5r0NqX xxD9Eaqg3y7Mj3j/A4U5Jjv94UpuGtw= X-MC-Unique: fSwcKSxANw2w69Okp--cPg-1 X-Mimecast-MFC-AGG-ID: fSwcKSxANw2w69Okp--cPg_1762167538 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Zhao Liu , Manos Pitsidianakis Subject: [PULL 14/22] tests/functional/x86_64/test_virtio_balloon: Fix cosmetic issues from pylint Date: Mon, 3 Nov 2025 11:58:11 +0100 Message-ID: <20251103105824.322039-15-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167581372158500 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complains about some style issues in this file: Unused variables should be marked with an underscore, "when > then and when < now" can be simplified to "now > when > then" and expectData doesn't conform to the usual snake_case naming style. Reviewed-by: Zhao Liu Reviewed-by: Manos Pitsidianakis Signed-off-by: Thomas Huth Message-ID: <20251029075342.47335-1-thuth@redhat.com> --- tests/functional/x86_64/test_virtio_balloon.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/functional/x86_64/test_virtio_balloon.py b/tests/functio= nal/x86_64/test_virtio_balloon.py index 5877b6c408c..7a579e0d69a 100755 --- a/tests/functional/x86_64/test_virtio_balloon.py +++ b/tests/functional/x86_64/test_virtio_balloon.py @@ -66,7 +66,7 @@ def assert_initial_stats(self): when =3D ret.get('last-update') assert when =3D=3D 0 stats =3D ret.get('stats') - for name, val in stats.items(): + for _name, val in stats.items(): assert val =3D=3D UNSET_STATS_VALUE =20 def assert_running_stats(self, then): @@ -87,10 +87,10 @@ def assert_running_stats(self, then): =20 now =3D time.time() =20 - assert when > then and when < now + assert now > when > then stats =3D ret.get('stats') # Stat we expect this particular Kernel to have set - expectData =3D [ + expect_data =3D [ "stat-available-memory", "stat-disk-caches", "stat-free-memory", @@ -103,7 +103,7 @@ def assert_running_stats(self, then): "stat-total-memory", ] for name, val in stats.items(): - if name in expectData: + if name in expect_data: assert val !=3D UNSET_STATS_VALUE else: assert val =3D=3D UNSET_STATS_VALUE --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167582; cv=none; d=zohomail.com; s=zohoarc; b=F+rwEY2PzTAeDUkqtX/ZzGsTnc8AXyOWjdTcvDzUbRXqWglSKUAPXCjL/mTv9AzQh9NrQBjh4A6n70GXmSz/NWm8KKYTyEZIzZbD1cb+A0YyZVdv+DjVTqXFtv/qUrHox8dm89c0qCxGfOfVmGMaigZXaDfyFoZstyrA+FumYX0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167582; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Xp3u8EowvHKtIDJCJbY2AvxOiezuc0g+CF3lzUo74ZM=; b=fi1L7hd2I3GRwtzKT75nQ50HOv3E2Xod+QxtEHGZMU235nJ/22WOLslhkqDGmqQsSu72KBPeN+d0bgd3NM9wGYrwxvYmh38vMVKkc5/pq1yJV4MkwD6j7m0gRoPu12lAdhhcIeIhUY9M+aSH+c+fkf3VFJlFZI1EioGhV96sIl8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167582190512.5886630640885; Mon, 3 Nov 2025 02:59:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHO-000428-8o; Mon, 03 Nov 2025 05:59:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHM-000401-Bb for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHB-0004Vy-SO for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:14 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-158-BqSJYWS9PxC0EnsW5OF5eg-1; Mon, 03 Nov 2025 05:59:00 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E8180195420D; Mon, 3 Nov 2025 10:58:59 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 80A7630001A8; Mon, 3 Nov 2025 10:58:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xp3u8EowvHKtIDJCJbY2AvxOiezuc0g+CF3lzUo74ZM=; b=PRt3LuAWc3L5gVaE9iHuRP19hf7uOANaPciqciMhuDjsfGDoBKY/HCXH+4tae8zK124Eew hsgP6WUtQMW/UzKTBwsE9pSPTE/rfLrQVQIQV90RdkpeE0t5zVvPpwS0UiIhx7wHBnhuoa mYqi6qesstptKP4FVtRXT8mlMf2JU3c= X-MC-Unique: BqSJYWS9PxC0EnsW5OF5eg-1 X-Mimecast-MFC-AGG-ID: BqSJYWS9PxC0EnsW5OF5eg_1762167540 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , Glenn Miles Subject: [PULL 15/22] tests/functional/ppc64: Fix class names to silence pylint warnings Date: Mon, 3 Nov 2025 11:58:12 +0100 Message-ID: <20251103105824.322039-16-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167585143154100 Content-Type: text/plain; charset="utf-8" From: Thomas Huth Pylint complains about inconsistent CamelCase names here, so let's slightly change the names to make pylint happy again. In the sam460ex test, also split a line where pylint was complaining about it being too long. Reviewed-by: Glenn Miles Signed-off-by: Thomas Huth Message-ID: <20251029141946.86110-1-thuth@redhat.com> --- tests/functional/ppc/test_74xx.py | 2 +- tests/functional/ppc/test_sam460ex.py | 5 +++-- tests/functional/ppc64/test_powernv.py | 2 +- tests/functional/ppc64/test_pseries.py | 2 +- tests/functional/ppc64/test_reverse_debug.py | 2 +- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/functional/ppc/test_74xx.py b/tests/functional/ppc/test_= 74xx.py index 5386016f261..219c7991aca 100755 --- a/tests/functional/ppc/test_74xx.py +++ b/tests/functional/ppc/test_74xx.py @@ -10,7 +10,7 @@ from qemu_test import QemuSystemTest from qemu_test import wait_for_console_pattern =20 -class ppc74xxCpu(QemuSystemTest): +class Ppc74xxCpu(QemuSystemTest): =20 timeout =3D 5 =20 diff --git a/tests/functional/ppc/test_sam460ex.py b/tests/functional/ppc/t= est_sam460ex.py index 31cf9dd6de8..024406d155c 100755 --- a/tests/functional/ppc/test_sam460ex.py +++ b/tests/functional/ppc/test_sam460ex.py @@ -8,10 +8,11 @@ from qemu_test import exec_command_and_wait_for_pattern =20 =20 -class sam460exTest(LinuxKernelTest): +class Sam460exTest(LinuxKernelTest): =20 ASSET_BR2_SAM460EX_LINUX =3D Asset( - 'https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main/bui= ldroot/qemu_ppc_sam460ex-2023.11-8-gdcd9f0f6eb-20240105/vmlinux', + ('https://github.com/legoater/qemu-ppc-boot/raw/refs/heads/main' + '/buildroot/qemu_ppc_sam460ex-2023.11-8-gdcd9f0f6eb-20240105/vmli= nux'), '6f46346f3e20e8b5fc050ff363f350f8b9d76a051b9e0bd7ea470cc680c14df2') =20 def test_ppc_sam460ex_buildroot(self): diff --git a/tests/functional/ppc64/test_powernv.py b/tests/functional/ppc6= 4/test_powernv.py index 9ada832b781..0ea6c93e428 100755 --- a/tests/functional/ppc64/test_powernv.py +++ b/tests/functional/ppc64/test_powernv.py @@ -10,7 +10,7 @@ from qemu_test import LinuxKernelTest, Asset from qemu_test import wait_for_console_pattern =20 -class powernvMachine(LinuxKernelTest): +class PowernvMachine(LinuxKernelTest): =20 timeout =3D 90 KERNEL_COMMON_COMMAND_LINE =3D 'printk.time=3D0 console=3Dhvc0 ' diff --git a/tests/functional/ppc64/test_pseries.py b/tests/functional/ppc6= 4/test_pseries.py index 67057934e8d..7840c4e3ff8 100755 --- a/tests/functional/ppc64/test_pseries.py +++ b/tests/functional/ppc64/test_pseries.py @@ -10,7 +10,7 @@ from qemu_test import QemuSystemTest, Asset from qemu_test import wait_for_console_pattern =20 -class pseriesMachine(QemuSystemTest): +class PseriesMachine(QemuSystemTest): =20 timeout =3D 90 KERNEL_COMMON_COMMAND_LINE =3D 'printk.time=3D0 console=3Dhvc0 ' diff --git a/tests/functional/ppc64/test_reverse_debug.py b/tests/functiona= l/ppc64/test_reverse_debug.py index 69551fb84df..4eef779936d 100755 --- a/tests/functional/ppc64/test_reverse_debug.py +++ b/tests/functional/ppc64/test_reverse_debug.py @@ -18,7 +18,7 @@ from reverse_debugging import ReverseDebugging =20 =20 -class ReverseDebugging_ppc64(ReverseDebugging): +class ReverseDebuggingPpc64(ReverseDebugging): =20 @skipFlakyTest("https://gitlab.com/qemu-project/qemu/-/issues/1992") def test_ppc64_pseries(self): --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167603; cv=none; d=zohomail.com; s=zohoarc; b=cc5ZgDs1CgKGooBsj/0tW2E1oAN+nCd6HNPqOzqxiEPWTY0Wq4I4RAhzDwh7DQJqBfTDmEZY5Aqbk3BxymxskikJgA8rQvGwAxifZdMCZuncYqMHVyYJNnS2cWR66yrnEAyYhue60EPCl/Vg3zcfDjIGi/uNlsAkYznTaFw7oZw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167603; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TOB46FLkOPzLypWRLCumctcya+KyNXvCGRnoZAGa/Os=; b=ZngCL8pDrwJCcc1NnzTryN+wC33HVhPem/VUUta1S8ruPdFJXUdnFTXCKy0IW59uKGOBnW+2E32AmAp6X6clv1AvKmS528HSmHsAzIaIQPBhwLSpda963UfFSqCYNFdgyfjqQq/e56E6PQgSsVFyBeFWHYBqkBHpjHVcRf9eASg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176216760369224.227434526958177; Mon, 3 Nov 2025 03:00:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHO-00042F-I4; Mon, 03 Nov 2025 05:59:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHM-000400-BK for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:16 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHG-0004WK-7i for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:14 -0500 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-101-L-IZCGomMlqynPhXj91Jmw-1; Mon, 03 Nov 2025 05:59:02 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0BDD21955F2D; Mon, 3 Nov 2025 10:59:02 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 739F430001A1; Mon, 3 Nov 2025 10:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TOB46FLkOPzLypWRLCumctcya+KyNXvCGRnoZAGa/Os=; b=RQo0ycMS/4b1s76R2RPO0IXCCdVurt+CYcq51UvXeq0+Lt0k/8pALc7t5QELdqpCMxQM8O M7TIj/r5m86AaaIvVJilQLxR+nZXA5h8IFZduyCv42ioISP3wa0mIozK5c5k3u0Uzk7jn2 3PJMCP+JzIiPOEvZC0T6jqDh7aCAQdQ= X-MC-Unique: L-IZCGomMlqynPhXj91Jmw-1 X-Mimecast-MFC-AGG-ID: L-IZCGomMlqynPhXj91Jmw_1762167542 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 16/22] tests/functional: include logger name and function in messages Date: Mon, 3 Nov 2025 11:58:13 +0100 Message-ID: <20251103105824.322039-17-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167615715158500 From: Daniel P. Berrang=C3=A9 As we collect debug logs from a wide range of code it becomes increasingly confusing to understand where each log messages comes from. Adding "%(name)s" gives us the logger name, which is usually based on the python __name__ symbol, aka the code module name. Then "%(funcName)s" completes the story by identifying the function. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Thomas Huth Message-ID: <20251028182651.873256-2-berrange@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/qemu_test/testcase.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu= _test/testcase.py index a122acb5609..d9d114e63e3 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -217,7 +217,7 @@ def setUp(self): self._log_fh =3D logging.FileHandler(self.log_filename, mode=3D'w') self._log_fh.setLevel(logging.DEBUG) fileFormatter =3D logging.Formatter( - '%(asctime)s - %(levelname)s: %(message)s') + '%(asctime)s - %(levelname)s: %(name)s.%(funcName)s %(message)= s') self._log_fh.setFormatter(fileFormatter) self.log.addHandler(self._log_fh) =20 --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167633; cv=none; d=zohomail.com; s=zohoarc; b=aymuB1xmn5Li1PKgH1R+9KtoI6qXJrNUPph33TcFZvqSNW9LE7akfAnS/JDXdAVDvIwMac8JOGIjuE/tV6TIm2/6g/HYxsGI6irioswsqxS9fDZg7AJ2ggtAEn2sxK8V1nX/EwpUI4Axk4w4V0huTYn60WEUHZuoiDiQQijviSs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167633; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IOVDcGhMCkuyVVd2jbsDowfYGThYB1elQwWqVfTLoV4=; b=J8wfilo9HbxN1SssutRlGdoYy2ei9dHnHrXxMSzij4eq1LTwTmD8pXE2OjdQoFs4i/P9Z7ohnBNAzE9kd3RQPNKivJq8F7fYfSjyChCOP9yr1GTLwp/OnOVfy6WkMbrCifsRVwI44PKkBAQIkSDgm0hOL89hs+WP+4Zl0iAapsQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167633164994.9190487734218; Mon, 3 Nov 2025 03:00:33 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHK-0003zT-2X; Mon, 03 Nov 2025 05:59:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHI-0003xn-Lt for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHE-0004WN-UE for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:11 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-GYjWc5YxPDm-uNYWh0oLQQ-1; Mon, 03 Nov 2025 05:59:04 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 166C61954230; Mon, 3 Nov 2025 10:59:04 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8CF3330001A1; Mon, 3 Nov 2025 10:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IOVDcGhMCkuyVVd2jbsDowfYGThYB1elQwWqVfTLoV4=; b=dDqM9dF5lWPyrEXKIZr4pQf0EdtjlzXK1lefQbWCeo1IFlYZiMSEYFNrg3iDfsMLghCqtv yQLS7spqoYSVWZ1319Nmoa0U6DcXt1X3Wf74/qf3vD69HdMKNktNgfpG3wM2HPIYdfVFy0 wCyONvFWWBadrJR6T/PN7mbuD1Ngfqc= X-MC-Unique: GYjWc5YxPDm-uNYWh0oLQQ-1 X-Mimecast-MFC-AGG-ID: GYjWc5YxPDm-uNYWh0oLQQ_1762167544 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 17/22] tests/functional: include the lower level QMP log messages Date: Mon, 3 Nov 2025 11:58:14 +0100 Message-ID: <20251103105824.322039-18-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167636800154100 From: Daniel P. Berrang=C3=A9 We've seen a GitLab CI timeout failure in the test_pseries.py test, where it appears likely that the test has hung in a self.qmp('quit') call, but we don't have conclusive proof. Adding the QMP log category to what we capture should help us diagnose this, at the cost of the base.log file becoming significantly more verbose. The previous commit to include the logger category name and function should at least help understanding the more verbose logs. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Thomas Huth Message-ID: <20251028182651.873256-3-berrange@redhat.com> Signed-off-by: Thomas Huth --- tests/functional/qemu_test/testcase.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu= _test/testcase.py index d9d114e63e3..1d773dd697d 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -225,6 +225,9 @@ def setUp(self): self.machinelog =3D logging.getLogger('qemu.machine') self.machinelog.setLevel(logging.DEBUG) self.machinelog.addHandler(self._log_fh) + self.qmplog =3D logging.getLogger('qemu.qmp') + self.qmplog.setLevel(logging.DEBUG) + self.qmplog.addHandler(self._log_fh) =20 if not self.assets_available(): self.skipTest('One or more assets is not available') @@ -235,6 +238,7 @@ def tearDown(self): if self.socketdir is not None: self.socketdir.cleanup() self.socketdir =3D None + self.qmplog.removeHandler(self._log_fh) self.machinelog.removeHandler(self._log_fh) self.log.removeHandler(self._log_fh) self._log_fh.close() --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167777; cv=none; d=zohomail.com; s=zohoarc; b=mxq4lI17QYudq5xm6l2dVih+8p9Nb/+ZHDdOr49cUlUZv0vf8oWAbhYws0/Fz8hlGgg8OrYyAGMvuFgOqAw6H3cBo3NXYUjslVxFwJhbV3MDdnqMrfTzNQcJvvuwBOxxWJJSxh/g3jfhiRvX7gawg1IgoKEzVZoWxoHRxYWlw4g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167777; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=I4Fb37wScOwgmWnW1IPXgfwX3Teaam8o++ijSqOP9Qs=; b=RSudeT6nc1gda5MLMVAJt11UFukZun3aJPjnMXY1sT5hFmNE+H0bjyvO6s67A5ZY48ib4adgCOfvVU0kPF6+1CffkcolaJFTyjzlxQsLxlExohwfYGjKXhbO44oUOiqtydmAmiLp8eQGR7qgm9CcV3sjM7EFlkSebDlZ+zlwOA8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167777228958.987050037061; Mon, 3 Nov 2025 03:02:57 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHg-0004B7-El; Mon, 03 Nov 2025 05:59:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHP-000429-B8 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHK-0004Yq-Av for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:16 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-368-t0SR7iWuMB6Kf6y6PjwEBg-1; Mon, 03 Nov 2025 05:59:08 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F2F68195423A; Mon, 3 Nov 2025 10:59:06 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A4D6A30001A1; Mon, 3 Nov 2025 10:59:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167551; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I4Fb37wScOwgmWnW1IPXgfwX3Teaam8o++ijSqOP9Qs=; b=Xs86beAZB415bHuBs1tQ/BxjWMxm9uO0wPDKa5F4vj9pTgJwXNXLIwl3C6hnnTd2ub0zVL TELe7ef3MCBHbIFBJU7OkxdgJBat6mspM8iYv0i7z5+SbHlkhUaRMkHWLcybsfFxXSuye0 8u42kxzMINlMUd3bYlbBAh3/VTmzjx0= X-MC-Unique: t0SR7iWuMB6Kf6y6PjwEBg-1 X-Mimecast-MFC-AGG-ID: t0SR7iWuMB6Kf6y6PjwEBg_1762167547 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Hildenbrand Subject: [PULL 18/22] hw/s390x: Use memory_region_size() Date: Mon, 3 Nov 2025 11:58:15 +0100 Message-ID: <20251103105824.322039-19-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167779077154100 From: Philippe Mathieu-Daud=C3=A9 MemoryRegion::size is private data of MemoryRegion, use the proper memory_region_size() getter to get it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20251028181300.41475-10-philmd@linaro.org> Reviewed-by: Thomas Huth Reviewed-by: David Hildenbrand Signed-off-by: Thomas Huth --- hw/s390x/s390-pci-inst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c index a3bb5aa2216..5841dfc4fec 100644 --- a/hw/s390x/s390-pci-inst.c +++ b/hw/s390x/s390-pci-inst.c @@ -396,7 +396,7 @@ static MemoryRegion *s390_get_subregion(MemoryRegion *m= r, uint64_t offset, uint64_t subregion_size; =20 QTAILQ_FOREACH(subregion, &mr->subregions, subregions_link) { - subregion_size =3D int128_get64(subregion->size); + subregion_size =3D memory_region_size(subregion); if ((offset >=3D subregion->addr) && (offset + len) <=3D (subregion->addr + subregion_size)) { mr =3D subregion; --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167781; cv=none; d=zohomail.com; s=zohoarc; b=Hf7PfQ4VjpqGL+c5zhVVpH/Q0RDixvh+2yLAa6OnQN0j6d+yb93JaieAps5aMXk/mBQOfmJS0TsLPTu8rmkqv4GQo9G5ZZuPeU59Ux5i47mUu15sB/f8RHTMmilfj8qUV3Ch+SKnxmu5cs0XwsktqNcSUAdwmFRFwXOfjLgcRJo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167781; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hQkomqBVfyTyw72k/1MPcm4ncmSX/eShfArXYnpEc0E=; b=WiOB9Rq8N4hx4uY5xjxF1y+3s4ATS4YSYYeCV8ZA7gGoIj/Kb4jIrPav6mmPTCLgmgQUj5ULYXuTmGRcmAt1WXtA7F8eC/Jt3R117fEycqgf7CcrdkY2PsjXLScyR7nBfnvdy7WRBHa0DnN8lrK9O+hTf8WhvASSM7foDbVJyxc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167781085719.0971859515331; Mon, 3 Nov 2025 03:03:01 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHl-0004I4-NZ; Mon, 03 Nov 2025 05:59:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHT-00046u-Pl for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHO-0004a6-0w for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:23 -0500 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-Kv9mizjOO8SIjkwvXaxxmA-1; Mon, 03 Nov 2025 05:59:10 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 55CDC1954B1B; Mon, 3 Nov 2025 10:59:09 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A2A7A30001A1; Mon, 3 Nov 2025 10:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hQkomqBVfyTyw72k/1MPcm4ncmSX/eShfArXYnpEc0E=; b=DFJofnqxGBBm7U5G9FRW8tn1k5degGd7QP7+jzZ4h8J9561J6KIz2mm5vXSH3AQC21+97t MG7hycgcxa019sVTXes8IUBOJCRQ3Jwj4fI1lHczvM66Vewu1o+np5G0Wr+VS4n6zfmhk6 MKeeckA9F+mGLbbLgjxnrvvmm8mB05s= X-MC-Unique: Kv9mizjOO8SIjkwvXaxxmA-1 X-Mimecast-MFC-AGG-ID: Kv9mizjOO8SIjkwvXaxxmA_1762167549 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-stable@nongnu.org, Ilya Leoshkevich Subject: [PULL 19/22] target/s390x: Fix missing interrupts for small CKC values Date: Mon, 3 Nov 2025 11:58:16 +0100 Message-ID: <20251103105824.322039-20-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167791047158500 Content-Type: text/plain; charset="utf-8" From: Ilya Leoshkevich Suppose TOD clock value is 0x1111111111111111 and clock-comparator value is 0, in which case clock-comparator interruption should occur immediately. With the current code, tod2time(env->ckc - td->base.low) ends up being a very large number, so this interruption never happens. Fix by firing the timer immediately if env->ckc < td->base.low. Cc: qemu-stable@nongnu.org Reviewed-by: Thomas Huth Signed-off-by: Ilya Leoshkevich Message-ID: <20251016175954.41153-2-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- target/s390x/tcg/misc_helper.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/target/s390x/tcg/misc_helper.c b/target/s390x/tcg/misc_helper.c index 6d9d601d29a..215b5b9d933 100644 --- a/target/s390x/tcg/misc_helper.c +++ b/target/s390x/tcg/misc_helper.c @@ -199,11 +199,15 @@ static void update_ckc_timer(CPUS390XState *env) return; } =20 - /* difference between origins */ - time =3D env->ckc - td->base.low; + if (env->ckc < td->base.low) { + time =3D 0; + } else { + /* difference between origins */ + time =3D env->ckc - td->base.low; =20 - /* nanoseconds */ - time =3D tod2time(time); + /* nanoseconds */ + time =3D tod2time(time); + } =20 timer_mod(env->tod_timer, time); } --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167605; cv=none; d=zohomail.com; s=zohoarc; b=Eaevzuxq36AS66adHYEc0Y3HfD4+1aPF0Abfgav7yJXHZVGpIi+dh1waNa4xJzISn33RQQRbQcPwOum/6NRu9Xsb9ZfYOqWIAqzRao2d66xRrTs3mOEG98eEMCJfZrSeaSo0YF3weKVCx9Fns3mtX/OIU9gQ1KYLAgrHhEY47ZQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167605; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qTnH6S3Bw8xH+z2ZRrA7mhfL4V2VfEnhe8gpVHFu6sw=; b=bgQ41p6ZatJ20y36OOHowWgVYe5UAiN8yw+ng1HtiV01EHr3dFD5JZGEhBULgiLxhXDmN6mljkFAkJXssMdUI/leTMisuCJkbbcHzRsh8tYVFQXuC3zyCuCgbbyU3sS/VFWhp7snCtC8xcnsU5FcoM9Vv7BwSSrrYTnIbmqtNOw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167605013136.37175339910107; Mon, 3 Nov 2025 03:00:05 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHo-0004SY-Qf; Mon, 03 Nov 2025 05:59:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHj-0004Io-VM for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHf-0004m5-NN for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:39 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-aXnXK3L0OkCxDuck5fe0iA-1; Mon, 03 Nov 2025 05:59:12 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BD1CE180A22B; Mon, 3 Nov 2025 10:59:11 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D063130001A8; Mon, 3 Nov 2025 10:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167572; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qTnH6S3Bw8xH+z2ZRrA7mhfL4V2VfEnhe8gpVHFu6sw=; b=iXNI8gxNJvaTP9oBS2m3ZDN+eEwKEhB3VgMKRMT9ynsd7VzSYn85xTch4S4Bm9LoPFTtk9 mliWIpcj8cPsmAFuz159UWzURB+lfV+vd3KbUFMwZpHvCoNmjlH20Ugda0knvfc9Hte9DQ yD+G6NUsjZX22tKCE9dCy2kvTvg7s5E= X-MC-Unique: aXnXK3L0OkCxDuck5fe0iA-1 X-Mimecast-MFC-AGG-ID: aXnXK3L0OkCxDuck5fe0iA_1762167551 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-stable@nongnu.org, Ilya Leoshkevich Subject: [PULL 20/22] target/s390x: Fix missing clock-comparator interrupts after reset Date: Mon, 3 Nov 2025 11:58:17 +0100 Message-ID: <20251103105824.322039-21-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167607108154100 Content-Type: text/plain; charset="utf-8" From: Ilya Leoshkevich After reset, CKC value is set to 0, so if clock-comparator interrupts are enabled, one should occur very shortly thereafter. Currently the code that loads the respective control register does not set tod_timer, so this does not happen. Fix by adding a tcg_s390_tod_updated() call to LCTL and LCTLG. Cc: qemu-stable@nongnu.org Suggested-by: Thomas Huth Reviewed-by: Thomas Huth Signed-off-by: Ilya Leoshkevich Message-ID: <20251016175954.41153-3-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- target/s390x/tcg/mem_helper.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c index f1acb1618f7..24675fc818d 100644 --- a/target/s390x/tcg/mem_helper.c +++ b/target/s390x/tcg/mem_helper.c @@ -1959,6 +1959,10 @@ void HELPER(lctlg)(CPUS390XState *env, uint32_t r1, = uint64_t a2, uint32_t r3) if (env->cregs[i] !=3D val && i >=3D 9 && i <=3D 11) { PERchanged =3D true; } + if (i =3D=3D 0 && !(env->cregs[i] & CR0_CKC_SC) && (val & CR0_CKC_= SC)) { + BQL_LOCK_GUARD(); + tcg_s390_tod_updated(env_cpu(env), RUN_ON_CPU_NULL); + } env->cregs[i] =3D val; HELPER_LOG("load ctl %d from 0x%" PRIx64 " =3D=3D 0x%" PRIx64 "\n", i, src, val); @@ -1989,10 +1993,15 @@ void HELPER(lctl)(CPUS390XState *env, uint32_t r1, = uint64_t a2, uint32_t r3) =20 for (i =3D r1;; i =3D (i + 1) % 16) { uint32_t val =3D cpu_ldl_data_ra(env, src, ra); + uint64_t val64 =3D deposit64(env->cregs[i], 0, 32, val); if ((uint32_t)env->cregs[i] !=3D val && i >=3D 9 && i <=3D 11) { PERchanged =3D true; } - env->cregs[i] =3D deposit64(env->cregs[i], 0, 32, val); + if (i =3D=3D 0 && !(env->cregs[i] & CR0_CKC_SC) && (val64 & CR0_CK= C_SC)) { + BQL_LOCK_GUARD(); + tcg_s390_tod_updated(env_cpu(env), RUN_ON_CPU_NULL); + } + env->cregs[i] =3D val64; HELPER_LOG("load ctl %d from 0x%" PRIx64 " =3D=3D 0x%x\n", i, src,= val); src +=3D sizeof(uint32_t); =20 --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167663; cv=none; d=zohomail.com; s=zohoarc; b=EQ7NPKAnirKRbyWABEDIo9uIwoVgGzcEiZlN/dLVMege65nc2c6yXe5a9rfNBfvCqPL6xJ3nibM9q2G3OnlMKm00Btc4CQg6vyTOLAIscliWZT2VvAi9tPAs0JILxzi694q3jPTemIjIqByzop4rNKPbBKRlHaj0Dy1Be6tzDBE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167663; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cbh68C6fmQ5R1KcYwKeBdnUQDfSG4HCjvnxl+QuCZ4I=; b=B3SuBRA4OML5sMhPbh3CELNx+nMF9s0clKUSAfxeLiYA2Yk2wJkqVW6lkGho72U1JWxEZY59zuQcrzcdM/mgA6tN/jT5GoV8OWCg8U6L2/TjNkINMU1msdOK8/RzbEwMyTFXQG9u5h+lXjVvL4TEwk/5LNiNyheV4iS2yTSzj6g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167663535496.113883703232; Mon, 3 Nov 2025 03:01:03 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHo-0004Sd-Ro; Mon, 03 Nov 2025 05:59:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHV-000478-KU for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHR-0004cd-2R for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:23 -0500 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-522-YvLVsSD2NAujAWMC1IL9_w-1; Mon, 03 Nov 2025 05:59:16 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B7CCE180120B; Mon, 3 Nov 2025 10:59:14 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4746730001A1; Mon, 3 Nov 2025 10:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cbh68C6fmQ5R1KcYwKeBdnUQDfSG4HCjvnxl+QuCZ4I=; b=SCwZEldhre3MQ+78PLwAZlQsI8HTz+wSeH3Suwb51abst9+TH1C9+rZw6/6L4PeHGG1ipv HjtHXl2pB77L+TelorX72IgEQpghAhywv4lKCVk64P+9s2/qIAbUjV53nwrSoycGa4tovM RDKXicuCY26tFYewnwbuJjTUcYZ7zZ4= X-MC-Unique: YvLVsSD2NAujAWMC1IL9_w-1 X-Mimecast-MFC-AGG-ID: YvLVsSD2NAujAWMC1IL9_w_1762167554 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , =?UTF-8?q?Thomas=20Wei=C3=9Fschuh?= , Heiko Carstens , qemu-stable@nongnu.org, Ilya Leoshkevich Subject: [PULL 21/22] target/s390x: Use address generation for register branch targets Date: Mon, 3 Nov 2025 11:58:18 +0100 Message-ID: <20251103105824.322039-22-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167666122158500 From: Ilya Leoshkevich Indirect branches to addresses taken from registers go through address generation, e.g., for BRANCH ON CONDITION Principles of Operation says: In the RR format, the contents of general register R2 are used to generate the branch address QEMU uses r2_nz handler for the respective register operands. Currently it does not zero out extra bits in 24- and 31-bit addressing modes as required by address generation. The very frequently used s390x_tr_init_disas_context() function has a workaround for this, but the code for saving an old PSW during an interrupt does not. Add the missing masking to r2_nz. Enforce PSW validity by replacing the workaround with an assertion. Reported-by: Thomas Wei=C3=9Fschuh Reported-by: Heiko Carstens Link: https://lore.kernel.org/lkml/ab3131a2-c42a-47ff-bf03-e9f68ac053c0@t-8= ch.de/ Cc: qemu-stable@nongnu.org Signed-off-by: Ilya Leoshkevich Tested-by: Thomas Wei=C3=9Fschuh Message-ID: <20251016175954.41153-4-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index ec9e5a07516..4d2b8c5e2be 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -5613,6 +5613,7 @@ static void in2_r2_nz(DisasContext *s, DisasOps *o) int r2 =3D get_field(s, r2); if (r2 !=3D 0) { o->in2 =3D load_reg(r2); + gen_addi_and_wrap_i64(s, o->in2, o->in2, 0); } } #define SPEC_in2_r2_nz 0 @@ -6379,10 +6380,12 @@ static void s390x_tr_init_disas_context(DisasContex= tBase *dcbase, CPUState *cs) { DisasContext *dc =3D container_of(dcbase, DisasContext, base); =20 - /* 31-bit mode */ - if (!(dc->base.tb->flags & FLAG_MASK_64)) { - dc->base.pc_first &=3D 0x7fffffff; - dc->base.pc_next =3D dc->base.pc_first; + if (dc->base.tb->flags & FLAG_MASK_32) { + if (!(dc->base.tb->flags & FLAG_MASK_64)) { + assert(!(dc->base.pc_first & ~((1ULL << 31) - 1))); + } + } else { + assert(!(dc->base.pc_first & ~((1ULL << 24) - 1))); } =20 dc->cc_op =3D CC_OP_DYNAMIC; --=20 2.51.0 From nobody Sun Nov 16 01:09:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1762167827; cv=none; d=zohomail.com; s=zohoarc; b=HuYeWrqpsJ6jRNJnMMX31yAXNlErtSie+19wG8tZSftFMczAGzpbQEyEBd2pwLTGOZk65zD9IPCoHfRP8pkf+9yUEbNo18tsTYweQOoHawWKAvzk6XRBMXnaF7WpV9T8JKrlA+xeB5AI4fFc8HzCKMrJclcqG2nuJFMvYrllBz8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762167827; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gSuvTRmXv2fofIP+bvbCeQLENVrlaMGpCelkpxptMhg=; b=Q1TNfV49aUy1db9d1Q3EWlpgycTSYiyGBM+NF3Eir6WTBo0O2w1APrhsykVCnbaLJxBZRoBQrIqoVW/DIGvWPlkBa4ajQnvczUIQ5a+oJAIWh64lsv3GAjue7h5Wv1JHFhqkR8WG2byDg1hbQGmAHJBzzN5fNAdIKWkF7nYeO3w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762167827601273.0858414138286; Mon, 3 Nov 2025 03:03:47 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFsHm-0004M7-Q5; Mon, 03 Nov 2025 05:59:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHZ-0004AZ-9w for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:33 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFsHT-0004eP-VY for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:59:28 -0500 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-584-CMfXd6aSMnebgpwbm6jd_w-1; Mon, 03 Nov 2025 05:59:18 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EFC941801376; Mon, 3 Nov 2025 10:59:16 +0000 (UTC) Received: from thuth-p1g4.redhat.com (unknown [10.44.33.12]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 417D830001BC; Mon, 3 Nov 2025 10:59:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762167562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gSuvTRmXv2fofIP+bvbCeQLENVrlaMGpCelkpxptMhg=; b=hccVFyCJpnW9LJ3FHQfxm+qyJGZnD+yEH0hevEyGqRarfJ7c9q2qO6ZDSDuBC2HFjV0m/e D/lFqpbtY/E1ZPlAclWhvvQdjlTxBUS+u3RHf5FVUa66N0ULRtzVYhGl+f62/r/QKdaeFS 9bf9U0O/tIlUyebE+QS7V/nVSFM+BpY= X-MC-Unique: CMfXd6aSMnebgpwbm6jd_w-1 X-Mimecast-MFC-AGG-ID: CMfXd6aSMnebgpwbm6jd_w_1762167557 From: Thomas Huth To: qemu-devel@nongnu.org Cc: Richard Henderson , qemu-stable@nongnu.org, Ilya Leoshkevich Subject: [PULL 22/22] tests/tcg/s390x: Test SET CLOCK COMPARATOR Date: Mon, 3 Nov 2025 11:58:19 +0100 Message-ID: <20251103105824.322039-23-thuth@redhat.com> In-Reply-To: <20251103105824.322039-1-thuth@redhat.com> References: <20251103105824.322039-1-thuth@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1762167849562158500 Content-Type: text/plain; charset="utf-8" From: Ilya Leoshkevich Add a small test to prevent regressions. Cc: qemu-stable@nongnu.org Reviewed-by: Thomas Huth Signed-off-by: Ilya Leoshkevich Message-ID: <20251016175954.41153-5-iii@linux.ibm.com> Signed-off-by: Thomas Huth --- tests/tcg/s390x/Makefile.softmmu-target | 1 + tests/tcg/s390x/sckc.S | 63 +++++++++++++++++++++++++ 2 files changed, 64 insertions(+) create mode 100644 tests/tcg/s390x/sckc.S diff --git a/tests/tcg/s390x/Makefile.softmmu-target b/tests/tcg/s390x/Make= file.softmmu-target index 8cd4667c63b..a4425d3184a 100644 --- a/tests/tcg/s390x/Makefile.softmmu-target +++ b/tests/tcg/s390x/Makefile.softmmu-target @@ -28,6 +28,7 @@ ASM_TESTS =3D = \ mc = \ per = \ precise-smc-softmmu = \ + sckc = \ ssm-early = \ stosm-early = \ stpq = \ diff --git a/tests/tcg/s390x/sckc.S b/tests/tcg/s390x/sckc.S new file mode 100644 index 00000000000..ecd64a3059e --- /dev/null +++ b/tests/tcg/s390x/sckc.S @@ -0,0 +1,63 @@ +/* + * Test clock comparator. + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + .org 0x130 +ext_old_psw: + .org 0x1b0 +ext_new_psw: + .quad 0x180000000, _ext /* 64-bit mode */ + .org 0x1d0 +pgm_new_psw: + .quad 0x2000000000000,0 /* disabled wait */ + .org 0x200 /* lowcore padding */ + + .globl _start +_start: + lpswe start31_psw +_start31: + stctg %c0,%c0,c0 + oi c0+6,8 /* set clock-comparator subclass ma= sk */ + lctlg %c0,%c0,c0 + +0: + brasl %r14,_f /* %r14's most significant bit is 1= */ + jg 0b +_f: + br %r14 /* it must not end up in ext_old_ps= w */ + +_ext: + stg %r0,ext_saved_r0 + + lg %r0,ext_counter + aghi %r0,1 + stg %r0,ext_counter + + cgfi %r0,0x1000 + jnz 0f + lpswe success_psw +0: + + stck clock + lg %r0,clock + agfi %r0,0x40000 /* 64us * 0x1000 =3D~ 0.25s */ + stg %r0,clock + sckc clock + + lg %r0,ext_saved_r0 + lpswe ext_old_psw + + .align 8 +start31_psw: + .quad 0x100000080000000,_start31 /* EX, 31-bit mode */ +success_psw: + .quad 0x2000000000000,0xfff /* see is_special_wait_psw() */ +c0: + .skip 8 +clock: + .quad 0 +ext_counter: + .quad 0 +ext_saved_r0: + .skip 8 --=20 2.51.0