From nobody Fri Nov 14 21:01:16 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1762164738; cv=none; d=zohomail.com; s=zohoarc; b=DD5lDpxImj6ZVFcbwJHnAlkBv3ui2fp4jswxcw4VGM6mlAbfVlVu/SXd/qdOYFXMwPC90WLMeN7k6U1U1oyXDKKEJuTC7vqIsWt2HYmOjujP2KwUZY6ct0B0JSX6MMdFySEqQLhyAMnsMFhkijkwNVpQen8A9sZ4Pr+FuZ7g0zA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762164738; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=rvdpQqu+6tXXSi2BeJVnKSBoAv9PMGvcr8JslOxrI6M=; b=ba57cyLdLBe3Z1utXJDg678ZHsbsMdlNIM9g7RHbNMHmPSnyfXwmxjUOePvm+hekgK2QBcD72qdkDxAnYgTBgQw6cGMnxrYl34Y/UsTT8NBGTWx2++pzRnxtvcQ0d1/H/fL6SXzya+EF0axY0Z2iVvZuT8E9o1WbuQiINQCkhtg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762164738559518.2135905184042; Mon, 3 Nov 2025 02:12:18 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFrXL-0002xJ-L4; Mon, 03 Nov 2025 05:11:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFrXK-0002xA-Hm for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:11:42 -0500 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vFrXC-0002XS-R1 for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:11:42 -0500 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-426f1574a14so2568713f8f.3 for ; Mon, 03 Nov 2025 02:11:34 -0800 (PST) Received: from localhost.localdomain (ip-185-104-138-122.ptr.icomera.net. [185.104.138.122]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429c1125ad0sm19770172f8f.13.2025.11.03.02.11.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 03 Nov 2025 02:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762164692; x=1762769492; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rvdpQqu+6tXXSi2BeJVnKSBoAv9PMGvcr8JslOxrI6M=; b=EF6jwDrxSTYt0Wq4ilEpWSO62nclplJ8ttOH7ZAhAqfjupBjJ+TckZ75Eji4lMyj6+ ZWqHusYfhoX97ttuex0wh7I0OD5HRlQNTBvPKSF3aH7bOk0F5yycZdP4Ts46IjfjwdO5 pDRbugWJ/eVxMUSwdhUB8hVk3jDgiyQgQfNLZu6izIfgJVc4DuXN9W5IPBQXfroOW0zQ 9+2oABCuD2L7c1hpGXTqwqF7nKeBjd8UKynceNLexmm/ff6K37JpWoxRAkG6h0CZ+j/o 8b5fkP0IqchGRngARpw9vBXQPXWzjdNwcxEFne4aG0kx76wus+gVoKCfD1hhdZ1dan2l sQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762164692; x=1762769492; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rvdpQqu+6tXXSi2BeJVnKSBoAv9PMGvcr8JslOxrI6M=; b=CcNtxwnfJ5Dfesz14XlGIcSpXqEQL5bSEWzxCDxXksKmrvbm2jOydXhoJjyxWvGMY4 sIausXWmlKg8f5v3dNSCJqVmMpDGnn/h6KXy4N77s1MxR+UA0Mo88cQLY3ChHrWwnlZf tmyFLnEjY86d6/ykJTKC+NBdtelawgNgipeOBt7yLubo8eAbOzK/bNinOQ7+JZJALzP4 JNqiMkbuSpbSRfc0uSVBAVuTp/cXg/nL4FzJE45svq+d7LfjuBmVUgfYqRLZbbnYX4vj 3Ww/WEBkTVbSQr630WUhbhcpqpZmEfmBLVkFBBD1RnTT+nzdlwow2cD2ZS4rvV6w/A1m wYQg== X-Gm-Message-State: AOJu0YylvV94AtgTkg4r734Xhd4lhHwbCkc6z/l7i9dF3nCKHDSthRlz kaRXQ4UYDeSFDW9d92qNu2iG0DQahaW3nsiTVW4S5Q+VHx5PXhC5nbe4Xj5LBwsitvdkkcJAdUm BHp1QaI8= X-Gm-Gg: ASbGncv9crKT2AlI2uz0W3PBvrBJ1b8+S1/4PcGKW03pU3t94bioGs+YKBdwVxAyPKu N7zz6Be5kxzz0Oofdm227aKXtpfuZAm+XizklWYfxLBusVFED+L7QgajafCT1xmEKdIj7ct0vb5 3fy9ewlheiHtBZPVju3Shl99ukcDIJSd5WWLbothEu4zbantiwKBcvUSkhemo8w/LjM7F+nL6/J QHeoN1GX5R9GKICqptR5FEBXAJRrxesarQtRa8ARZMyoFGtHcfPk+r3pQAM9eFczqH1fihtCX4/ P4NMkqiyj+MrBY0L1gzcjzDLZcpaM8qq14GEmhGGndub34ctIxx3b3MF8HQX8I+hd0J+UuQO2aK 92lyhc0nL8mhAbs5EeF4e6vgO/0VdDb4WsdQXBcgIEFmcBPKcAcatv4tnn4MLZoUQnstetK/fIp 96Jv8iqxK4TNMYQTUwpnc2i5UIjqPwe/oRHodnsRexZJ7LsZ4f9gt66iwDdERdWvuRQ1Gf5A== X-Google-Smtp-Source: AGHT+IE9lsqLlSOEI/P1WSyQb3ydqWLetKEiFWATx2PIl7ZWPsfmfrIBEEo13jhxiaVxfTlw1LQltw== X-Received: by 2002:a05:6000:2510:b0:429:d6dc:ae0f with SMTP id ffacd0b85a97d-429d6dcb154mr1113674f8f.49.1762164692269; Mon, 03 Nov 2025 02:11:32 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Roman Bolshakov , Alexander Graf , Phil Dennis-Jordan , qemu-arm@nongnu.org, Paolo Bonzini , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Akihiko Odaki , Peter Collingbourne , Cameron Esfahani , Mads Ynddal , Mohamed Mediouni Subject: [PATCH v4 02/23] target/i386/hvf: Use host page alignment in ept_emulation_fault() Date: Mon, 3 Nov 2025 11:10:11 +0100 Message-ID: <20251103101034.59039-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251103101034.59039-1-philmd@linaro.org> References: <20251103101034.59039-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1762164741171158500 While on x86 the host page size is fixed to 4KB, it is better to call qemu_real_host_page_size() for consistency. Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/hvf/hvf.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 16febbac48f..9a1bf026a4a 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -76,7 +76,7 @@ #include "qemu/main-loop.h" #include "qemu/accel.h" #include "target/i386/cpu.h" -#include "exec/target_page.h" +#include "exec/cpu-common.h" =20 static Error *invtsc_mig_blocker; =20 @@ -137,9 +137,12 @@ static bool ept_emulation_fault(hvf_slot *slot, uint64= _t gpa, uint64_t ept_qual) =20 if (write && slot) { if (slot->flags & HVF_SLOT_LOG) { - uint64_t dirty_page_start =3D gpa & ~(TARGET_PAGE_SIZE - 1u); + uintptr_t page_size =3D qemu_real_host_page_size(); + intptr_t page_mask =3D -(intptr_t)page_size; + uint64_t dirty_page_start =3D gpa & page_mask; + memory_region_set_dirty(slot->region, gpa - slot->start, 1); - hv_vm_protect(dirty_page_start, TARGET_PAGE_SIZE, + hv_vm_protect(dirty_page_start, page_size, HV_MEMORY_READ | HV_MEMORY_WRITE | HV_MEMORY_EXE= C); } } --=20 2.51.0