From nobody Fri Nov 14 21:01:33 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1762165062; cv=none; d=zohomail.com; s=zohoarc; b=m/KthaZ4drxOWF/vuVIxeLx3mAKDdsmSefSvrK7jlxSo0ReTM3rR8TxzSZqMOCnMt7+byihO8apw+gsLmP8ypRLMJsyWS/BMcvcs7aCHCZhS3++rN241Ji04YWaPw9H5rZrNSjwsyaajimGK3G0ZTid5PzEnGkaSO+xyqvoTyw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1762165062; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4jVZL+EPfNSiEcUqc0mMtti7iz45SaUWfxueOvD5pC8=; b=GS6M1ybCQeQfgtgClhuu3Q5ydEVbAGwaiCtJg9y1Cf+z14SU2Y3rEbkcg36HzITDwT5c+IC1uZcHvAg1NUMTH/4FGDh/0u66hj1yQPCQvW04Hk2Hfj+6lssZHeGMGol5V31kRkhFnpyNZcg1SvdOiUyZnPzOfyHYwdN4nb61FNU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762165062706534.3836940240028; Mon, 3 Nov 2025 02:17:42 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFrbA-0008CZ-FA; Mon, 03 Nov 2025 05:15:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFrb7-000828-Ho for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:15:37 -0500 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vFrb2-0003LV-Tv for qemu-devel@nongnu.org; Mon, 03 Nov 2025 05:15:35 -0500 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4710683a644so33123855e9.0 for ; Mon, 03 Nov 2025 02:15:29 -0800 (PST) Received: from localhost.localdomain (ip-185-104-138-122.ptr.icomera.net. [185.104.138.122]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4773c394f0csm145356445e9.16.2025.11.03.02.15.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 03 Nov 2025 02:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1762164927; x=1762769727; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4jVZL+EPfNSiEcUqc0mMtti7iz45SaUWfxueOvD5pC8=; b=tAzf9P4EjRPgLr8FVv1hca4kjM2As4clwhcmFcDAu00WpEGfuqjRCI9h6H85mCSdXd Lz7uMkVGZAy34QNytbvuQMqWI+EMGWLmSGQ3+d1ZRmyPQO/oqO0biZGhJEqQGxW4go52 tcXZFd7sqC++mlpLtxlFyZB13p61wGmpS6pgd4a1VyVvvnWkrvRmUYRJQXYHX9IlS8bb g4fcHPI4OJzDCuKXjea21rM/vnhESPtSv1jRyhtXlWAvCQmi4Yoyhb9YEp0LMwD9yk4Z XN/xM7v2nEs70jGhXQmaZw2S2M3z9LBHX4ktj0gAZ2O8yqy5XYYbMAMOMB1ujGmrC3sF DUAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762164927; x=1762769727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4jVZL+EPfNSiEcUqc0mMtti7iz45SaUWfxueOvD5pC8=; b=diQ96upO3nZx0qOX5dvhzhxkC7WNZBvERST92oIuEr7vpzHJs31oz62aJPuuhdXrfu p5rTY3xwX0evSCIYMgMqDwGRF8PrAzLHhd0zux6r7KlM/PyVdyBMnsyRlXA2zkBTyh3L sm0yitrGv03zGAXJUpnYnihlJ+bY7C1Fw5QwFF5gQtwzHTyUZxRpuRX1/hFlF2PeDb5b Rvh990JYtj/PYtS8ipxIEDi8yjiv6Wzt2M2h+XDgMhrCQMvczB4+59PfqY7q0sybiwzg 3W6JNzWlOgMQ8Sm88XEuGVQmyS6LVp4ywoXWrXd8FO8AThvM2TZWT3MhOni1YMa+u6zO tYdg== X-Gm-Message-State: AOJu0YytGH3SDnrPu1XQNHwMkksQ78jite/oT6KMIPInBnQaQRhShsLv Il87Z828DLUbPuzZsjnj01MdEFkUquk0Ifql1T8fxfYiZDP88X5YTwBx7hKe35nVID9mzBsT1+O U/IcLfA4= X-Gm-Gg: ASbGnctrXQNaDK3bLkdIQ2AkZIWtJ210CNjAQOnI4JtHy34+RxsGagePax5bX97CqHW TCLiH4BFWwIE85en15YxAV/bkoJF5OIc7ePYdAdNJdiWClRvQLBATK+MrG1VtYBHKq2GDz/7I5Y iJb4ON8OuIqg3ORbX7vJgETtqn0rPhf0mQ8y9JhYqbqYJ2NUgcGjOC70p1Q9+hmZozot9YN4Zn5 NWzvVJHnhSTpNsj/0jo4VOSpqYuvjejc8fuNh6+f+4B/eDlBU9cWdHIW0m9FnP01EK46A6gNI7g IyPAPFjJ3rXm3Ne1rczWRQ8EgV3BHF9LnZKkyPuEA4d5k9g44GAInm+lxCd5esmJdJh4NbMj3/W impgjARwOSODBJJWHzHp53r78ntnsbauvcH0V577LGtfakWps9ReJwR7GrjnAN9SLWGo9kG27Eu 2MMebUGO/NwsjqGlmdevh4q0rrA4upFe44qnZjGGB9lPEBaw5Yh+RjolAo2vjKmQ/7ho3E6Q== X-Google-Smtp-Source: AGHT+IGduk51gM2vy9eDhtnuyyaB6zcePqGNY3tSTdUHZOPImWAYPDhGV/Bac1PijLJi9wQG36XOMQ== X-Received: by 2002:a05:600c:530f:b0:46f:a8fd:c0dc with SMTP id 5b1f17b1804b1-47730068201mr132385495e9.3.1762164927408; Mon, 03 Nov 2025 02:15:27 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Roman Bolshakov , Alexander Graf , Phil Dennis-Jordan , qemu-arm@nongnu.org, Paolo Bonzini , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Akihiko Odaki , Peter Collingbourne , Cameron Esfahani , Mads Ynddal , Mohamed Mediouni Subject: [PATCH v4 11/23] target/arm/hvf: Implement dirty page tracking Date: Mon, 3 Nov 2025 11:10:20 +0100 Message-ID: <20251103101034.59039-12-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251103101034.59039-1-philmd@linaro.org> References: <20251103101034.59039-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1762165064621154100 From: Richard Henderson Notice writes to pages which are being monitored. Mark the page dirty, re-enable writes, and retry the instruction without emulation. Assert the fault is not from a stage1 page table walk. Signed-off-by: Richard Henderson Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/hvf/hvf.c | 52 ++++++++++++++++++++++++++++++++++++-------- 1 file changed, 43 insertions(+), 9 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index de1e8fb8a05..0f584b8137a 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1869,9 +1869,10 @@ static int hvf_handle_exception(CPUState *cpu, hv_vc= pu_exit_exception_t *excp) uint32_t srt =3D (syndrome >> 16) & 0x1f; uint32_t cm =3D (syndrome >> 8) & 0x1; uint64_t val =3D 0; + uint64_t ipa =3D excp->physical_address; + AddressSpace *as =3D cpu_get_address_space(cpu, ARMASIdx_NS); =20 - trace_hvf_data_abort(excp->virtual_address, - excp->physical_address, isv, + trace_hvf_data_abort(excp->virtual_address, ipa, isv, iswrite, s1ptw, len, srt); =20 if (cm) { @@ -1880,23 +1881,56 @@ static int hvf_handle_exception(CPUState *cpu, hv_v= cpu_exit_exception_t *excp) break; } =20 + /* Handle dirty page logging for ram. */ + if (iswrite) { + hwaddr xlat; + MemoryRegion *mr =3D address_space_translate(as, ipa, &xlat, + NULL, true, + MEMTXATTRS_UNSPECIF= IED); + if (memory_region_is_ram(mr)) { + uintptr_t page_size =3D qemu_real_host_page_size(); + intptr_t page_mask =3D -(intptr_t)page_size; + uint64_t ipa_page =3D ipa & page_mask; + + /* TODO: Inject exception to the guest. */ + assert(!mr->readonly); + + if (memory_region_get_dirty_log_mask(mr)) { + memory_region_set_dirty(mr, ipa_page + xlat, page_size= ); + hvf_unprotect_dirty_range(ipa_page, page_size); + } + + /* Retry with page writes enabled. */ + break; + } + } + + /* + * TODO: If s1ptw, this is an error in the guest os page tables. + * Inject the exception into the guest. + */ + assert(!s1ptw); + + /* + * TODO: ISV will be 0 for SIMD or SVE accesses. + * Inject the exception into the guest. + */ assert(isv); =20 + /* + * Emulate MMIO. + * TODO: Inject faults for errors. + */ if (iswrite) { val =3D hvf_get_reg(cpu, srt); - address_space_write(&address_space_memory, - excp->physical_address, - MEMTXATTRS_UNSPECIFIED, &val, len); + address_space_write(as, ipa, MEMTXATTRS_UNSPECIFIED, &val, len= ); } else { - address_space_read(&address_space_memory, - excp->physical_address, - MEMTXATTRS_UNSPECIFIED, &val, len); + address_space_read(as, ipa, MEMTXATTRS_UNSPECIFIED, &val, len); if (sse) { val =3D sextract64(val, 0, len * 8); } hvf_set_reg(cpu, srt, val); } - advance_pc =3D true; break; } --=20 2.51.0