From nobody Fri Nov 14 17:01:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=eik.bme.hu Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1762016030079673.9395485497552; Sat, 1 Nov 2025 09:53:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vFEqM-0002tt-Vd; Sat, 01 Nov 2025 12:52:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFEqK-0002sI-TJ; Sat, 01 Nov 2025 12:52:45 -0400 Received: from zero.eik.bme.hu ([152.66.115.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vFEqI-0006Xi-Dm; Sat, 01 Nov 2025 12:52:44 -0400 Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 7CECB5972E8; Sat, 01 Nov 2025 17:52:38 +0100 (CET) Received: from zero.eik.bme.hu ([127.0.0.1]) by localhost (zero.eik.bme.hu [127.0.0.1]) (amavis, port 10028) with ESMTP id 7DMw_nZe28nv; Sat, 1 Nov 2025 17:52:36 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 76E8B5972E3; Sat, 01 Nov 2025 17:52:36 +0100 (CET) X-Virus-Scanned: amavis at eik.bme.hu From: BALATON Zoltan Subject: [PATCH] hw/ppc/pegasos: Fix memory leak To: qemu-devel@nongnu.org, qemu-ppc@nongnu.org Cc: Nicholas Piggin , Harsh Prateek Bora Message-Id: <20251101165236.76E8B5972E3@zero.eik.bme.hu> Date: Sat, 01 Nov 2025 17:52:36 +0100 (CET) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1762016039431158500 Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Commit 9099b430a4 introduced an early return that caused a leak of a GString. Allocate it later to avoid the leak. Fixes: 9099b430a4 (hw/ppc/pegasos2: Change device tree generation) Resolves: Coverity CID 1642027 Signed-off-by: BALATON Zoltan Reported-by: Peter Maydell Reviewed-by: Harsh Prateek Bora Reviewed-by: Peter Maydell --- hw/ppc/pegasos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/pegasos.c b/hw/ppc/pegasos.c index 3a498edd16..8ce185de3e 100644 --- a/hw/ppc/pegasos.c +++ b/hw/ppc/pegasos.c @@ -847,7 +847,7 @@ static struct { static void add_pci_device(PCIBus *bus, PCIDevice *d, void *opaque) { FDTInfo *fi =3D opaque; - GString *node =3D g_string_new(NULL); + GString *node; uint32_t cells[(PCI_NUM_REGIONS + 1) * 5]; int i, j; const char *name =3D NULL; @@ -871,6 +871,7 @@ static void add_pci_device(PCIBus *bus, PCIDevice *d, v= oid *opaque) break; } } + node =3D g_string_new(NULL); g_string_printf(node, "%s/%s@%x", fi->path, (name ?: pn), PCI_SLOT(d->devfn)); if (PCI_FUNC(d->devfn)) { --=20 2.41.3