From nobody Fri Nov 14 16:59:34 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1761985430; cv=none; d=zohomail.com; s=zohoarc; b=f5GNk3PN/iygnBWwMzKqXgVR+Sgvqy7kHGwS1JeAX+RzTanzvtNZKouxdhksi1qmXvQ3RrsnWbBSVdqjqPCsAM9Wigelw5QTrWkovmUU4MmYkFV4nTN/1fJNX0SjAEHvoLc1FmyuaLWyk9mvhYBmp75H6tQWoMJ09M3dQnpO7sQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761985430; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/yBHTrJrMO56DmEqa5wp1on29U5TjU6FjVLIGGo7tTo=; b=C8A1jG3ROetlQIgaNNkB/LFIzN1kaI/L9ULdzKJKCtfBVJ7PeJo9RLlLKkSdDg+HM1nns7cZNacr1G6fKHPH7H7YizFN6MS/TcXLRhiySWXLMrvozPGi7wxRAyVZsSPEt8FJTOypsEeQ0MV+tKNYL0bltAp2fVNVDVFlRYaSDuk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176198543081019.561589925478415; Sat, 1 Nov 2025 01:23:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vF6sm-0000yv-AU; Sat, 01 Nov 2025 04:22:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vF6sk-0000ym-0k for qemu-devel@nongnu.org; Sat, 01 Nov 2025 04:22:42 -0400 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vF6si-0002tH-78 for qemu-devel@nongnu.org; Sat, 01 Nov 2025 04:22:41 -0400 Received: by mail-pf1-x441.google.com with SMTP id d2e1a72fcca58-78af3fe5b17so2931362b3a.2 for ; Sat, 01 Nov 2025 01:22:39 -0700 (PDT) Received: from fedora.. ([103.2.232.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a7db197335sm4582156b3a.47.2025.11.01.01.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Nov 2025 01:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761985358; x=1762590158; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/yBHTrJrMO56DmEqa5wp1on29U5TjU6FjVLIGGo7tTo=; b=kMybrxXKy45DkAWoEHBdo70KsiEi+npZ6PCWiCUf0P2NPtnJObV8c47QV+0WxBsbr9 30WnCuoNsGSa5fLxSW3UOMQQllpFoqp5ENffV42ZGByIhT6y6dp9FAbEoQIWXsIqrLhJ RWl6rKDTMhbQyOmBCwUgXEKCu+rCpkM6dd7Sw0kyY0RYu8ujbeYeioaRlsl6G6VSYYn/ buklAM6L+rzpN+0ZW9nqkpgY41O5QGhYX8dVsPlsLjj/f1d5tgLIsxpQeSCdp4xyNYQU jq9sUChRLVMm56tEr1n6jXlQN967fpNx+sLUSCjOWLAD7UCDxmv0YZdNMLF2c76ONjcV yfjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761985358; x=1762590158; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/yBHTrJrMO56DmEqa5wp1on29U5TjU6FjVLIGGo7tTo=; b=vapHEUiEGNowKFy31KdDd5+EnLIPfvtTQUv9pe2f103SinSF3cPCqruezmGozGP8av CUiE3CFkx4eTZ6cN7dqKrcwiwEwxXjwpcKsYQxCFiayxR5hzPk5Apoj2QCjquht3Jyi2 FVNrgHGc+hBJQq4fXKc1rwqbCjgrxXyw9blquurVRPHpDfhcE41ddXn1ly0avJQLDqyt cibnSNLAIHU1lcWnPhzGg/+oFqFwT5e8isGEtpX/4UiV0Qy09x9Ikv9OveyA94G8MLln XLAyfgm4aksyH5tm2YW5QGFWkVFYOOZW1wxN/+RO4HQj4KUUrIZgac/UcASJQaQeoAK7 e3vg== X-Forwarded-Encrypted: i=1; AJvYcCX0Wu5oNxyA1EJ1QmRDz8l+AmfD83SlcoQuHWul1Wj46ehYrpmOKKPIzkJ573Wb959fodxqHxAxJI8K@nongnu.org X-Gm-Message-State: AOJu0YyGmCPEKzA41/ZNp3GOl6/tGCyAQUpZUh8Q/7lBrcC/uHbCsnrV Q6rp+kG1HKD7giUZaEntoNpz52PPrAEz0cTu+7kMhIDVG35ISf+XdPv8 X-Gm-Gg: ASbGncvbQSJJJOfIDFnZtGIm/WuSebdGIDgSFrlziH7vKBA5SAxD4pjZiwIO6DwaFZF Fi7Vajx/HZKCSBC2KChk1Gc700hc+hgVE9f3AaD66wECd7Bb5UhOR6c/skFbxgxsRxUEYjiN0HW yy9fEkGBW7K0rB3H9zgp0kyuNtjhpScyn7gE0RZtaWrv7ihV5kt/5+FO+0VkAaAK5T6dfdY/UWK YUUsirGBsM+NoCjWr1dqD176xBoC7DKm2EMbWSFWkDmk+Q6SEBhFgvBtzX9GV4lcF4EBnlokc3D +zRE4JZIU+YRD0xXHq/5Ry8zCkPruupEt1mmIuJNUer4PYL+8sFRNZfZCbH3W5nhHoA9kqJfjzj 75CblZZfyJzd5FFz7UqQlrkWefHga3j8CGJ9trY08HcOPXoPev0/sw85toxOIzQWWiGN+fck9Sn SS5EYM98cevjhhOS+kb4vrjIfXIod796F6pTcOWYonuoY0ehiWKA== X-Google-Smtp-Source: AGHT+IFCeYODO3tyqMNK+Kw/LvmH7vHC+D905bPchT3112nnpg12YOYKBiJAMXNemL9GZjiUMcXmig== X-Received: by 2002:a05:6a00:98a:b0:77f:1ef8:8acb with SMTP id d2e1a72fcca58-7a777d3b6d1mr8414933b3a.13.1761985357819; Sat, 01 Nov 2025 01:22:37 -0700 (PDT) From: Soumyajyotii Ssarkar To: deller@gmx.de, qemu-devel@nongnu.org, mark.cave-ayland@ilande.co.uk, stefanha@gmail.com, sarkarsoumyajyoti23@gmail.com Cc: Paolo Bonzini , Fam Zheng , RemZapCypher Subject: [PATCH v3] hw/scsi/ncr53c710: Fixing defects reported by Coverity Scan for QEMU Date: Sat, 1 Nov 2025 13:52:31 +0530 Message-ID: <20251101082231.8681-1-soumyajyotisarkar23@gmail.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::441; envelope-from=soumyajyotisarkar23@gmail.com; helo=mail-pf1-x441.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1761985436932158500 Content-Type: text/plain; charset="utf-8" From: RemZapCypher Fixing Null pointer dereference & Async/Sync IDENTICAL_BRANCHES Reported-by: Stefan Hajnoczi --- hw/scsi/ncr53c710.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/scsi/ncr53c710.c b/hw/scsi/ncr53c710.c index b3d4593b72..dd9884c8bf 100644 --- a/hw/scsi/ncr53c710.c +++ b/hw/scsi/ncr53c710.c @@ -834,13 +834,11 @@ void ncr710_transfer_data(SCSIRequest *req, uint32_t = len) } } =20 - /* Host adapter (re)connected */ - s->current->dma_len =3D len; s->command_complete =3D NCR710_CMD_DATA_READY; - if (!s->current) { - return; + s->current =3D (NCR710Request *)req->hba_private; } + s->current->dma_len =3D len; =20 if (s->waiting) { s->scntl1 |=3D NCR710_SCNTL1_CON; @@ -1367,11 +1365,6 @@ again: case PHASE_DI: s->waiting =3D NCR710_WAIT_DMA; ncr710_do_dma(s, 0); - if (s->waiting !=3D NCR710_WAIT_NONE) { - /* Async - stop and wait */ - break; - } - /* Sync - continue execution */ break; case PHASE_CO: ncr710_do_command(s); --=20 2.49.0