From nobody Fri Nov 14 16:55:17 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1761929551; cv=none; d=zohomail.com; s=zohoarc; b=d5AJy6Fm/y6ZLozTq9scix6A5aZo6RClkfft6UUArGO/CZNI1SryqlZjQ0N0ieudauxa/d3Scxwx5WScwoP1Vz3xNjatuDsb3xp5OFtwSST6g3WX0eyOqzts4ZGdvILPqbpFML7/sFqjd05wRtv1zOaNX5ZIz0ZEk4FojcyPaI8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761929551; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=beyCY99b/Vjqke+r22UnEMDrIprbFl76fhiUtHqNLrk=; b=BuJ/5J5FFLq2Z89P2+QGVqXD0eDd6I1EvuGCCLPVAXbipx3lg4AyCKUdz7mPJExLQ6D8iRCTORMFvsb++Y9wLhfuBW3pwpRlAcVLeM3vPBHy0UgJw9uqcrxVoH70SMeuxXFp5F85uTfhCgvf2DyCLWGcvUr7jfoPUjfTClN3YbM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761929551974901.6794666468165; Fri, 31 Oct 2025 09:52:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vEsKZ-0007K2-L4; Fri, 31 Oct 2025 12:50:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vEsKU-0007Iv-Iv for qemu-devel@nongnu.org; Fri, 31 Oct 2025 12:50:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vEsKJ-0007B0-DY for qemu-devel@nongnu.org; Fri, 31 Oct 2025 12:50:22 -0400 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-189-TVC6V2k5OQyRTJ5A1Vy35A-1; Fri, 31 Oct 2025 12:50:00 -0400 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-880441e0f93so5463206d6.1 for ; Fri, 31 Oct 2025 09:50:00 -0700 (PDT) Received: from x1.com ([142.188.210.50]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-88036317113sm14165106d6.42.2025.10.31.09.49.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Oct 2025 09:49:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761929404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=beyCY99b/Vjqke+r22UnEMDrIprbFl76fhiUtHqNLrk=; b=RIqC+xQAQ3dPBNwt51KcZcEF2ydsYnU+rZk/iS+lHBG+s/BgPbJACYe3x1JQVABZP9Hx1/ 1yUMt04mVOsunHD2603I6uojfaY8BlvQJcOhhQ5r/aJKWghB6GjxX17Jd5b885PAZ+cZWL OTDdbF5eQHYR2aXLlJoNbN4AIgElwk0= X-MC-Unique: TVC6V2k5OQyRTJ5A1Vy35A-1 X-Mimecast-MFC-AGG-ID: TVC6V2k5OQyRTJ5A1Vy35A_1761929400 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761929400; x=1762534200; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=beyCY99b/Vjqke+r22UnEMDrIprbFl76fhiUtHqNLrk=; b=g3xAAlt/pJdrkL8A0x9cKOUXVyBIhqPfXueGiR3oXIS53z+gSeKFcR2q+tqmvMFawU rfdktbkQlGQVgjgCU7qct6ppu0z//EUkskUimRvGOBuctWI6TzDRMhkkO/kUWgEQEHbD 8CTtNxLwDR+3zLdSnMJtOqBlRx2fUvemiDxOGt3kYEeuwW1GtCE4gfgZddgMevU4SM4m JcjaKAbY1mHmVpCC/CGRT3uB/83wo6o14ZJKK/ARrgiT8QIay7t94QlIUHpaq6DwHODX yvMYcPVcdCX1sAp+syjtjAWtECQ9anhRpRvBb5RX/rnae04S4mwJj9ZMlIgIo7m34zEO Q3gQ== X-Gm-Message-State: AOJu0YxYyg+2ojNFFg/cd4FhS5d2cYDmoIaDXesY+JHsCeKDm0A5KCm9 izn9Th8lCxt/ss6A6mDmlwWO3e1Ig2cOLg6OUUhDrcfKkWMBlfdYxu/SCsLN/6mLO/mLHnZi6Wc nXpD2BTJajJHQnGT2uc504AD2wjovNhw+wdecnMhbtZSogiKeesjMyFtaJKfbNX3H987uR8NhUr pRU5T4akELzRznXXqGLmLqKuB+8jAZYOvH5D7DWQ== X-Gm-Gg: ASbGncsvwDT152rM0vcLu/7Owmf0xPfrdx0fgFRF2NLoF881XwYx0hmSvQPxs3kRdrc Bec3Vbw+gZzU1UONcfvPd51HrV5CoB1d8i1HwYYsrbDhk74Dkm0s8I40gfrY+tbeGB9bX85gwyE 4bd9OshyQRb9Up7RT1Ejg75gpcGzeO0HNaX+8SdQSDinKsoAxmrT2hfTavkvrP5z1aLrddSoOn0 qKw+wRYRZOsqZuI2bdZp5DWEm0CToBPbKtYEtQLgGxwPgZdvi0S0iuPqxxAAJsfR7Bl+DaaaUhf 6cZBVfcDWFs9XQZQWcBfR/qjJk6tblwKZ5YSmEvutqmk69yHQ/XjvIN9xVv2gOok X-Received: by 2002:a05:6214:19c6:b0:87d:ca33:2599 with SMTP id 6a1803df08f44-8801ac24967mr103352196d6.13.1761929399992; Fri, 31 Oct 2025 09:49:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHte/aL07P5KYNmw+jry83Svj9dF7SvAsBT83K0BHId46ZwrUqZlVuKDtXUYAFhhgdz22OjGA== X-Received: by 2002:a05:6214:19c6:b0:87d:ca33:2599 with SMTP id 6a1803df08f44-8801ac24967mr103351626d6.13.1761929399420; Fri, 31 Oct 2025 09:49:59 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Fabiano Rosas , Juraj Marcin , peterx@redhat.com Subject: [PATCH] tests/migration-test: Check error-desc after pre-switch cancel tests Date: Fri, 31 Oct 2025 12:49:56 -0400 Message-ID: <20251031164956.3409661-1-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1761929554254154100 Content-Type: text/plain; charset="utf-8" error-desc should present on dest QEMU after migration failed on dest when exit-on-error is set to FALSE. Check the error message. Signed-off-by: Peter Xu Reviewed-by: Juraj Marcin --- tests/qtest/migration/precopy-tests.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/tests/qtest/migration/precopy-tests.c b/tests/qtest/migration/= precopy-tests.c index 57ca623de5..5f02e35324 100644 --- a/tests/qtest/migration/precopy-tests.c +++ b/tests/qtest/migration/precopy-tests.c @@ -759,6 +759,14 @@ static void test_cancel_src_after_none(QTestState *fro= m, QTestState *to, wait_for_migration_complete(to); } =20 +static void assert_migration_error(QTestState *vm) +{ + QDict *rep =3D migrate_query(vm); + + g_assert(qdict_get_str(rep, "error-desc")); + qobject_unref(rep); +} + static void test_cancel_src_pre_switchover(QTestState *from, QTestState *t= o, const char *uri, const char *ph= ase) { @@ -784,6 +792,7 @@ static void test_cancel_src_pre_switchover(QTestState *= from, QTestState *to, =20 wait_for_migration_status(to, "failed", (const char * []) { "completed", NULL }); + assert_migration_error(to); } =20 static void test_cancel_src_after_status(void *opaque) --=20 2.50.1