From nobody Fri Nov 14 18:17:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1761835817; cv=none; d=zohomail.com; s=zohoarc; b=RH7wwdyQCofoIkwAcP+Bdgdk1tIN/qaC2pmzgtP15ap8ltHvXW8jXoClNdt1No7DoFLzxb+p+EF8lQJRNd5MjMNEWTL4deA7qCDxq8ZmcPfYNHt/r4wO340OJIQwtKwZ3K0DMbrCHsVW/V+5v5wOriDBknpSLumoTFL60rACSXk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761835817; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V63kLovDtLxShSX97e1gMJ0rHkzBCZtg+z1997cvzJc=; b=PHAt5CePMhJ5jY11eshqgr3OqdD+MqM6EYXa4A0LsSvnotBLY564dRd0Iliwz16eveo44WBbjRf6CDeOEPieAUg1t9qTTKZ+LKmajWQX9VtZQvHQC5v3CULf3OzW9C+7EDHpWYib15UCNYWuWUbe2LeGMsyEGTVeLDThiptG+FQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761835817869700.123092304043; Thu, 30 Oct 2025 07:50:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vETx1-0008PH-BG; Thu, 30 Oct 2025 10:48:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vETwz-0008Lr-5U for qemu-devel@nongnu.org; Thu, 30 Oct 2025 10:48:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vETwt-0001KA-GD for qemu-devel@nongnu.org; Thu, 30 Oct 2025 10:48:28 -0400 Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-486-Znw35p0AOoGaZKGT85wIFg-1; Thu, 30 Oct 2025 10:48:15 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 59FA61955E74; Thu, 30 Oct 2025 14:48:14 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.42.28.122]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 02E831800581; Thu, 30 Oct 2025 14:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761835698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V63kLovDtLxShSX97e1gMJ0rHkzBCZtg+z1997cvzJc=; b=f+TfaA2yPBuZko5ggxX04tdUDGwnocVYsHTh53Gr8C0KLsxna6P9EZ9tHqD2sPRr4G1ShF 25eu0MdWArk9yP4FhiFfO5mdkLePaI9GRMdjL2nCaXv5kHA2L1rTahYWjcQwdyIHn45++2 QgLd5ULQjqTdBaZd+sBHRtQTowybhcI= X-MC-Unique: Znw35p0AOoGaZKGT85wIFg-1 X-Mimecast-MFC-AGG-ID: Znw35p0AOoGaZKGT85wIFg_1761835694 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , devel@lists.libvirt.org Subject: [PATCH 03/21] crypto: replace stat() with access() for credential checks Date: Thu, 30 Oct 2025 14:47:47 +0000 Message-ID: <20251030144805.2239954-4-berrange@redhat.com> In-Reply-To: <20251030144805.2239954-1-berrange@redhat.com> References: <20251030144805.2239954-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1761835819043158500 Readability of the credential files is what matters for our usage, so access() is more appropriate than stat(). Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- crypto/tlscreds.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/crypto/tlscreds.c b/crypto/tlscreds.c index 9e59594d67..208a7e6d8f 100644 --- a/crypto/tlscreds.c +++ b/crypto/tlscreds.c @@ -100,7 +100,6 @@ qcrypto_tls_creds_get_path(QCryptoTLSCreds *creds, char **cred, Error **errp) { - struct stat sb; int ret =3D -1; =20 if (!creds->dir) { @@ -114,7 +113,7 @@ qcrypto_tls_creds_get_path(QCryptoTLSCreds *creds, =20 *cred =3D g_strdup_printf("%s/%s", creds->dir, filename); =20 - if (stat(*cred, &sb) < 0) { + if (access(*cred, R_OK) < 0) { if (errno =3D=3D ENOENT && !required) { ret =3D 0; } else { --=20 2.51.1