From nobody Fri Nov 14 19:43:45 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1761672964; cv=none; d=zohomail.com; s=zohoarc; b=R2arAKss3XgTCng0Qslgzoa+/mPY0I91kRA23zBkj4Ci3D0w34RB6LmRCf+zt7sqkXRtbVdgsCRSiL3KcGyZf1o86Tv3J0T8GNKjI9IWp2Xk1d0kYtN4qPBos1zlivAw4gF/mXMDlKtHnkvRyAABMRvd8tuMgtwMXxs6loO0Se0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761672964; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=uNUgC+CpMFn7MC6N/Zib6jbMtfkLhzBQ6ENJcnYPLcY=; b=LTv57NmeqJX/kZo0g3pKrMpi6anSPKbd4BazdFyrFDwvE8YBm8Ltu/WdJEsnQ1KrCvPTLzlP/Ghn3sdIBGecMjMma9n7EBk6mRUGdFsKDJoZQcNcgaO+qr+nI4Lxom0aOoaOnN/nUrLEPOs2GAywOk/3cIx7LEIvmZfYDqKC21E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761672964452391.5951384596758; Tue, 28 Oct 2025 10:36:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDnbH-0006DH-5S; Tue, 28 Oct 2025 13:35:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDnbF-0006Bp-Df for qemu-devel@nongnu.org; Tue, 28 Oct 2025 13:35:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDnb8-0004Sc-M4 for qemu-devel@nongnu.org; Tue, 28 Oct 2025 13:35:13 -0400 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-682-kmWzT40lPXC-t_oV4CoUUw-1; Tue, 28 Oct 2025 13:35:00 -0400 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4711899ab0aso44619155e9.2 for ; Tue, 28 Oct 2025 10:35:00 -0700 (PDT) Received: from [192.168.10.48] ([151.95.110.222]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4771e202093sm3535315e9.11.2025.10.28.10.34.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Oct 2025 10:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761672901; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uNUgC+CpMFn7MC6N/Zib6jbMtfkLhzBQ6ENJcnYPLcY=; b=UgeQ3lbihjE4uB/Q12iv9e+6L8p8PeWEgqqRshyAHxJQvviSGGDxqOK7b3Z28ZW2zqTI7g zovQoye6d6jM1+kswS7xHzQK4J7btf276ikBOrApzIUKkz1pF0fE/3CLOW/bKY5oQ5Aww7 r1NZNExI+VysuTGsJ7FS75o5zWEo0w8= X-MC-Unique: kmWzT40lPXC-t_oV4CoUUw-1 X-Mimecast-MFC-AGG-ID: kmWzT40lPXC-t_oV4CoUUw_1761672899 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761672898; x=1762277698; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uNUgC+CpMFn7MC6N/Zib6jbMtfkLhzBQ6ENJcnYPLcY=; b=iNyDV4h3ijk8zo0Bhx68MdbbQXg50b+j7d9/QK2ih4/WywC84v6pWsQE5fhnA98733 YZbNcVoscpw87iQVa9sp0IvqWz7srBuSEAYsmO3WIeAFmufv77hYaB/x7iHn0GHCXwxp cXcMvIxhnpJbYagfwTDpGUfduPqtg/fQA795JXShX5wVbalBUklRvgA4SLQHuzCvhOJw FO3cxXQejZMAu/BlUT2j3oK39oZygi0w2lc8Mz2vdjhKPbjwZ2OIWEXkChBpFq3i9f2u nmBhJy0ocSJa3K8d6Kb3b2sxmrNdl3T4CH2eKqMz64hJyilBoBwlTlPf9cogPTQKpH5v tyMA== X-Gm-Message-State: AOJu0YwGPNsoLh/ml0uX6slumT09pGcLn91X7U5pxUnwzk4MeOqnLKHs ae2nJapB80ryGJiP+y4iaevQV2o5bE6MH6SfUXtlvBWIxYLmTT7n7EQoX5z/fkVoM51FVB8V/Vj JH7B6CF4UkgKjyIP9wf9QGyIlMZcC8DfKGOlRrM+HR9yy2B8oendjW2XiYCUPoo+f5euZwTo6HY lBym/RcnYBq2JtyPimrqmM95ylbnOEQxWJHtUoZSDw X-Gm-Gg: ASbGncvFX8mz5tED8OSu3lpWKIYmsv8TaSnseHsKC4f2tg4OMp3bQTnvo5g47a+PI3k +vgdqxxEE4MNYsMH+KnqjGkRCV1WW6RBfcs9wDHCbraMGFY/G+ZmpXquR9z81ou+fB5ji1E3XT8 bPfD+xE7VdkkOnwz7TOQhj6iNXWQ0tSs4XBmQw8y3fp7wsw5fk/bgUquZwrcnsRGgB0fb9HC+bY h06/33vlcZwAVQ0L1TAcCRQLSMXqcKst6P8BzXYm+r1HOrDXWz4aN/jN8LJzf8/mlvve6x+iRiC h7z/lTQpt5BX/3UJ9bxXEt80dI+aEUgnaEELopAR+WMfl+D66247WeJcBmJfrKPOcw6MSfz8wmZ CrO0v33ajflMLKDNziW0Q8dENTr4HsB3BKpt1bAmm4gNNIe2+o/gSXMlFX4wcpx+/Cqpl22n60H YvF/o= X-Received: by 2002:a05:600c:1992:b0:475:d952:342f with SMTP id 5b1f17b1804b1-4771e24e0fdmr2056235e9.39.1761672897803; Tue, 28 Oct 2025 10:34:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF3OeZeHSZv4NQ7tuLzYcaOXr9HroN3Ew7tD56JoIb97RfKqnz54BteuTIHb+bwl2DtvtGdJw== X-Received: by 2002:a05:600c:1992:b0:475:d952:342f with SMTP id 5b1f17b1804b1-4771e24e0fdmr2055935e9.39.1761672897248; Tue, 28 Oct 2025 10:34:57 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Peter Maydell Subject: [PULL 09/18] accel/mshv: use return value of handle_pio_str_read Date: Tue, 28 Oct 2025 18:34:21 +0100 Message-ID: <20251028173430.2180057-10-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.1 In-Reply-To: <20251028173430.2180057-1-pbonzini@redhat.com> References: <20251028173430.2180057-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1761672972022158500 Content-Type: text/plain; charset="utf-8" Coverity complains because we assign to ret here but then never read it again before we overwrite it with the call to set_x64_registers(). Analyzed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- target/i386/mshv/mshv-cpu.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 1f7b9cb37ec..1c3db02188c 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -1489,6 +1489,10 @@ static int handle_pio_str(CPUState *cpu, hv_x64_io_p= ort_intercept_message *info) reg_values[0] =3D info->rsi; } else { ret =3D handle_pio_str_read(cpu, info, repeat, port, direction_fla= g); + if (ret < 0) { + error_report("Failed to handle pio str read"); + return -1; + } reg_names[0] =3D HV_X64_REGISTER_RDI; reg_values[0] =3D info->rdi; } --=20 2.51.1