From nobody Fri Nov 14 19:42:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761630862; cv=none; d=zohomail.com; s=zohoarc; b=OS0BlZ8qh6ykptznCEghk/1LfPtts8P3ziX2UzeXywV7aU+8Wu8iwlw9GypMod/UVN8T7dwvrt3hoMB9XYZHfU2c6lv+7w30PLTU78ivMzU452ftZ/wRgj39+MdO+YtRbrUOc6Q9m8fJnkn7IZIsFHWfcFzouLK1/rR/aBjt21s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761630862; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=D/iyIMlpli6FTCe5zjpzm5x3w0vLSEGAxerjR++HIGs=; b=RXSEyzHKBSKPC409nbXiYFkEEwHWMu1qVMtR6Oh16FIjVU+zYIOz+GO03AceS+W0bGqb/tu8/iUWyfGiwKNjFGtjHdFiMdwOhFLJNWcCJ7yLKi4fbGJ4V1ZRmBWwPuFe6f29WS7rOCjB7L37l96t1yCpwX+G0vV7EQ+P7u8fHRg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761630862615652.6261340258635; Mon, 27 Oct 2025 22:54:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDces-000438-81; Tue, 28 Oct 2025 01:54:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDceq-0003z3-PO for qemu-devel@nongnu.org; Tue, 28 Oct 2025 01:54:12 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vDcek-0004jb-C4 for qemu-devel@nongnu.org; Tue, 28 Oct 2025 01:54:12 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-47109187c32so29774945e9.2 for ; Mon, 27 Oct 2025 22:54:05 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dd477d0esm170237355e9.0.2025.10.27.22.54.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 27 Oct 2025 22:54:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761630844; x=1762235644; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D/iyIMlpli6FTCe5zjpzm5x3w0vLSEGAxerjR++HIGs=; b=XazHInvhBjbnktxjcs97gXDkCDmZCctvzbq8/Bt74RsmlNGVidtgwi/+7F3cJDjpgb lJ5dyj9KDfeWAgFWETII0xJtr3zsQfdTLEfR2wcNL0mTcFCwz8fDncXPgKQzs6103JAx 4deiL/MJ/+k/QrRtJ022tdgiW56BmtcTU/6dFe5bXs8AFM/xdZNOzXYFP6GWYKWoA+cO 2yn1MagkpfZZqg8NheEbWXxQhubrlNakPhpDO4mW1YKGnhoOEoaBlAbsBVzxrvE0qllk kVpbG9TFqxUUdqgLF48hBCjAqANxIw2saAsfyNcHI/Xy5xlq8e91Q0Z+yjYgSJDAQUl4 2crQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761630844; x=1762235644; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D/iyIMlpli6FTCe5zjpzm5x3w0vLSEGAxerjR++HIGs=; b=D5c2vwXiukgvoP30ljJtA9gNA1FPciR7DIA6q4IS4JDyemQTP/OPupPkdaX3vRkFbA wfAMSwOWVb1zVDPIgJhRm43/JZm4blmwJ4cM/3ewyovoPbi55puMwIgQbzdDC/iyNihm nIZeyGVGMls8iF2CDDqig2sn1t+lgWEtmtO0YiAtt0AYQfcoXD24YuFX4w8ncmwFTfQx ZcUDU7hMV21csan/TER/PTF3oO3fAvOqU1v7ExCFogcNUGPG7hW6GNS1m+ZXG2kh/G1b hIKZzC5RcfUfC1ULbliFpW1SyurdXEMCutCkdPss5/coxFM+mk9+k3EtZ8inBPk9ulrv n7tQ== X-Gm-Message-State: AOJu0Yye9AplnuGaV2ylf9CKnof/Ntxyf/41kTINM+CRAvdoYc2sdPKE FFVo2Ku0/Bht1zJG+aHt4PViVA+Cq/T1OUJMipvYLBJ5Cn5lYFNtO9sOhMD8d46e4slW2+68htx +uYmlfOE= X-Gm-Gg: ASbGncsAeIHNovOh30Fma38xsAQUM1nY/riuru+CKmIMQYgMceyXVenyv+18Fxy9Tok igOlOpFJrp91ZGD97xnw/Vh/uTH9MiW7WQr+3aQ2cXdJCmL5MV+AyNKFfTaZY0C8RHJTkrBuHU8 tRt6DCF9YOIZKq/6o8CFj9ZmEjyrBqF2h+2KCEZVBT61hAziI77bQdFvQN3QNoPHKcGqYAN4JrB 96K2Hk9Vi6q44vPC8ruXycpysZRbA8Xh+7+8x4mlH5v8xtxgjjvJk2hVs0h2Mff6Y8T63Ii3b9d fNX+Gcf8XeJlYOnEFeUABOMurUq9K8J55kZkuiau/oGSXZdeAWccmkMN8Nk3Wg0JzFDQq5k9Pqr lFQiukMpDd4VpvioYN5kRtCdgrJz6Ds4bVueB2AcDdF22SP2utxjMYHzjjZlhkZ9kZpb7XjQPyq ZTtcNoBxyhXfP2zcHURSkpdDgJAft9xothZuekEXWDRtVrI3NeaMmgmsY= X-Google-Smtp-Source: AGHT+IEb5h81e+/XRFYjkuXTFEucItwYLOcip2VYuQP8l/oQrFzh/8Ox6YeT99QNDXQq5I5Nuj0bJw== X-Received: by 2002:a05:600c:3510:b0:46f:b42e:e394 with SMTP id 5b1f17b1804b1-47717e7a904mr13880105e9.41.1761630844106; Mon, 27 Oct 2025 22:54:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mads Ynddal , Cameron Esfahani , qemu-arm@nongnu.org, Roman Bolshakov , Akihiko Odaki , Phil Dennis-Jordan , Mohamed Mediouni , Peter Collingbourne , Peter Maydell , Alexander Graf , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 16/59] target/arm/hvf: switch hvf_arm_get_host_cpu_features to not create a vCPU Date: Tue, 28 Oct 2025 06:41:52 +0100 Message-ID: <20251028054238.14949-17-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251028054238.14949-1-philmd@linaro.org> References: <20251028054238.14949-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761630865290154100 From: Mohamed Mediouni Creating a vCPU locks out APIs such as hv_gic_create(). As a result, switch to using the hv_vcpu_config_get_feature_reg interface. Besides, all the following methods must be run on a vCPU thread: - hv_vcpu_create() - hv_vcpu_get_sys_reg() - hv_vcpu_destroy() Signed-off-by: Mohamed Mediouni Reviewed-by: Philippe Mathieu-Daud=C3=A9 Tested-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Mads Ynddal Message-ID: <20250808070137.48716-3-mohamed@unpredictable.fr> [PMD: Release config calling os_release()] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/hvf/hvf.c | 35 ++++++++++++++--------------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index dea1cb37d1f..fcb6950692b 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -744,25 +744,24 @@ static bool hvf_arm_get_host_cpu_features(ARMHostCPUF= eatures *ahcf) { ARMISARegisters host_isar =3D {}; static const struct isar_regs { - int reg; + hv_feature_reg_t reg; ARMIDRegisterIdx index; } regs[] =3D { - { HV_SYS_REG_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_IDX }, - { HV_SYS_REG_ID_AA64PFR1_EL1, ID_AA64PFR1_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64PFR1_EL1, ID_AA64PFR1_EL1_IDX }, /* Add ID_AA64PFR2_EL1 here when HVF supports it */ - { HV_SYS_REG_ID_AA64DFR0_EL1, ID_AA64DFR0_EL1_IDX }, - { HV_SYS_REG_ID_AA64DFR1_EL1, ID_AA64DFR1_EL1_IDX }, - { HV_SYS_REG_ID_AA64ISAR0_EL1, ID_AA64ISAR0_EL1_IDX }, - { HV_SYS_REG_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64DFR0_EL1, ID_AA64DFR0_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64DFR1_EL1, ID_AA64DFR1_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64ISAR0_EL1, ID_AA64ISAR0_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_IDX }, /* Add ID_AA64ISAR2_EL1 here when HVF supports it */ - { HV_SYS_REG_ID_AA64MMFR0_EL1, ID_AA64MMFR0_EL1_IDX }, - { HV_SYS_REG_ID_AA64MMFR1_EL1, ID_AA64MMFR1_EL1_IDX }, - { HV_SYS_REG_ID_AA64MMFR2_EL1, ID_AA64MMFR2_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64MMFR0_EL1, ID_AA64MMFR0_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64MMFR1_EL1, ID_AA64MMFR1_EL1_IDX }, + { HV_FEATURE_REG_ID_AA64MMFR2_EL1, ID_AA64MMFR2_EL1_IDX }, /* Add ID_AA64MMFR3_EL1 here when HVF supports it */ }; - hv_vcpu_t fd; hv_return_t r =3D HV_SUCCESS; - hv_vcpu_exit_t *exit; + hv_vcpu_config_t config =3D hv_vcpu_config_create(); uint64_t t; int i; =20 @@ -773,17 +772,11 @@ static bool hvf_arm_get_host_cpu_features(ARMHostCPUF= eatures *ahcf) (1ULL << ARM_FEATURE_PMU) | (1ULL << ARM_FEATURE_GENERIC_TIMER); =20 - /* We set up a small vcpu to extract host registers */ - - if (hv_vcpu_create(&fd, &exit, NULL) !=3D HV_SUCCESS) { - return false; - } - for (i =3D 0; i < ARRAY_SIZE(regs); i++) { - r |=3D hv_vcpu_get_sys_reg(fd, regs[i].reg, - &host_isar.idregs[regs[i].index]); + r |=3D hv_vcpu_config_get_feature_reg(config, regs[i].reg, + &host_isar.idregs[regs[i].inde= x]); } - r |=3D hv_vcpu_destroy(fd); + os_release(config); =20 /* * Hardcode MIDR because Apple deliberately doesn't expose a divergent --=20 2.51.0