From nobody Fri Nov 14 20:44:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761630853; cv=none; d=zohomail.com; s=zohoarc; b=NnRDGUj5T8WbTpjUxYJefycpTnqzOLzh4VO1r+U/1mMh2wXH7iIqsici8mUpgZcEwYuwusK+l/GcquzvJG/OHBHuwsCJFVrysVQAHjnKJvR0HseqZ3wcVUQ0V4cLPd+EYKs0xsYjdBVshAHXM3Bd7JTZsmEIue1iP61K9aGTgbg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761630853; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YPRRwLj76IcDwxiEgjfHUMq405RINil88LOEgkCDg4g=; b=XmxKebHuTZTJ1rwfN0pvims0607J1hOk1hZ056Hpq99pXSrS6pVzWyWPKX/ugWaqyhflpW+oQoEcpJ/VwtHuKGeMb9QBf/mKhRPyU5O3+KyEFCW72uIZU+xXNev6+4wtI4GRhy3jV8qvie/4hcsF7UYNh8fhh9UQo9+AxpWNgAg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761630853384260.6876550017287; Mon, 27 Oct 2025 22:54:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDceN-0003Xj-0d; Tue, 28 Oct 2025 01:53:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDceA-0003R2-9O for qemu-devel@nongnu.org; Tue, 28 Oct 2025 01:53:35 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vDce4-0004gy-6b for qemu-devel@nongnu.org; Tue, 28 Oct 2025 01:53:28 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3ee12807d97so4881425f8f.0 for ; Mon, 27 Oct 2025 22:53:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b79absm17995807f8f.3.2025.10.27.22.53.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 27 Oct 2025 22:53:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761630802; x=1762235602; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YPRRwLj76IcDwxiEgjfHUMq405RINil88LOEgkCDg4g=; b=l0pF6zHTLcorNjwnMtTlFAp6Jy9DfTIPZpLI1I/MuTBc5WxVpIVUfr4xflacPqCMEH wcLpu/N9Qxxy+NQ6iSsSTNdpeVIHFRS0dztOfUc7T11G9vDJXFbECzCY2shH3B/AP4yc nOsL0LGt7XWdAaET/U2eiYkWUO7w91p1ScinYFZXAPNwNJ4aujumh9V2uyKh93ORkiSY hbRoiOoy+yG2QOISkj6lPSkfPZmLqBxvEngWMkGZpzSP6hV9TcBgJZomR8miF+Nt4fWm MJAbUAiqn6uJuXCZFcATU/mHy6Suv7TnNFEfIQ2DVE6mXSapvGx7751PO5JVJ+2a9XVg xqTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761630802; x=1762235602; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YPRRwLj76IcDwxiEgjfHUMq405RINil88LOEgkCDg4g=; b=tm2Yzny/EKQc1kNSJRoMInCsLCuTIh9XoZHx3XatIOjTFeNEJDrOYLiE0qEyWM9Z4m jDPBJrVWMKsbdcVAEGK/bs4fmrqqW/CRDAdz+2C9erB6qSuWI5awPckLFCCXsdAJMJWw JFFTu6+41uPhea7Vn/jbZYDanOieVCvu1IGUoAscfF9bPl7fU8XPEmZYbPAiEJZQIn6Q mhdfATVphqtPWFO/Jykv2dzL2F+uvclx3FVLF4E+kjLlwskwCNp0DQR0VHJstAVzOFn4 HCB33b70vS0itWAW7Y4ayVb5ngX7AD3hz5TPSMn+tdAkAWu1z0targ/C4UZLiK0nbQin 57IA== X-Gm-Message-State: AOJu0YwaMg4CV75YcajXzQEThCSsQXafIDqksUn6c8VpzZBD57QKIdEE vEM4Pb9HmkKA7XrjoJkB96jP+F0JGeieIb1l7HQaY1/b3cMELtcHZ2r29vjqPeMSfkvcup8V5KS OC7I5FE4= X-Gm-Gg: ASbGncs3CdUxWgSLuyrgfu4autiMajV6a2fwXFxYVGGhYpVWVCLLdZt7YxM3m/PcmAt +H3sk7r5ftv43OJrU1B2qcayrEcpyaMvRpDBAvi2hO4R3qAHo4i6OayYhsrymfvknMPz4sMPaOI m/+gvqByz6bRNG7V3/pe2bSNH7Z2x2GyNmT+AeYFJbH5tXPUsUaYaXFQ9L42mtVaH8Idnaepok+ fVsf1AAQWIXgGtnp5JFbAz9UWoCajR8pRVsDMTwBSvGCy2+H1yFPa3iVZjgOAl1Fm9JUeLk/TXv g3xdFmad/JoxJ3afSbFyqoapWjEy8wV37IDZqZdquA8jSLoqVlTujVQ+8WbtUk4hmZkzadSvdx5 ZncQR05P2qyIbUOHZtHuwTF4wn19cDqmfqY5bV1f3uO7dBSSm3T54h2fgsnjHXEEcR5KN6gQl7H WS5IMoRd4yOVySopRm0rceYRGHcqBRDcHUj2+YUlewoIYRDqr6Z+KNf1I= X-Google-Smtp-Source: AGHT+IGBx//945fjY+61kZB9I3lDSHqKuRIUCe22/xupT8sh4qbgKfJbxvD5raUlJ/JvbSaJV1ScOg== X-Received: by 2002:a05:6000:2911:b0:428:52d8:9680 with SMTP id ffacd0b85a97d-429a7e5522bmr1605473f8f.18.1761630801797; Mon, 27 Oct 2025 22:53:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Mads Ynddal , Cameron Esfahani , qemu-arm@nongnu.org, Roman Bolshakov , Akihiko Odaki , Phil Dennis-Jordan , Mohamed Mediouni , Peter Collingbourne , Peter Maydell , Alexander Graf , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v3 15/59] target/arm/hvf: Simplify hvf_arm_get_host_cpu_features() Date: Tue, 28 Oct 2025 06:41:51 +0100 Message-ID: <20251028054238.14949-16-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251028054238.14949-1-philmd@linaro.org> References: <20251028054238.14949-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761630858883158500 Use index in the structure, dereference &host_isar.idregs[] once. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 890e9266f93..dea1cb37d1f 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -743,21 +743,21 @@ static void clamp_id_aa64mmfr0_parange_to_ipa_size(AR= MISARegisters *isar) static bool hvf_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf) { ARMISARegisters host_isar =3D {}; - const struct isar_regs { + static const struct isar_regs { int reg; - uint64_t *val; + ARMIDRegisterIdx index; } regs[] =3D { - { HV_SYS_REG_ID_AA64PFR0_EL1, &host_isar.idregs[ID_AA64PFR0_EL1_ID= X] }, - { HV_SYS_REG_ID_AA64PFR1_EL1, &host_isar.idregs[ID_AA64PFR1_EL1_ID= X] }, + { HV_SYS_REG_ID_AA64PFR0_EL1, ID_AA64PFR0_EL1_IDX }, + { HV_SYS_REG_ID_AA64PFR1_EL1, ID_AA64PFR1_EL1_IDX }, /* Add ID_AA64PFR2_EL1 here when HVF supports it */ - { HV_SYS_REG_ID_AA64DFR0_EL1, &host_isar.idregs[ID_AA64DFR0_EL1_ID= X] }, - { HV_SYS_REG_ID_AA64DFR1_EL1, &host_isar.idregs[ID_AA64DFR1_EL1_ID= X] }, - { HV_SYS_REG_ID_AA64ISAR0_EL1, &host_isar.idregs[ID_AA64ISAR0_EL1_= IDX] }, - { HV_SYS_REG_ID_AA64ISAR1_EL1, &host_isar.idregs[ID_AA64ISAR1_EL1_= IDX] }, + { HV_SYS_REG_ID_AA64DFR0_EL1, ID_AA64DFR0_EL1_IDX }, + { HV_SYS_REG_ID_AA64DFR1_EL1, ID_AA64DFR1_EL1_IDX }, + { HV_SYS_REG_ID_AA64ISAR0_EL1, ID_AA64ISAR0_EL1_IDX }, + { HV_SYS_REG_ID_AA64ISAR1_EL1, ID_AA64ISAR1_EL1_IDX }, /* Add ID_AA64ISAR2_EL1 here when HVF supports it */ - { HV_SYS_REG_ID_AA64MMFR0_EL1, &host_isar.idregs[ID_AA64MMFR0_EL1_= IDX] }, - { HV_SYS_REG_ID_AA64MMFR1_EL1, &host_isar.idregs[ID_AA64MMFR1_EL1_= IDX] }, - { HV_SYS_REG_ID_AA64MMFR2_EL1, &host_isar.idregs[ID_AA64MMFR2_EL1_= IDX] }, + { HV_SYS_REG_ID_AA64MMFR0_EL1, ID_AA64MMFR0_EL1_IDX }, + { HV_SYS_REG_ID_AA64MMFR1_EL1, ID_AA64MMFR1_EL1_IDX }, + { HV_SYS_REG_ID_AA64MMFR2_EL1, ID_AA64MMFR2_EL1_IDX }, /* Add ID_AA64MMFR3_EL1 here when HVF supports it */ }; hv_vcpu_t fd; @@ -780,7 +780,8 @@ static bool hvf_arm_get_host_cpu_features(ARMHostCPUFea= tures *ahcf) } =20 for (i =3D 0; i < ARRAY_SIZE(regs); i++) { - r |=3D hv_vcpu_get_sys_reg(fd, regs[i].reg, regs[i].val); + r |=3D hv_vcpu_get_sys_reg(fd, regs[i].reg, + &host_isar.idregs[regs[i].index]); } r |=3D hv_vcpu_destroy(fd); =20 --=20 2.51.0