From nobody Fri Nov 14 19:46:55 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex.ru ARC-Seal: i=1; a=rsa-sha256; t=1761568377; cv=none; d=zohomail.com; s=zohoarc; b=FxRF2HkitIs7iLke2C/REO6LRQB137SL/WzUn7VYfTwK8aPyAwtJmT35YmN1zYDEw+od8samHQQRWIsB/5px/OXq0mbIamMYdvQ3KoJa0Iy3vqgkNijl/4DTXU9o2BAjYh4u2r1uslqE2RZpeuAOYxFttrNdbAiHoHTR0M9VBo0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761568377; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bPMnPeeBFpFY4Xe9n7lPZLYeTj8HS2ZblZJQfScrpLo=; b=c/4fB0UgkvVGLDVUMYoAxgNTUuO5aNyWCfNqMTg/V2cC7/8QvAR3OiqR0s3mPPN8OrzA5F5acQV09Oy2cWrp6xSkPdxA7Gus5tt0a/Naq62X3QyiDH7PDEmnjAWbOPnPZUeUezKirOepd5PFZLRYiMa9M7oAaq8iZeZfSzjn3l4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761568377835774.7515907344703; Mon, 27 Oct 2025 05:32:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDMNm-0007zR-DW; Mon, 27 Oct 2025 08:31:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDMNW-0007s7-4r; Mon, 27 Oct 2025 08:31:14 -0400 Received: from forward102d.mail.yandex.net ([2a02:6b8:c41:1300:1:45:d181:d102]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDMNQ-0005GY-C2; Mon, 27 Oct 2025 08:31:12 -0400 Received: from mail-nwsmtp-smtp-production-main-59.klg.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-59.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:2dcb:0:640:715b:0]) by forward102d.mail.yandex.net (Yandex) with ESMTPS id 0224AC01BD; Mon, 27 Oct 2025 15:30:55 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-59.klg.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id nUbd1g4LwiE0-U3VZqJ7u; Mon, 27 Oct 2025 15:30:54 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1761568254; bh=bPMnPeeBFpFY4Xe9n7lPZLYeTj8HS2ZblZJQfScrpLo=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=Wg7Fy25BxHqeQvVV3WhbVTrNtQzcYFKRY0jSe9jMlRG+ULrx82rhuz56np/8wc+zT nlkygqS9Zn5MFzZqRWSJGAJUzgwL79F71UZHCwuRmjTIrwJBGfE2wY58iXr2fTe3gQ J5saJwedh0H/tUHx7Mdde6p6pDidjtOlC8PtRuwU= Authentication-Results: mail-nwsmtp-smtp-production-main-59.klg.yp-c.yandex.net; dkim=pass header.i=@yandex.ru From: Danila Zhebryakov To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Laurent Vivier , Nicholas Piggin , Ilya Leoshkevich , David Hildenbrand , qemu-ppc@nongnu.org, Riku Voipio , Chinmay Rath , Thomas Huth , Richard Henderson , qemu-s390x@nongnu.org, Danila Zhebryakov Subject: [PATCH v4 4/4] target/ppc: fix GDB stub to work correctly with LE pages Date: Mon, 27 Oct 2025 15:30:48 +0300 Message-ID: <20251027123049.32038-5-d.zhebryakov@yandex.ru> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20251027123049.32038-1-d.zhebryakov@yandex.ru> References: <20251027123049.32038-1-d.zhebryakov@yandex.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c41:1300:1:45:d181:d102; envelope-from=d.zhebryakov@yandex.ru; helo=forward102d.mail.yandex.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex.ru) X-ZM-MESSAGEID: 1761568380714154100 Content-Type: text/plain; charset="utf-8" GDB is expected to be set to the endianness of the currently running code, = which may be in LE page. Bswap the registers accordingly. Signed-off-by: Danila Zhebryakov --- target/ppc/gdbstub.c | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/target/ppc/gdbstub.c b/target/ppc/gdbstub.c index 3b28d4e21c..89c783894c 100644 --- a/target/ppc/gdbstub.c +++ b/target/ppc/gdbstub.c @@ -19,6 +19,8 @@ */ #include "qemu/osdep.h" #include "cpu.h" +#include "accel/tcg/probe.h" +#include "exec/tlb-flags.h" #include "exec/gdbstub.h" #include "gdbstub/helpers.h" #include "internal.h" @@ -84,7 +86,20 @@ static int ppc_gdb_register_len(int n) void ppc_maybe_bswap_register(CPUPPCState *env, uint8_t *mem_buf, int len) { #ifndef CONFIG_USER_ONLY - if (!FIELD_EX64(env->msr, MSR, LE)) { + bool le_page =3D false; + + if (env->mmu_model =3D=3D POWERPC_MMU_BOOKE206) { + CPUTLBEntryFull *full; + void *host; + int mmu_idx =3D ppc_env_mmu_index(env, true); + + probe_access_full_mmu(env, env->nip, 0, MMU_INST_FETCH, mmu_idx, + &host, &full); + + le_page =3D full->tlb_fill_flags & TLB_BSWAP; + } + + if (!le_page && !FIELD_EX64(env->msr, MSR, LE)) { /* do nothing */ } else if (len =3D=3D 4) { bswap32s((uint32_t *)mem_buf); --=20 2.47.3