From nobody Fri Nov 14 18:17:34 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761564241; cv=none; d=zohomail.com; s=zohoarc; b=ejSDYdxGhrHpkVyAN5nG04ejl9uWq3QBvGfag/uwRO1KzPFWy1nOCoC7uzvOurnHxW2UVR+TUwHonjyjlUaQJZ+J7yaeEinlM6YfcZ2L5Amt/y4HqLAI0UqV691Fi+MX1VHS/2Xx0p0DO/EMzCGiIYF/GU9AseDlFPiXwGcGo+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761564241; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=20+Pg1YzalxffzZimZzm5T6sHmYTccFzyLEmWL6cKds=; b=ikGlVLAlmV8vDvkVLXp4pKzUBZF0QLY51wGyYXAlMsoOrN4nkQH28gK6b3VU5+TmJZJgJpQLBDy/afocW4wVTnCpGXjLrUUjh7IUZ5lVg5+ZJPrdvcguxOggz0uAXOMgeYg0xlvAeCtLjFJDH0wM2rEBXOlwqQj6f41grNQ8Abw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761564241205557.8211103426786; Mon, 27 Oct 2025 04:24:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDLJm-00044h-ES; Mon, 27 Oct 2025 07:23:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDLJk-000440-JW for qemu-devel@nongnu.org; Mon, 27 Oct 2025 07:23:16 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vDLJf-00024W-PZ for qemu-devel@nongnu.org; Mon, 27 Oct 2025 07:23:16 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-47117f92e32so40227475e9.1 for ; Mon, 27 Oct 2025 04:23:11 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475dcbe5587sm154973155e9.0.2025.10.27.04.23.07 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 27 Oct 2025 04:23:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761564189; x=1762168989; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=20+Pg1YzalxffzZimZzm5T6sHmYTccFzyLEmWL6cKds=; b=JH9fIK6LY/UzB6UMWuot1UIzBLebFXpUcfNDvcdWjr1OdAKdmxFnPJx/2ab6Tkzn8Z SmqN/tYb3cWadFXH3asbiCOBBXDqxvMFMdgeObYBpk93ojs+K38Yp0FXR+gyZ6SOI9VA 8BWDEfG9ClmL66M+W0SZtPs9MzOxgLwZl+b85xPanHCteS8NN8feLbPynIpZ/ljval4A cgQtNEswmNQzqt9WDHF1oyqUydxXvau3K5XjBiWA7PLzf8W+aYUd7+GMK7ccllKE+rgF UhbMtbtxSno1NtG05q5g04ChVc7u7Yf7le6+y2h2EoNYWLQ3LeLPmTB2N5JAvUOJxHSY VHjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761564189; x=1762168989; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=20+Pg1YzalxffzZimZzm5T6sHmYTccFzyLEmWL6cKds=; b=K3FOKmJ3v912hFqI9vnjGMKHd9gBkMaJxNebOkoLB4IB29Gu1RZK0RNwPqDOxiSKDS k3h/XoxvVtKuj7yaQ6qKtWoGUHh4mv8XXmYuOMDw3sZUWSzwlFxkcB45aYARo3BBWYwF y52IRBuIvd932WLAn2kyfTsbOEoKdFezkHyudOypi4r2+LL95WCzVXuF0HuqhodtM0MI gJlVCZGoYLIj2S3FJeugR1T0mMM884ao05LAulA9bo6to2Ev5kCyTIMv9BJXFkqrloVg N1trLnho3dxIKgOPCuipWgeVGNPLY7B2I9layuuYuVm9T2WmYChoAAHb3Dxhx4rUW62c Vl0w== X-Gm-Message-State: AOJu0YyZ/0qoPQWCu9f4lpa39VmC36jRYIg3bK2b7HeXhzXhSxyUvvS6 a5h6NJYcJY6k9iaaBzMPNg4x5THUFljNTWSvjwUEXmlkb4KBgJp9Djlaziv9/EaH3Kj03v46kD1 dwBXGpvo= X-Gm-Gg: ASbGncuyQBjq+0cNu+mTrdi/x9VPVuom6AWfx8wnxMzRlRUynefswJ/OkBm97Msk4nV QoHMaSxPeUsR6U5iiAR+ACn4orVhH7vPY1U+srkeRc+Bwt9eYMwabJUExVRf5O4hLWug5/Tdc+K oKuQNI073sV0A5iwYsUSm2GAUXFGpfbjs3KP2HzoDds9brmLSD1lRpGZoIiyEB7QeSFfpO6p7lN aWpYXd12VR7XIgejXbhvGuITmy8J5uRmICHNztjn4IruvYmTR6KsahbYdFfpKAp1BOAXRSjQs4O 8wkyhsQ9Tuum0yIgOLfU7ooUkkrrbm+Beddj+KU8vIjTNwyHCd7XBjWhoVcvDztqfdw4bddTqm+ fRTxBe+O7mXu6+RXZV4zmFrh1Q2ulf5w1EuXJ3cXGKw3ZFLhdHSLzxh1NGC5XcbWT8oGEZFd6up 4Daf8tJD8wpCZqqZFbDmJ/eWjIkcHZTkq6hf+ckU4MgHHZQY3XHCi3HzE= X-Google-Smtp-Source: AGHT+IHWmR02eS08AMVPvEe8tzAJju6AfX5hvsFq5n1hxn8GoCBPhvgjvfftJ1LlsoFexS08EWqrKQ== X-Received: by 2002:a05:600c:450d:b0:475:dcbb:76b0 with SMTP id 5b1f17b1804b1-475dcbb783dmr57834555e9.12.1761564188907; Mon, 27 Oct 2025 04:23:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Jamin Lin , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Troy Lee , Mark Cave-Ayland , Glenn Miles , Elena Ufimtseva , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Paul Burton , Joel Stanley , Jagannathan Raman , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno , BALATON Zoltan , Aditya Gupta , "Michael S. Tsirkin" , Aleksandar Rikalo , Bernhard Beschow , qemu-arm@nongnu.org, Andrew Jeffery , Steven Lee , Nicholas Piggin , Marcel Apfelbaum , Andrey Smirnov , qemu-ppc@nongnu.org Subject: [PATCH] hw/pci-host: Set DEVICE_CATEGORY_BRIDGE once in parent class_init() Date: Mon, 27 Oct 2025 12:23:06 +0100 Message-ID: <20251027112306.57634-1-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761564245104154100 No need to set DEVICE_CATEGORY_BRIDGE for each device implementing TYPE_PCI_HOST_BRIDGE: set it once in the parent. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- hw/pci-host/articia.c | 1 - hw/pci-host/aspeed_pcie.c | 1 - hw/pci-host/designware.c | 3 --- hw/pci-host/gpex.c | 2 -- hw/pci-host/grackle.c | 1 - hw/pci-host/gt64120.c | 1 - hw/pci-host/mv64361.c | 1 - hw/pci-host/pnv_phb.c | 1 - hw/pci-host/ppce500.c | 1 - hw/pci-host/q35.c | 1 - hw/pci-host/raven.c | 1 - hw/pci-host/remote.c | 1 - hw/pci-host/sabre.c | 1 - hw/pci-host/uninorth.c | 4 ---- hw/pci-host/xilinx-pcie.c | 2 -- hw/pci/pci_host.c | 1 + 16 files changed, 1 insertion(+), 22 deletions(-) diff --git a/hw/pci-host/articia.c b/hw/pci-host/articia.c index cc65aac2a87..47f223879f0 100644 --- a/hw/pci-host/articia.c +++ b/hw/pci-host/articia.c @@ -200,7 +200,6 @@ static void articia_class_init(ObjectClass *klass, cons= t void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D articia_realize; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); } =20 /* TYPE_ARTICIA_PCI_HOST */ diff --git a/hw/pci-host/aspeed_pcie.c b/hw/pci-host/aspeed_pcie.c index f7593444fc4..2499d3fe680 100644 --- a/hw/pci-host/aspeed_pcie.c +++ b/hw/pci-host/aspeed_pcie.c @@ -312,7 +312,6 @@ static void aspeed_pcie_rc_class_init(ObjectClass *klas= s, const void *data) dc->desc =3D "ASPEED PCIe RC"; dc->realize =3D aspeed_pcie_rc_realize; dc->fw_name =3D "pci"; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); =20 hc->root_bus_path =3D aspeed_pcie_rc_root_bus_path; device_class_set_props(dc, aspeed_pcie_rc_props); diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index f6e49ce9b8d..b0b51ad9517 100644 --- a/hw/pci-host/designware.c +++ b/hw/pci-host/designware.c @@ -593,8 +593,6 @@ static void designware_pcie_root_class_init(ObjectClass= *klass, PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); - k->vendor_id =3D PCI_VENDOR_ID_SYNOPSYS; k->device_id =3D 0xABCD; k->revision =3D 0; @@ -736,7 +734,6 @@ static void designware_pcie_host_class_init(ObjectClass= *klass, =20 hc->root_bus_path =3D designware_pcie_host_root_bus_path; dc->realize =3D designware_pcie_host_realize; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; dc->vmsd =3D &vmstate_designware_pcie_host; } diff --git a/hw/pci-host/gpex.c b/hw/pci-host/gpex.c index b806a2286f7..5f809028be2 100644 --- a/hw/pci-host/gpex.c +++ b/hw/pci-host/gpex.c @@ -200,7 +200,6 @@ static void gpex_host_class_init(ObjectClass *klass, co= nst void *data) hc->root_bus_path =3D gpex_host_root_bus_path; dc->realize =3D gpex_host_realize; dc->unrealize =3D gpex_host_unrealize; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; device_class_set_props(dc, gpex_host_properties); } @@ -242,7 +241,6 @@ static void gpex_root_class_init(ObjectClass *klass, co= nst void *data) PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->desc =3D "QEMU generic PCIe host bridge"; dc->vmsd =3D &vmstate_gpex_root; k->vendor_id =3D PCI_VENDOR_ID_REDHAT; diff --git a/hw/pci-host/grackle.c b/hw/pci-host/grackle.c index f9da5a908c1..fa872c17e3b 100644 --- a/hw/pci-host/grackle.c +++ b/hw/pci-host/grackle.c @@ -140,7 +140,6 @@ static void grackle_class_init(ObjectClass *klass, cons= t void *data) =20 dc->realize =3D grackle_realize; device_class_set_props(dc, grackle_properties); - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; sbc->explicit_ofw_unit_address =3D grackle_ofw_unit_address; } diff --git a/hw/pci-host/gt64120.c b/hw/pci-host/gt64120.c index b1d96f62fe9..bffa1165580 100644 --- a/hw/pci-host/gt64120.c +++ b/hw/pci-host/gt64120.c @@ -1298,7 +1298,6 @@ static void gt64120_class_init(ObjectClass *klass, co= nst void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); device_class_set_props(dc, gt64120_properties); dc->realize =3D gt64120_realize; device_class_set_legacy_reset(dc, gt64120_reset); diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c index e05b6770102..e5e6614b139 100644 --- a/hw/pci-host/mv64361.c +++ b/hw/pci-host/mv64361.c @@ -108,7 +108,6 @@ static void mv64361_pcihost_class_init(ObjectClass *kla= ss, const void *data) =20 dc->realize =3D mv64361_pcihost_realize; device_class_set_props(dc, mv64361_pcihost_props); - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); } =20 static const TypeInfo mv64361_pcihost_info =3D { diff --git a/hw/pci-host/pnv_phb.c b/hw/pci-host/pnv_phb.c index 4b0ced79b08..e07cf8a0d0f 100644 --- a/hw/pci-host/pnv_phb.c +++ b/hw/pci-host/pnv_phb.c @@ -202,7 +202,6 @@ static void pnv_phb_class_init(ObjectClass *klass, cons= t void *data) hc->root_bus_path =3D pnv_phb_root_bus_path; dc->realize =3D pnv_phb_realize; device_class_set_props(dc, pnv_phb_properties); - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->user_creatable =3D true; } =20 diff --git a/hw/pci-host/ppce500.c b/hw/pci-host/ppce500.c index 975d191ccb8..edadc35384c 100644 --- a/hw/pci-host/ppce500.c +++ b/hw/pci-host/ppce500.c @@ -516,7 +516,6 @@ static void e500_pcihost_class_init(ObjectClass *klass,= const void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D e500_pcihost_realize; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); device_class_set_props(dc, pcihost_properties); dc->vmsd =3D &vmstate_ppce500_pci; } diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 1951ae440cc..c134679fa0c 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -194,7 +194,6 @@ static void q35_host_class_init(ObjectClass *klass, con= st void *data) device_class_set_props(dc, q35_host_props); /* Reason: needs to be wired up by pc_q35_init */ dc->user_creatable =3D false; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; } =20 diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c index eacffc86d84..661a4223d69 100644 --- a/hw/pci-host/raven.c +++ b/hw/pci-host/raven.c @@ -365,7 +365,6 @@ static void raven_pcihost_class_init(ObjectClass *klass= , const void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->realize =3D raven_pcihost_realizefn; dc->fw_name =3D "pci"; } diff --git a/hw/pci-host/remote.c b/hw/pci-host/remote.c index e6d2af4502a..959beb5c301 100644 --- a/hw/pci-host/remote.c +++ b/hw/pci-host/remote.c @@ -55,7 +55,6 @@ static void remote_pcihost_class_init(ObjectClass *klass,= const void *data) dc->realize =3D remote_pcihost_realize; =20 dc->user_creatable =3D false; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; } =20 diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c index 538624c5079..f95e5db583a 100644 --- a/hw/pci-host/sabre.c +++ b/hw/pci-host/sabre.c @@ -505,7 +505,6 @@ static void sabre_class_init(ObjectClass *klass, const = void *data) dc->realize =3D sabre_realize; device_class_set_legacy_reset(dc, sabre_reset); device_class_set_props(dc, sabre_properties); - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; sbc->explicit_ofw_unit_address =3D sabre_ofw_unit_address; } diff --git a/hw/pci-host/uninorth.c b/hw/pci-host/uninorth.c index 194037d6e75..d337a2fd62c 100644 --- a/hw/pci-host/uninorth.c +++ b/hw/pci-host/uninorth.c @@ -435,7 +435,6 @@ static void pci_unin_main_class_init(ObjectClass *klass= , const void *data) =20 dc->realize =3D pci_unin_main_realize; device_class_set_props(dc, pci_unin_main_pci_host_props); - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; sbc->explicit_ofw_unit_address =3D pci_unin_main_ofw_unit_address; } @@ -453,7 +452,6 @@ static void pci_u3_agp_class_init(ObjectClass *klass, c= onst void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D pci_u3_agp_realize; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); } =20 static const TypeInfo pci_u3_agp_info =3D { @@ -469,7 +467,6 @@ static void pci_unin_agp_class_init(ObjectClass *klass,= const void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D pci_unin_agp_realize; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); } =20 static const TypeInfo pci_unin_agp_info =3D { @@ -485,7 +482,6 @@ static void pci_unin_internal_class_init(ObjectClass *k= lass, const void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->realize =3D pci_unin_internal_realize; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); } =20 static const TypeInfo pci_unin_internal_info =3D { diff --git a/hw/pci-host/xilinx-pcie.c b/hw/pci-host/xilinx-pcie.c index c71492de9e7..1540533223c 100644 --- a/hw/pci-host/xilinx-pcie.c +++ b/hw/pci-host/xilinx-pcie.c @@ -172,7 +172,6 @@ static void xilinx_pcie_host_class_init(ObjectClass *kl= ass, const void *data) =20 hc->root_bus_path =3D xilinx_pcie_host_root_bus_path; dc->realize =3D xilinx_pcie_host_realize; - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->fw_name =3D "pci"; device_class_set_props(dc, xilinx_pcie_host_props); } @@ -291,7 +290,6 @@ static void xilinx_pcie_root_class_init(ObjectClass *kl= ass, const void *data) PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); DeviceClass *dc =3D DEVICE_CLASS(klass); =20 - set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); dc->desc =3D "Xilinx AXI-PCIe Host Bridge"; k->vendor_id =3D PCI_VENDOR_ID_XILINX; k->device_id =3D 0x7021; diff --git a/hw/pci/pci_host.c b/hw/pci/pci_host.c index 7179d99178b..b5c624e12e8 100644 --- a/hw/pci/pci_host.c +++ b/hw/pci/pci_host.c @@ -245,6 +245,7 @@ static void pci_host_class_init(ObjectClass *klass, con= st void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); device_class_set_props(dc, pci_host_properties_common); dc->vmsd =3D &vmstate_pcihost; + set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); } =20 static const TypeInfo pci_host_type_info =3D { --=20 2.51.0