From nobody Mon Oct 27 14:14:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1761424082; cv=none; d=zohomail.com; s=zohoarc; b=n3PqQWzynx0uHG4xFpYXMeOj+Vlh+p8jle4aRMEakqZNuzVz7T+nKmFOrCVmK/Mn6Wr+aGxe/MXZHKFV5FEkkvvrzu55D5c+374HqSvPMJe8UujQV16VgUpMdBrlnmDKo2aEgMP74wuMweJZGENvoOmQ1VKT5hlXXTMn7E1WmT4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761424082; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BNvSwyaRHN7VmEP0n/ZLbmkke10ix+maxXmnT9gEJCs=; b=biveHRe1R8kvnrya6bqF6x8fRhupyoXj3+dStbcqs2ftgYxMkYBUqPKgEoGyJXalWAiAo3ChNnj/A3hu16/wgIzODwFSkgKCR/dLFnPZFvp3isAjx0ykcdgPDXzV8UJxH3DYvePKlk0D+Dip0l+5hDRLBCK0QaTavVjTHYRyp6s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761424081880658.7224745093669; Sat, 25 Oct 2025 13:28:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vCkqv-0004uL-AQ; Sat, 25 Oct 2025 16:27:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCkqt-0004t9-Cu for qemu-devel@nongnu.org; Sat, 25 Oct 2025 16:27:03 -0400 Received: from forwardcorp1b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:df01]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCkqp-0004XG-Py for qemu-devel@nongnu.org; Sat, 25 Oct 2025 16:27:03 -0400 Received: from mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net [IPv6:2a02:6b8:c10:49f:0:640:b99a:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 47E3B808B7; Sat, 25 Oct 2025 23:26:55 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:538::1:38]) by mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id pQh1fa1bDqM0-1nBaao80; Sat, 25 Oct 2025 23:26:54 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1761424014; bh=BNvSwyaRHN7VmEP0n/ZLbmkke10ix+maxXmnT9gEJCs=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=CffV2sN78XN/2W2cgw5m1zVPGGmCiSr3VBcHgDqBGosWTVgd0CJPki2PLYU7lCCES Fyo3CDJZEusDU9X6AETcnGOMvqbOoAI05uuGpmFrvIjnDs0Dl6Tm1lbzBdXPUHpYPa M+FHNTcFOR+Y/wTxlKHytBF9y0TOOwBHc0Od/B2U= Authentication-Results: mail-nwsmtp-smtp-corp-canary-81.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: peterx@redhat.com Cc: stefanb@linux.vnet.ibm.com, farosas@suse.de, qemu-devel@nongnu.org, armbru@redhat.com, berrange@redhat.com, vsementsov@yandex-team.ru Subject: [PATCH v3 2/4] tmp_emulator: fix unset errp on error path Date: Sat, 25 Oct 2025 23:26:47 +0300 Message-ID: <20251025202649.1122420-3-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251025202649.1122420-1-vsementsov@yandex-team.ru> References: <20251025202649.1122420-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a02:6b8:c02:900:1:45:d181:df01; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1761424085084154100 Content-Type: text/plain; charset="utf-8" Note, that called tpm_emulator_startup_tpm_resume() does error_report() failure paths, which could be turned into error_setg() to passthough an error. But, not on all error paths. Not saying about tpm_emulator_startup_tpm_resume() return -1 on failure and we mix it with -errno from tpm_emulator_set_state_blobs(). So, it all needs deeper refactoring, which is out of scope of this small fix. Fixes: 42e556fa3f7ac "backends/tpm: Propagate vTPM error on migration failure" Signed-off-by: Vladimir Sementsov-Ogievskiy --- backends/tpm/tpm_emulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c index dacfca5ab7..aa69eb606f 100644 --- a/backends/tpm/tpm_emulator.c +++ b/backends/tpm/tpm_emulator.c @@ -961,6 +961,7 @@ static int tpm_emulator_post_load(void *opaque, int ver= sion_id, Error **errp) } =20 if (tpm_emulator_startup_tpm_resume(tb, 0, true) < 0) { + error_setg(errp, "Failed to resume tpm"); return -EIO; } =20 --=20 2.48.1