From nobody Mon Oct 27 11:20:40 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1761339416; cv=none; d=zohomail.com; s=zohoarc; b=LPyA6CPRDpI+9uJha9Lr8o4jDt+ZVB9Gc2obxU5kM0mRHVH3+uZa+sJ5JXCKgs0zjGPXfA6VI6t4W226QJR1UjugTvHRIBca820aOmoctwLG4w20Ld8Y5pTWzEbAinM/xodwduu0hGDLmnYk4BlfHFjBo/J16Ac3s0af/VIHkYM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761339416; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=yl9QdN2x2OfkILOmRRrJUOvqG+TmkZlFlVGZNq759n4=; b=eks8rjL2mdxboebYX5C9nGxsoPjOu7DZ3CGRf377T1joPLdVDnhJ3qmDGvrquVj802mC38eWRnsnyrq64Ci+GqklC7UgbPzW7jlwZXU43H+zeWXckaheDuQ+vhdf3FiAKt5A3S/x7N5nX25PdEF1zJ/Ltsj4C/xyKFhZ0nc4/Ac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761339416020991.9216929403045; Fri, 24 Oct 2025 13:56:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vCOpY-0005N4-1z; Fri, 24 Oct 2025 16:56:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCOpV-0005LU-91 for qemu-devel@nongnu.org; Fri, 24 Oct 2025 16:56:10 -0400 Received: from [115.124.30.130] (helo=out30-130.freemail.mail.aliyun.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCOpL-00053E-4o for qemu-devel@nongnu.org; Fri, 24 Oct 2025 16:56:08 -0400 Received: from localhost(mailfrom:guobin@linux.alibaba.com fp:SMTPD_---0WqvCQcm_1761339332 cluster:ay36) by smtp.aliyun-inc.com; Sat, 25 Oct 2025 04:55:37 +0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1761339337; h=From:To:Subject:Date:Message-Id:MIME-Version; bh=yl9QdN2x2OfkILOmRRrJUOvqG+TmkZlFlVGZNq759n4=; b=f/gcm34kt8ChW8QTqg9khUkP+Q8JqCmLEKkHzOjHNJmVDkpEGpjgxaYUT0KEnhx21bhTV3lh+q7wHnH3+HnVcpl2ecBp2eIWZAV0fzT9WjJ+2/KetVu/8U2WAO7MRn/1K2wK3Ije3sfvHaQh2z3qX7WiyAikPVYc3y3VdYeMwZk= From: Bin Guo To: qemu-devel@nongnu.org Cc: peterx@redhat.com, farosas@suse.de, armbru@redhat.com, berrange@redhat.com Subject: [PATCH v2] migration: Don't free the reason after calling migrate_add_blocker Date: Sat, 25 Oct 2025 04:55:32 +0800 Message-Id: <20251024205532.19883-1-guobin@linux.alibaba.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.124.30.130 (deferred) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=115.124.30.130; envelope-from=guobin@linux.alibaba.com; helo=out30-130.freemail.mail.aliyun.com X-Spam_score_int: -166 X-Spam_score: -16.7 X-Spam_bar: ---------------- X-Spam_report: (-16.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, RDNS_NONE=0.793, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01, UNPARSEABLE_RELAY=0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linux.alibaba.com) X-ZM-MESSAGEID: 1761339417605158500 Content-Type: text/plain; charset="utf-8" Function migrate_add_blocker will free the reason and set it to NULL if failure is returned. Signed-off-by: Bin Guo Reviewed-by: Markus Armbruster --- hw/intc/arm_gicv3_kvm.c | 1 - target/i386/sev.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index 66b0dddfd4..6f311e37ef 100644 --- a/hw/intc/arm_gicv3_kvm.c +++ b/hw/intc/arm_gicv3_kvm.c @@ -841,7 +841,6 @@ static void kvm_arm_gicv3_realize(DeviceState *dev, Err= or **errp) error_setg(&kvm_nv_migration_blocker, "Live migration disabled because KVM nested virt is ena= bled"); if (migrate_add_blocker(&kvm_nv_migration_blocker, errp)) { - error_free(kvm_nv_migration_blocker); return; } =20 diff --git a/target/i386/sev.c b/target/i386/sev.c index 1057b8ab2c..fd2dada013 100644 --- a/target/i386/sev.c +++ b/target/i386/sev.c @@ -1661,7 +1661,6 @@ sev_snp_launch_finish(SevCommonState *sev_common) ret =3D migrate_add_blocker(&sev_mig_blocker, &local_err); if (local_err) { error_report_err(local_err); - error_free(sev_mig_blocker); exit(1); } } --