From nobody Mon Oct 27 14:05:19 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1761283750; cv=none; d=zohomail.com; s=zohoarc; b=i4bGD7qRdg4poCQTms76Y+2XZlL6/wybml0+oWRPD86GX6pBzEX4lSRHxuaOKLyht5fgQ5fM/lzto8ppVAkgzVLOGlYMKD4gghSTy/dyhL5kS1Uk81Q/HzGMwwF9UeY/XhMANh7yynzsZzY79+FSpN8EKs+A0FKpRR88efYTXZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761283750; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Gq/WHDlUh8spgPYBpEywHSfRNf6ahpKsKuWx0r0w/P0=; b=nEkCcujYaOE1dH1s8/fNEytJPn1OZsmsbMvIL5S/MNkgGbRzcub/1qkraGnrJpOIcCX8YQPBsa8EYgKVTL4BEv1eK+O3RqOBRVW5rx8LJ1B8Ayg2sLTCUbxwl8Cj/UyCu342G85R6SmleounDqbrHDzJQQy6yAP0CHE8hAEgv+w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761283750282419.51756393740266; Thu, 23 Oct 2025 22:29:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vCALA-00037a-Jd; Fri, 24 Oct 2025 01:27:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCAL3-00035i-Dk; Fri, 24 Oct 2025 01:27:46 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vCAL1-0003Ne-17; Fri, 24 Oct 2025 01:27:44 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59O17U3B032408; Fri, 24 Oct 2025 05:27:38 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31cm9da-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Oct 2025 05:27:38 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 59O5Rcf1011007; Fri, 24 Oct 2025 05:27:38 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31cm9d5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Oct 2025 05:27:38 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59O1JwQX011075; Fri, 24 Oct 2025 05:27:37 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 49vqx1h95n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Oct 2025 05:27:37 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59O5RXoZ8847632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Oct 2025 05:27:33 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 336B32004B; Fri, 24 Oct 2025 05:27:33 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8E7AE20049; Fri, 24 Oct 2025 05:27:30 +0000 (GMT) Received: from vishalc-ibm (unknown [9.39.24.189]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 24 Oct 2025 05:27:30 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=Gq/WHDlUh8spgPYBp EywHSfRNf6ahpKsKuWx0r0w/P0=; b=M7SmGB5zsKsE1KK8JAk/rj9nf64fyXoQ/ vWQmZCWOAFvO7L/MPDqH8g5c0Pb20UmLSyuuUByCe7VM7TI5m9XDNPUxrcaCvUQ3 qVK2fFyUIHb2zdABpI6BBkGHTHLXKyG3xZil49QujhQyodTEUJfK2u155YGCkSVX qnoNDmwliwkeCwMvwbfRLD02/cQD46IGMKs+MoYVAD6c15sxLjBQdoOS6xIb3+0Z TCQFHvxsmVCltIMnUrwWNcry6viZMrJ1onv20iquzWtkKgTIHT8JRUmwdfa3dlrw Jj19klQFhdtjnwN0rNFM9L5hTu2BqYhShNY5g7naPBG8FwDJMR3kQ== From: Vishal Chourasia To: adityag@linux.ibm.com, harshpb@linux.ibm.com, milesg@linux.ibm.com, npiggin@gmail.com, peter.maydell@linaro.org, alistair23@gmail.com, balaton@eik.bme.hu, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, berrange@redhat.com Cc: Vishal Chourasia Subject: [Patch v8 3/5] core/loader: add check for zero size in load_image_targphys_as Date: Fri, 24 Oct 2025 10:57:05 +0530 Message-ID: <20251024052707.1852358-4-vishalc@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251024052707.1852358-1-vishalc@linux.ibm.com> References: <20251024052707.1852358-1-vishalc@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 759xWnI1cK4Iol9IwF2x5aG_KlSGvMa5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfXxjv0I/IQ0xBZ stDRoHZn3Kc9JvJpSwOy+qgqSWVBhKIpsUHUmx0NQSrmoYCfZv7NXodZXghgLvABrboWOwCXU+J NoCavwfqQAAJppnl+ZS9OsV7jEkAmCP6ANTOPQclzLbU7RTrgmHlJB6IthJTLcQSC5n9iJA1o84 Bi+3M6yO99/bhuV4bbgwUF6BCiYUiDvdkwniviHOaV2d48fC1l5lnQ8fQmchErKnLvP0Vs7YOhP DOZzTb+02qE338H2an6AqshqnH8ODNcolhBkhNGbe0zcHEyEqrCbO1mSyQ/Iz80JKPwPIBLDfmH +Ce9L1kw+a6jnjgepaHyo5bTfZqiurm3VEtdTsspdAClvdUjXtyWa7qrgMSda25cHY/WjbuE34Y Afp/gz9d0KhPQw7KIr735SItoyxOTw== X-Proofpoint-GUID: JdFZ9CulUjFxZv_Rkslr7hWrOhKnAp0t X-Authority-Analysis: v=2.4 cv=SKNPlevH c=1 sm=1 tr=0 ts=68fb0e4a cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=EMG23Z06JWfOmfJaRK0A:9 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-23_03,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.158.5; envelope-from=vishalc@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1761283757633158500 Content-Type: text/plain; charset="utf-8" Currently load_image_targphys_as() returns -1 on file open failure or when max size is exceeded. Add an explicit check for zero-sized files to catch this error early, since some callers check for size <=3D 0. Signed-off-by: Vishal Chourasia --- hw/core/loader.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index 48dd4e7b33..6717324527 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -141,6 +141,11 @@ ssize_t load_image_targphys_as(const char *filename, return -1; } =20 + if (size =3D=3D 0) { + error_setg(errp, "empty file: %s", filename); + return -1; + } + if (size > max_sz) { error_setg(errp, "%s exceeds maximum image size (%" PRIu64 " MiB)", filename, max_sz / MiB); --=20 2.51.0