From nobody Fri Nov 14 18:26:44 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=163.com ARC-Seal: i=1; a=rsa-sha256; t=1761202977; cv=none; d=zohomail.com; s=zohoarc; b=UZxnI78psld9K6uVnUwjCdy2zgqYtGG3Gn8M5HFSo7rOx3kXAOqndDvXGgAwDWG2/6OnFtKN/DifGFaY8A9Z8h02IG4+LLWiyErYFw26/gShxHDvUmkd4FEx8l6jFe3P1oxL87uGP7Hn+P3MDK+Jqqsy+WBt5hxRZ26+5aRh6MI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761202977; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=x+KqWjhT+O7WNHy8kUjC6JCtlPmqZdIv2x4KUrDDi5Q=; b=RJE21lVGwsvOJtwygqvqbHJ5LBPrbRbJ89QKJ+6rLVvQnUIhjXaBXHdx76GzjPNP2OM7H+q+pw2R2AxeeS678wd2FFxnDMbJK0OOeWrFHzXeD9Jo0N731z3yBf9gdh8H2CNx/C9dx+37C7qd+2v91qs7yGCZZGua6z0XT1qO6os= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761202977028964.0039513242166; Thu, 23 Oct 2025 00:02:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBpLF-00044c-Ov; Thu, 23 Oct 2025 03:02:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBorD-0001n7-2R for qemu-devel@nongnu.org; Thu, 23 Oct 2025 02:31:31 -0400 Received: from m16.mail.163.com ([117.135.210.2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBor7-0000vr-3I for qemu-devel@nongnu.org; Thu, 23 Oct 2025 02:31:30 -0400 Received: from localhost.localdomain (unknown []) by gzga-smtp-mtada-g0-4 (Coremail) with SMTP id _____wCXntWsy_loyhRSBw--.27046S2; Thu, 23 Oct 2025 14:31:09 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:To:Subject:Date:Message-ID:MIME-Version; bh=x+ KqWjhT+O7WNHy8kUjC6JCtlPmqZdIv2x4KUrDDi5Q=; b=AjR5YTL5iFc9nkQLLm qG8eCsNYpT0adnePTm3tD+rKI4U6puNq4bmFegCfG9X9I59NpV0CKvTky6X/H0Ri nUHL0X/lB56MebCXci6Y25cVn8Xm5lbDcL6ezMpz11Je70PmjJGD8Q3/xb32lHf6 gS3B7cjVC0u1T3mwSrr2Ft8Rs= From: zhaoguohan_salmon@163.com To: kraxel@redhat.com Cc: qemu-devel@nongnu.org (open list:All patches CC here), GuoHan Zhao Subject: [PATCH] hw/uefi/ovmf-log: Fix memory leak in hmp_info_firmware_log Date: Thu, 23 Oct 2025 14:31:06 +0800 Message-ID: <20251023063106.9834-1-zhaoguohan_salmon@163.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCXntWsy_loyhRSBw--.27046S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrtw4DWFy8WF1DZryUXr48Xrb_yoWfArbEk3 yUGFs7ur1rJrWY93Z8GFW0vFWYgw48Way8Gry2yw47Z34UtF12q3s7G34YqFy7W34UXrZr Jw1jqrZ8Aan5GjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0jYLDUUUUU== X-Originating-IP: [116.128.244.169] X-CM-SenderInfo: 52kd0wpxrkt0xbvdzzlrq6il2tof0z/1tbiFA-vEGj5wuS8iQAAsm Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=117.135.210.2; envelope-from=zhaoguohan_salmon@163.com; helo=m16.mail.163.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Thu, 23 Oct 2025 03:02:13 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @163.com) X-ZM-MESSAGEID: 1761202979783154100 Content-Type: text/plain; charset="utf-8" From: GuoHan Zhao The FirmwareLog object returned by qmp_query_firmware_log() was not being freed, causing a memory leak. Use g_autoptr to ensure the object is automatically freed when it goes out of scope. Fixes: c8aa8120313f ("hw/uefi: add 'info firmware-log' hmp monitor command.= ") Signed-off-by: GuoHan Zhao Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/uefi/ovmf-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/uefi/ovmf-log.c b/hw/uefi/ovmf-log.c index 98ebb0209491..850ef21f8859 100644 --- a/hw/uefi/ovmf-log.c +++ b/hw/uefi/ovmf-log.c @@ -261,7 +261,7 @@ void hmp_info_firmware_log(Monitor *mon, const QDict *q= dict) g_autofree gchar *log_esc =3D NULL; g_autofree guchar *log_out =3D NULL; Error *err =3D NULL; - FirmwareLog *log; + g_autoptr(FirmwareLog) log =3D NULL; gsize log_len; int64_t maxsize; =20 --=20 2.43.0