From nobody Fri Nov 14 21:03:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1761192960; cv=none; d=zohomail.com; s=zohoarc; b=myjV/vc7oP95D/9+MUrLbv9jPUWxvIxqAbpKK0jc0XQuM6tqNIxV05oJsuMCN62ZbPhjP4x9NEf6ODPTPG1tJhBYGEWWK0apoIF0c02xXi112u/DZjEIfJl8VYEO9rAKhS5+oLG3ycmLItaNSXU+jr4YfFZ93c1e9WSh82AOmJ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761192960; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Zk8Kix8Kg+2CjYkxMY72LuG/VHJwD8T3oyL5Prb33rA=; b=dDeO9Gwrb3vKz++n53YOqKKqtl7QmUSbkEDp+TV9N+4eEVc8FVLzdFODSLHl4PylO3QH23Su6VLFY1xvd2d0IoGGeGmGFXpRh5Kh/MKlw26jCiUpaZsVEYOeCsaI6ZWE0Y5yCxAMO6EnD7CHFY8eV8Ms8vQZUVinM4Gq6qkvudI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761192960635827.4457606719895; Wed, 22 Oct 2025 21:16:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBmjr-0000u9-D4; Thu, 23 Oct 2025 00:15:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBmjp-0000pk-Ex for qemu-devel@nongnu.org; Thu, 23 Oct 2025 00:15:45 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBmjn-0007Mv-PN for qemu-devel@nongnu.org; Thu, 23 Oct 2025 00:15:45 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-7a2754a7f6aso434303b3a.1 for ; Wed, 22 Oct 2025 21:15:42 -0700 (PDT) Received: from toolbx.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a274abe5f0sm961640b3a.34.2025.10.22.21.15.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 21:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1761192941; x=1761797741; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Zk8Kix8Kg+2CjYkxMY72LuG/VHJwD8T3oyL5Prb33rA=; b=H+m5dJhODNTYn5sX7SPcSC2TNqYQCuP+52Y80+IcRm/caQ8YOrw01AA4TRmisniTS0 JG9Td1Q4SWlAKe5I8PR6Ckh9GxAYNDstGOFiM1k0dXI1Mo4tYciTnwvyGA/Ii3YBNvBo IuypahtFN6c5p+x4KPtAYEMCY4iEt5xyfUtTbWv+tH/7XbMmLhbeqT7Rxpxv0C6evA5l VDcrp2iQ+Yk1RSZ5kzFj01Q56lY5cNSYkVfqm15bJS4fD7Awmm/GDYOC6M+eaDl3+STq foWpvqcbJRVX1+McI5d3wmYKtEArG1blHAjM6M6cF3/pXXYQsPfbmd37s/5NX1Pk1IBQ aVdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761192941; x=1761797741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zk8Kix8Kg+2CjYkxMY72LuG/VHJwD8T3oyL5Prb33rA=; b=Ap3u1p/QCQQh+hBB8vP7TvS4CpqV6MBz5FjdnSDjXitCmIK450W8mVCR2ASHhxnBXh sVRPde+UV0sP7Psrahmvqla9T5HYmGuPOg9J88EaEH1h3x3+gcwFuq0I+hyHHMt9szO3 7b1a+Oz1JOAEJUcCAfi+kWsx0Vj6yHmxzfyfFxYeQYYMtAMxzQWyufQo89nbrDDMnCoM bAZ/K8BFvfIGeqZD6WhHXyQRPc91UyVOtzc/c2xqjTmARPzrgGpPouGNdUXinaSlRwIn rejD4t4TZ8+mDRVEkTv7ZD7C475HRVd888jpFT1GXU3I6qwHl5QGy5Ak9uLP4tW4JuZZ QXYA== X-Gm-Message-State: AOJu0Yz3rDzWS/bpITBOoN/vJ3tmjjeFIOGTwm78Jb1sv02JA7SEOuQ+ yzsbp0asHvGJErG+5zeU/7pV7FihbZUA1QapV5yoN9jiP19YQN3LIrcfaaTwzg== X-Gm-Gg: ASbGncvykcwLuhZxmMn6fDCutPvK5io2tDQPVZVo1CTKpi5m5DlbUHCuToxOrSu99i+ 5uctC7zRGNEgkzGc/V8GfPZXLAf2PqjcK+ovCNVpDp9wn4A64bj+QySWv1+/BB2nSUE2qnkrtCU L+YtKuvGEreXcjg5Bj8eySpGK+HHtNZG8bmHBv52RKuT6nyeGpXsTB68bEPGuknpZGsrFJlhJzf RCn6bDe6ySoclXoAW4wqXpYF3ryPKT1l81993+Q775Be8xosGLj5lTahiy0s8T1cw766//06WbD ljZbG6IDODEyGoo94m0Dnd/633pj0t/0kvMbdDT7nFRm1bgvNREoVVo/a5GbIR71ozcnr4s6ULR pdiaCP9s9O7rchWOWtVGZ5E42ZmvscY11qhPQ5QChV8t1tsJyjO46gUcrLWSONBvIhYXW2OAzSL YWQlk8gDuOwR2i3ULG8oXtXjR8lv+fWqHuuxtcHHtnxCrjcoLo05NyU/VlLnnYJV7y1f8wCLz1s 0Vm1kF/WlWX8mKwKaVY X-Google-Smtp-Source: AGHT+IHnHX2rxYQa45csMgbb5w7SXXTQQkIGjXVcQUyctFpZF4ZVN8yRnxhNm4BwI/6MtlQ89OKLIw== X-Received: by 2002:a05:6a20:5493:b0:334:84f7:5646 with SMTP id adf61e73a8af0-334a8650262mr33732964637.58.1761192940905; Wed, 22 Oct 2025 21:15:40 -0700 (PDT) From: alistair23@gmail.com X-Google-Original-From: alistair.francis@wdc.com To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, Guenter Roeck , Alistair Francis Subject: [PULL 16/37] hw/net/cadence_gem: Add pcs-enabled property Date: Thu, 23 Oct 2025 14:14:14 +1000 Message-ID: <20251023041435.1775208-17-alistair.francis@wdc.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251023041435.1775208-1-alistair.francis@wdc.com> References: <20251023041435.1775208-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=alistair23@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1761192962431154100 Content-Type: text/plain; charset="utf-8" From: Guenter Roeck The Linux kernel checks the PCS disabled bit in the R_DESCONF register to determine if SGMII is supported. If the bit is set, SGMII support is disabled. Since the Microchip Icicle devicetree file configures SGMII interface mode, enabling the Ethernet interfaces fails when booting the Linux kernel. Add pcs-enabled property to to let the driver know if PCS should be enabled. Set the flag to false by default (indicating that PCS is disabled) to match the exiting code. Signed-off-by: Guenter Roeck Acked-by: Alistair Francis Message-ID: <20251004200049.871646-4-linux@roeck-us.net> Signed-off-by: Alistair Francis --- include/hw/net/cadence_gem.h | 1 + hw/net/cadence_gem.c | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/include/hw/net/cadence_gem.h b/include/hw/net/cadence_gem.h index 21e7319f53..e63941f18f 100644 --- a/include/hw/net/cadence_gem.h +++ b/include/hw/net/cadence_gem.h @@ -62,6 +62,7 @@ struct CadenceGEMState { uint8_t num_type2_screeners; uint32_t revision; uint16_t jumbo_max_len; + bool pcs_enabled; =20 /* GEM registers backing store */ uint32_t regs[CADENCE_GEM_MAXREG]; diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c index 520324adfd..44896f1801 100644 --- a/hw/net/cadence_gem.c +++ b/hw/net/cadence_gem.c @@ -1477,7 +1477,10 @@ static void gem_reset(DeviceState *d) s->regs[R_TXPARTIALSF] =3D 0x000003ff; s->regs[R_RXPARTIALSF] =3D 0x000003ff; s->regs[R_MODID] =3D s->revision; - s->regs[R_DESCONF] =3D 0x02D00111; + s->regs[R_DESCONF] =3D 0x02D00110; + if (!s->pcs_enabled) { + s->regs[R_DESCONF] |=3D 0x00000001; + } s->regs[R_DESCONF2] =3D 0x2ab10000 | s->jumbo_max_len; s->regs[R_DESCONF5] =3D 0x002f2045; s->regs[R_DESCONF6] =3D R_DESCONF6_DMA_ADDR_64B_MASK; @@ -1821,6 +1824,8 @@ static const Property gem_properties[] =3D { num_type2_screeners, 4), DEFINE_PROP_UINT16("jumbo-max-len", CadenceGEMState, jumbo_max_len, 10240), + DEFINE_PROP_BOOL("pcs-enabled", CadenceGEMState, + pcs_enabled, false), DEFINE_PROP_BOOL("phy-connected", CadenceGEMState, phy_connected, true= ), DEFINE_PROP_LINK("phy-consumer", CadenceGEMState, phy_consumer, TYPE_CADENCE_GEM, CadenceGEMState *), --=20 2.51.0