From nobody Fri Nov 14 18:19:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1761161321; cv=none; d=zohomail.com; s=zohoarc; b=BE0Zhx0KgQK5Q5jtYKd3sxMEGQUpzYdbIoWgooDrf8kDXThOrmd/Z28orE4VSaZLkyJ/dgXcpKBmnBkujuh/9sGcdB8xemB4eukW+6AAgyQgGBJiNqlxJViT2Zmr9iAkcD3j9Tzb7EzJ4tHYGvgeWi9s6m1ZnbH0dPe86jLcU5w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761161321; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6MG5H2rdn6AOGLT3/QofZzQfvud8goyYPy2TUqKhe3w=; b=cza9/4I1+Ed6fNFHPRR/otzgANtI3SgDWYxMRjhNS884h1gbLodEaIESFno1XN8dTFam+9R1U9mwUFN5Ju1vNM6N1ZkO3m0mEzqaUr/YTHo9j5f4tZCvFzedMmlZKdF5lFPnzYVcZhHkcElm5JIoWggF/szo6BJpMwfskIdmfO0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176116132148930.25669630750201; Wed, 22 Oct 2025 12:28:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBeVa-0007SD-Sz; Wed, 22 Oct 2025 15:28:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBeVR-0007GU-JO; Wed, 22 Oct 2025 15:28:24 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBeVP-0001eC-Jb; Wed, 22 Oct 2025 15:28:21 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59MC9Emt005743; Wed, 22 Oct 2025 19:28:15 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31s6nwp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 19:28:15 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 59MJSEgD011580; Wed, 22 Oct 2025 19:28:14 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31s6nwg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 19:28:14 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59MIePXb011066; Wed, 22 Oct 2025 19:28:13 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 49vqx19v6v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 22 Oct 2025 19:28:13 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59MJSASq53215720 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Oct 2025 19:28:10 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EC47A2004B; Wed, 22 Oct 2025 19:28:09 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3490420040; Wed, 22 Oct 2025 19:28:07 +0000 (GMT) Received: from vishalc-ibm.ibm.com (unknown [9.39.25.30]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 22 Oct 2025 19:28:06 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=6MG5H2 rdn6AOGLT3/QofZzQfvud8goyYPy2TUqKhe3w=; b=hqAdgJ0un2joFrhuE+yGl2 m1eVhHxtAlK0e2Ah7nao7NPKgLSXDG69NSnFHeQJ/7WC+BkCtH3mE7Z8EYHetkIe fqmacNgKrrrrGobeCaEETGAFfgY25NVNP7cSEgDxraflF6vazQAMTj31i3hFO7tF vRYhyQW2nHAfk6p+tzv6GSh7DGDePRFuxzUArvq93Lu16bBoN6WIlIxIscABb6MU VV0ho99Q8H2C6TT0AXPLFCYwKx4zXMGLGpkQ7CIv8QxnRGENt5FcIuRrEnP+pmct 65xcydhC1CnBZuiWpUVSI8SGILdyNJ/GifK4iw8BYmCOGzP2DmzPaiiEDzdf8ByQ == From: Vishal Chourasia To: adityag@linux.ibm.com, harshpb@linux.ibm.com, milesg@linux.ibm.com, npiggin@gmail.com, peter.maydell@linaro.org, alistair23@gmail.com, balaton@eik.bme.hu, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, berrange@redhat.com Cc: Vishal Chourasia Subject: [Patch v7 1/5] hw/core/loader: Use qemu_open() instead of open() in get_image_size() Date: Thu, 23 Oct 2025 00:57:14 +0530 Message-ID: <20251022192717.1644251-3-vishalc@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251022192717.1644251-1-vishalc@linux.ibm.com> References: <20251022192717.1644251-1-vishalc@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: ayvMIoVFb1CFUHicPtStQHuxtdIKM1l2 X-Proofpoint-GUID: NV1WPV9fZ8dG3-s7deqW6by6opizDG56 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfXyxQ1pNkiYE0Z pgoHiQ258JsBeUNKxKiNda5jyGDlVYW8fVeqhOoRGvzT6wlXa1YpOx2/UImOqdYPSHTit5r1GTQ ES5HEaFFMJOcGScAUwlQUrOHNzjna3A4nIYBpUBzoQGWRI1Iz1Qr/2yjcx0xzP5UZUGKCykBR/X uDHy8l9k9cT8/VIWJMibm/6pFYbGmUKIZqE1YuowPe2wKN+CQ8Ouo3C81FeULdsdJjKpXjwqwbI wwpfUFG/5qkKU0JYlAJuRPozZgFGCcbSPpAaHwWXui6wYE+S+x2jYTefqSsPanovUvdWdaOa5mj 1Pt4uk0sgho5RxXGuLdualUw/ZkdjsTtUUQsUlIRftTx7xp/LaABiE+TzyGJTJjHYUaGwFaMdXq V/g7psbVEKyKhsYuWhTiICOTE3JUiw== X-Authority-Analysis: v=2.4 cv=IJYPywvG c=1 sm=1 tr=0 ts=68f9304f cx=c_pps a=aDMHemPKRhS1OARIsFnwRA==:117 a=aDMHemPKRhS1OARIsFnwRA==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=20KFwNOVAAAA:8 a=VnNF1IyMAAAA:8 a=-CUL7ttSjCJlytmGOe4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-22_08,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=vishalc@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1761161323618154100 Replace open() with qemu_open() which provides better error handling via the Error object, automatically sets O_CLOEXEC, and supports FD passing with /dev/fdset. Currently pass errp argument as NULL. Suggested-by: Daniel P. Berrang=C3=A9 Signed-off-by: Vishal Chourasia --- hw/core/loader.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 477661a025..c9782d67e8 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -74,7 +74,7 @@ int64_t get_image_size(const char *filename) { int fd; int64_t size; - fd =3D open(filename, O_RDONLY | O_BINARY); + fd =3D qemu_open(filename, O_RDONLY | O_BINARY, NULL); if (fd < 0) return -1; size =3D lseek(fd, 0, SEEK_END); --=20 2.51.0