From nobody Fri Nov 14 18:24:04 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1761137855; cv=none; d=zohomail.com; s=zohoarc; b=NbExs/kMTwrCt4rb0ycabGKcqar4y+rlRWS+Mp3DUgWxvqm5CiXc35I05xbEZabydPjl7r/CoTmo6fOFy0AaeYgx+FaussNnc7TpwrzQ4TF1vam8danGrVcCkUMqqrCDFIPtLBOLQLfxURlf4vXHu8pTGY1horOycBnE4U1c+3A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761137855; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LOO0KdkHNx89CU58iBA7rR0/YEfe+JIC9zq+WuZvcg4=; b=Awi52fh7mOK8QWbjbUpv4mp3+A4lnYk4xh3u6vzx+IpmycNj+W7pXFb50Cm9S6t7T/qRs39l1PaE6IzuGRcRXo+XvSmJJNTJZH8TKmlgTGSSQjtR5Pm92eiofTo0/fHBbF6MHOnYvgJFp8sMKpY9zN/CnQN/iFBh+rGbtGKCvFE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761137855689651.1647816869701; Wed, 22 Oct 2025 05:57:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBYOk-0001QN-P5; Wed, 22 Oct 2025 08:57:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBYOf-0001Pe-Ld for qemu-devel@nongnu.org; Wed, 22 Oct 2025 08:56:57 -0400 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBYOc-0002nv-8T for qemu-devel@nongnu.org; Wed, 22 Oct 2025 08:56:57 -0400 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-796f9a8a088so6159610b3a.1 for ; Wed, 22 Oct 2025 05:56:53 -0700 (PDT) Received: from grind.dc1.ventanamicro.com ([189.38.141.22]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7a23010d96dsm14394685b3a.60.2025.10.22.05.56.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 05:56:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1761137812; x=1761742612; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LOO0KdkHNx89CU58iBA7rR0/YEfe+JIC9zq+WuZvcg4=; b=ox06EU0Cp0FraEcGbjyU8pQFHlgLNCw9GlX4vX1C16ulb1E/gB+apV1jUMuDuIdEEU DFynLy0b2QuOw3+Q11TL8jpwOktSFhT3qMP/Pq2Bg3TFbWpHQ7SX1aJBynrn+KAwrSYS x890oJgYjJ29MkV+3+BZncbKtLN6IP7Idp8Ykw6wTM5eTZ5IUf1pfU5AXo9N+aDoJhOJ rIoFNz4aV2TJ27vZDwJcN1u+ki/WHINeqswPg6eddt9ueYTkFTvn82RH05HexwwaaR0g W39PogfNcrtWnPmBhOQh58Eh01AJWKbOvwCLFqtDLE7+b3I1bGc46d9cKwsm16qADYiu TETQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761137812; x=1761742612; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LOO0KdkHNx89CU58iBA7rR0/YEfe+JIC9zq+WuZvcg4=; b=YAqCuqbym4IhNJaMgQV6Xw2lT8iBWnilUCLvA6OZnUxLBMbu+oy3NV17OLYVijmHtm AtoBgFVWGE1N4hC3VjKjl+jrt8w4S74vMGF2PgRzCpe4b+JzW9GaMPBG7upHRJDUq4bB jWWp6RDy4K/O1/m/VFZGel7XS9RSwfaf2tKRdKCOiaDMI2XwnnXpKOcBKvJeiJE6MVSU jzx3xQHMGDAiNl1yb0AnJbs7f2ReXgJ7W8GI+NpBl50ndjoi6B2TQz5xCq8dBVJ13mde PNK9Lq7w3szuM6Gu2ls9nl2McJBbc/IOpO4RzmcnaePkczUhJWTtFVsajhTb3S5DxOnL y56g== X-Gm-Message-State: AOJu0Yy/IUCCToIz+Do3y9LQX6tP9dfLo58rYeYDYhiJdfhKjwHJpc20 uA4LpwtwGYlWheZIy3uG0rXbrJd8KVjzvpEpBHLDvb15Td8HnfRuCyXfxzlu8O1CSA2O2VlxqQZ lWKcYQfw= X-Gm-Gg: ASbGncsxifX+C9yXxefvFBG+xbYWfJ0SGnbdwZ09FUPz4rCAEm8+1/8SwL47llrKk1Y N5ETfTxrKC2Hs6LnBJrV+PtgHz2J9880rvR3urZNPyG+GvIOlnWmDH+hErzz2Jj9dsf9pFli3AW txzr709T/xCxjDwr5CzqIzAprqDsxpse2LLn4bwMddT049ors0s4ZeUgco6CdeAKYN9/9yr2tKV z/z/3AZfVNY0+GgFCl8glsq0clGgYidx/mzenOt3zcHUgITq72+kH99HHwG3vlrKG9mxat6S6sI o/6UCUA0M8PtQD0DNUt/FrCOHHAMaOUwAu4LD+qMIs0O8tCgsXlLwKD7ZP0hdLBe4VdIdJbxV9b PXwo2oTjCEySclIviGfePvWF3GOcs8kdSG2WntcNWa8tduTtRm6BHKmko+xoAFAMEH3R5lV3KD9 v0/Ifmop8XVkE0CYe/wcdKOfjBWA== X-Google-Smtp-Source: AGHT+IERjfi5Y7rlk5D6c4f1utj6ef9JMt35zcVoqns+kEA6uDPUYuz2bNlVs7xrORPxrNuM7lHHTQ== X-Received: by 2002:a05:6a00:3a21:b0:781:4ec:4ec4 with SMTP id d2e1a72fcca58-7a220d30df8mr25903150b3a.31.1761137811775; Wed, 22 Oct 2025 05:56:51 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Cc: qemu-riscv@nongnu.org, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, palmer@dabbelt.com, Daniel Henrique Barboza , Peter Maydell Subject: [PATCH v2] target/riscv/riscv-qmp-cmds.c: coverity-related fixes Date: Wed, 22 Oct 2025 09:56:43 -0300 Message-ID: <20251022125643.588947-1-dbarboza@ventanamicro.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::430; envelope-from=dbarboza@ventanamicro.com; helo=mail-pf1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1761137859345158500 Content-Type: text/plain; charset="utf-8" Coverity CID 1641401 reports that, in reg_is_ulong_integer(), we're dereferencing a NULL pointer in "reg1" when using it in strcasecmp() call. A similar case is reported with CID 1641393. In theory that will never happen - it's guaranteed that both "reg1" and "reg2" is non-NULL because we're retrieving them in compile-time from static arrays. Coverity doesn't know that though. To make Coverity happier and add a bit more clarity in the code, g_assert() each token to make it clear that those 2 values aren't supposed to be NULL ever. Do that in both reg_is_ulong_integer() and reg_is_u64_fpu(). We're also taking the opportunity to implement suggestions made by Peter in [1] in both functions: - use g_strsplit() instead of strtok(); - use g_ascii_strcasecmp() instead of strcasecmp(). [1] https://lore.kernel.org/qemu-devel/CAFEAcA_y4bwd9GANbXnpTy2mv80Vg_jp+A-= VkQS5V6f0+BFRAA@mail.gmail.com/ Coverity: CID 1641393, 1641401 Fixes: e06d209aa6 ("target/riscv: implement MonitorDef HMP API") Suggested-by: Peter Maydell Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis --- Changes from v1: - use g_auto(GStrv) instead of g_autofree - v1 link: https://lore.kernel.org/qemu-riscv/20251022110524.483588-1-dbarb= oza@ventanamicro.com/ target/riscv/riscv-qmp-cmds.c | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/target/riscv/riscv-qmp-cmds.c b/target/riscv/riscv-qmp-cmds.c index c499f9b9a7..d5e9bec0f8 100644 --- a/target/riscv/riscv-qmp-cmds.c +++ b/target/riscv/riscv-qmp-cmds.c @@ -273,12 +273,13 @@ static bool reg_is_ulong_integer(CPURISCVState *env, = const char *name, } =20 for (int i =3D 0; i < 32; i++) { - g_autofree char *reg_name =3D g_strdup(reg_names[i]); - char *reg1 =3D strtok(reg_name, "/"); - char *reg2 =3D strtok(NULL, "/"); + g_auto(GStrv) reg_name =3D g_strsplit(reg_names[i], "/", 2); =20 - if (strcasecmp(reg1, name) =3D=3D 0 || - (reg2 && strcasecmp(reg2, name) =3D=3D 0)) { + g_assert(reg_name[0]); + g_assert(reg_name[1]); + + if (g_ascii_strcasecmp(reg_name[0], name) =3D=3D 0 || + g_ascii_strcasecmp(reg_name[1], name) =3D=3D 0) { *val =3D vals[i]; return true; } @@ -294,12 +295,13 @@ static bool reg_is_u64_fpu(CPURISCVState *env, const = char *name, uint64_t *val) } =20 for (int i =3D 0; i < 32; i++) { - g_autofree char *reg_name =3D g_strdup(riscv_fpr_regnames[i]); - char *reg1 =3D strtok(reg_name, "/"); - char *reg2 =3D strtok(NULL, "/"); + g_auto(GStrv) reg_name =3D g_strsplit(riscv_fpr_regnames[i], "/", = 2); + + g_assert(reg_name[0]); + g_assert(reg_name[1]); =20 - if (strcasecmp(reg1, name) =3D=3D 0 || - (reg2 && strcasecmp(reg2, name) =3D=3D 0)) { + if (g_ascii_strcasecmp(reg_name[0], name) =3D=3D 0 || + g_ascii_strcasecmp(reg_name[1], name) =3D=3D 0) { *val =3D env->fpr[i]; return true; } --=20 2.51.0