From nobody Tue Feb 10 09:57:26 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761079928; cv=none; d=zohomail.com; s=zohoarc; b=hcePOspAhwxWDHVlRPNE7Hbx4lEpC3+9yQ8l549Z5Bw3s13YkQ8GjluD2ddaQgwPoCbXys3FBDFZvH/vqMMmx5ApAcsBFuML6Fj8W/XCHJ856OchyDguXsdJmWNF/d43G2AZEfZRBWdVsQS9AH7Yt1l46CJf5+Yv09MFc+8YncU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761079928; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=im+OEuCaVAw5x7x2mUEPI+ZYBfpg88mOANk8NkPxsC0=; b=NinRpmGEoWxyoNaWpGSxWFpEUQVh2GW7xXEtGt+IU0q6R8HVkbRz8Ldv29wI7PC/j3gXijMI+yfvoGvPANnjCdDWE7ezVBXCHs6azeZ2riJfLvdKoVccrpGeVapN06qMs1jgai8PH2ITlPGwAfXjMOI9kJOdKgFrdA++S5HeXu0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17610799286401017.3835024996323; Tue, 21 Oct 2025 13:52:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBJHg-0007nC-Ok; Tue, 21 Oct 2025 16:48:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBJHd-0007ak-Tw for qemu-devel@nongnu.org; Tue, 21 Oct 2025 16:48:42 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBJHR-00019p-8p for qemu-devel@nongnu.org; Tue, 21 Oct 2025 16:48:35 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-471066cfc2aso14345795e9.0 for ; Tue, 21 Oct 2025 13:48:28 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c428e9b2sm9680685e9.5.2025.10.21.13.48.22 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Oct 2025 13:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761079704; x=1761684504; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=im+OEuCaVAw5x7x2mUEPI+ZYBfpg88mOANk8NkPxsC0=; b=hu/SCg0Z6gAuBUlRnxaU9ObpNn3xtFJfMn08ac/p2NfGD57SY/ZlRlgcGoY5oQk4GW W6SWE3uymki/AUbB/cOuR7XOgo2+BCFX5ISVN7XReziU/p47pIGV3UQQNLs8SoINVT7i 2c2yhIQmPkz3xGUMVkri1T9b+3BuV/MmAyJI+hugGW1cfIWqYbLUHGJss9FJ9+qjsQ5r e947jsx2RANpO25AF+Bjsef/jhQ7+hRdLgmn3wqLC3+5fiC0cIlaIaG5fVYRmlMJrZSy xA4t2rC8Eb1Xl5vXcJl7s+RE/oGyMJgj5wQhKzyALrUt4B6iV/zC8Is29isMAZ4UCmzi 2+sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761079704; x=1761684504; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=im+OEuCaVAw5x7x2mUEPI+ZYBfpg88mOANk8NkPxsC0=; b=BmlnkPExFoTHKlL1mbLnVNXm2gcbFTsfFx3TcSg8qDwNszrr72wNhG4AA7AxuaWD7V wISfnySHpSnem9ci+/4W3mnH7h2O3eP4qqQwUoxtHzDO21Tyg2YQd+YsU26khDSC1dfa xsj+uqYNH8h97XUhL3ZRrkv+sJHcewr7AKCq5Y6+3o2tkSzHmOqgxbql9QwSa78PL7pe 5YzaR+RYnA5KBmAERtc4rMYtK8GyG0Dw9jDCp5vTezt8hxKTfrz5wxfOTfluzF9o0+zy WUtLV98IMsa8hXQ1JE1vKxGij21iEzTNgII7heUz1s3w9R0KxATuTRU0FrUCfXlEQNq3 Phlw== X-Gm-Message-State: AOJu0YwWS7sV/182hS1cAZsp70EtvZUFC1SAQgPCr7GF2+Wt5iXoZwTm RzTj2aFz+FGxjXwPWUIodvIBgGpWcfiAQh16xGgMEoGiJ7b8m21LqnwyJLFBYmnHh5hr3xmFnuG ldIdRMUk= X-Gm-Gg: ASbGncsZY3ETxFEOj4Z0/yvlpfqaRr7DeGDIqc0Jh7ZhwQNUSO4jqWzF4M3Ucyk33tl 6wWwwuRzgCnvLxfOKQsA4jftIMfwn5usaRwQorpEH9g4BwhTN9+jXKgl7qixlnr7VZ+WVZt8Yp0 t86sj1fYQrpi60RmaJU4TVBN4fExym4y+Rtil8N48+D3+BPIEsvSDYqrR5ck84U1RGXS6jmiJzM uzj2qetQuWE+WY2E1cf14BdZ/gr3qcJ7nn3Nwm2aZZlUFQYdgVaYpv5Ow2VYzTv5SWS67gJCSkY FA3LPkRv7DW6v1GZhWNpIjPZpNO81w6pNFRww4SSnn/wa/UemmTxZ5G72Ze36A0OtXe7Tz7w95O /KcvOgNhH1E/9Z+v6dE+8lSkQKvpBg/+hASBqv3RxEIT4PxGWZtgd09UgkXo7/Dq5tsSzCFrdkv vKdKSf+8Fg2rqIt4yD04nLPNNXgK6aJrgpGaCdc+IEUzBPH5b8vPK2rDfP+Cwv X-Google-Smtp-Source: AGHT+IETgh478E3vvkI5VMl3KmOPE93VhkJeXNs7JngB+USmWlOp4L1BQXawj3X5Y5Hedw7qe+251A== X-Received: by 2002:a05:600d:4395:b0:471:a259:cdbe with SMTP id 5b1f17b1804b1-471a259d086mr55392225e9.23.1761079703625; Tue, 21 Oct 2025 13:48:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 17/45] hw/core/register: remove the REGISTER device type Date: Tue, 21 Oct 2025 22:46:31 +0200 Message-ID: <20251021204700.56072-18-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251021204700.56072-1-philmd@linaro.org> References: <20251021204700.56072-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761079931235158500 From: Luc Michel The REGISTER class (RegisterInfo struct) is currently a QOM type inheriting from DEVICE. This class has no real purpose: - the qdev API is not used, - according to the comment preceding it, the object_initialize call is here to zero-initialize the struct. However all the effective struct attributes are then initialized explicitly. - the object is never parented. This commits drops the REGISTER QOM type completely, leaving the RegisterInfo struct as a bare C struct. The register_register_types function is left empty here because it is reused in the next commit. Reviewed-by: Alistair Francis Reviewed-by: Francisco Iglesias Reviewed-by: Edgar E. Iglesias Signed-off-by: Luc Michel Message-ID: <20251017161809.235740-2-luc.michel@amd.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/register.h | 7 ------- hw/core/register.c | 18 ------------------ hw/net/can/xlnx-versal-canfd.c | 2 -- 3 files changed, 27 deletions(-) diff --git a/include/hw/register.h b/include/hw/register.h index a913c52aee5..4d13ea183c7 100644 --- a/include/hw/register.h +++ b/include/hw/register.h @@ -75,10 +75,6 @@ struct RegisterAccessInfo { */ =20 struct RegisterInfo { - /* */ - DeviceState parent_obj; - - /* */ void *data; int data_size; =20 @@ -87,9 +83,6 @@ struct RegisterInfo { void *opaque; }; =20 -#define TYPE_REGISTER "qemu-register" -DECLARE_INSTANCE_CHECKER(RegisterInfo, REGISTER, - TYPE_REGISTER) =20 /** * This structure is used to group all of the individual registers which a= re diff --git a/hw/core/register.c b/hw/core/register.c index 3340df70b06..2553cb15aba 100644 --- a/hw/core/register.c +++ b/hw/core/register.c @@ -258,9 +258,6 @@ static RegisterInfoArray *register_init_block(DeviceSta= te *owner, int index =3D rae[i].addr / data_size; RegisterInfo *r =3D &ri[index]; =20 - /* Init the register, this will zero it. */ - object_initialize((void *)r, sizeof(*r), TYPE_REGISTER); - /* Set the properties of the register */ r->data =3D data + data_size * index; r->data_size =3D data_size; @@ -318,24 +315,9 @@ void register_finalize_block(RegisterInfoArray *r_arra= y) g_free(r_array); } =20 -static void register_class_init(ObjectClass *oc, const void *data) -{ - DeviceClass *dc =3D DEVICE_CLASS(oc); - - /* Reason: needs to be wired up to work */ - dc->user_creatable =3D false; -} - -static const TypeInfo register_info =3D { - .name =3D TYPE_REGISTER, - .parent =3D TYPE_DEVICE, - .class_init =3D register_class_init, - .instance_size =3D sizeof(RegisterInfo), -}; =20 static void register_register_types(void) { - type_register_static(®ister_info); } =20 type_init(register_register_types) diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c index 343348660b5..99bbdd7d3fe 100644 --- a/hw/net/can/xlnx-versal-canfd.c +++ b/hw/net/can/xlnx-versal-canfd.c @@ -1868,8 +1868,6 @@ static int canfd_populate_regarray(XlnxVersalCANFDSta= te *s, int index =3D rae[i].addr / 4; RegisterInfo *r =3D &s->reg_info[index]; =20 - object_initialize(r, sizeof(*r), TYPE_REGISTER); - *r =3D (RegisterInfo) { .data =3D &s->regs[index], .data_size =3D sizeof(uint32_t), --=20 2.51.0