From nobody Fri Nov 14 16:40:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761052776; cv=none; d=zohomail.com; s=zohoarc; b=X0urFE8gmtQafH38HUSMnxDhOBsYfb6ybrW2kq9zhJEIhXFH3l2VEOIbdMAdFeK2+Jf8lVh4NnPfmmRzstX4TPhvnJ97E15vA4FwU+yrAVGbx3sWEZp4eW6sRPLB1IIegXgh1d43y1qoidcwcJsQ1up2aAOSvzO43ek14TuDlkw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761052776; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aoKouDHRM63ur8bgDiAr/baaSlSpEgMJ6p1OQu1/W50=; b=mYg+cq2CG6mrDNv4PXdygQzOWz43GOoRu91DDMCij2Iwan7fxv9M75yvG77DRp0t9Ojxw4Si/ZAOKhKJj2o6VbOHwe/DZK0kBkyr2qLFzd4m6bf8AOfU5TrZZuQhZAXs5oIF0G7n7ElIBaMpLwRIS7KKEUfweIEoE40PbL4JdxY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761052776368484.70352473763796; Tue, 21 Oct 2025 06:19:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBCG6-0002GX-PJ; Tue, 21 Oct 2025 09:18:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBCG4-0002GJ-2m for qemu-devel@nongnu.org; Tue, 21 Oct 2025 09:18:36 -0400 Received: from mail-wr1-x42a.google.com ([2a00:1450:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBCG2-0002Xr-3o for qemu-devel@nongnu.org; Tue, 21 Oct 2025 09:18:35 -0400 Received: by mail-wr1-x42a.google.com with SMTP id ffacd0b85a97d-426fc536b5dso3099852f8f.3 for ; Tue, 21 Oct 2025 06:18:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5b3c65sm20280934f8f.15.2025.10.21.06.18.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Oct 2025 06:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761052712; x=1761657512; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aoKouDHRM63ur8bgDiAr/baaSlSpEgMJ6p1OQu1/W50=; b=nBrRKvSk8kalJRqmHD8bwmfRuqNDhxEodkMgOkx3yB/tUIUfyP/qPPfE/iMoYALXbo HyIRc3LSG7+PnNfnG4BgPdnyK0ERjEAjfJyWB1/VoHHoAdO0FgfhrNia+XbRYM3jBUxF 15MWTZnacbqK0b7YU8OZOke6fYCLCzabbMpok3KKIT9UJTRaE3/laarrRLpWdOPgZl4r eg20VmmvUMZYI+nv2F1lvRHcILvzm8qrPONv1GhqRsBxoXlVhXDwjdJU7EHi+4pO6Yar kTGmOel+PcdamL3u2GvSWgWy0/0TQl7hPu9Dg00w8JnX5VMqqP+qCTU8LthMKNswmGb8 EtSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761052712; x=1761657512; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aoKouDHRM63ur8bgDiAr/baaSlSpEgMJ6p1OQu1/W50=; b=WP3jWnlzJSH9zFMU8Srhf5Mm1KBEy1+6WxOzaXb+/GwQWGwlOLf5RyrlzGvIEQijMw ht/f3tkxXvIh2dQdnaRC/5eMZurC8pnbrgZSkDLEiPtFgJPwiB6i10URdQlwON8CllCe 3YwQwK7dScwbefq7ojMrNLrWJPfhRheDKSMxuf/pj4w2ctD1GQe8RguVtPVGGj8xTBqI XXh8sK85zHVgdEEX5RjUzFDvtRZEjX1RIjIyns8JsihRIvBiS47KUx1MFIU5wcY6VyeM 4yhWRIBTm+LHtAupgkfIA9Nc03Bo70km8rm42qVVXBUPsmueoVf3DSjLNtMH149Muqkp 5Yvw== X-Forwarded-Encrypted: i=1; AJvYcCVIj0s+s9u2f8tZxvSVCv7RiXebE+dulv1xh6bmg0sRSRhcYwip14pARmU/NGHP2SJcMAwIS5XsP40M@nongnu.org X-Gm-Message-State: AOJu0YyD8jDA7C77eRCn7RScfJnXbmLsbrlZkytX0R72ZIt6PRVve6k0 yUxchwHqzbr8cveZqLFXo4KyBI8KYZvVsMG8BCjbnwy+Ptxfw0BlYWKBLienaWj4vR0= X-Gm-Gg: ASbGnctoi50B1Y/qDOrVxpFmlH0pzxl+U6pH1yQrSh0pI22b+9VmqbJ1vOPPUeQfluo pbz030LZBGeFtBQ3cesQQ8qHoMAaUZM8l2rc8v3XTVHz5IR0FGnkZU7lULHpDD/cEip79jC3b0S Iz90FhaFfcXuGRzowY4Q+aPHdPh3Cr7SXGdEDARP6z3oCpXh2Oc3JpW9dSOa5tWmDoeW9mVV4p5 iRD6im1PyYk08E1RXsXxRF5Yq0/w70W2HD1zjMPAP3QcamFye4v9aFVlPpNqWvIoEhgrUuWfhKc Br6N400rMFImgM+OzRZJw2wYvvJgqgRfYQhH+8tOY7hjqiDDG8bYLP8o2KeIm37tEiF97u3JWEE t/1Aw6bBRWIQTdTMeroPIKoZIDr/hsG/eR4L97/lxeup5AE/LibJlB+ESO1YJe6nI1AYSc5VLc8 Xt1NCEk6agh/BNKRmw4hX3gsPQMzgIQmzlwIUgti7EK8Ysv/ZCHQ== X-Google-Smtp-Source: AGHT+IHHUkiq/drGct6Hys9nEIgCTKXHqdZpC96vX11imtoQQ+eM4Z1KkqZY1aVH/uIyonDQJXR0Jg== X-Received: by 2002:a05:6000:26ca:b0:428:3c66:a013 with SMTP id ffacd0b85a97d-4283c66a3f8mr7877888f8f.55.1761052711702; Tue, 21 Oct 2025 06:18:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Gerd Hoffmann , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] docs: Update mentions of removed '-soundhw' command line option Date: Tue, 21 Oct 2025 15:18:22 +0200 Message-ID: <20251021131825.99390-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251021131825.99390-1-philmd@linaro.org> References: <20251021131825.99390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42a; envelope-from=philmd@linaro.org; helo=mail-wr1-x42a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761052780006158500 The `-soundhw` CLI was removed in commit 039a68373c4 ("introduce -audio as a replacement for -soundhw"). Remove outdated comments and update the document mentioning the old usage. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- docs/qdev-device-use.txt | 4 ++-- system/qdev-monitor.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index 043ae461140..fb420da2a9e 100644 --- a/docs/qdev-device-use.txt +++ b/docs/qdev-device-use.txt @@ -311,9 +311,9 @@ constraints. =20 Host and guest part of audio devices have always been separate. =20 -The old way to define guest audio devices is -soundhw C1,... +The old way to define guest audio devices was -soundhw C1,... =20 -The new way is to define each guest audio device separately with +The current way is to define each guest audio device separately with -device. =20 Map from -soundhw sound card name to -device: diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c index 4b732f579ad..5c95926aadd 100644 --- a/system/qdev-monitor.c +++ b/system/qdev-monitor.c @@ -73,9 +73,9 @@ typedef struct QDevAlias =20 /* Please keep this table sorted by typename. */ static const QDevAlias qdev_alias_table[] =3D { - { "AC97", "ac97" }, /* -soundhw name */ + { "AC97", "ac97" }, { "e1000", "e1000-82540em" }, - { "ES1370", "es1370" }, /* -soundhw name */ + { "ES1370", "es1370" }, { "ich9-ahci", "ahci" }, { "lsi53c895a", "lsi" }, { "virtio-9p-device", "virtio-9p", QEMU_ARCH_VIRTIO_MMIO }, --=20 2.51.0 From nobody Fri Nov 14 16:40:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761052772; cv=none; d=zohomail.com; s=zohoarc; b=Rsid6/ROFBfwMSNNlx171PT4WcWQPUpFBUxJezwg2uMssnT579ozfwdGIsEkLLf1VO9baqgDF0v4tRF7ma6OgNC7YXjmRFLH9Q5YB6UQ0y0W0tieKx/lTNqyl4jB5cbkAPnKnqgJUNeJ756myZ/H2FCJ+Q39zk2CVtwkfmcKpPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761052772; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fajL8D4qjkZYuIz+6S2Vfjd7bqCu0mIrYWtAC9gi6bw=; b=a25J+r+A6be8rr8809acBJz5rdaP5w7ShA+KAS+2kQFo2PcV13rHSNFiydhu9XMoOooE80+lbHgez8NehRW5oy2qN5Cy7+xkTEglV27UbB3zPblCJ5XtjXfmwDqr1e4WdMbBKtdbUE6Q9UgQlPNi2T2+r86J0sIjr+Lb2yetQ94= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761052772014661.6643499097206; Tue, 21 Oct 2025 06:19:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBCGC-0002H2-Tm; Tue, 21 Oct 2025 09:18:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBCG8-0002Gp-Pc for qemu-devel@nongnu.org; Tue, 21 Oct 2025 09:18:41 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBCG6-0002YS-M4 for qemu-devel@nongnu.org; Tue, 21 Oct 2025 09:18:40 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3ecde0be34eso3827462f8f.1 for ; Tue, 21 Oct 2025 06:18:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471144239f4sm282487475e9.2.2025.10.21.06.18.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Oct 2025 06:18:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761052716; x=1761657516; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fajL8D4qjkZYuIz+6S2Vfjd7bqCu0mIrYWtAC9gi6bw=; b=xXGIcEND3zDm2NFfOc/i8aYWrRrZ/UkxN9d/9UCA6AhVYOMH09xXA9vwXa7bYzSy01 +5Sc0x+agYJpm4VHgG0RLMSGJ+ldDrmZywyf/FKU7Zksj+jacmCqg4iJjBvdhxlDoM0l 26OzsK2V52D/H9AZ1moK6Yaoaz+FRLIs8FtJuZVQhWITRGGjIScX0NU7Te0dcEAFFqNE HTt+XB9s1AAU4/VWiJROUSs3M8hsPWPpLs2+U56VVnxx7S+yJVZ3CzybCC0c0AO19kqX /B/G7recMXbxKpKP/40AQAQMnUcs3GE55BC0jVxJOELCYtzAzc24sqLlpZQU5ulCi3zS sFag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761052716; x=1761657516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fajL8D4qjkZYuIz+6S2Vfjd7bqCu0mIrYWtAC9gi6bw=; b=XqA1ziTp3em//B3BBqm2mQQqkJuJ4zRZTvtgWSo/bzXE6g8BbH5JdeVE9NDlgQ3ijQ L0DwPlsWjnZGQykXp2uwB/oDwndLzQ+NSN8z7rsgL1cFAcO9+sYjVQnx1SSNM6yRHjvj H9HhW63I+khhdBvHZHCGTP8QyTpXI9aKPcA57zlYx0pb9NTyQ8vAwzoq/hMfhZoabCQH D4iug5PKxRaAH+TXDIk0K183Fujv9xFa+OgBRcuP97HrXnJiXB5rRxDHRoaE6ELYyDb7 bX/lHAvISQrRIot1a76l3m03WwuYW8vftUh/lCBDKx1Oi/LWlRD4bSgd8Qi6ZMIZLpNW pnHQ== X-Forwarded-Encrypted: i=1; AJvYcCUy+vdF7dek5u7RUxzCLHo7vEJRAu5aVE2fnmEw1jzypFxbzS3wiGsJ9/RSNQe05/BsH9ooclZZ/Zie@nongnu.org X-Gm-Message-State: AOJu0YwMiwZpl21C/q/G19rYKylCzDMfbeuOZuYnPJLayTjlJcoHLP1e Ldq/Vkr3S5X4AM/gb1e7Sl6ilPGcyXU3Ko89AtRpru02EFVfq/7YH8Juts6dDo2Qh+0= X-Gm-Gg: ASbGnctJBaFDNvjP0uTirPjSK8HDgIps0cZuLoBh4G3xJywVlrN1NS3c78qGsLh7CgG ZF8EkDGIlrm0LAMxELbNdrda6o+Ag1U0Znoq4I6v+eqAa+slcDThtAY39TGEQiqvx8L7HiR/Gxh HghirBU6k9AcmSHtHklnocJEZ540vEZjsD5p8NRrFqbTRWGYcAiOR2d/iZkuloug96kTXjs6TVg 30/8MDnvXe4gDEkKulo4D2kHpEWBKBTlbcQb2ouiIqpjuEZ2FCRVn4k0qk/dTYAWtyYedOI/nWm YV23rSWIrp9xb5UDmqw/9yncZDCuhc2G5nrWm1eZW4jN2KAr8Jma8LxiNbXO0j/vuwTDMuiKsmM 5cs/sMC6FNa+sJIgVHBcRxqbdWaNGJEvlkAa53I9ALQguA2EnNtngJxbk6/K6t8MaIvGxPdUIoZ dbStYyJPiFI8BG5hSjoMd2qZvWYAqGwQ8xg8qb8nrtGpHIo5392+iy8Um3d3hTV/zUmrDGP80= X-Google-Smtp-Source: AGHT+IGdTf3jbXDnwIVm5nOMuReJXchf9bxXuWcDAyHHZRdqU61kWM7AjqAkvt/WVHCD/TuSyK8iag== X-Received: by 2002:a5d:5886:0:b0:410:f600:c35e with SMTP id ffacd0b85a97d-426fb6a7055mr13815590f8f.8.1761052716385; Tue, 21 Oct 2025 06:18:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Gerd Hoffmann , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 2/3] hw/audio: Remove intel_hda_and_codec_init() Date: Tue, 21 Oct 2025 15:18:23 +0200 Message-ID: <20251021131825.99390-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251021131825.99390-1-philmd@linaro.org> References: <20251021131825.99390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761052773357154100 `-soundhw hda` was removed in commit 039a68373c4 ("introduce -audio as a replacement for -soundhw"). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/audio/intel-hda.c | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 0d35afa4ab4..83bb7e597db 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda.c @@ -1301,28 +1301,6 @@ static const TypeInfo hda_codec_device_type_info =3D= { .class_init =3D hda_codec_device_class_init, }; =20 -/* - * create intel hda controller with codec attached to it, - * so '-soundhw hda' works. - */ -static int intel_hda_and_codec_init(const char *audiodev) -{ - g_autoptr(QDict) props =3D qdict_new(); - DeviceState *intel_hda, *codec; - BusState *hdabus; - - qdict_put_str(props, "driver", "intel-hda"); - intel_hda =3D qdev_device_add_from_qdict(props, false, &error_fatal); - hdabus =3D QLIST_FIRST(&intel_hda->child_bus); - - codec =3D qdev_new("hda-duplex"); - qdev_prop_set_string(codec, "audiodev", audiodev); - qdev_realize_and_unref(codec, hdabus, &error_fatal); - object_unref(intel_hda); - - return 0; -} - static void intel_hda_register_types(void) { type_register_static(&hda_codec_bus_info); @@ -1330,7 +1308,6 @@ static void intel_hda_register_types(void) type_register_static(&intel_hda_info_ich6); type_register_static(&intel_hda_info_ich9); type_register_static(&hda_codec_device_type_info); - audio_register_model_with_cb("hda", "Intel HD Audio", intel_hda_and_co= dec_init); } =20 type_init(intel_hda_register_types) --=20 2.51.0 From nobody Fri Nov 14 16:40:31 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1761052768; cv=none; d=zohomail.com; s=zohoarc; b=bqJw8TA+q05MEGTy1MVzWbYC69WfLPOh2Brj+Zc664/pelKfDLIXrPgH0+DOOy1ZUwDsC7tJ9enCLuCzyq7jOJ/wJObwaiYGcSCBbjaWcTCPXdEtqsRjcVoshz/qkDdI6xsphEU9N2fP41UVWp0K65CBhcpcfEgZOCn9/TM34g4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761052768; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=P0uUVCcSfLTNFb2IKz4tw3RJXNvASiNTQpt4aEdv6HM=; b=PgAu+ioUP33R0bRrQqJ/9WEgK6C4OLulDNnnpizT3ZLf6Js75CDzsUxQ8uMcuki7V6LUcdBsFdDYqG/jQapGrUwlDiXAJ00Bnln3T4iQYedUwrWQAjkdt2NMxeP3q77whbrAgY0iuputZCXfeJA2cZVbJNwLztZG1TTEBi34jrI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761052767993462.03361130367955; Tue, 21 Oct 2025 06:19:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBCGF-0002HZ-F6; Tue, 21 Oct 2025 09:18:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBCGD-0002HK-C4 for qemu-devel@nongnu.org; Tue, 21 Oct 2025 09:18:45 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vBCGB-0002Yp-9A for qemu-devel@nongnu.org; Tue, 21 Oct 2025 09:18:45 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-475c1f433d8so1942155e9.3 for ; Tue, 21 Oct 2025 06:18:42 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-471144b5d48sm284179415e9.9.2025.10.21.06.18.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 21 Oct 2025 06:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761052721; x=1761657521; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P0uUVCcSfLTNFb2IKz4tw3RJXNvASiNTQpt4aEdv6HM=; b=ka9dMAwO5GFwxqp8JuDlpkm/xF1E8uxdkjI7KEwQcuY7ASswrLQ0HlL/drpQWgTbht I26ZNti48DJR3oKOnRLtaHskbM6+mvCowXUsx6n9qdC9QrS0sIE4jochRRoqoawJAWPk RC05pDDBpepUolVfJe3WVPfK1W2MpN9Wpf01P3pWptksg4eA5iZtx/MVb4Sdgi6PKmm5 Ti6ukecyMa49USR431sxa9lCHhOhI2/D55+4cZNOhslfC9fwWOYOu31IyKosULF9f2RQ RFmVMbuSAqNaO4RQo/MKX3fqGv+6dnPWQLYXjEJCH1cDwCzVhG3pZKRo20sdaFG9DFKC 2j9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761052721; x=1761657521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P0uUVCcSfLTNFb2IKz4tw3RJXNvASiNTQpt4aEdv6HM=; b=SI1razr4WCSpc2wxB2RY4NsNDCUcrVOh6aBuH50kZIhfNYi85IKddvfKk4AwWW6mFt HzUNmIWqNwgS58iBTvvT1GllH4MeWhCjIlC8wMXJzFhegRiOmIjQr7A0tRxb8+FXphab Fog//q3Q26KOYtYr9Ns94LaHXcTqEKumTTHArl+N6Miq9P+LupbVsZisuYyIE+GLzWgB tpnkme4o5w+ECWJtcbbKJ/AkUcG6tnd023fx4KQCys1U7cejf/GEep/Ur0YLpK6k5l1p 0ueQ1Xx1BqXwnq4eF+bHVUecUATFFgkgAUSdRPa0Kh2G1pUz1M0duNSyFG7P1+1dizeY LBrA== X-Forwarded-Encrypted: i=1; AJvYcCVmbs/4O1cy0vnuGMlxDKW3/wbbPMzUowRcNtAoSYcP6GHGpQYvpRJ5LXP3M7vudQ6RfMmx15cA/oiT@nongnu.org X-Gm-Message-State: AOJu0YyJtgz+HCoA5/ejE7UTbNurfnTRGWmFsNifJsCZMhYBVQui80dZ enpbXE8ZJnO6IfoJtXwNgOkVTYMzOvjcM1RhHxcJKUluxO4osu23XrKFstTJn8a9Mwo= X-Gm-Gg: ASbGncvKTdGSgCdFfIx+3PwEygSbilnJK/1uaG1jt46WWd0ldiPnygoZpUv+bvPdHWr QPUv9K9RqXeqSVPC6aBp9EpDxryq37pLfTX9T6vV73aZZnZK/DvdONoZg8WRfleA91CDEoSya2M g+SVodUQxHz6YYx9wO0uVeaJAtXnK7Lzgy0XwUFgoe26qut8YWWUIRlyB7LLBudObovhBOrKUcL eWJwP1+GZjYzwSnRfeeAyJdHmWXKzbsu9p6SoR4Hxvnu7+p0yLINOHvZsElMMhZjHfaydpdQtS7 wHXCwSwaVNBwBVJy+ufAY0uqcIL3PryMAYx5vqwmM+M2cl/V9vCOf5qzfNNFWLUQ83JwBnJW+Yr 7VfXHyltfLWGYI3d/HjHXmtHdOgHciZLKfIt8bXeFoC+06tz/t1joCnky02vw153bVt6gtr11Ze X7/qt3veM43/OwDJwMd4IC81fpvC357rvymMZShDliR1Clmsk++Q== X-Google-Smtp-Source: AGHT+IFKy3bSBEz8fQTS59zTV+WvhpfKv8SoUOxzKPyUGE+4h7zk2iI0bC/V12ulczUPJEplRfXZzA== X-Received: by 2002:a05:600c:34d0:b0:471:1717:409 with SMTP id 5b1f17b1804b1-471179071b4mr109526995e9.23.1761052721093; Tue, 21 Oct 2025 06:18:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , qemu-devel@nongnu.org Cc: Gerd Hoffmann , Paolo Bonzini , Eduardo Habkost , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 3/3] hw/audio: Remove unused audio_register_model_with_cb() Date: Tue, 21 Oct 2025 15:18:24 +0200 Message-ID: <20251021131825.99390-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251021131825.99390-1-philmd@linaro.org> References: <20251021131825.99390-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1761052771686154100 We remove the last use of audio_register_model_with_cb(), remove it as not needed anymore, simplifying audio_model_init(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/audio/model.h | 2 -- hw/audio/model.c | 26 +++++++------------------- 2 files changed, 7 insertions(+), 21 deletions(-) diff --git a/include/hw/audio/model.h b/include/hw/audio/model.h index ebe456c22ff..b812c9211a0 100644 --- a/include/hw/audio/model.h +++ b/include/hw/audio/model.h @@ -1,8 +1,6 @@ #ifndef HW_AUDIO_MODEL_H #define HW_AUDIO_MODEL_H =20 -void audio_register_model_with_cb(const char *name, const char *descr, - int (*init_audio_model)(const char *audi= odev)); void audio_register_model(const char *name, const char *descr, const char *typename); =20 diff --git a/hw/audio/model.c b/hw/audio/model.c index 924a41e0ac9..d1e00b4eaa4 100644 --- a/hw/audio/model.c +++ b/hw/audio/model.c @@ -34,22 +34,11 @@ struct audio_model { const char *name; const char *descr; const char *typename; - int (*init)(const char *audiodev); }; =20 static struct audio_model audio_models[9]; static int audio_models_count; =20 -void audio_register_model_with_cb(const char *name, const char *descr, - int (*init_audio_model)(const char *audi= odev)) -{ - assert(audio_models_count < ARRAY_SIZE(audio_models) - 1); - audio_models[audio_models_count].name =3D name; - audio_models[audio_models_count].descr =3D descr; - audio_models[audio_models_count].init =3D init_audio_model; - audio_models_count++; -} - void audio_register_model(const char *name, const char *descr, const char *typename) { @@ -105,17 +94,16 @@ void audio_set_model(const char *name, const char *aud= iodev) void audio_model_init(void) { struct audio_model *c =3D selected; + DeviceState *dev; + BusState *bus; =20 if (!c) { return; } =20 - if (c->typename) { - DeviceState *dev =3D qdev_new(c->typename); - BusState *bus =3D qdev_find_default_bus(DEVICE_GET_CLASS(dev), &er= ror_fatal); - qdev_prop_set_string(dev, "audiodev", audiodev_id); - qdev_realize_and_unref(dev, bus, &error_fatal); - } else { - c->init(audiodev_id); - } + g_assert(c->typename); + dev =3D qdev_new(c->typename); + bus =3D qdev_find_default_bus(DEVICE_GET_CLASS(dev), &error_fatal); + qdev_prop_set_string(dev, "audiodev", audiodev_id); + qdev_realize_and_unref(dev, bus, &error_fatal); } --=20 2.51.0