From nobody Fri Nov 14 18:03:33 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1761044232; cv=none; d=zohomail.com; s=zohoarc; b=ZSNPu+rR5VAsU9HAzazUkMTIw5a1t8ohiY9u4Q58VF6HFMJ63ZVRGSg4MpunS3kbNGgl2Uw1CBY8hmxl0c3aeNlvozMC7dQ9BLZ9k5EFUfWxv5haimtKObagx9Pf6B/B5yPnKr7sKYPecnAwRftWcO6jhupx39y8Y/lJHzx8r00= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761044232; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FO1mcICwLiIn/LNi1WBqGKKba0QseRn08I3lIz2M2SE=; b=Rz3nZY+MuPRzvJh+hkpvlYfs49CjX4moP0RD2r1PYBZUCzThj//EFxPxhLbDGPIgfawjKos1phpXyksu3lx1zjtCap6aN4bMogwSFaP7kkyQRhs0DMKz0hgRQ8PzcRWVib65GzAMyND489t6/E/LjmpyaeoN+sWiYrSu4jKXG5k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17610442329721020.8735166730082; Tue, 21 Oct 2025 03:57:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBA2k-00063j-6R; Tue, 21 Oct 2025 06:56:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBA2H-0005go-MX; Tue, 21 Oct 2025 06:56:13 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBA2F-0001YR-6W; Tue, 21 Oct 2025 06:56:13 -0400 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59L8m0F2005743; Tue, 21 Oct 2025 10:56:05 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31rxj8e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Oct 2025 10:56:04 +0000 (GMT) Received: from m0356517.ppops.net (m0356517.ppops.net [127.0.0.1]) by pps.reinject (8.18.1.12/8.18.0.8) with ESMTP id 59LAhe94023457; Tue, 21 Oct 2025 10:56:04 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 49v31rxj89-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Oct 2025 10:56:04 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 59L81fsG032099; Tue, 21 Oct 2025 10:56:03 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 49vp7mt9mk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Oct 2025 10:56:03 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 59LAtxj650725298 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Oct 2025 10:55:59 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 21D5F20043; Tue, 21 Oct 2025 10:55:59 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 41D012004B; Tue, 21 Oct 2025 10:55:56 +0000 (GMT) Received: from vishalc-ibm.ibm.com (unknown [9.39.24.196]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 21 Oct 2025 10:55:56 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=FO1mcICwLiIn/LNi1 WBqGKKba0QseRn08I3lIz2M2SE=; b=a0vQtHMpgB6WT9xXu+n1M/Tb0rWTtJAum oSEYW1PtSG6wYyyNePYO/5ZwNQ99aGDQe/mhkQ6S389JFbsudRYp5C4HRHlWZSOB lyZ8gJCON0/7eUVbRcU03G6QaJmNbr4KmBxLCJZ1/XWxhbQ8xUONDSusFapSfv1d NkJSpqxOErCXiTORhMIsaUtFiYstTqT1HI59QGlw/CTmS07SobBhkBnN4pt57fRe IhYtVm17qAxD7yEObBiSpJciwDdn/iP4orDLXdhbnQO9ARPn3W2lySGEWwBks0gI vpuVqMAC5HWj2K+5217+bEaXI+w5oIGIKEz6zc4Qpfv15ZQPCg43A== From: Vishal Chourasia To: adityag@linux.ibm.com, harshpb@linux.ibm.com, milesg@linux.ibm.com, npiggin@gmail.com, peter.maydell@linaro.org, alistair23@gmail.com, balaton@eik.bme.hu, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, berrange@redhat.com Cc: Vishal Chourasia Subject: [Patch v5 3/6] hw/core/loader: add check for zero size in load_image_targphys_as Date: Tue, 21 Oct 2025 16:24:42 +0530 Message-ID: <20251021105442.1474602-7-vishalc@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251021105442.1474602-2-vishalc@linux.ibm.com> References: <20251021105442.1474602-2-vishalc@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: lGM34rt_6froou_mL19YpQ2b960sgBF0 X-Proofpoint-GUID: m_Ojn-USPqA8QCOwLFSJuWF2NoS1RZAB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMiBTYWx0ZWRfX/4bzQJJh43wY SlStUyVficisa7ABQtzc+BjRZ5eZHMDrETczdsP8tAhHW1rEuOTBoCidkDAo26iP+YyP4S227DY hh+I+zH7fDYTnN1RHtk9fpbSGU2vC08PcYn+sa2SSa+g+EMdlx3cGhPhxqecDDm6tiLdy29H8ff gsSoYBVlwVqXvGn6oEHNcqGL9X7XoQQs5rQx3M8ya5Ct1ziFh+jAF63CRV3bc69ihvJbcGuBH84 wH6zaMy7NAXhjpByLwfFOrrytOtS8jQdGab33gH2IM+hXV6CJeNS3ZEO0WoLpBBlDw61TnXuWbK pJcTC4izVhqihoSrkmSHMXrMaXheVGZjhkEju9rDNGVvBxjp1dpqM3JCl6UdDxjlqe8ebmEWc7q Rwtkq4nX58AuVKCaUEGIY2fXzPwGVQ== X-Authority-Analysis: v=2.4 cv=IJYPywvG c=1 sm=1 tr=0 ts=68f766c4 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VnNF1IyMAAAA:8 a=EMG23Z06JWfOmfJaRK0A:9 a=cPQSjfK2_nFv0Q5t_7PE:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-21_01,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 bulkscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180022 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.156.1; envelope-from=vishalc@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ibm.com) X-ZM-MESSAGEID: 1761044236840154100 Content-Type: text/plain; charset="utf-8" Currently load_image_targphys_as() returns -1 on file open failure or when max size is exceeded. Add an explicit check for zero-sized files to catch this error early, since some callers check for size <=3D 0. Signed-off-by: Vishal Chourasia --- hw/core/loader.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/core/loader.c b/hw/core/loader.c index de35e40719..e1a30da2ac 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -141,6 +141,11 @@ ssize_t load_image_targphys_as(const char *filename, return -1; } =20 + if (size =3D=3D 0) { + error_setg(errp, "empty file"); + return -1; + } + if (size > max_sz) { error_setg(errp, "%s exceeds maximum image size (%" PRIu64 " MiB)", filename, max_sz / MiB); --=20 2.51.0