From nobody Fri Oct 31 04:53:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass(p=none dis=none) header.from=collabora.com ARC-Seal: i=2; a=rsa-sha256; t=1761003802; cv=pass; d=zohomail.com; s=zohoarc; b=UTkN7Rdi8A0trTlmosCAcIIYKluOjk7C9Jhumm7lM+uEBCJKW/bVgtC0x48o7bh2Y0PhwCi8udxP+3Om6CDcFZsTMpy2qHTnylkRh03SFVTo0gq60akyz7KaMhyMNduPh5dntXXBplau/lsrQcRguFgjrFeiwoOF+KverPh3Zig= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761003802; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xoNYZD9pDu+P2E5/JLiwc710z+NNAcl0Hckzln/LmX4=; b=ihDTRE1VeH9OQbDaZgkG6JpZG7dbFuQuQ5qVpQ5tliQ/IX/Jb0+zjamVLZuvgEF9NyVDQCPvt5SF+4UJsjHIfDKlCsN1HXtGv5PZTJPeMdnpG8OAD5MacFMlh398NmcUcMBEaTb9Q8hUm9RvgUN81HBc8sBuVGdh5nyg8gT1g20= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass header.i=dmitry.osipenko@collabora.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=collabora.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1761003802661286.53007677852827; Mon, 20 Oct 2025 16:43:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vAzWx-0003dm-Uz; Mon, 20 Oct 2025 19:43:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vAzWv-0003bP-Lo for qemu-devel@nongnu.org; Mon, 20 Oct 2025 19:43:09 -0400 Received: from sender4-op-o15.zoho.com ([136.143.188.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vAzWt-0001yI-U9 for qemu-devel@nongnu.org; Mon, 20 Oct 2025 19:43:09 -0400 Received: by mx.zohomail.com with SMTPS id 1761003775334300.48194411016993; Mon, 20 Oct 2025 16:42:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1761003776; cv=none; d=zohomail.com; s=zohoarc; b=bnSDKhKbYxJoZMNbjFR5ho4i6WkLko682Z0xom/nX9y4mbpBkqFjNtH6xbA5DHBJcaGgcT+hHl2OVdJ50MAd1DMSV8qYEd8ZsbRh+SACuvzwd/FmiG5a2Huh5DYAJKiWjk00r+5cIL0MJ7dkofekGNLHl4UqZ0pGjUN4vlAcIjY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1761003776; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=xoNYZD9pDu+P2E5/JLiwc710z+NNAcl0Hckzln/LmX4=; b=AUif5b14EC+z/4gSXtHSFsxRzUsooJIGWr07KJG4m4fYzaunypXZl42uNnH3fyp9A0VKFBGl+dSWbLmbdhMaMUlkuz/kOXc8onCc8eVQS32OZkqM9UhAqww+ryXIV8tgc+JumN9vEpsbzCTCAh8+JHqH7gphEKXhlJwJupC9Ts4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=dmitry.osipenko@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1761003776; s=zohomail; d=collabora.com; i=dmitry.osipenko@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=xoNYZD9pDu+P2E5/JLiwc710z+NNAcl0Hckzln/LmX4=; b=RqC/l5bRc9mwUofHHNHMoSI56o+KEQ/TQM6jlgDTKZX/hjOITDFCFmsYE6OztW2w OU+ImxKmRaLLoyJW/qu4pcu7rxlhwzx+ybZ8bxZumVnqc7KJmPdbelcoYxeMAbRkgdf e6NLgPFINA5cw/y2jj/X06OwoZnTUaS+4FJt/DQw= From: Dmitry Osipenko To: Akihiko Odaki , Huang Rui , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierre-Eric Pelloux-Prayer , "Michael S . Tsirkin" , Paolo Bonzini Cc: Gert Wollny , qemu-devel@nongnu.org, Gurchetan Singh , Alyssa Ross , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Alex Deucher , Stefano Stabellini , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xenia Ragiadakou , Honglei Huang , Julia Zhang , Chen Jiqian , Rob Clark , Yiwei Zhang , Sergio Lopez Pascual Subject: [PATCH v14 07/10] ui/gtk: Don't disable scanout when display is refreshed Date: Tue, 21 Oct 2025 02:39:46 +0300 Message-ID: <20251020233949.506088-8-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251020233949.506088-1-dmitry.osipenko@collabora.com> References: <20251020233949.506088-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=136.143.188.15; envelope-from=dmitry.osipenko@collabora.com; helo=sender4-op-o15.zoho.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity dmitry.osipenko@collabora.com) X-ZM-MESSAGEID: 1761003805218158500 Display refreshment is invoked by a timer and it erroneously disables the active scanout if it happens to be invoked after scanout has been enabled. This offending scanout-disable race condition with a timer can be easily hit when Qemu runs with a disabled vsync by using SDL or GTK displays (with vblank_mode=3D0 for GTK). Refreshment of display's content shouldn't disable the active display. Fix it by keeping the scanout's state unchanged when display is redrawn. Reviewed-by: Akihiko Odaki Acked-by: Michael S. Tsirkin Tested-by: Alex Benn=C3=A9e Signed-off-by: Dmitry Osipenko --- ui/gtk-egl.c | 1 - ui/gtk-gl-area.c | 1 - 2 files changed, 2 deletions(-) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index ae9239999cdb..0dbb429958e5 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -180,7 +180,6 @@ void gd_egl_refresh(DisplayChangeListener *dcl) =20 if (vc->gfx.glupdates) { vc->gfx.glupdates =3D 0; - gtk_egl_set_scanout_mode(vc, false); gd_egl_draw(vc); } } diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 05fc38096eca..88496c3dbfc6 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -184,7 +184,6 @@ void gd_gl_area_refresh(DisplayChangeListener *dcl) =20 if (vc->gfx.glupdates) { vc->gfx.glupdates =3D 0; - gtk_gl_area_set_scanout_mode(vc, false); gtk_gl_area_queue_render(GTK_GL_AREA(vc->gfx.drawing_area)); } } --=20 2.51.0