From nobody Fri Nov 14 19:45:34 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1760907973; cv=none; d=zohomail.com; s=zohoarc; b=U7NI7ZgXx60bxOUAqXFqgIFzWzbGm9CR6rgsnWgd5TayFy1FtPgcB3oWDcMk8FHAUcza+uPDSwY35HrqXzFjiU6o26Pl0TGiTXpVCF8/t7Ws9NQMO4AbVwpkJssRuVAL5mpe9fl+B7GDF/8Q9+8cEQnqx4K2FR8cZjEQFC6NGpI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760907973; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WqDslS9NKjHnUWYR3Oq3CSi9/FfiBOz9NHEnZxcZS80=; b=MvNDBJmtscLFIBz7iBXJoaDQVayN1n/ZV405qc/ADbPjbs8sIeUJI7bdtVwn3JkFOnw5ppU5fCjMuBD9vdoxq0Me/Jl/KHM7RnlCVxun/8KlututKibd/vmgWpkNn3hCbbUxhTeeWFHn04C5BzxqdboYcAaFWqYQg+SqWMzM96o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760907973798763.4847548366802; Sun, 19 Oct 2025 14:06:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vAaZ2-0007Qa-Tz; Sun, 19 Oct 2025 17:03:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vAaZ0-0007P2-Tp for qemu-devel@nongnu.org; Sun, 19 Oct 2025 17:03:39 -0400 Received: from mail-ej1-x62a.google.com ([2a00:1450:4864:20::62a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1vAaYy-00021L-ES for qemu-devel@nongnu.org; Sun, 19 Oct 2025 17:03:37 -0400 Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-b456d2dc440so590934466b.0 for ; Sun, 19 Oct 2025 14:03:36 -0700 (PDT) Received: from archlinux (dynamic-002-245-026-170.2.245.pool.telefonica.de. [2.245.26.170]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-63c4945f003sm5107655a12.27.2025.10.19.14.03.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Oct 2025 14:03:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760907815; x=1761512615; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WqDslS9NKjHnUWYR3Oq3CSi9/FfiBOz9NHEnZxcZS80=; b=JdT50y4pTYhg+g9mxUO+Gozw1kBVM91ffYWoztdmf3OF5EOOVIwAAhdVGw7nXq3VRq +ved9IA+EX39WIZBOITN9Rz52QSPsdFe7EKvtZH591CYtPNskX3Z+ojApxLVdvsPXXb/ I3pCTNWnMlLwpHBZLOItgmWoMn1xQDMh0EliU2m2oAY2OVlXgRk1NBbrYsZKFnzlKnk2 /F+08VhMwVSB0Um9GJ95pcVj70eqsDTrxA/E84Cwp7Bjnal/SWeFoAhT4GafuvszG2LE RLIOcl92c67pxcj1AT4wI7Fmb82M4quQRtrE6KRaXRuxj984G2edFLxkEQvLRJrTcyYT edPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760907815; x=1761512615; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WqDslS9NKjHnUWYR3Oq3CSi9/FfiBOz9NHEnZxcZS80=; b=WUrDi+Ro8hDjtRIcBQqJEGOkxt3TcrH2Ocg/T5vDo5V/mFyc0UrvT8fJpWrFzO74/J lK8/QaXu89fXEXZn9cIR3Uu033Na7Zw+IbSAP0q/e2FyACzqCywfpE1ofALTFDVcXf5h NpggN2XhLebpAnbaKvAPKovjiHliLSfZY9kVOanCMRRYrntG6miJSGiE5X1B2ddwed4s /X1Aiok5g6j6A4t5qtfD55+0RjlY29ixNZTMn/EOPm389L7S9eKozWJTPPIgoWkwL5Cm HH/hmZB18wBF7xtvT4XXrHhOvg4ukCBpONH7da7iwvoc8+0Vt1EWMVKvU8cOiL3J0olb IrgA== X-Gm-Message-State: AOJu0Yx9KyRA0bon6AKzxkt9/tnN8ci9Z8hCpA9ZbDdy/0AB+DYye7lR O9rEWNzqcj3HUJXeiufWedO1YrlN+6h3mIDaYQcxpYiVRIonYv7TnzuJMrvDnFfo X-Gm-Gg: ASbGnctwgeVt+Rw8JFjQswINbi6u54afUxjjdmGicmgpgE9wxebsV9VNmY0QYwwuFvl WQFuxZ7sb3FmsK3I8S72zbKaOAi7WcxHRZBQvPY/lgGyDjUa3AlSHlCZ7JCuqEPueoeGmZhimfq a4mZ35T+i3amashY2/RLp7kF6q4Iba+3UVf7X5CAI4KXkTO8jDhT41GBxPjegXH/+lEupjdSAfu NqNGchrAJkGKd9fzvT+t+HJLJUzTGyRYX5ffskMyKJoQ3H2WQQiVtDFD7503RVIHHs2hF98rWx/ es2f0UqfihHmq6k8lfI/OAWvDDeBpVWJPdOvPknJoOVlr9y/6NWdLV0muvbilwS/3DI2GpGSjYC HOu5yMbQ97O5BZ0LJKA+rXkmtElZlZmgox42Cgg69LZPYBoSLngOi4gB2hrfiIemv1ZWJVbFmQK srfy0A4eZzuk6si0Jq0I8mPKkBDVqaIYRpRt/TrlwlyRugIK/NONNh55gsFdR3b56ELdpL X-Google-Smtp-Source: AGHT+IGPfPy34v/udZLQXvm5jDIXrAZ61l/oD9nGQpnV8TbdI46dqjRmVUAcVk/yLDzjHgyLvbFqIQ== X-Received: by 2002:a17:907:728c:b0:b57:5353:1032 with SMTP id a640c23a62f3a-b6472b5fab6mr1140469866b.5.1760907814623; Sun, 19 Oct 2025 14:03:34 -0700 (PDT) From: Bernhard Beschow To: qemu-devel@nongnu.org Cc: Marcel Apfelbaum , Laurent Vivier , "Michael S. Tsirkin" , Eduardo Habkost , Zhao Liu , kvm@vger.kernel.org, Michael Tokarev , Cameron Esfahani , qemu-block@nongnu.org, Paolo Bonzini , qemu-trivial@nongnu.org, Laurent Vivier , Richard Henderson , Roman Bolshakov , Phil Dennis-Jordan , John Snow , Fabiano Rosas , Gerd Hoffmann , Sunil Muthuswamy , Marcelo Tosatti , Bernhard Beschow Subject: [PATCH v3 05/10] hw/rtc/mc146818rtc: Assert correct usage of mc146818rtc_set_cmos_data() Date: Sun, 19 Oct 2025 23:02:58 +0200 Message-ID: <20251019210303.104718-6-shentey@gmail.com> X-Mailer: git-send-email 2.51.1.dirty In-Reply-To: <20251019210303.104718-1-shentey@gmail.com> References: <20251019210303.104718-1-shentey@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62a; envelope-from=shentey@gmail.com; helo=mail-ej1-x62a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1760907978222158500 Content-Type: text/plain; charset="utf-8" The offset is never controlled by the guest, so any misuse constitutes a programming error and shouldn't be silently ignored. Fix this by using asse= rt(). Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/rtc/mc146818rtc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/rtc/mc146818rtc.c b/hw/rtc/mc146818rtc.c index 5a89062b4c..8631386b9f 100644 --- a/hw/rtc/mc146818rtc.c +++ b/hw/rtc/mc146818rtc.c @@ -726,9 +726,8 @@ static uint64_t cmos_ioport_read(void *opaque, hwaddr a= ddr, =20 void mc146818rtc_set_cmos_data(MC146818RtcState *s, int addr, int val) { - if (addr >=3D 0 && addr < ARRAY_SIZE(s->cmos_data)) { - s->cmos_data[addr] =3D val; - } + assert(addr >=3D 0 && addr < ARRAY_SIZE(s->cmos_data)); + s->cmos_data[addr] =3D val; } =20 int mc146818rtc_get_cmos_data(MC146818RtcState *s, int addr) --=20 2.51.1.dirty