From nobody Fri Nov 14 16:59:37 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1760735640; cv=none; d=zohomail.com; s=zohoarc; b=OkSTOhgo/pcVLFXiSac9cIIhILnH0e0zgJ8uFVWttzFxueO8TOFbcZFcYwbcjmRaV1cyNZ7m30ef1Ley6AEf27XbsY+vLQHPg6U+jYnRoF9OjTq50yO6owOld6q5GxMFAiXrKwvr9Ml+dyDWMVkh+2HVn+1vZKilHghqYniT/50= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760735640; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=5Sbhjsngm4RxsNio2W5tuQwDo7g8V5Wa8vXSVRSbXiA=; b=bF0nfE8b0bwEFMG1yDNeDMlxaJ2QKkmOeviFs2NycpZx9ZctVkP44CXov7Z+SH/oylX/Mg2/zkzBXdt3cFPYJZZUgtaNA+ckAAkE0GSHJto4qJAWUJ1kTqQiK9DFq9vd3TneiW5fEcghogmqQaefeNUgEqFzOLM3SlBCw0ym1fM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760735640537570.2900043836761; Fri, 17 Oct 2025 14:14:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v9rka-0003q5-TJ; Fri, 17 Oct 2025 17:12:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9rkX-0003pY-BD for qemu-devel@nongnu.org; Fri, 17 Oct 2025 17:12:34 -0400 Received: from pc232-55.mailgun.net ([143.55.232.55]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v9rkT-0005ko-9z for qemu-devel@nongnu.org; Fri, 17 Oct 2025 17:12:33 -0400 Received: from mail.yodel.dev (mail.yodel.dev [35.209.39.246]) by 65586c34f6143b3160f0ced55fa49016b6000fbc8f25c7264d78fa599f872416 with SMTP id 68f2b132698b6ee81bb95cba; Fri, 17 Oct 2025 21:12:18 GMT DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mail.yodel.dev; q=dns/txt; s=pdk1; t=1760735538; x=1760742738; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Subject: Cc: To: To: From: From: Sender: Sender; bh=5Sbhjsngm4RxsNio2W5tuQwDo7g8V5Wa8vXSVRSbXiA=; b=BzBUH30JxVAYTvAfIrQ8JVYNaBe1JMaKlrr2yhYwdG5I4BxNBikQDx5jARWLBUKNbMC1ZGmfHHhMuYni8tGlje9bKBK53VSfgPgTAw2a5YG57FMGseQikqbghedbfJABie0DmjG2c3XcRZeL9WPT4NBn02ozOd04GhD0wGJn3lelUSd5/tPdW811gYC/wiTsXerAtNZJ4xjdZpEri/LDsXgeFtcdQfkEhwCgkkwCPWDW+Qjy53q/E7J+Z3ojwqzdCHQrLp/Tjh7w2lwb43fziA9fDICn/+FXLNMXO1CrX8YDTcglAbARdwJJE6VCXuYWc27hPgpc/qVNKJbRe5pWgg== X-Mailgun-Sid: WyJjZmM4NiIsInFlbXUtZGV2ZWxAbm9uZ251Lm9yZyIsIjMzZTkyMCJd X-Mailgun-Sending-Ip: 143.55.232.55 To: qemu-devel@nongnu.org Cc: Yodel Eldar , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 1/3] include/gdbstub/syscalls: Add GDB_{EIO, ENOSYS} errno values Date: Fri, 17 Oct 2025 16:11:43 -0500 Message-ID: <20251017211149.163762-2-yodel.eldar@yodel.dev> In-Reply-To: <20251017211149.163762-1-yodel.eldar@yodel.dev> References: <20251017211149.163762-1-yodel.eldar@yodel.dev> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1030; i=yodel.eldar@yodel.dev; h=from:subject; bh=x0CRH2C9uucROXz3oRf89PhjQREONSb8IRV2Yv27pjw=; b=owGbwMvMwCU29Z3/drNU3zWMp9WSGDI+reARYNuVOzdL6cwhjc+hFXxxD8XrtQNXCHRl1gWfb RLQeCjRUcrCIMbFICumyHL5rMRZh9zdXWkrf9yHmcPKBDKEgYtTACZy/Qojwwnz/m4rJSYDuS8X HRd8Edpyr0hyE2dp3rUn6oWNsxca8TH84ay8/LXj1qYDqvFtKtGyBx7V/j05+fFDB7UErx6zRYX NDAA= X-Developer-Key: i=yodel.eldar@yodel.dev; a=openpgp; fpr=D3CD18CD406DBB8A66A9F8DF95EE4FB736654DAC Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=143.55.232.55; envelope-from=bounce+c033f0.33e920-qemu-devel=nongnu.org@mail.yodel.dev; helo=pc232-55.mailgun.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Yodel Eldar From: Yodel Eldar via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1760735644041158500 Content-Type: text/plain; charset="utf-8" This patch adds the EIO and ENOSYS errno values as supported by GDB's File-I/O. Until recently, they were not documented in the relevant section of the GDB manual: https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html Signed-off-by: Yodel Eldar Reviewed-by git trailer, because the patch underwent nontrivial Reviewed-by: Richard Henderson --- include/gdbstub/syscalls.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/gdbstub/syscalls.h b/include/gdbstub/syscalls.h index d63228e96b..6200416f77 100644 --- a/include/gdbstub/syscalls.h +++ b/include/gdbstub/syscalls.h @@ -22,6 +22,7 @@ #define GDB_EPERM 1 #define GDB_ENOENT 2 #define GDB_EINTR 4 +#define GDB_EIO 5 #define GDB_EBADF 9 #define GDB_EACCES 13 #define GDB_EFAULT 14 @@ -37,6 +38,7 @@ #define GDB_ENOSPC 28 #define GDB_ESPIPE 29 #define GDB_EROFS 30 +#define GDB_ENOSYS 88 #define GDB_ENAMETOOLONG 91 #define GDB_EUNKNOWN 9999 =20 --=20 2.51.1.dirty From nobody Fri Nov 14 16:59:37 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1760735638; cv=none; d=zohomail.com; s=zohoarc; b=NQMPLgW66VM4otfcsH5G2bErq6esXsQzpK2XZJyzcAuXzHs5U5lahWq7NC/Owt8UkAFTvLtWJKaMtPpL8gSKCdybD4Fm9qV15lT45aQzgX4oyOYqa2Nd8WBST4VQNAgoWKCGXTboyCNZZakEbFnCHUwEy57BEaWHws/JDaTsUzg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760735638; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=7RaMqVq9LVHB5AkvPy1Ho3/qstErFKHAfQLACcNmNO4=; b=YPaHxQMDdQxdJ+XBhMooaryx8vFpuPzipbtsNUVq0+UNWRGkVVqAI5Gu1aYK5Y99i/AHTVLWx9vtMUKmJTBnbXmYDpCAZhthF7UsOtIhVJhB+kVP/1qXWxYF0aP4RVojEEUPo1U6PQsMYl4yYxxU3y1sfpWl8jp7Cq4dcOlHdm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760735638170281.0559460100751; Fri, 17 Oct 2025 14:13:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v9rkZ-0003pk-AC; Fri, 17 Oct 2025 17:12:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9rkW-0003pO-E2 for qemu-devel@nongnu.org; Fri, 17 Oct 2025 17:12:32 -0400 Received: from pc232-55.mailgun.net ([143.55.232.55]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v9rkT-0005kq-2u for qemu-devel@nongnu.org; Fri, 17 Oct 2025 17:12:32 -0400 Received: from mail.yodel.dev (mail.yodel.dev [35.209.39.246]) by 1001765c7195ef6bfe8cebbd019a8be688a4339ff96cc184dd076cac1911cda9 with SMTP id 68f2b13393f3c68ae8e65114; Fri, 17 Oct 2025 21:12:19 GMT DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mail.yodel.dev; q=dns/txt; s=pdk1; t=1760735539; x=1760742739; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Subject: Cc: To: To: From: From: Sender: Sender; bh=7RaMqVq9LVHB5AkvPy1Ho3/qstErFKHAfQLACcNmNO4=; b=F+zIiUSMzhMczlPV13uOHzhAtrkLlQs1StT5rKpF2p+5Lz57KzhNUwZfQ8FJzzt0fNrwQk0oIFSWYP4zmicojPuzcT8zOaKUdTEo2c4mlRCQWMAhJdBGrZ2okq4a0gomSM28e2IrsicEE3YzIDb0o3eAmt5G6kCEKeZ6lxqNzHN45q0ylIIMNsicN+ag1HjUUZwUYTHUGWmAUpUNecqiGRDiXZotqFQA4K67/TR0lzMUteC/D3uRI0Lif9U6Czs3RpcvyRzd8vZYuDtRQtbORrJevXD6YCjaCf0R6EW4aQRLYE6sT0ZqIOihE/g1fbYc2wwr0bJE7IfoKuLiLQFkng== X-Mailgun-Sid: WyJjZmM4NiIsInFlbXUtZGV2ZWxAbm9uZ251Lm9yZyIsIjMzZTkyMCJd X-Mailgun-Sending-Ip: 143.55.232.55 To: qemu-devel@nongnu.org Cc: Yodel Eldar , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier Subject: [PATCH v2 2/3] gdbstub: Export host_to_gdb_errno File-I/O helper function Date: Fri, 17 Oct 2025 16:11:44 -0500 Message-ID: <20251017211149.163762-3-yodel.eldar@yodel.dev> In-Reply-To: <20251017211149.163762-1-yodel.eldar@yodel.dev> References: <20251017211149.163762-1-yodel.eldar@yodel.dev> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3105; i=yodel.eldar@yodel.dev; h=from:subject; bh=ALPbEMOWcHQOXutuQFJZ4q+7mixc5saDwW84TXMMKCc=; b=owGbwMvMwCU29Z3/drNU3zWMp9WSGDI+reB5IKSecTpN73XWYY3dZzNNWpa19L8Lmr/d40lOw LyQxi2LOkpZGMS4GGTFFFkun5U465C7uytt5Y/7MHNYmUCGMHBxCsBEWD4z/DPLZG3tqrtXsF5f qNwj1nDWv1gjn/n/ZodUzvXotDe90M3I0Lt2nkGXxK/d58y1DjsrbYq/FK+jFnJU9PiepGVL1x0 zYQUA X-Developer-Key: i=yodel.eldar@yodel.dev; a=openpgp; fpr=D3CD18CD406DBB8A66A9F8DF95EE4FB736654DAC Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=143.55.232.55; envelope-from=bounce+c033f0.33e920-qemu-devel=nongnu.org@mail.yodel.dev; helo=pc232-55.mailgun.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Yodel Eldar From: Yodel Eldar via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1760735641717154100 Content-Type: text/plain; charset="utf-8" Move host_to_gdb_errno from target/m68k/m68k-semi.c to gdbstub/syscalls.c. Declare it in include/gdbstub/syscalls.h. Add both newly added GDB File-I/O supported errno values, EIO and ENOSYS, to the mapping. Signed-off-by: Yodel Eldar Reviewed-by git trailer, because the patch underwent nontrivial Reviewed-by: Richard Henderson --- gdbstub/syscalls.c | 36 ++++++++++++++++++++++++++++++++++++ include/gdbstub/syscalls.h | 9 +++++++++ target/m68k/m68k-semi.c | 29 ----------------------------- 3 files changed, 45 insertions(+), 29 deletions(-) diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c index e855df21ab..b166f4cc77 100644 --- a/gdbstub/syscalls.c +++ b/gdbstub/syscalls.c @@ -145,6 +145,42 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const = char *fmt, ...) gdb_syscall_handling(gdbserver_syscall_state.syscall_buf); } =20 +/* + * Map host error numbers to their GDB protocol counterparts. + * For the list of GDB File-I/O supported error numbers, please consult: + * https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html + */ +int host_to_gdb_errno(int err) +{ +#define E(X) case E##X: return GDB_E##X + switch (err) { + E(PERM); + E(NOENT); + E(INTR); + E(IO); + E(BADF); + E(ACCES); + E(FAULT); + E(BUSY); + E(EXIST); + E(NODEV); + E(NOTDIR); + E(ISDIR); + E(INVAL); + E(NFILE); + E(MFILE); + E(FBIG); + E(NOSPC); + E(SPIPE); + E(ROFS); + E(NOSYS); + E(NAMETOOLONG); + default: + return GDB_EUNKNOWN; + } +#undef E +} + /* * GDB Command Handlers */ diff --git a/include/gdbstub/syscalls.h b/include/gdbstub/syscalls.h index 6200416f77..a09559128b 100644 --- a/include/gdbstub/syscalls.h +++ b/include/gdbstub/syscalls.h @@ -102,6 +102,15 @@ void gdb_do_syscall(gdb_syscall_complete_cb cb, const = char *fmt, ...); */ int use_gdb_syscalls(void); =20 +/** + * host_to_gdb_errno: convert host errno to GDB errno value + * @err: errno from host + * + * Given an error number from the host, this helper function returns + * its GDB File-I/O specified representation. + */ +int host_to_gdb_errno(int err); + /** * gdb_exit: exit gdb session, reporting inferior status * @code: exit code reported diff --git a/target/m68k/m68k-semi.c b/target/m68k/m68k-semi.c index 6fbbd140f3..e33fd6fedd 100644 --- a/target/m68k/m68k-semi.c +++ b/target/m68k/m68k-semi.c @@ -46,35 +46,6 @@ #define HOSTED_ISATTY 12 #define HOSTED_SYSTEM 13 =20 -static int host_to_gdb_errno(int err) -{ -#define E(X) case E##X: return GDB_E##X - switch (err) { - E(PERM); - E(NOENT); - E(INTR); - E(BADF); - E(ACCES); - E(FAULT); - E(BUSY); - E(EXIST); - E(NODEV); - E(NOTDIR); - E(ISDIR); - E(INVAL); - E(NFILE); - E(MFILE); - E(FBIG); - E(NOSPC); - E(SPIPE); - E(ROFS); - E(NAMETOOLONG); - default: - return GDB_EUNKNOWN; - } -#undef E -} - static void m68k_semi_u32_cb(CPUState *cs, uint64_t ret, int err) { CPUM68KState *env =3D cpu_env(cs); --=20 2.51.1.dirty From nobody Fri Nov 14 16:59:37 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1760735640; cv=none; d=zohomail.com; s=zohoarc; b=aj7nqjmyOaQ3S+EEvfrKQ4Hn38TT+vJaMTUjLimNByEzWEkVyQ8A68zYFNuuY9rMlebvlqQfPToxHUq3NNihz1HBi1po4tPgJhHrY9B3wqHTqK7x3tMyRZuJ0HoT+22j7Oi+l+rPyqTBBUp7MdUcQDjILvumzPDfo8YFWIg0bKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760735640; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=V2QwT0iEj1rNE2XxLHsxUmoaqZnzVqzzJbOqYQWXuv8=; b=j43+0kFLWTQ4pxGdQXFa97yyIyy1nLfgYLwlVwc2lZne8b72T0+idq95lgmRuR1MrRrmhZJfoZy3OPLlA6M/KwPARD5GgMXj9I6L9b9Knm68ZIAHFOtR7RODgcpPCbyB/IG0ddP9W9Qcf71kH8Yuqzs2XrJQDnj0DkqFPBos3dc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176073564019454.71919207123017; Fri, 17 Oct 2025 14:14:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v9rkb-0003qT-2r; Fri, 17 Oct 2025 17:12:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9rkX-0003pZ-M0 for qemu-devel@nongnu.org; Fri, 17 Oct 2025 17:12:34 -0400 Received: from pc232-55.mailgun.net ([143.55.232.55]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v9rkT-0005ku-33 for qemu-devel@nongnu.org; Fri, 17 Oct 2025 17:12:33 -0400 Received: from mail.yodel.dev (mail.yodel.dev [35.209.39.246]) by ab8633fbac176f2aee457eaa601272b9130470064ab5fa536c6b5351319b4c45 with SMTP id 68f2b1337813828cce311e11; Fri, 17 Oct 2025 21:12:19 GMT DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mail.yodel.dev; q=dns/txt; s=pdk1; t=1760735540; x=1760742740; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Subject: Cc: To: To: From: From: Sender: Sender; bh=V2QwT0iEj1rNE2XxLHsxUmoaqZnzVqzzJbOqYQWXuv8=; b=YQ+EK4JZS7Q2KmfpvTSD7e0+RvLtaAoyNX3FE9Rwiu/+xXsxpRQ1SVZkHTN3c51RJBV+Jj62sJXXElKpgfr0iIl2L8RtBLIsEG0r7pQQERxnQBd10gxZsXA/Mx1n2Vv27+7KyrECZd3NvhPV1Vg8F6vxPjlib4VzzEOAaDWqjoHH8eYW+QBlxKQWGYhvA65+gDd93gsFjjt3NVS1rrbN4Ddx5GcXfHRzHli8tLIrqie4GGBKSu0U72ze+FDTA/imFPutafCFA0xhr9FBO6m1OacjiQHIFFEuoMwXi4+O7FpF6YBdkigNpUAdRUu1kngMGDHLHcBjnTlpg5UtzUo8JA== X-Mailgun-Sid: WyJjZmM4NiIsInFlbXUtZGV2ZWxAbm9uZ251Lm9yZyIsIjMzZTkyMCJd X-Mailgun-Sending-Ip: 143.55.232.55 To: qemu-devel@nongnu.org Cc: Yodel Eldar , Dominik 'Disconnect3d' Czarnota , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 3/3] gdbstub/user-target: Convert host errno to GDB File-I/O errno Date: Fri, 17 Oct 2025 16:11:45 -0500 Message-ID: <20251017211149.163762-4-yodel.eldar@yodel.dev> In-Reply-To: <20251017211149.163762-1-yodel.eldar@yodel.dev> References: <20251017211149.163762-1-yodel.eldar@yodel.dev> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2469; i=yodel.eldar@yodel.dev; h=from:subject; bh=fRlpSe6mPp7oCWAdGXRMZBW1yxjFM0brX70zX9dxEDw=; b=owGbwMvMwCU29Z3/drNU3zWMp9WSGDI+reDhi/66ZCW/9afpmlcKO3c1//upFXv3o9SWrJ2dk 8tt6hbbdZSyMIhxMciKKbJcPitx1iF3d1fayh/3YeawMoEMYeDiFICJbJvK8L+8T8s5M/k17/9t OoZs+ktrj0etX5vfH/u6kuutiNxMpouMDFfixTq/Hm488ap2UkT/xuthmbseTPr9e9Gxqc9FD6S ZT+QAAA== X-Developer-Key: i=yodel.eldar@yodel.dev; a=openpgp; fpr=D3CD18CD406DBB8A66A9F8DF95EE4FB736654DAC Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=143.55.232.55; envelope-from=bounce+c033f0.33e920-qemu-devel=nongnu.org@mail.yodel.dev; helo=pc232-55.mailgun.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Yodel Eldar From: Yodel Eldar via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1760735642064158500 Content-Type: text/plain; charset="utf-8" Use host_to_gdb_errno to convert host-supplied errnos to their GDB File-I/O remote protocol values, and use them in F reply packets. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2751 Reported-by: Dominik 'Disconnect3d' Czarnota Signed-off-by: Yodel Eldar Reviewed-by git trailer, because the patch underwent nontrivial --- gdbstub/user-target.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/gdbstub/user-target.c b/gdbstub/user-target.c index 43231e695e..7ef0282f70 100644 --- a/gdbstub/user-target.c +++ b/gdbstub/user-target.c @@ -10,6 +10,7 @@ #include "qemu/osdep.h" #include "exec/gdbstub.h" #include "gdbstub/commands.h" +#include "gdbstub/syscalls.h" #include "qemu.h" #include "internals.h" #ifdef CONFIG_LINUX @@ -315,7 +316,8 @@ void gdb_handle_v_file_open(GArray *params, void *user_= ctx) int fd =3D open(filename, flags, mode); #endif if (fd < 0) { - g_string_printf(gdbserver_state.str_buf, "F-1,%x", errno); + int gdb_errno =3D host_to_gdb_errno(errno); + g_string_printf(gdbserver_state.str_buf, "F-1,%x", gdb_errno); } else { g_string_printf(gdbserver_state.str_buf, "F%x", fd); } @@ -327,7 +329,8 @@ void gdb_handle_v_file_close(GArray *params, void *user= _ctx) int fd =3D gdb_get_cmd_param(params, 0)->val_ul; =20 if (close(fd) =3D=3D -1) { - g_string_printf(gdbserver_state.str_buf, "F-1,%x", errno); + int gdb_errno =3D host_to_gdb_errno(errno); + g_string_printf(gdbserver_state.str_buf, "F-1,%x", gdb_errno); gdb_put_strbuf(); return; } @@ -350,7 +353,8 @@ void gdb_handle_v_file_pread(GArray *params, void *user= _ctx) =20 ssize_t n =3D pread(fd, buf, bufsiz, offset); if (n < 0) { - g_string_printf(gdbserver_state.str_buf, "F-1,%x", errno); + int gdb_errno =3D host_to_gdb_errno(errno); + g_string_printf(gdbserver_state.str_buf, "F-1,%x", gdb_errno); gdb_put_strbuf(); return; } @@ -373,7 +377,8 @@ void gdb_handle_v_file_readlink(GArray *params, void *u= ser_ctx) ssize_t n =3D readlink(filename, buf, BUFSIZ); #endif if (n < 0) { - g_string_printf(gdbserver_state.str_buf, "F-1,%x", errno); + int gdb_errno =3D host_to_gdb_errno(errno); + g_string_printf(gdbserver_state.str_buf, "F-1,%x", gdb_errno); gdb_put_strbuf(); return; } --=20 2.51.1.dirty