From nobody Fri Nov 14 18:19:57 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1760701904; cv=none; d=zohomail.com; s=zohoarc; b=Wgai1X5xv6iBm3nxDTUR9hLfv8Q+A0wPERkZE7JETdd6rWuA802FFGqWn5gpjTGIDu94BvCJrVnH9ztfRe0J8o4ltEqL2kNX6cOM3mfXR/KTaAmrt8ysQyn9vhymHd96HYbQO0uPpxDGrX7CVC9Q2xybsFNUiIKP8wLjCeaCaNg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760701904; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7D0hQz6CMWKShm3bh3hBUjaMBV63w8hQjqgtINS4wqs=; b=cTVUnLINBLwdjlWNAKMSvd9o4l039+GgJ1Gkns64If97MR8tw/hKVNwtIcahA0aydqTl4cxZw8od1JQSVODu7JvTAVHuyAUg45CrqYqeKrDgwSBWMlmTjVLcnxadQhsOET8mNabTotgEwp3APn8M9LTNIvBkjr4V1quh0K0Yz20= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760701904199875.9767962986105; Fri, 17 Oct 2025 04:51:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v9iye-0002JK-Dq; Fri, 17 Oct 2025 07:50:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9iyc-0002It-0C for qemu-devel@nongnu.org; Fri, 17 Oct 2025 07:50:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9iyT-00084u-Uy for qemu-devel@nongnu.org; Fri, 17 Oct 2025 07:50:29 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-1-u0xcLB6mPxKeUXsU2X3kFw-1; Fri, 17 Oct 2025 07:50:14 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A29D2195608D; Fri, 17 Oct 2025 11:50:12 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.44.32.27]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8EFE71956056; Fri, 17 Oct 2025 11:50:11 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 463B518000BA; Fri, 17 Oct 2025 13:50:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760701819; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7D0hQz6CMWKShm3bh3hBUjaMBV63w8hQjqgtINS4wqs=; b=LnAvImhhRElFJ6LY09gecYeL+X8DH/Ro+OpPwSLPUmwHIQhLExJNxZmDOeuY099QW7l7P2 RsR/vbSAPtQtPN0c2F9/5FEXi8armfA0PeXpSdITrOInLFmQzFL2zAEaoPHyIuNv2LH4A7 KRqYDNaJBGxdli5aML/wEgyULj09czk= X-MC-Unique: u0xcLB6mPxKeUXsU2X3kFw-1 X-Mimecast-MFC-AGG-ID: u0xcLB6mPxKeUXsU2X3kFw_1760701812 From: Gerd Hoffmann To: qemu-devel@nongnu.org Cc: Eric Blake , Marcel Apfelbaum , Eduardo Habkost , Zhao Liu , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Gerd Hoffmann , Paolo Bonzini , Fabiano Rosas , "Dr. David Alan Gilbert" , Yanan Wang , Markus Armbruster Subject: [PATCH v6 2/3] hw/uefi: add 'info firmware-log' hmp monitor command. Date: Fri, 17 Oct 2025 13:50:04 +0200 Message-ID: <20251017115006.2696991-3-kraxel@redhat.com> In-Reply-To: <20251017115006.2696991-1-kraxel@redhat.com> References: <20251017115006.2696991-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1760701907422158500 Content-Type: text/plain; charset="utf-8" This adds the hmp variant of the query-firmware-log qmp command. Signed-off-by: Gerd Hoffmann Reviewed-by: Markus Armbruster --- include/monitor/hmp.h | 1 + hw/uefi/ovmf-log.c | 27 +++++++++++++++++++++++++++ hmp-commands-info.hx | 13 +++++++++++++ 3 files changed, 41 insertions(+) diff --git a/include/monitor/hmp.h b/include/monitor/hmp.h index 897dfaa2b6d9..83721b5ffc6d 100644 --- a/include/monitor/hmp.h +++ b/include/monitor/hmp.h @@ -179,5 +179,6 @@ void hmp_boot_set(Monitor *mon, const QDict *qdict); void hmp_info_mtree(Monitor *mon, const QDict *qdict); void hmp_info_cryptodev(Monitor *mon, const QDict *qdict); void hmp_dumpdtb(Monitor *mon, const QDict *qdict); +void hmp_info_firmware_log(Monitor *mon, const QDict *qdict); =20 #endif diff --git a/hw/uefi/ovmf-log.c b/hw/uefi/ovmf-log.c index 0d4bd503a06a..fe8acbd19236 100644 --- a/hw/uefi/ovmf-log.c +++ b/hw/uefi/ovmf-log.c @@ -231,3 +231,30 @@ FirmwareLog *qmp_query_firmware_log(Error **errp) ret->log =3D g_base64_encode((const guchar *)log->str, log->len); return ret; } + +void hmp_info_firmware_log(Monitor *mon, const QDict *qdict) +{ + g_autofree gchar *log_esc =3D NULL; + g_autofree guchar *log_out =3D NULL; + Error *err =3D NULL; + FirmwareLog *log; + gsize log_len; + + log =3D qmp_query_firmware_log(&err); + if (err) { + hmp_handle_error(mon, err); + return; + } + + g_assert(log !=3D NULL); + g_assert(log->log !=3D NULL); + + if (log->version) { + g_autofree gchar *esc =3D g_strescape(log->version, NULL); + monitor_printf(mon, "[ firmware version: %s ]\n", esc); + } + + log_out =3D g_base64_decode(log->log, &log_len); + log_esc =3D g_strescape((gchar *)log_out, "\r\n"); + monitor_printf(mon, "%s\n", log_esc); +} diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 25b4aed51f56..33cf740bbc1b 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -995,3 +995,16 @@ SRST ``info cryptodev`` Show the crypto devices. ERST + + { + .name =3D "firmware-log", + .args_type =3D "", + .params =3D "", + .help =3D "show the firmware (ovmf) debug log", + .cmd =3D hmp_info_firmware_log, + }, + +SRST + ``info firmware-log`` + Show the firmware (ovmf) debug log. +ERST --=20 2.51.0