From nobody Fri Nov 14 21:05:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1760615483; cv=none; d=zohomail.com; s=zohoarc; b=mNi5gNlWa/qa3SEecD5fQNyWd6NYpGbPKMhRqC0iajGomJ10SFdgpwwd5nvB2e3Fs5aF/yhOCgBeltU+5IQzzK68ZJRs9wj+zGZMYFFJpb2A5B0hrF5ASVYSGzt7n3BJv0/jJKXweQtB0w/vTkpwhSDpzAEtPCCIthv2lkSINps= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760615483; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CfhYPdDYFOJ4e5JUBvq3LuUdv3/kmqX/+3b/YXayICo=; b=ECrfOCD/9WUDsHvt4IqpLMcGco81vUrKnL6uMUd9a615MmuksIS7JsVr8WsmZE9Z9w/aqYCMulhFFDMZYsmcWPhz/WzY9zhjW4+9LgS0hy5QH/BOoellvYxWHM6AtTSDnzgxQE0VNWq7QT/hHepckxLdCB4duqFDiYxpioGsmH0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760615483623489.2688640393143; Thu, 16 Oct 2025 04:51:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v9MNV-0007No-OO; Thu, 16 Oct 2025 07:42:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9MMa-000759-J1; Thu, 16 Oct 2025 07:41:44 -0400 Received: from forwardcorp1a.mail.yandex.net ([178.154.239.72]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v9MMS-0003T4-BH; Thu, 16 Oct 2025 07:41:42 -0400 Received: from mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net [IPv6:2a02:6b8:c1f:3a87:0:640:845c:0]) by forwardcorp1a.mail.yandex.net (Yandex) with ESMTPS id F15A2C01B6; Thu, 16 Oct 2025 14:41:23 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:a8c::1:19]) by mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id LfP2M73FEmI0-miagcnfi; Thu, 16 Oct 2025 14:41:23 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1760614883; bh=CfhYPdDYFOJ4e5JUBvq3LuUdv3/kmqX/+3b/YXayICo=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=zjmQvNXa10TTR0yKPhfPwBcD6OSuEK6RTnsIkM5zrcCWo+iGH/T1SRKko4ClU5UAy PhSsmLH9FTGaUx0giQgBMfXytg87HLUtxqhuSiNsm/D4pAbLuQkLQMJfMn7TA7m/TN RcK7xepRFCUePAuTdF+e0UDj/xgOji2JJJV8yK7Y= Authentication-Results: mail-nwsmtp-smtp-corp-main-69.vla.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: raphael@enfabrica.net, pbonzini@redhat.com, farosas@suse.de Cc: mst@redhat.com, sgarzare@redhat.com, marcandre.lureau@redhat.com, kwolf@redhat.com, hreitz@redhat.com, berrange@redhat.com, eblake@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org, steven.sistare@oracle.com, vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru, jasowang@redhat.com Subject: [PATCH v2 01/25] vhost: store busyloop_timeout into struct vhost_dev Date: Thu, 16 Oct 2025 14:40:38 +0300 Message-ID: <20251016114104.1384675-2-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251016114104.1384675-1-vsementsov@yandex-team.ru> References: <20251016114104.1384675-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.72; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1a.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1760615490800158500 Content-Type: text/plain; charset="utf-8" We'll split vhost_dev_init() into _init() and _connect(), to be able to postpone communication with backend, to support backend-transfer migration of vhost-user-blk in future commit. So, instead of passing it through parameters, store it in vhost_dev structure. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Raphael Norwitz --- hw/virtio/vhost.c | 11 +++++------ include/hw/virtio/vhost.h | 1 + 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 7ba90c24db..9fc6e7ba65 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1501,8 +1501,7 @@ static void vhost_virtqueue_error_notifier(EventNotif= ier *n) } =20 static int vhost_virtqueue_init(struct vhost_dev *dev, - struct vhost_virtqueue *vq, int n, - bool busyloop_timeout) + struct vhost_virtqueue *vq, int n) { int vhost_vq_index =3D dev->vhost_ops->vhost_get_vq_index(dev, n); struct vhost_vring_file file =3D { @@ -1539,8 +1538,8 @@ static int vhost_virtqueue_init(struct vhost_dev *dev, vhost_virtqueue_error_notifier); } =20 - if (busyloop_timeout) { - r =3D vhost_virtqueue_set_busyloop_timeout(dev, n, busyloop_timeou= t); + if (dev->busyloop_timeout) { + r =3D vhost_virtqueue_set_busyloop_timeout(dev, n, dev->busyloop_t= imeout); if (r < 0) { VHOST_OPS_DEBUG(r, "Failed to set busyloop timeout"); goto fail_err; @@ -1628,6 +1627,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaq= ue, =20 hdev->vdev =3D NULL; hdev->migration_blocker =3D NULL; + hdev->busyloop_timeout =3D busyloop_timeout; =20 r =3D vhost_set_backend_type(hdev, backend_type); assert(r >=3D 0); @@ -1650,8 +1650,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaq= ue, } =20 for (i =3D 0; i < hdev->nvqs; ++i, ++n_initialized_vqs) { - r =3D vhost_virtqueue_init(hdev, hdev->vqs + i, hdev->vq_index + i, - busyloop_timeout); + r =3D vhost_virtqueue_init(hdev, hdev->vqs + i, hdev->vq_index + i= ); if (r < 0) { error_setg_errno(errp, -r, "Failed to initialize virtqueue %d"= , i); goto fail; diff --git a/include/hw/virtio/vhost.h b/include/hw/virtio/vhost.h index 1ba1af1d86..f1a7e7b971 100644 --- a/include/hw/virtio/vhost.h +++ b/include/hw/virtio/vhost.h @@ -105,6 +105,7 @@ struct vhost_dev { VIRTIO_DECLARE_FEATURES(_features); VIRTIO_DECLARE_FEATURES(acked_features); =20 + uint32_t busyloop_timeout; uint64_t max_queues; uint64_t backend_cap; /* @started: is the vhost device started? */ --=20 2.48.1