From nobody Fri Nov 14 18:21:34 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1760525764; cv=none; d=zohomail.com; s=zohoarc; b=WnCSmLQsr1e9vyccehvIvn7xrpKsPpS0C8CCtp5pw/32dy11lryet9d/BB1Zx8007YjT2Uqvlpqm8ZWsfL2mnueWHZ8xl6dZpqAq2Pkq+VcrOxhLNo6QxWCRNBg5o202rIGfHnybTJOff0rhIhJoZRNpTTctKWgStqUCXdL/III= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760525764; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3zVtH0qCGKpNT+qP1Z8g653PyrNRWy7b40fBpybhARc=; b=cBYCx+UbR7GlDCJWUcKyOoxK2pGP/NQFHUmch5Z8pTUotNL/alLnT8oiTL317NoWKc9JHyPFjKVPXLqRb+Ss8zxmEuCKhL8JJvh7TBiQRF9SJoDrMjvVtfLIT9AF7BkW+DrSJqLEpo+RPf2TtASW+jm67JczPxVDo4FqaRdtPXw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760525764271832.6223156039124; Wed, 15 Oct 2025 03:56:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8z9b-0006g6-0n; Wed, 15 Oct 2025 06:54:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8z9Z-0006fk-Fh for qemu-devel@nongnu.org; Wed, 15 Oct 2025 06:54:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8z9O-0005uQ-8p for qemu-devel@nongnu.org; Wed, 15 Oct 2025 06:54:43 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-553-fj8n1LK4OPim_nSgfFssjA-1; Wed, 15 Oct 2025 06:54:25 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9641319560B7; Wed, 15 Oct 2025 10:54:24 +0000 (UTC) Received: from localhost (unknown [10.45.242.3]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 4F03D180044F; Wed, 15 Oct 2025 10:54:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760525668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3zVtH0qCGKpNT+qP1Z8g653PyrNRWy7b40fBpybhARc=; b=KFd0t55lt0x1L+GT32elwR3wyUiS6rwMsZsxUJz2lWcRfg0yP2/zL/UULKUzfiThQW9dTH 61yOkMQBKOZpKSze40aga2GA9c7qMUx1cUPsrg5lUgdqYH1O46vPAx/wPdXf6o43Pw/2sO 8u96S5e3sfHL1OqoB8hn+HK0r9Hn7yE= X-MC-Unique: fj8n1LK4OPim_nSgfFssjA-1 X-Mimecast-MFC-AGG-ID: fj8n1LK4OPim_nSgfFssjA_1760525664 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost Subject: [PATCH] RFC: qdev: add legacy properties only for those print()-able Date: Wed, 15 Oct 2025 14:54:19 +0400 Message-ID: <20251015105419.2975542-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1760525781064158500 From: Marc-Andr=C3=A9 Lureau The link properties are not printed in "info qtree", I don't know if this was intentional. We currently register legacy properties for link/ptr properties, but they don't have PropertyInfo getters (only ObjectPropertyAccessor, when using non-legacy properties) By not registering a (unusable?) legacy property, "info qtree" can now print the link. Signed-off-by: Marc-Andr=C3=A9 Lureau --- hw/core/qdev-properties.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index b7e8a89ba5..fe260a9670 100644 --- a/hw/core/qdev-properties.c +++ b/hw/core/qdev-properties.c @@ -1143,14 +1143,13 @@ static void qdev_class_add_legacy_property(DeviceCl= ass *dc, const Property *prop { g_autofree char *name =3D NULL; =20 - /* Register pointer properties as legacy properties */ - if (!prop->info->print && prop->info->get) { + if (!prop->info->print) { return; } =20 name =3D g_strdup_printf("legacy-%s", prop->name); object_class_property_add(OBJECT_CLASS(dc), name, "str", - prop->info->print ? qdev_get_legacy_property : prop->info->get, + qdev_get_legacy_property, NULL, NULL, (Property *)prop); } =20 --=20 2.51.0