From nobody Mon Oct 27 01:14:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1760491221; cv=none; d=zohomail.com; s=zohoarc; b=eKgCSMHhqqVZYCkc4nMCZ0Wl7U4q/9vQph+AhwHtqnIgkQyeokgzdti4b76AowQZ9LfQFz8EsIZaQnmNH/7g2rLATSmYdioDLTv47hkA/acEoTGbBinAAo3uOGPxTA2W+WkHdgRqkT6UAs1zQngxeMX4LTd0Uq0ODz3QEWZ2BlQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760491221; h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=br1b472i1wUs/pSTcxpYafrcAix2wuzSuhGHbD2r6is=; b=RQD+I+QMZusJmtKAbCwMv9/2sw2TCdMyGuFUosy4xynvWMTNlTF2Mml1V1RhlKvFeLjkCNfgDE+GYfNEYnlAciTVGgEYVHt7oW4wJ+jPmWMitva17fDVO2MHf3I+UPhgux4+uKgrzUCTk/nCNfgvh2uJx9/z2soJsP2WO6eH1Kg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176049122135344.58817599545239; Tue, 14 Oct 2025 18:20:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8qA6-0000Pn-PJ; Tue, 14 Oct 2025 21:18:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3a_buaAkKCmILIXIAOYANGOOGLE.COMQEMU-DEVELNONGNU.ORG@flex--lixiaoyan.bounces.google.com>) id 1v8qA5-0000Oe-8E for qemu-devel@nongnu.org; Tue, 14 Oct 2025 21:18:41 -0400 Received: from mail-pf1-x44a.google.com ([2607:f8b0:4864:20::44a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3a_buaAkKCmILIXIAOYANGOOGLE.COMQEMU-DEVELNONGNU.ORG@flex--lixiaoyan.bounces.google.com>) id 1v8qA1-0003CX-Rr for qemu-devel@nongnu.org; Tue, 14 Oct 2025 21:18:40 -0400 Received: by mail-pf1-x44a.google.com with SMTP id d2e1a72fcca58-7900f597d08so8378330b3a.1 for ; Tue, 14 Oct 2025 18:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1760491115; x=1761095915; darn=nongnu.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=br1b472i1wUs/pSTcxpYafrcAix2wuzSuhGHbD2r6is=; b=XxiI9HYMZTh3lWtTqjXNgfDEwm5BZ6/9gl3y0s5aTO6wJPRPjW6cYNgyvrFS9FmyVw ZML/Ml9CcGjk47PLudmj5xHT/l41SZmzzAsJuMk5fZAc4v/MukPrezd6ZgREce1kMxh1 EH8vQjk++i8ofS9TFda3KPJTv8IN5EHZv1YBseKg6UAaRJ/3cKFqmU3xcYAWJZJZNep8 csdEZE+jlcbpybizY6AMU91sRJhRP1iNsvkaDXHJc1uw252vmFfyRAlR2kq/LD1TWX4x WWf+LlxNFMHZ40RBR6TgoGjfmC435W3fzg6yJWV6FV29AZGqExFDrJY6KQ9hQ5YmxiTY HjEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760491115; x=1761095915; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=br1b472i1wUs/pSTcxpYafrcAix2wuzSuhGHbD2r6is=; b=YTKpL34/IdpXfUwm6SyuyUisEMyjAT37triJ09vUlVtnCpXMD3Y4aFVws7Meg9ee+1 ARNQyHffGyTEmCAlNmN1xO9JZKhsMfh0qPIRPB3RioqLrGwteNUWwD5s1cSnFe0rCYsa Ozv1yBrE1qBSHR2PE1a9QHWjNYORo5DZ2BQyTsk6f6RGEEbZTN9WsLJxQRUVMapm2QXM eyl1pvsR3J3FX58b/XydpZcvWGqkFwsGkMFwv0MfsBUAzClKcaChdOOXVxni3jfsnfgf h2XHs+oLEgFt3H1AAe5v+T93oBOj89wNCo07gqPi5AparOAATpl+kXWWigNOCmKP9B1r 5EHQ== X-Forwarded-Encrypted: i=1; AJvYcCU+IxekBmTCs669yryvEuExbYeNKhfqYB9SG5ng7/u4djqUmgEElrUMjJ0gUY96tMvhcK06irqwD+z3@nongnu.org X-Gm-Message-State: AOJu0YwAJe4kDeip5KocF7HnZGOZVd26AwcHYXFCtuozBx/MzH02rYCn lVxlI+fHnbd7MxuNCLQSbhKgPwnzuLq3hZYFTwHmjv2nKKXhD5XSU0MljJjv6rm827N2F72LC35 NvrTzcgc1TK1+Bt2uFQ== X-Google-Smtp-Source: AGHT+IHbk/xA1p5r1qAbvU3M8yXXgmw/JxqWiFcRjPO95okkaM3zslpG4i9/gx+EzUEtjArn8d56QLt19ZZROyc= X-Received: from pjzb22.prod.google.com ([2002:a17:90a:e396:b0:338:3770:a496]) (user=lixiaoyan job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:3383:b0:2f1:a8f0:9631 with SMTP id adf61e73a8af0-32da80bb5fcmr35583758637.10.1760491115532; Tue, 14 Oct 2025 18:18:35 -0700 (PDT) Date: Wed, 15 Oct 2025 01:18:25 +0000 In-Reply-To: <20251015011830.1688468-1-lixiaoyan@google.com> Mime-Version: 1.0 References: <20251015011830.1688468-1-lixiaoyan@google.com> X-Mailer: git-send-email 2.51.0.788.g6d19910ace-goog Message-ID: <20251015011830.1688468-2-lixiaoyan@google.com> Subject: [PATCH v2 1/5] hw/gpio: Add property for ASPEED GPIO in 32 bits basis From: Coco Li To: peter.maydell@linaro.org, clg@kaod.org Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, lixiaoyan@google.com, flwu@google.com, andrew@codeconstruct.com.au, philmd@linaro.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::44a; envelope-from=3a_buaAkKCmILIXIAOYANGOOGLE.COMQEMU-DEVELNONGNU.ORG@flex--lixiaoyan.bounces.google.com; helo=mail-pf1-x44a.google.com X-Spam_score_int: -88 X-Spam_score: -8.9 X-Spam_bar: -------- X-Spam_report: (-8.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.269, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_FROM=0.998, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @google.com) X-ZM-MESSAGEID: 1760491224212158500 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Felix Wu Added 32 bits property for ASPEED GPIO. Previously it can only be access in= bitwise manner. The changes to qobject is to index gpios with array indices on top of acces= sing with registers. This allows for easier gpio access, especially in tests with complex behavi= ors that requires large number of gpios at a time, like fault injection and= networking behaviors. Indexing multiple gpios at once allows qmp/side band client to no longer ha= rdcode and populate register names and manipulate them faster. Signed-off-by: Felix Wu Reviewed-by: Andrew Jeffery --- hw/gpio/aspeed_gpio.c | 57 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) diff --git a/hw/gpio/aspeed_gpio.c b/hw/gpio/aspeed_gpio.c index 609a556908..2d78bf9515 100644 --- a/hw/gpio/aspeed_gpio.c +++ b/hw/gpio/aspeed_gpio.c @@ -1308,6 +1308,57 @@ static void aspeed_gpio_2700_write(void *opaque, hwa= ddr offset, } =20 /* Setup functions */ +static void aspeed_gpio_set_set(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + uint32_t set_val =3D 0; + AspeedGPIOState *s =3D ASPEED_GPIO(obj); + AspeedGPIOClass *agc =3D ASPEED_GPIO_GET_CLASS(s); + int set_idx =3D 0; + + if (!visit_type_uint32(v, name, &set_val, errp)) { + return; + } + + if (sscanf(name, "gpio-set[%d]", &set_idx) !=3D 1) { + error_setg(errp, "%s: error reading %s", __func__, name); + return; + } + + if (set_idx >=3D agc->nr_gpio_sets || set_idx < 0) { + error_setg(errp, "%s: invalid set_idx %s", __func__, name); + return; + } + + aspeed_gpio_update(s, &s->sets[set_idx], set_val, + ~s->sets[set_idx].direction); +} + +static void aspeed_gpio_get_set(Object *obj, Visitor *v, + const char *name, void *opaque, + Error **errp) +{ + uint32_t set_val =3D 0; + AspeedGPIOState *s =3D ASPEED_GPIO(obj); + AspeedGPIOClass *agc =3D ASPEED_GPIO_GET_CLASS(s); + int set_idx =3D 0; + + if (sscanf(name, "gpio-set[%d]", &set_idx) !=3D 1) { + error_setg(errp, "%s: error reading %s", __func__, name); + return; + } + + if (set_idx >=3D agc->nr_gpio_sets || set_idx < 0) { + error_setg(errp, "%s: invalid set_idx %s", __func__, name); + return; + } + + set_val =3D s->sets[set_idx].data_value; + visit_type_uint32(v, name, &set_val, errp); +} + +/****************** Setup functions ******************/ static const GPIOSetProperties ast2400_set_props[ASPEED_GPIO_MAX_NR_SETS] = =3D { [0] =3D {0xffffffff, 0xffffffff, {"A", "B", "C", "D"} }, [1] =3D {0xffffffff, 0xffffffff, {"E", "F", "G", "H"} }, @@ -1435,6 +1486,12 @@ static void aspeed_gpio_init(Object *obj) g_free(name); } } + + for (int i =3D 0; i < agc->nr_gpio_sets; i++) { + char *name =3D g_strdup_printf("gpio-set[%d]", i); + object_property_add(obj, name, "uint32", aspeed_gpio_get_set, + aspeed_gpio_set_set, NULL, NULL); + } } =20 static const VMStateDescription vmstate_gpio_regs =3D { --=20 2.51.0.788.g6d19910ace-goog