From nobody Fri Nov 14 18:19:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1760469641; cv=none; d=zohomail.com; s=zohoarc; b=MUGthx7okOWt1L5OaKBVbTt72eRP0hfasgp0D4NhozbhdKUi1yF5HAW4neAXpQ7ywN75Bo8x5FCmby9tXNKSL80sQtU5WL9vyukcApuqo03OH08FJst5OA+4k1C4W2w7nTZ/t4CUsAb38EQzG0zgny3M1wdFEXGHhG437C0u+Ms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760469641; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V6i0nVanfDujpYn//cEXKWgfyzyv69/ASXLJkx8rKto=; b=LOA4br3CGOG8ToKc5qtduZg0GOWyO7yLdBHfTelyyZ46ivTShxXb/MJF7D4MCRNFH18mqAlLsYtkWEidCq2vjhNiY3yf+itISQbf1qIlvQJvO2/26Y0ouERTqYQr9Hb3HabIWcL6VILcVPTk3klPRoNFQRcTXXKkR14KG6rW2I8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760469641807348.81465924797544; Tue, 14 Oct 2025 12:20:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8kZ0-00061l-7s; Tue, 14 Oct 2025 15:20:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8kYw-0005zp-VE for qemu-devel@nongnu.org; Tue, 14 Oct 2025 15:19:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8kYr-0007Yp-V9 for qemu-devel@nongnu.org; Tue, 14 Oct 2025 15:19:57 -0400 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-ZQbf-LLYOCKFmFpYg18YRw-1; Tue, 14 Oct 2025 15:19:50 -0400 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-856c1aa079bso86834485a.0 for ; Tue, 14 Oct 2025 12:19:50 -0700 (PDT) Received: from x1.com ([142.188.210.50]) by smtp.gmail.com with ESMTPSA id af79cd13be357-884a22744f2sm1256602585a.44.2025.10.14.12.19.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 12:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760469592; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V6i0nVanfDujpYn//cEXKWgfyzyv69/ASXLJkx8rKto=; b=iXnLYAACMpE/jKhLXftYzN46oXOmmsJohZheX4QCjZRs4yRJxNxUzi1+wMZx27PiDVrBO/ 6KA3isSSAtb8S1WbIERRap+1TweVchLtSY6mP//BQ8AbIgceHHD+0xmtJW5PGFWDBUQqJC LymOwoW8SllOpFnRqXSX0LRkprVHQKs= X-MC-Unique: ZQbf-LLYOCKFmFpYg18YRw-1 X-Mimecast-MFC-AGG-ID: ZQbf-LLYOCKFmFpYg18YRw_1760469590 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760469589; x=1761074389; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V6i0nVanfDujpYn//cEXKWgfyzyv69/ASXLJkx8rKto=; b=u2WBaBhIHJCSojqhPq/7nHsVW8Q2pVYbXLe5A17REFnAuEnX3kk3jq1+uMwQoqG3wP B1a6tjobxki3JRoYJXyYMtF3nRI1tkL7Ae8SxtvyGeywgU+tUTLGJPqcuYbNAJXbFM63 pBlxJ+NE/8CSvTijgYHqbHb3/RspkPcdv+fqq+GOMS8ARPL4ej4m4pEV5GM1N1ZI4fIL lcTq3VKk4zHllpCxBTsNkj54vPprsutIvEUl7JEPKnTBGMEn+lvJgxt1z8zqnuWMhe2B WR4dqjdhyhdUPA40yvil9yIiPspWm73SkVj3UVPTdk0qzG7GYATf7Ne0n89ZxvdvVYdC JbpA== X-Gm-Message-State: AOJu0YwBtK6fzz+eGSyfafZ9S/755Pr2xokcOWg38xYAfb6oUnwnOWgQ eeaMfD4Q+VOq0+/gQCnqUfQ4ZT+3IeUN4wjqD8KgVuD7diFXqjiAjVooFDs8HVIv247Ic7XnXAq tpkfUBgb8BgrjLoIAWkSPfo+jJ/0P7tofc99rRm/E9aTn31drndv/5zfDbYLJRtPfnL4nfQtlEi JfyguY2O8LIHK4WpYYONPGLeTXXdACQ5CmWZswHg== X-Gm-Gg: ASbGncs1L3YG2d8Echzv0Sqm2DS6cEVnopQXeXA2ihHclM1X0w/QG2RHx8zIiXkEvem 1objj9kp55Ed9Y0L1SRwPdDvrqCk9adgcHmLKTvbMgkHAyspS9870rxWxjEJ8msDgObN9XBf+24 CQWa5Q7kEfPnNjDpwa9pz92WpyUPZyJ8h+2h964z/PCW70IcEn8RU5VcFV0xHjHZdCf4SWGna0s mfm5x/iA5vkxuodY2Iknm6Sxsc31Joe0qW4i82/rNvANCtzKua5PEhyxu1Ld0skP3uTg5xU32rP 2N4xR6YziGG2QNV0tZI0/7gJCUW1vg== X-Received: by 2002:a05:620a:1a06:b0:836:974d:978e with SMTP id af79cd13be357-8820d666600mr3452113085a.41.1760469589400; Tue, 14 Oct 2025 12:19:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGF1YMSO5fjIviqhqlyWlgg7NrWaBHjGPprZFtXYgRhdhQRs6TkX0J25lpM04xubNqmQAIDWA== X-Received: by 2002:a05:620a:1a06:b0:836:974d:978e with SMTP id af79cd13be357-8820d666600mr3452108785a.41.1760469588862; Tue, 14 Oct 2025 12:19:48 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , Stefan Hajnoczi , peterx@redhat.com, Richard Henderson , "Emilio G . Cota" Subject: [PATCH v2 1/3] qht: Zero-initialize qht_map Date: Tue, 14 Oct 2025 15:19:42 -0400 Message-ID: <20251014191944.2225735-2-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251014191944.2225735-1-peterx@redhat.com> References: <20251014191944.2225735-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1760469643858154100 Content-Type: text/plain; charset="utf-8" QEMU almost always do this across the tree except QHT. This prepares for rcu to track double free. Signed-off-by: Peter Xu Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- util/qht.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/qht.c b/util/qht.c index 208c2f4b32..872d9f9cec 100644 --- a/util/qht.c +++ b/util/qht.c @@ -441,7 +441,7 @@ static struct qht_map *qht_map_create(size_t n_buckets) struct qht_map *map; size_t i; =20 - map =3D g_malloc(sizeof(*map)); + map =3D g_malloc0(sizeof(*map)); map->n_buckets =3D n_buckets; =20 map->n_added_buckets =3D 0; --=20 2.50.1 From nobody Fri Nov 14 18:19:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1760469632; cv=none; d=zohomail.com; s=zohoarc; b=m7KKxkVTp3wMCMfyjlF4BBAne6MZHvk4SJekQQLZwhEymJlHb8XwkJHnteLs8FE8CbYgd6OR25pO5QI1TW6EVcDmol2srGmQAJxEgxvDhPS7CFDpZ2qcPlhqUckHDXOhE5UjVRWMKfezLKZHbCR0IVIKMckKAff1Phkb6gioT4g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760469632; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V+VWQlRtDiKUJEtuqAgZyiqfrGUS0b2sMRTtBiC3lXE=; b=Q8f6TaZx2XZ6VpzoSRE7pjXAKFETDadxR8t0CTSvBgf1Gq4qsHHsS5HLfoKDoKoOuTOuZjABPh2lQc9V+lcJIa70sDa/cKnPyRmBZgWstg/oUocYcifotbPCBenlHN/sg6D84FC6zONftUW01xf4ARb7TCLBNFBAID0QtATh7nA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176046963217865.21186994294249; Tue, 14 Oct 2025 12:20:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8kYz-00060Y-7R; Tue, 14 Oct 2025 15:20:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8kYw-0005zo-Ox for qemu-devel@nongnu.org; Tue, 14 Oct 2025 15:19:58 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8kYu-0007Yv-Bg for qemu-devel@nongnu.org; Tue, 14 Oct 2025 15:19:58 -0400 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-ZbC3z-73NKK4nxwViJpfhw-1; Tue, 14 Oct 2025 15:19:52 -0400 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-86df46fa013so3583462985a.2 for ; Tue, 14 Oct 2025 12:19:52 -0700 (PDT) Received: from x1.com ([142.188.210.50]) by smtp.gmail.com with ESMTPSA id af79cd13be357-884a22744f2sm1256602585a.44.2025.10.14.12.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 12:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760469593; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V+VWQlRtDiKUJEtuqAgZyiqfrGUS0b2sMRTtBiC3lXE=; b=d77Vq/QmMu3MWK+4OQ2unumvW2B7aRTwkYy6m5btBULLEGetJThH5LT0/cmczZj94nd3RK 3r48mVU2CUGlp4V/qrZkwlbJ1OO+cZE2n5uUcb4UVo2F3SahGDvhzg3EThWSinhWIa4LRx 6hDgESO22YAzaAyipMYrtm5BJkJi9ts= X-MC-Unique: ZbC3z-73NKK4nxwViJpfhw-1 X-Mimecast-MFC-AGG-ID: ZbC3z-73NKK4nxwViJpfhw_1760469592 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760469591; x=1761074391; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V+VWQlRtDiKUJEtuqAgZyiqfrGUS0b2sMRTtBiC3lXE=; b=rGiUOeVABYgEV4B1DB5NCBB4RfrzSjwptf7Aa1gtN33YXSCfFJblEb5b0pzW0VRBuo oy7/el90ScyIO/kVNIMB2MRPfBucLIrdmYU6JIIjSxYPQxEjRA3s6fXQh+Dz8z+EFX1T OQ6O8XjPdIJQtOXG5p8oLRejRvKtzQlynqzg1014w0jPcT9KpgytvawvVOPDyGK+0TjY 5b+X3pVp/yRGylBosz/e8WwuT347BDx/9WkP17jXLJ1ZpEqxzBXdxS3oGIGoqjGqJxzm 5FBbsJsEaigPwaV2Jogim39/47WR57ion26zIJlH3w1EIZOXM7fP5mSNdQIyTJYtWUY3 hQaQ== X-Gm-Message-State: AOJu0YxmoK1EsxCb9A0hew8rNIZLRF64sURARrzzwE0lVFLSK9JwUpT+ Ia4LJuv+Z983eoouCu75/xRaUEi8KC8hKUhyHzPqfkTN6JbS0YMgg4oAkS+GrjvW2gIRB2VCNoy pJrdY0j+rzbI+eKiFlQMY795j4f7ec8zRvEiCn+DU6eHyzb0E6imvahLPv1NJc7wDvadKpDJ4se dttulpZTy1hvIihQHZTnFvtOPARBCB9bQIZ9emdg== X-Gm-Gg: ASbGncv8ZaZXujaN2Yh1JAlcU51rwO5MLyjujGVSu4RMvIMrJJ+nq3EW75oASUAkFtG +Tq8bJQLjX77mxRxptAExfni1aa1uah+aHPOZcpvyxZcORd/PL/DerF5CCwIFNTHI0U90VQG4Kc JPsGN12KCFPwaA2txz6uTmH+/stQz6Imf9aicQo09hkzi+EQsuMZHXwMBT7TjDkLSpWgKdmOqgg b1fytJL86ctdvHf9FDpPLE4F4mMi38NE4KBtNbaIFJQZUWGK4ZH6sQ0cQpQD+Xa5Y2HIICspdy1 GhM6un4/EaT0kQVOP47ST/qCQQ4kpQ== X-Received: by 2002:a05:620a:2981:b0:84a:f7cc:1eaf with SMTP id af79cd13be357-88350f575a5mr4294861285a.35.1760469591169; Tue, 14 Oct 2025 12:19:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGoakdbp9BljsWaX0AKJTl/ij+zsqC0Zbicq0Rxf7FJqOn2GPnzuFXEGfZ8S8aBbhB++KEikQ== X-Received: by 2002:a05:620a:2981:b0:84a:f7cc:1eaf with SMTP id af79cd13be357-88350f575a5mr4294854485a.35.1760469590612; Tue, 14 Oct 2025 12:19:50 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , Stefan Hajnoczi , peterx@redhat.com, Richard Henderson , "Emilio G . Cota" Subject: [PATCH v2 2/3] tests/test-rcu-*: Zero-initialize allocated elements Date: Tue, 14 Oct 2025 15:19:43 -0400 Message-ID: <20251014191944.2225735-3-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251014191944.2225735-1-peterx@redhat.com> References: <20251014191944.2225735-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1760469636447158500 Content-Type: text/plain; charset="utf-8" QEMU almost always do this, so do it too with the RCU unit tests. It's preparation work to start asserting on possible rcu double free. Signed-off-by: Peter Xu Reviewed-by: Richard Henderson --- tests/unit/test-rcu-list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/test-rcu-list.c b/tests/unit/test-rcu-list.c index 8f0adb8b00..853c9e33d9 100644 --- a/tests/unit/test-rcu-list.c +++ b/tests/unit/test-rcu-list.c @@ -233,7 +233,7 @@ static void *rcu_q_updater(void *arg) TEST_LIST_FOREACH_RCU(el, &Q_list_head, entry) { j++; if (target_el =3D=3D j) { - struct list_element *new_el =3D g_new(struct list_element,= 1); + struct list_element *new_el =3D g_new0(struct list_element= , 1); n_nodes_local++; TEST_LIST_INSERT_AFTER_RCU(el, new_el, entry); break; @@ -259,7 +259,7 @@ static void rcu_qtest_init(void) nthreadsrunning =3D 0; srand(time(0)); for (i =3D 0; i < RCU_Q_LEN; i++) { - new_el =3D g_new(struct list_element, 1); + new_el =3D g_new0(struct list_element, 1); TEST_LIST_INSERT_HEAD_RCU(&Q_list_head, new_el, entry); } qemu_mutex_lock(&counts_mutex); --=20 2.50.1 From nobody Fri Nov 14 18:19:20 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1760469667; cv=none; d=zohomail.com; s=zohoarc; b=cSu8Hpk7EQyo5PTAipziERcIt2wlBzUnA+eE/iVguGYn+j+I1ikUdH7t1XuqIMFaWuInpO2j27M6iqWJgmIDOHsDZPyk2h5BFJMDNH70Jvwie/BfW258QRePJpt7roCQKmOm1LVeZzNthhZGqJl1xtaskC3wgsUjnY2LYydC3pA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760469667; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cuPOCIy/RPHCF/8+cQhbwLAooQJNz3B3/YsEPxih0A4=; b=VSYBm7gSXb5VUvGeO0SmGNL5qaUrNgsd8hiN57ilf8h/hgglW4KQW7RE3hHPqN1HdEgPlagXiNeQhhllrlKE6Q2tdSkoPKRlvAsjYcHpck457BRnQSliLuVnua4clcDHwBusx3tIX8yWCOvQNm6RAjfwDgQmR1MXkc1hamJTel0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760469667600804.7084534708375; Tue, 14 Oct 2025 12:21:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8kZ0-00061n-Lu; Tue, 14 Oct 2025 15:20:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8kYy-00060X-Vj for qemu-devel@nongnu.org; Tue, 14 Oct 2025 15:20:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8kYw-0007Z7-Jm for qemu-devel@nongnu.org; Tue, 14 Oct 2025 15:20:00 -0400 Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-437-g0eXpgR0OviiIZfnmX9qig-1; Tue, 14 Oct 2025 15:19:54 -0400 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8635d475523so2735514785a.3 for ; Tue, 14 Oct 2025 12:19:54 -0700 (PDT) Received: from x1.com ([142.188.210.50]) by smtp.gmail.com with ESMTPSA id af79cd13be357-884a22744f2sm1256602585a.44.2025.10.14.12.19.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Oct 2025 12:19:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760469595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cuPOCIy/RPHCF/8+cQhbwLAooQJNz3B3/YsEPxih0A4=; b=ChvEihdMUjgv758/dcyoNfuiA0WUNbQmc+SdxAfN4TYkIwmz3IjwtA5ex1U5v62dPA63Ep ihoMSJkoqoCpm9PaARuoI6kB0tJWgUST7NtQbkBLRTmdyIwcE6a4dTIVGV1gIkIvmvh0c8 cb43Wpr5BX4bVUg60HFh/2c4c9KzPbs= X-MC-Unique: g0eXpgR0OviiIZfnmX9qig-1 X-Mimecast-MFC-AGG-ID: g0eXpgR0OviiIZfnmX9qig_1760469593 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760469593; x=1761074393; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cuPOCIy/RPHCF/8+cQhbwLAooQJNz3B3/YsEPxih0A4=; b=aFP61W/qYFnnu0hcmjslR/ipjZ+I1MdVfFGhxOqs2yQMSbm0MDj+0eyrWG9rJO3rmX Auyyr71Jb/G9OcTs7hsez/AavALbQIlZZpJuUEdkTO2Ylsxr7u+bcgHqrh9WO3wiFhrK RN1O+rA95NhKbYfxIzkGNfyqGcVVjx7+5460PucH4dzVczGvVQnknBN42JAHwKzb8Spx BpN4gONenLPAkuMkhlssVENWSgCe59z2EWsUIEl178PTqdYrHmu5KVTzKn5nHoYRIrKt X8Lx2604vDn9riy4oJsGAQMgoECp1WVm+GMHxtC1X8Kgb1X/i1lp/e8ufHE85slfH7zy cw+A== X-Gm-Message-State: AOJu0YzB9zw1+/D/sFZApw8fltq4NCeetGp7dL/9fkuyZvieFPs4hiuC XxHQMrDhuS08+GZqGHFP/Xpgx+X6g3SgRn0B3dWr0IZA/mCFX39oQvTkqlH/BLZwMeiiWahf8xY C+weWM5o+gRMXofpLEUG/oju6858flrsNIbEpZSW64Azb2WVEucdpfiFXqXPYLdQq0pOa90fXyl fpE3GdBEw2D5FTy0/MCcw1L6JjaaFzSwpkFw3SiQ== X-Gm-Gg: ASbGncsRJYgaU14Lx6CHqMtUHS0WBghwY3v2YM/JylsWVcPV9yNw2sDTPzhG0qEjob+ t7A9F2xwUaZkadQ53oFf4xzESS4NYkr+foCgg1U/PKZ64ru2q3Gh2cve0yXZzrhYA96m9uSNUQQ EvYA9ZDBBhvBhvFYgkMsURspu5wVvg5lvls66weOb6kz0ewnTLnwM1Bc9/W6QYa/9kqA1ifBtDW WIZxZy5RIz/RggDTV941cTzlySjWs02MqvL33sfTLdDHbSCVOYmHd3EoG7MreipwfXpQMVc3HAM ZZZRRU16lHVYQSj182oP3obzcsdq3w== X-Received: by 2002:a05:620a:3185:b0:863:125d:dfe3 with SMTP id af79cd13be357-883504a9873mr3477284285a.24.1760469592985; Tue, 14 Oct 2025 12:19:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUsoowF8eNFQ/Es6f3sLwoAiKfNb1YASzM96/fL0YyxnuzyJ6Q9tM8adLUQPKGAXPbn7BOEg== X-Received: by 2002:a05:620a:3185:b0:863:125d:dfe3 with SMTP id af79cd13be357-883504a9873mr3477278085a.24.1760469592321; Tue, 14 Oct 2025 12:19:52 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Cc: Peter Maydell , Paolo Bonzini , Stefan Hajnoczi , peterx@redhat.com, Richard Henderson , "Emilio G . Cota" Subject: [PATCH v2 3/3] rcu: Catch rcu_head misuse Date: Tue, 14 Oct 2025 15:19:44 -0400 Message-ID: <20251014191944.2225735-4-peterx@redhat.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20251014191944.2225735-1-peterx@redhat.com> References: <20251014191944.2225735-1-peterx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1760469668862158500 Content-Type: text/plain; charset="utf-8" Trap call_rcu1() to make sure it won't be invoked twice for one rcu head by accident. Suggested-by: Peter Maydell Signed-off-by: Peter Xu Reviewed-by: Richard Henderson --- util/rcu.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/util/rcu.c b/util/rcu.c index b703c86f15..fc4b18812b 100644 --- a/util/rcu.c +++ b/util/rcu.c @@ -307,6 +307,11 @@ static void *call_rcu_thread(void *opaque) =20 void call_rcu1(struct rcu_head *node, void (*func)(struct rcu_head *node)) { + /* + * Avoid accidental reuse of rcu_head, e.g. enqueuing one node twice + * (especially, when the function pointers are different). + */ + assert(node->func =3D=3D NULL); node->func =3D func; enqueue(node); qatomic_inc(&rcu_call_count); --=20 2.50.1