From nobody Fri Nov 14 18:23:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1760453466; cv=none; d=zohomail.com; s=zohoarc; b=DXDL14R2rFWyaAz1D/uwOIHpASLZ6eQmqOjEtzy7xSDkxOP5ixHH3GkzSUuUSkLafGKebOWpwQXUUP/RvUl0yNKLqgW6lQ5Xi7zFa4zoKohU9y4twI0PXUxCirtfB4/HajkWQxLl+ooD9xi90B7KcOc2qGsojOaGCUfto5ZHyls= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760453466; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IbmNQFvxIVZDFrun6qXUc+sIe+TxdINRiVwPIrkN7NQ=; b=f9woMsIpb6ifkolD37c99KPIAgu6UfFZAfN9ykNiQTR0tv4VnQg/foetCQ3AlFxF8KereSudafPZQgK++dqjTwvoyj4Nr8DeE35t60tY0IhGchRlRp8G4l92bVHCrrxHMz7x6+RHv8C6EysbejSgzEO2shUNIrrood3SWbjXce8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760453466069965.5897477995518; Tue, 14 Oct 2025 07:51:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8gMM-0001yz-5e; Tue, 14 Oct 2025 10:50:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8gML-0001yp-HB for qemu-devel@nongnu.org; Tue, 14 Oct 2025 10:50:41 -0400 Received: from forwardcorp1b.mail.yandex.net ([178.154.239.136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8gMJ-0002m6-7O for qemu-devel@nongnu.org; Tue, 14 Oct 2025 10:50:41 -0400 Received: from mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net [IPv6:2a02:6b8:c21:2d8b:0:640:7d49:0]) by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 5101B808B6; Tue, 14 Oct 2025 17:50:35 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:a8a::1:35]) by mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id XoQnFO3Fpa60-5LQqAeDt; Tue, 14 Oct 2025 17:50:34 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1760453434; bh=IbmNQFvxIVZDFrun6qXUc+sIe+TxdINRiVwPIrkN7NQ=; h=Message-ID:Date:Cc:Subject:To:From; b=0VR8S+UUiGlwsV/gOE1YZqS6FqYiVO9mWNDOzQCqFFBoDO2umzbsKTh8iuMqNhdDG ycAmCi9ZA58aPqWknk/Q+2AU4fKjYnFU5GfDAp9X8uNYpg5TB9f7WDuTOSHTcg1MgU 116d1dsTwOGeXQ6oSIh39bSswY4d9XOJkzenEBtE= Authentication-Results: mail-nwsmtp-smtp-corp-main-34.sas.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, peter.maydell@linaro.org, Vladimir Sementsov-Ogievskiy Subject: [PATCH] chardev/char-file: fix failure path Date: Tue, 14 Oct 2025 17:50:28 +0300 Message-ID: <20251014145029.949285-1-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.136; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1760453474244158500 Content-Type: text/plain; charset="utf-8" 'in' will be -1 when file->in is unset. Let's not try to close invalid fd. Reported-by: Peter Maydell Coverity: CID 1630444 Fixes: 69620c091d62f "chardev: qemu_chr_open_fd(): add errp" Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-Andr=C3=A9 Lureau --- I was going to send it inside v3 of "chardev: postpone connect", but it seems the discussion may continue there, so, decided to send this small fix in separate. chardev/char-file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/chardev/char-file.c b/chardev/char-file.c index 89e9cb849c..1f7adf592f 100644 --- a/chardev/char-file.c +++ b/chardev/char-file.c @@ -94,7 +94,9 @@ static void qmp_chardev_open_file(Chardev *chr, =20 if (!qemu_chr_open_fd(chr, in, out, errp)) { qemu_close(out); - qemu_close(in); + if (in >=3D 0) { + qemu_close(in); + } return; } #endif --=20 2.48.1