From nobody Fri Nov 14 21:04:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=yandex-team.ru ARC-Seal: i=1; a=rsa-sha256; t=1760362817; cv=none; d=zohomail.com; s=zohoarc; b=X4JIrO45NGXUPXvRPudEtNOrQam4BOSpXnZsai0US+646gXGkTu/3JuRENnrJbTyxii3vRyB7mkTcTCXGCdEwTGFNuYSdDsOqjdocgVUxchlu53j6AfQkpYzvUWAcrH5Ofw56/DmcKkOdoIVPcWCf8RuwueD2mCmoqvIyReloic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760362817; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=C18OuIlimmlWDuharbJ33fa8fObs2EZBJ6NY+9n/VlQ=; b=apQIrBP68OIgR2fAhst522q1ZUSvMZloM+Ol4E10bKWgYoblHkd1Bpf/IGbWUVaJbCtn+CzPAz1ikiqUiW6f+vxLk2TzGf+6h4mw+DGfuakNwHD4D7PowkijL0iIh13VTRQwiSVyDdB9ruxZTaq27b06WTDaCf/dcfqNFlp9iLk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760362816542262.09953436388116; Mon, 13 Oct 2025 06:40:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v8IlM-0006ei-6q; Mon, 13 Oct 2025 09:38:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8IlK-0006eE-OK for qemu-devel@nongnu.org; Mon, 13 Oct 2025 09:38:55 -0400 Received: from forwardcorp1d.mail.yandex.net ([178.154.239.200]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v8IlD-0006b6-Af for qemu-devel@nongnu.org; Mon, 13 Oct 2025 09:38:54 -0400 Received: from mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net [IPv6:2a02:6b8:c42:65a0:0:640:e1de:0]) by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 822A48086B; Mon, 13 Oct 2025 16:38:45 +0300 (MSK) Received: from vsementsov-lin.. (unknown [2a02:6bf:8080:a50::1:2a]) by mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id ccOm1D2F0Cg0-0k4i5MRo; Mon, 13 Oct 2025 16:38:45 +0300 Precedence: bulk X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru; s=default; t=1760362725; bh=C18OuIlimmlWDuharbJ33fa8fObs2EZBJ6NY+9n/VlQ=; h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From; b=Zc2MqVjMnnw7l0H4Sh8GxdwyjaOYftV0UIB9apxwTDYlkCzxXEXHlfEObr42dwvg+ zQjxbL0PYIwGg2XFAWJHO1HtHKOXQuIzXSmv2DQ36RLm0vjQX0X1phwviNZ9cNk9Ma hfzEWkful7S2Xr5/+bGTj2ba5tlfyyRvfPZjb6PI= Authentication-Results: mail-nwsmtp-smtp-corp-main-56.klg.yp-c.yandex.net; dkim=pass header.i=@yandex-team.ru From: Vladimir Sementsov-Ogievskiy To: marcandre.lureau@redhat.com Cc: pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net, qemu-devel@nongnu.org, vsementsov@yandex-team.ru, raphael@enfabrica.net, armbru@redhat.com, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru Subject: [PATCH v2 7/7] char: vhost-user-blk call connect by hand Date: Mon, 13 Oct 2025 16:38:36 +0300 Message-ID: <20251013133836.852018-8-vsementsov@yandex-team.ru> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20251013133836.852018-1-vsementsov@yandex-team.ru> References: <20251013133836.852018-1-vsementsov@yandex-team.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=178.154.239.200; envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @yandex-team.ru) X-ZM-MESSAGEID: 1760362819545158500 Content-Type: text/plain; charset="utf-8" Give vhost-user-blk a possibility (and responsibility) to decide when do connect. It will help us to realize vhost-user-blk backend-transfer migration feature: For incoming migration we'll need to postpone connect at least until early stage of migrate-incoming command, when we already know all migration parameters and can decide, are we going to do incoming backend-transfer (and get chardev fd from incoming stream), or we finally need to connect. With this patch, we don't modify vhost-user-blk.c: it already do call qemu_chr_fe_wait_connected(), which in turn calls qemu_chr_connect(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- chardev/char-fe.c | 21 +++++++++++++++++---- hw/core/qdev-properties-system.c | 2 +- include/chardev/char-fe.h | 2 ++ 3 files changed, 20 insertions(+), 5 deletions(-) diff --git a/chardev/char-fe.c b/chardev/char-fe.c index 973fed5bea..9e2c658cb9 100644 --- a/chardev/char-fe.c +++ b/chardev/char-fe.c @@ -189,12 +189,20 @@ bool qemu_chr_fe_backend_open(CharBackend *be) return be->chr && be->chr->be_open; } =20 -bool qemu_chr_fe_init(CharBackend *b, Chardev *s, Error **errp) +bool qemu_chr_fe_init_ex(CharBackend *b, Chardev *s, ObjectClass *oc, + Error **errp) { unsigned int tag =3D 0; - - if (!qemu_chr_connect(s, errp)) { - return false; + const char *driver =3D oc ? object_class_get_name(oc) : NULL; + + /* + * vhost-user-blk wants call qemu_chr_connect by hand, + * to support backend-transfer migration feature. + */ + if (!driver || !g_str_has_prefix(driver, "vhost-user-blk")) { + if (!qemu_chr_connect(s, errp)) { + return false; + } } =20 if (s) { @@ -218,6 +226,11 @@ bool qemu_chr_fe_init(CharBackend *b, Chardev *s, Erro= r **errp) return true; } =20 +bool qemu_chr_fe_init(CharBackend *b, Chardev *s, Error **errp) +{ + return qemu_chr_fe_init_ex(b, s, NULL, errp); +} + void qemu_chr_fe_deinit(CharBackend *b, bool del) { assert(b); diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-sys= tem.c index 1f810b7ddf..35eed17d4d 100644 --- a/hw/core/qdev-properties-system.c +++ b/hw/core/qdev-properties-system.c @@ -297,7 +297,7 @@ static void set_chr(Object *obj, Visitor *v, const char= *name, void *opaque, if (s =3D=3D NULL) { error_setg(errp, "Property '%s.%s' can't find value '%s'", object_get_typename(obj), name, str); - } else if (!qemu_chr_fe_init(be, s, errp)) { + } else if (!qemu_chr_fe_init_ex(be, s, obj->class, errp)) { error_prepend(errp, "Property '%s.%s' can't take value '%s': ", object_get_typename(obj), name, str); } diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h index 8ef05b3dd0..f1c05cc5ed 100644 --- a/include/chardev/char-fe.h +++ b/include/chardev/char-fe.h @@ -34,6 +34,8 @@ struct CharBackend { * Returns: false on error. */ bool qemu_chr_fe_init(CharBackend *b, Chardev *s, Error **errp); +bool qemu_chr_fe_init_ex(CharBackend *b, Chardev *s, ObjectClass *oc, + Error **errp); =20 /** * qemu_chr_fe_deinit: --=20 2.48.1