From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760103894; cv=none; d=zohomail.com; s=zohoarc; b=G3soitWllaYdk8JTENltBJv+xCCKp0obhztKOCeGkmO9CH2q6/I6axXt8DKrDjTPn20YXZqRadPEtge2dZmDwjZqhLrOGsqDxBilUrZp5JfmdqOxvHTSHoKsRtKCyN+9hpEPlvvKH6LYKbQXXvhma1jXz4/FbgaeaGyfVm0NNvs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760103894; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wozWQ4+uKhU2Woke0EiPtGgDjWqN+p+Av15OT51Ys1o=; b=kIYgdz3xitOPGRsCkBbI3SjNiACVpWr1kmphIghJxcZlMyDP56qtMHynLXGwJeG0R76AXrxzYRZ95TUDiTEkCin5WGwVJHI+67YeTP7zsFxPiAMikOXXB/ExciQmqatV8KsQwJOMmVLwAv61uqe+oChY97af5HSnLjgBzf8cpm8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 176010389453882.70187785187852; Fri, 10 Oct 2025 06:44:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DOt-0002Ch-84; Fri, 10 Oct 2025 09:43:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DOm-000294-Lq for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:09 -0400 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DOT-0007np-GR for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:02 -0400 Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-3f2ae6fadb4so2426655f8f.1 for ; Fri, 10 Oct 2025 06:42:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce50d70esm4457288f8f.0.2025.10.10.06.42.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103753; x=1760708553; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wozWQ4+uKhU2Woke0EiPtGgDjWqN+p+Av15OT51Ys1o=; b=CZyK/SYWWIqxN+JiCD0ks+wEAzbLuIBS4tJZTut0Q1ReuEWtDLuwaSTQUTFK/JK1xs 6VyuLPFwgOqHw8F8JPWTLrOiOQtJMO3AfZLGA4R6tqLd0vTcp0xkA3JYUG8+uP+iqqG5 hWZgWBQl4QPoqJ7zhA1bERTfkq55OOZiHESccj5nPiknrGbQALDnH8dIX7O8FVJJkUaO 2a9HvvVGUulf+gPOPOAXqA/mh6Cqmd84S0Rn3dtSUIvRzbk+IhBEsdI+YmDdYp9CUYAX mXhvsWAwKKARE3Ja2BhgUh3gMy20ae9kjqM/rWXJKGVwaTQA+3VW9G/R7vETRC9qTG16 Gb5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103753; x=1760708553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wozWQ4+uKhU2Woke0EiPtGgDjWqN+p+Av15OT51Ys1o=; b=bqmX7n8N5xbnoOR9VcYVW6rZ8qhtptVQXbUpgfZe8NnOMDUTaNQKub5QeebHKQvDRw WNa6z/UYFpKJngw1zNlMc6DeP6MLZcL6WEvBlLtvKzoP2n5lI4TUEGtQTfHzMaU9YQP+ W3ZUO+2+r+wCu7bPbumrmnG0eslW87lQatuJqTxkfnAXHuqFSSxG0+6d5d4lr1Uzr7n/ TbjEBO4QzHTa1oDDcdhD37FfCm1ZyHttVY87a04DtElFB5eBHA46o41R5GpEHbqEgGzf VAiq9kYFeGgEs+J1lDR/xJ/7vv/YPf549EWjg3Jtj8oGPt10bQl54btSHzKqBBpJhYAB hVZw== X-Gm-Message-State: AOJu0Yx3lZb3Xxqnkcj3oEIo16uzNaHgqAVtJd5mx1lGi/BK0wcfw483 x7OgaQMWp4aWfwScOR6BCyd6fW5Z8h93BJzlJcH03EU16+DbUpw7kac207EI4he23KpmG25G+VB IUnpBTMQb6w== X-Gm-Gg: ASbGncvIxO2zKTGyD5bnnvp6cVXKhwOJpe9PGepvRFXVZ9fMlL2hHb3Q4cNpeJlYynl HgIS5XLoaVWKpSPyw670MKxn8C+3xcj88krcDny3omNL45Uwpc4aCcJuA/lcbaFFxyuGkiTDYso CHgIj9kCAMFk/+3K91VvCjnQeqHcRE9ppHWDWK7d2U+3vH1yPin2ov9gCfgkieYAI5U/OGTsWUM 5ohDRvR6ulDNUvF/2C59EO5S6q/1IWc4/cfFwdBF5CcuV231pG6YInj8l7pL71M7hSBHzzWziQm pQu6Hk1/3cDzBHFSwzOfWAY5GZSwS7+d/rPMt95gB9io74liBJbHPpxmbz+iYVQuvKLeYaXw5lz +WkrJS2V2p8316OVrHDI80CVMOm5gbs74KHtoiDdXu/kMV/lPEUCKwiMP277RUk/FQby/SA472y QFEn5IOGBM53R2QpvxYkmv4Uk9C5a32g== X-Google-Smtp-Source: AGHT+IErZZEwB4uw1hXoXCFarD7Y+fhbeaRNLRAD8qc0l2ueYPzIctHC9WNhaN8/3Y7GMnt0v+LIkA== X-Received: by 2002:a05:6000:2505:b0:405:3028:1be2 with SMTP id ffacd0b85a97d-42666ac4748mr7297622f8f.11.1760103753514; Fri, 10 Oct 2025 06:42:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier Subject: [PATCH 01/16] linux-user/arm: Checkpatch style cleanups Date: Fri, 10 Oct 2025 15:42:10 +0200 Message-ID: <20251010134226.72221-2-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760103898147154100 Update style in a pair of methods we are going to modify in the following commit. No functional change. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/arm/nwfpe/fpa11_cpdt.c | 66 ++++++++++++++++--------------- 1 file changed, 35 insertions(+), 31 deletions(-) diff --git a/linux-user/arm/nwfpe/fpa11_cpdt.c b/linux-user/arm/nwfpe/fpa11= _cpdt.c index fee525937c5..6b0317883a7 100644 --- a/linux-user/arm/nwfpe/fpa11_cpdt.c +++ b/linux-user/arm/nwfpe/fpa11_cpdt.c @@ -40,18 +40,18 @@ void loadSingle(const unsigned int Fn, target_ulong add= r) static inline void loadDouble(const unsigned int Fn, target_ulong addr) { - FPA11 *fpa11 =3D GET_FPA11(); - unsigned int *p; - p =3D (unsigned int*)&fpa11->fpreg[Fn].fDouble; - fpa11->fType[Fn] =3D typeDouble; + FPA11 *fpa11 =3D GET_FPA11(); + unsigned int *p; + p =3D (unsigned int *)&fpa11->fpreg[Fn].fDouble; + fpa11->fType[Fn] =3D typeDouble; #if HOST_BIG_ENDIAN - /* FIXME - handle failure of get_user() */ - get_user_u32(p[0], addr); /* sign & exponent */ - get_user_u32(p[1], addr + 4); + /* FIXME - handle failure of get_user() */ + get_user_u32(p[0], addr); /* sign & exponent */ + get_user_u32(p[1], addr + 4); #else - /* FIXME - handle failure of get_user() */ - get_user_u32(p[0], addr + 4); - get_user_u32(p[1], addr); /* sign & exponent */ + /* FIXME - handle failure of get_user() */ + get_user_u32(p[0], addr + 4); + get_user_u32(p[1], addr); /* sign & exponent */ #endif } =20 @@ -108,16 +108,18 @@ void storeSingle(const unsigned int Fn, target_ulong = addr) { FPA11 *fpa11 =3D GET_FPA11(); float32 val; - register unsigned int *p =3D (unsigned int*)&val; + register unsigned int *p =3D (unsigned int *)&val; =20 switch (fpa11->fType[Fn]) { case typeDouble: - val =3D float64_to_float32(fpa11->fpreg[Fn].fDouble, &fpa11->fp_s= tatus); + val =3D float64_to_float32(fpa11->fpreg[Fn].fDouble, + &fpa11->fp_status); break; =20 case typeExtended: - val =3D floatx80_to_float32(fpa11->fpreg[Fn].fExtended, &fpa11->f= p_status); + val =3D floatx80_to_float32(fpa11->fpreg[Fn].fExtended, + &fpa11->fp_status); break; =20 default: val =3D fpa11->fpreg[Fn].fSingle; @@ -130,29 +132,31 @@ void storeSingle(const unsigned int Fn, target_ulong = addr) static inline void storeDouble(const unsigned int Fn, target_ulong addr) { - FPA11 *fpa11 =3D GET_FPA11(); - float64 val; - register unsigned int *p =3D (unsigned int*)&val; + FPA11 *fpa11 =3D GET_FPA11(); + float64 val; + register unsigned int *p =3D (unsigned int *)&val; =20 - switch (fpa11->fType[Fn]) - { - case typeSingle: - val =3D float32_to_float64(fpa11->fpreg[Fn].fSingle, &fpa11->fp_s= tatus); - break; + switch (fpa11->fType[Fn]) { + case typeSingle: + val =3D float32_to_float64(fpa11->fpreg[Fn].fSingle, + &fpa11->fp_status); + break; =20 - case typeExtended: - val =3D floatx80_to_float64(fpa11->fpreg[Fn].fExtended, &fpa11->f= p_status); - break; + case typeExtended: + val =3D floatx80_to_float64(fpa11->fpreg[Fn].fExtended, + &fpa11->fp_status); + break; =20 - default: val =3D fpa11->fpreg[Fn].fDouble; - } - /* FIXME - handle put_user() failures */ + default: + val =3D fpa11->fpreg[Fn].fDouble; + } + /* FIXME - handle put_user() failures */ #if HOST_BIG_ENDIAN - put_user_u32(p[0], addr); /* msw */ - put_user_u32(p[1], addr + 4); /* lsw */ + put_user_u32(p[0], addr); /* msw */ + put_user_u32(p[1], addr + 4); /* lsw */ #else - put_user_u32(p[1], addr); /* msw */ - put_user_u32(p[0], addr + 4); /* lsw */ + put_user_u32(p[1], addr); /* msw */ + put_user_u32(p[0], addr + 4); /* lsw */ #endif } =20 --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104310; cv=none; d=zohomail.com; s=zohoarc; b=KmjGPggycFvN35IKAhIfjEXj7b+ZlAu5UqSGgyTfTz16Aqr9/qVxviJW6X1qB7Xd3lNaFwKygvjHq80DvJnHioIMNXrxwb8QWWiuNGBZtQL3mC7ELQnABQH2fAoph3upt9E6KlsAPnrhCvL7q8z6TnSZ6a8v42pLYPbzSdiTkQI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104310; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9OSShypqbaYu7gg2JRcaPkTQFiWcjkliGca982i75nQ=; b=jUo0A5Pooq3zmkXavGSIbXg37o33iChVCT6b11ZwGElPj0KxTKqJHkgZZ3vhijugMudXNyLBqmF0XYWOONG1ShPbNEHx8owSOGDMUvHF7mv32fLYna8Sx70AkupLMMBfG8b0vkfE5GfCWfNCMljUdkdUD+v8FqE9iqvW6qLL2dA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104310453704.926257336489; Fri, 10 Oct 2025 06:51:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DOv-0002EK-EJ; Fri, 10 Oct 2025 09:43:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DOo-0002Al-81 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:11 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DOU-0007ry-LR for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:09 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-4257aafab98so1829870f8f.3 for ; Fri, 10 Oct 2025 06:42:42 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5cfe74sm4140481f8f.35.2025.10.10.06.42.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103758; x=1760708558; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9OSShypqbaYu7gg2JRcaPkTQFiWcjkliGca982i75nQ=; b=J0vCIJG7y/kA8FgU9elcsWyEwAYXIQUKlcLT4IXuXZOMdl69a61Kt/0Iiy7U2wwSfj LqkmapS+gEGhpdIKRUZVjMMMhZn11ciYJtDmndsT1FGk/itLPG6FSxdq/CS31OUW4rrh 53IgeQYEYuGmJzGARc1lYItwippXBHgn+4AH//hyXYpcIEfA+rfrLW3hLoKn1ux3ZsYD jXUmH3ojX+CcLMeysslGCfTtMrkCjkWzqfyrakPS2XrYxBWoFlFtJTmJ2nqQ5KOQL3MW VBxs7uHvKd+3H0UqCL2KrkkhphHUAM58PdiMEXsXqi0FIhF9M707HVh/IGqSjAzQj15x 15Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103758; x=1760708558; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9OSShypqbaYu7gg2JRcaPkTQFiWcjkliGca982i75nQ=; b=ud8D3fLBWg4/4X9Dx87/eRVkthsjYxNOkaBeIVbJBL/0HHLSGZfuQcj6KDNh4hqZND f7nFYKDTgxRaRVZ+bxBYzO/fgh6rUobjn1aFkOlC5q+kW/Ox0Cu1K0SCl0VRVD7wWPUY GkfjFbTGp4kbv/OALg5XokSBct8ZI/8Cv5Xr5ZhM0HHyIuNqOeF2PABcfodI0TYWArJY G961B+Ws03IKKtAA7uy8clkjComrtveRN/BbCfOLPHAAn85/Eip7+ItkE1/oFuq21FlW f/nD/mRLe80d1xlfeVtrjpdQHrdPD1Kg7M54dtLNHbtewvpp18h0YVNQ6wGoveNG0XiY 45ig== X-Gm-Message-State: AOJu0YyBVmwUsEMe36IoDVijKEocqogtexxRmmWd+QuqEgs8isBUWSNA aA0gUhjCAQ8lEtNPPThYgMywn8iQ/rXfpdCtJKrl/r04/S+7cfDEc1Ad4LyutFJ8ZnmrSwkpZSe BWesnx6wo5g== X-Gm-Gg: ASbGncsWHWViCofTGLfeCcjdUL2g2/dw+iio3qnRMA4KH9/lfrzIfqieoD+vmfiEyKM Oxvg4FYRnYJRhAFHmUuNaVf/UzcaSICEhZ/LSSfyGM/jNFe5578wfxPdnI8QxNoIKZEnhv/W8zO 3h+G3FiRT0gSFkwwE5JYQRyBg3Aou5VjhiWXX4u+rbTow/JvkLX5UsAu1Ejkp/kV+lrT565Z3oC pdsO4egX4MxO67YVT3v7vM4IEQ01C7nzqdHNnKLCOL7+K4Lpa70lRIIoIbKs64Av8TPcrISf03N ey5Lj/adwhn7dsp5SpljhDaFScAIA7HGz8busJu+LieMtaWh+UUl53s59Ca6twZc7co46WDRjzM +Hh93yysXR4Q80aWKS9G6shmwFgkFn2Cut5gValtYQ5dfE++0nOvbpUODmUK6vwfXAuFGgLhG/9 hWiav2XXzj+RdBIMSlFtY= X-Google-Smtp-Source: AGHT+IGji93i+SOihun7JFXHhG4hGqXkH4wmT2Nj3yjUj0PvGZai8kOCJcP8uw/NluQ56SyBGkWf3Q== X-Received: by 2002:a05:6000:4023:b0:3ec:e277:288c with SMTP id ffacd0b85a97d-4266e7d90e2mr7334892f8f.31.1760103758528; Fri, 10 Oct 2025 06:42:38 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier Subject: [PATCH 02/16] linux-user/arm: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:11 +0200 Message-ID: <20251010134226.72221-3-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104311947154100 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- linux-user/arm/nwfpe/double_cpdo.c | 12 ++---------- linux-user/arm/nwfpe/fpa11_cpdt.c | 29 ++++++++++++++--------------- 2 files changed, 16 insertions(+), 25 deletions(-) diff --git a/linux-user/arm/nwfpe/double_cpdo.c b/linux-user/arm/nwfpe/doub= le_cpdo.c index d45ece2e2fe..e29b38aada0 100644 --- a/linux-user/arm/nwfpe/double_cpdo.c +++ b/linux-user/arm/nwfpe/double_cpdo.c @@ -150,11 +150,7 @@ unsigned int DoubleCPDO(const unsigned int opcode) case MNF_CODE: { unsigned int *p =3D (unsigned int*)&rFm; -#if HOST_BIG_ENDIAN - p[0] ^=3D 0x80000000; -#else - p[1] ^=3D 0x80000000; -#endif + p[!HOST_BIG_ENDIAN] ^=3D 0x80000000; fpa11->fpreg[Fd].fDouble =3D rFm; } break; @@ -162,11 +158,7 @@ unsigned int DoubleCPDO(const unsigned int opcode) case ABS_CODE: { unsigned int *p =3D (unsigned int*)&rFm; -#if HOST_BIG_ENDIAN - p[0] &=3D 0x7fffffff; -#else - p[1] &=3D 0x7fffffff; -#endif + p[!HOST_BIG_ENDIAN] &=3D 0x7fffffff; fpa11->fpreg[Fd].fDouble =3D rFm; } break; diff --git a/linux-user/arm/nwfpe/fpa11_cpdt.c b/linux-user/arm/nwfpe/fpa11= _cpdt.c index 6b0317883a7..7b0a715d403 100644 --- a/linux-user/arm/nwfpe/fpa11_cpdt.c +++ b/linux-user/arm/nwfpe/fpa11_cpdt.c @@ -44,15 +44,14 @@ void loadDouble(const unsigned int Fn, target_ulong add= r) unsigned int *p; p =3D (unsigned int *)&fpa11->fpreg[Fn].fDouble; fpa11->fType[Fn] =3D typeDouble; -#if HOST_BIG_ENDIAN /* FIXME - handle failure of get_user() */ - get_user_u32(p[0], addr); /* sign & exponent */ - get_user_u32(p[1], addr + 4); -#else - /* FIXME - handle failure of get_user() */ - get_user_u32(p[0], addr + 4); - get_user_u32(p[1], addr); /* sign & exponent */ -#endif + if (HOST_BIG_ENDIAN) { + get_user_u32(p[0], addr); /* sign & exponent */ + get_user_u32(p[1], addr + 4); + } else { + get_user_u32(p[0], addr + 4); + get_user_u32(p[1], addr); /* sign & exponent */ + } } =20 static inline @@ -151,13 +150,13 @@ void storeDouble(const unsigned int Fn, target_ulong = addr) val =3D fpa11->fpreg[Fn].fDouble; } /* FIXME - handle put_user() failures */ -#if HOST_BIG_ENDIAN - put_user_u32(p[0], addr); /* msw */ - put_user_u32(p[1], addr + 4); /* lsw */ -#else - put_user_u32(p[1], addr); /* msw */ - put_user_u32(p[0], addr + 4); /* lsw */ -#endif + if (HOST_BIG_ENDIAN) { + put_user_u32(p[0], addr); /* msw */ + put_user_u32(p[1], addr + 4); /* lsw */ + } else { + put_user_u32(p[1], addr); /* msw */ + put_user_u32(p[0], addr + 4); /* lsw */ + } } =20 static inline --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760103928; cv=none; d=zohomail.com; s=zohoarc; b=YJpul1RyHFz+C+NFi3QabWTbBYGjJ7e/B8eLfegs2UqV9LVTzlHy6TEpKmbSNjr+bisfG85VF2sBTCKxvr5VEoOyvSWLEqi9LvnzzX6Fq7t8UT3IHQDMOqI6HQ0LqY41PwjMTACKQvhPQlGB3m9zGqVRiBGXsL04k5zpvyxNHB8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760103928; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=61NQQUfc5AHH6sOajFhd3xe+bOM3Liy2MIqh9GGhkaQ=; b=Iyvxav35ufJ7DRBplhF/lWoyX9U7ddv10cxzlr1sO2hZkkFIrlRT975lC1oVaKCPcf8qONkvP0wwcCEJRIaui6sQVlueqhK3H8aVV4Hg3vSy/FI0XsmfwT+jGITwW3OchlckDCLSyfFendWgqAJFanBLcxV/KfRRY2ZVP7+YizI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760103928774763.9144454485003; Fri, 10 Oct 2025 06:45:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DOw-0002F9-6U; Fri, 10 Oct 2025 09:43:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DOt-0002Da-Dt for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:15 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DOW-0007sQ-83 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:15 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-46faa5b0372so13328305e9.1 for ; Fri, 10 Oct 2025 06:42:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb48a60b8sm47789695e9.19.2025.10.10.06.42.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103766; x=1760708566; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=61NQQUfc5AHH6sOajFhd3xe+bOM3Liy2MIqh9GGhkaQ=; b=blXreB/V8dK5HYLUa7/X02sv/fssOGeMRXB+QnSf28A2WZxhISeZ9HlSDuq/34HgsO yF6dgPCxCcbXGRiJ2hx6RgwDIJq6STqNICbNnnRtPNZJoVodbjBpLXabAWjKHDUqxPFK JkH8Rkl4Rep/GCGrdU/2v2Z8v7A73VJ+NfXbhsJvad+TovJWU4e2doZa1GFwn5QF4Rf7 FPzCJWJpjWXc1K1EUArhttc8N5T5AIM/QhX3IeWbuw3+o4k2wu2r1oqTJvHRXYW4Csgy t9VQxNAsPRvzl1zEPIABrllqN3SMwnbfgAMpH9mQXyP4RV+j2K/T2jhovh+HLzFFbGX7 n7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103766; x=1760708566; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=61NQQUfc5AHH6sOajFhd3xe+bOM3Liy2MIqh9GGhkaQ=; b=knenutEZgnhsTwJbeiR+1zvGn5ZLmIGqOVRV1RMZHFHpicm+bH4ceAK4a/2ndPDVVR S19DOI7ZalvkOzLR7VTnaKYEv/tVBuFM4x/zB7za3fn9aTEbosHWpmqmJKwu6mKvNJsV 2i0qXZHSFmOgcfB2+trCcq9IElBejeSJ0cJPJyNcBRRWBNBzMa3BrmEaDnb8epoEpWGh DSuxiuRFE3gLNVOqzPJZQLaucmmKTDtHNzJozrCEX3h3JguB2O49MYsTbhLBmsUXeXHF E4yJ93IQvaNwIRBIuE1k15loI9AEIvpRtnDjDX1qCwPKDWJtV3pczG+pMNLT6EHTd8tB fWHw== X-Gm-Message-State: AOJu0YzXzZnRTA669K00rA0TqZ0Vzs+PO9V9/yBiqdTBRkPkTv8n4e/i +04/wSbllXDsKndbM0oC8ECeJLCAhOvylOHHFBJOy0jgB/OyIlp6NqebBwYWhvBPDn6bLqs4sJp 48hvtwlzvyg== X-Gm-Gg: ASbGncsFV7dL3FzPQWoS+cDju5G3wg0BLZEJ5Zg7iUDr5uXBSH96OJGqyiGknXG5JK1 qe7GaNGVJfOd/xqNjlTt/SY31KC33mm6DtDvhR0jZ9MpWltWxa2nb03Agm4ydQI2VWqcb6gV6Io LGqqoYOvaXs7hle1oGJjLC65Vk6KweOoibfqPqBYmBQhwi9MalD4YWxMmDfL3kpA9VteMIUh4iW +uPoZWhRBgv6K4WMQYGdxRI52/bSSG4zrpiD2KsLDeGaLvbUYrlX5J/Qc6pZoT4qMT8UcZ+wSSi OKZX/+mbxNYHoIH+VVwiR0H6Pa5H2t7WxRb7zK7CRet1LUr+mJ8Bl6es4GgXrEhSbteUi6wVIQz n8ICJxi3Gb91SjBspeUx+fM0sOu+LdokXyhuTACfhlLbOUXOLE3VpH98TfVsNNxWEA/ul8tpTi/ 70bp+hvfWm40OpYjzPTtgMD/olHqR87Q== X-Google-Smtp-Source: AGHT+IEL530wYI6ec2dvGV8IhPhoS7pJXv2tYfyowgqvyrI+XiBgK9StQAaWW4IwhCKK6t2MFVEECw== X-Received: by 2002:a05:600d:4203:b0:46e:6af4:ed83 with SMTP id 5b1f17b1804b1-46fa9af9099mr85429505e9.23.1760103765671; Fri, 10 Oct 2025 06:42:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Subject: [PATCH 03/16] ui: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:12 +0200 Message-ID: <20251010134226.72221-4-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760103930676158500 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- ui/vdagent.c | 16 ++++++++-------- ui/vnc.c | 6 +----- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/ui/vdagent.c b/ui/vdagent.c index ddb91e75c64..66dc33567df 100644 --- a/ui/vdagent.c +++ b/ui/vdagent.c @@ -660,14 +660,14 @@ static void vdagent_chr_open(Chardev *chr, VDAgentChardev *vd =3D QEMU_VDAGENT_CHARDEV(chr); ChardevQemuVDAgent *cfg =3D backend->u.qemu_vdagent.data; =20 -#if HOST_BIG_ENDIAN - /* - * TODO: vdagent protocol is defined to be LE, - * so we have to byteswap everything on BE hosts. - */ - error_setg(errp, "vdagent is not supported on bigendian hosts"); - return; -#endif + if (HOST_BIG_ENDIAN) { + /* + * TODO: vdagent protocol is defined to be LE, + * so we have to byteswap everything on BE hosts. + */ + error_setg(errp, "vdagent is not supported on bigendian hosts"); + return; + } =20 vd->mouse =3D VDAGENT_MOUSE_DEFAULT; if (cfg->has_mouse) { diff --git a/ui/vnc.c b/ui/vnc.c index 77c823bf2e8..e93b5335690 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -2348,11 +2348,7 @@ static void pixel_format_message (VncState *vs) { vnc_write_u8(vs, vs->client_pf.bits_per_pixel); /* bits-per-pixel */ vnc_write_u8(vs, vs->client_pf.depth); /* depth */ =20 -#if HOST_BIG_ENDIAN - vnc_write_u8(vs, 1); /* big-endian-flag */ -#else - vnc_write_u8(vs, 0); /* big-endian-flag */ -#endif + vnc_write_u8(vs, HOST_BIG_ENDIAN); /* big-endian-flag */ vnc_write_u8(vs, 1); /* true-color-flag */ vnc_write_u16(vs, vs->client_pf.rmax); /* red-max */ vnc_write_u16(vs, vs->client_pf.gmax); /* green-max */ --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760103939; cv=none; d=zohomail.com; s=zohoarc; b=D24eyNpzYK4INOZX4ZicAZ7KNPrYBMh/bMTcdgUuy2SARaoFpGdd/hobedFFKa0GnsscHYprvHm7amZPujGynlruCtEQNCQ/0iXalUxB+h1T40vCENHa10307BCmQo4PaOPV6p6I4zsxhoTd1cSMAQRTOu4Uc9yorEMrpGsnEJI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760103939; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=glWOQWNC3/3zXE9lsfJz0FVW5jre8WEcmZkI6CO0cfo=; b=O+Nt6IT6HV/mM9YFPqpBCHRq3+7M/EHMRJO+7QvrW1HjGMOJMc5aP+syjANMISnK0TMlLG/tCNC8TnwDhw1I+DTXHlk3DpGlv8MirXfYD4UqB02nCfxt3pmEKGNQH3RHTN4rL0atF3WV2YTihT8Znad+hpyzgQgZpZ8YrEROS6U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760103939027961.6851513910947; Fri, 10 Oct 2025 06:45:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DPX-0002Nw-9p; Fri, 10 Oct 2025 09:43:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DPA-0002GQ-By for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:33 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DOk-0007uR-0t for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:31 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-46e5980471eso11553165e9.2 for ; Fri, 10 Oct 2025 06:42:53 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5e0a03sm4250770f8f.37.2025.10.10.06.42.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103771; x=1760708571; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=glWOQWNC3/3zXE9lsfJz0FVW5jre8WEcmZkI6CO0cfo=; b=EFzhVWxfOGOZcgMwM9IZKXokT9pM8ZaxsVx0y+xggG2iFyg4aIEDYLSDcVU5g7sF52 uZr8q+j/itYmHi7aKYu5K87C/zW0lFN6RBeXgqDhTF/OLwr8akBkRU2lHl4xnDM+16RE ehieUmfoPZN94sO0dQHUSoxndbq61L6TcyHJxWN6wyxOOJIChDbzcVsvC9VfDvKhBOPB hk+oXPpX8ZFPD61JYAvMKL2EOoTgxivzlk6FBvmTXGbpr3gidJwL74j8/TdmpKTXNwws 0CJEVofJQBj9DmkGmaC4KOYizzWRg2uZfbULufQSticK0ufTM0+OPvOX6px4IEPGOArc fx+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103771; x=1760708571; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=glWOQWNC3/3zXE9lsfJz0FVW5jre8WEcmZkI6CO0cfo=; b=ctdzfB03mgGBLfCRVcpVUumhpk4h7Y9MIY7bCVnxNCG0CpcxcxfWTR12dWFnDgJamU fCqFCCFnB+R4Uc3V/9X0eFJZ6ndBXUo+gl0kiJLJXS0NpCroOVb1sUBltYOc34/rfJVS iOJVsnkT6botwUMTl0DBtExilabdhLlsKP8G/hIAXGYS/AZewj3GrF5jHky/39In2jCs cdsPf4T0vG00OAU/9Q+VhhqviycE/S1+cI9rYLKZsuc3B336F81wEWL6V29s77Z6npwN MWffN/vWX/EaXQ54Hz9toFEzkDkikWkFZshMkcpUlLZ3FbNHSKlyuyTTfQGhL5e1vfVC zJjQ== X-Gm-Message-State: AOJu0YzFlX3Ri8O6+8D0zhwX+Nn7rA0CDG4M1pT+qCfrzPDVoVWzKYJB NFD5z7RbM2+k4vcOEXwBeCd79N3SCuAqrb5U8yEK81Ln1mssfpxqVD63Z/Qc0GctJDUnferqNWz 6NrqoqNo/1Q== X-Gm-Gg: ASbGncv4dCJxW+gdfmGiSFP8kCPlWDYaHgsySACWqkALyxZ7AAMheA+L/G5ypZy1Pn2 VCiqV0P0yuR49SfYfkgFGRv8WXE6Zg6ovzTXd/TNashQtA2di8zKQhABE95XegRQSHcKh2F+uCA qy5ePQEtQZvUXGiPXQT9vHW2i22JSnIrszjQbG9M1ArGS8oYdwZR5OlsPxY6AMxfNlb8lKv20ZJ 8dV0pkZhjm8PiQjdFEF1vvJfk+d9dv9VJW9Oa58LwQToC0GBTmLXVIO1bBeZq4cdY0o3zAiDdum rp9vezPD56ZYr5e+ftie9Klul4Krwf1vYBKnFUqL8XQ0StGhZYKXON/j6ZPCNS3oZOSCU/j3yaU Lrv1Pkqv39QD7W4TRnOGyDMNiyuuwcg1kPlYj7yF+UrRdZ7EIB9Mf2YY7Sb4moGcuNTvlZ7XU5M Tgcy3KykYSfvgsnUUypsU= X-Google-Smtp-Source: AGHT+IFj/ht5sl+sluGOMrkKYrfsxcYSRA4eSOSl5wJQr2sAZXH/Rlebae2Q4vcDEqBBJVKVMRb4Fw== X-Received: by 2002:a05:600c:1e86:b0:46e:4784:cdf5 with SMTP id 5b1f17b1804b1-46fa9a9f254mr89740875e9.15.1760103770793; Fri, 10 Oct 2025 06:42:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jason Wang Subject: [PATCH 04/16] net: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:13 +0200 Message-ID: <20251010134226.72221-5-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760103941207154100 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- net/net.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/net/net.c b/net/net.c index 27e0d278071..11d1f7616a6 100644 --- a/net/net.c +++ b/net/net.c @@ -593,28 +593,26 @@ bool qemu_get_vnet_hash_supported_types(NetClientStat= e *nc, uint32_t *types) =20 int qemu_set_vnet_le(NetClientState *nc, bool is_le) { -#if HOST_BIG_ENDIAN + if (!HOST_BIG_ENDIAN) { + return 0; + } if (!nc || !nc->info->set_vnet_le) { return -ENOSYS; } =20 return nc->info->set_vnet_le(nc, is_le); -#else - return 0; -#endif } =20 int qemu_set_vnet_be(NetClientState *nc, bool is_be) { -#if HOST_BIG_ENDIAN - return 0; -#else + if (HOST_BIG_ENDIAN) { + return 0; + } if (!nc || !nc->info->set_vnet_be) { return -ENOSYS; } =20 return nc->info->set_vnet_be(nc, is_be); -#endif } =20 int qemu_can_receive_packet(NetClientState *nc) --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760103908; cv=none; d=zohomail.com; s=zohoarc; b=ZmNRdKK7mIo1fno2IrMOyo8/Bjwe3eRmQ7L73s9ara8/Rvl4w1A+NrYWG15c2bzTtmeK60oTbHfg2PuuuqI480lgXY2xgCFxAMmbY4kxg4ODJkHaALkWRDrgxv8M7pfc6iR1anyZUMckt+ObPsC8St7RNAix9DYewHHeFyY2ua8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760103908; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jgHI5TW5wRLub5UB51c3C5+CkIARcYS3PKLqV1Iqios=; b=U6pxtyok7lQU+iIyqDsNVpxlR79bADSzTZB/FX3ntCADBnuL0z4mscXK4Gq3rLmVgY/vpLyvI5tpnnFyTiaj1/eJInUA+kb+i6XM+E4qIXDvrL1D4uvwrBMZAVQA/78OhiHqGWW7BVzNdvKwrQ+OsumffFo8MOpwV2LJM7pzh3c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760103908866311.8680176628128; Fri, 10 Oct 2025 06:45:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DPV-0002LY-Du; Fri, 10 Oct 2025 09:43:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DPB-0002Gy-Bb for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:33 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DOl-0007wl-VF for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:32 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-46e3af7889fso11681465e9.2 for ; Fri, 10 Oct 2025 06:42:59 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fab3703adsm59917755e9.0.2025.10.10.06.42.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103776; x=1760708576; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jgHI5TW5wRLub5UB51c3C5+CkIARcYS3PKLqV1Iqios=; b=IltQhRWvYpt0+OGIqM6wz4NAEs6czEH0QA7n9e6vNbdyJdS25vfx1dvxYbS4VBSwRk /Pq+je/jX3L/CGq5Ahbb/PSS6+Ixa4p+mNqJ74PlVlVP1F+mXK/Dkzi5mxTUVIvjWOYJ 8mXe7koqfUyBeor9Hhl2W1GvA4CJKrQurjpz9iMuJ9fzzkWOg1MJS854n3r0n6J85kn7 z6xn0AcMvUNOx9Y87v0zqL2EovQYvSs54n3wzuDIvp5W+78TojN72qWx9focgSAeuZ3/ 1/GeK2QcvIGnA3Oe2H6sR1nEJrgd5GjEDA2bj+KYPRYnlXZ0IjSaEYPxVvy+39TNC2cl dFWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103776; x=1760708576; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jgHI5TW5wRLub5UB51c3C5+CkIARcYS3PKLqV1Iqios=; b=jeoP7Y6/vQJ/jQyDjri4YkNhFLdn2cJtTcoiE8ubhSF4Ud9hnmA25yDbCTs9rmzaT3 dIw3f8lewfnEKcD+2KpG+PLBhU2qNBrAPrgTAZKM4jDyEhhbf5AjEK93XyyISGCm3URN DkOOLQucXldYzgXQgzeCLNg95fo1f0Ztzz0XMTK5NUA1/g/uw2mgNBVMauaV1rkDVFeg ZO/DaEvACSs2B3xukS8TYW29DWX8gaLzVZ/ZZTYY6vok2wK4Gd3PBc5MkQCAHkNlYGt5 reQRyKfP63Eb7AipZAWz5StttpWRLfTQSm3i0PtIrKwHZvLl9qAMLaqyqCBKyyGIS2El YeIQ== X-Gm-Message-State: AOJu0YyvWMaAk3TLugSHPM2RnpSa+k9/eHRQEQPQs6IEpfeugK+9Ybk/ olkuY5QwX3OajuaUoEwMAck5udfCOW9LYSPtF00wn24QUVDZ2+w9BLTnalfYypnEDqR9KWm1r/+ KM2KgYFvEhQ== X-Gm-Gg: ASbGncs0C/Zu/lZ9n1gNFq9YnB8BpYSiJYZcw/53wFBqCsQz57j6DNopRn+JvNKETxT s1l0HEO4onU0w3bRLuZDJQCBbtWkLbjxhjj8gf4YSaqQ87i56botIbehhZs9llLS8NZs1fkLMOJ XmDzpM0ctGxoG7MGeNp2FtoT+BtRcHwq04Hq/A9KuWeJ5NG0MzdeuRTemwGMnMzu3V080cwXRLY TSSumIW+FC+f0/d1QKGGw547t3U0ZoM4Wc19irV0r9NsqhLjX1EhFy5xRyX6g2Dd613byA5u9c1 K2ZbjL/pTEHTV2hzXXbm3gTqRrkZhXxr/XElw/W2dpAEaJ9F7eFVZsFKdch6/xNoEnxa+qDckL2 9G7f+hhcbE2MxtYvbQ9qXM6xeoiwjQ4m0f0HldoIZtQHldanWItSVDiOnOm8ouYh63V17Lb9Avj uncbc0ctGYkLOx7Off3mY= X-Google-Smtp-Source: AGHT+IGJIe3UiNIYTyhOEp3oDaTG0ipq8utQ5sMTJPXtgT8ePs3zSizNPMCFuwtMpE4+/UxIGkxGWw== X-Received: by 2002:a05:600c:1d18:b0:46e:3901:4a25 with SMTP id 5b1f17b1804b1-46fa9aef67bmr77368985e9.20.1760103775971; Fri, 10 Oct 2025 06:42:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 05/16] disas: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:14 +0200 Message-ID: <20251010134226.72221-6-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, SUSPICIOUS_RECIPS=2.51 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760103912694158500 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- disas/disas-host.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/disas/disas-host.c b/disas/disas-host.c index 8146fafe804..54be5ef18e4 100644 --- a/disas/disas-host.c +++ b/disas/disas-host.c @@ -37,11 +37,7 @@ static void initialize_debug_host(CPUDebug *s) =20 s->info.read_memory_func =3D host_read_memory; s->info.print_address_func =3D host_print_address; -#if HOST_BIG_ENDIAN - s->info.endian =3D BFD_ENDIAN_BIG; -#else - s->info.endian =3D BFD_ENDIAN_LITTLE; -#endif + s->info.endian =3D HOST_BIG_ENDIAN ? BFD_ENDIAN_BIG : BFD_ENDIAN_LITTL= E; #if defined(CONFIG_TCG_INTERPRETER) s->info.print_insn =3D print_insn_tci; #elif defined(__i386__) --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104269; cv=none; d=zohomail.com; s=zohoarc; b=cXHAnZRv9N5IwMQk9Vllr+Mk4PoFs1OPo8o6rN39VFVN4TDcoMQmpcE4+hZ5NUIyv5QyyTv1sZvnMzcaK0XBPeK6C74yurBNhmMqtUzoehR7kGAyeDfyyNlrNbSDoDfoKuX2mUeIaW6IfnEXi7lfcEfOuzLiYpqccojavjWWKZ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104269; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TwAzvO9gvcfrUDpFLGxwbVJ7FPHxQaLieV6nfbJhlno=; b=DYyHO70cfoH0L/0iOLAwaGp0Se/kf7unKh4gg4+b31DpBBHGT3ziSoqaIW0OTY8DVWmj8Y8p3KwStiEc1a8Tnbk0csHf2iKOHK44Uc3v6HUaEhrs5Lb20tteNAFwtfnWwgmXQHY09IGottB/+hfthMT2eZjCVJpjvFtLkuJmEC8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104269074447.0170704449928; Fri, 10 Oct 2025 06:51:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DPn-0002Va-7N; Fri, 10 Oct 2025 09:44:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DPT-0002MN-4Y for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:52 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DOq-00084T-99 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:50 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-45b4d89217aso12155105e9.2 for ; Fri, 10 Oct 2025 06:43:06 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb497aec2sm48065605e9.1.2025.10.10.06.42.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103782; x=1760708582; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TwAzvO9gvcfrUDpFLGxwbVJ7FPHxQaLieV6nfbJhlno=; b=q4MWCMfQNBPXg3A6nbpj0bJXV1rOdBextWwOtk0+a2sAw6O5N0YZPIkI8vtsRF1PN7 nAShrmlT2CV7qEFDgU35JQXWLTjqmSfDxz+g7cy8AUcZCbSYKYXaxRD1GCk80Gu2d6VG v8oxDY+92mWisUZdyb6xj/GHdMpbufw/xON/FedHC543e+FYRpcM8wdSISDXpu8gvZdi NvLV786qi4xZiduSjIRD4IhMiE09bEkgKG7tfD+D3raMxGUfa9bHIEDMKolRIOIaqj1T eHxofA0UGtZYFoK6k2/NPy2hd2bttkB8+B0YeqX3+1+4KLaIRdTQn/rZdyJ9ySiMGOEk hkTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103782; x=1760708582; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TwAzvO9gvcfrUDpFLGxwbVJ7FPHxQaLieV6nfbJhlno=; b=f4zDTKSEECS9qs0CPJ2wNjvkxXs9ZxuHLA8CeCJ5orviFM3dIiAEkBvkCDUh9qhkFJ /N8Ovn1uARvWASYTvLWvoFIWqclA8wfZYbgztzMNMLswDEpI7wrEcMtofYtYdA9DsC6r Wi9Pahqge2klcsLiB22+ixqtuZs5uRZnpHLtL7s3iXumSXh0w4hkeuW/4nG5HdH6qUfE NnOj/V1fFSgExKaXso97eGEtOEuKKqoLfNrjAZCZTlJsf2quiWLbnMzDpprej+IqmJcn ipcE0JR8z+LzWiYXpIRJZRCqJui84HRtpFooUN6X8IEc8dube3e1Y1sWyVe/vMIfM4Lz Ltmg== X-Gm-Message-State: AOJu0YzkQ1br3IFCihDfVhz21KAKXmU5c9Td0r8HeTb1ncHewNY7lym5 HrUS3EbgG/FF1LQkZjBP/1IxGlS+6spgzEfHmGRcTqEqA4VvVatQgD7SVRLUod35UPxthdaqiSc oO3V8V5DG/Q== X-Gm-Gg: ASbGncsEtmoQnkkNn+MEm13z9X/gQmqZmkupWUE9ApCvK58abK/LDOOILti7jfsyCCj SAnQRmLweX3xzPT24CzGSDXbLNZonKo5tljkCsLUBPYlsZlshwDNoGRK7oe+OktYlQyK2dO9wB5 IbcJyKmcel6t6hykx3eSeNz0kgvoTSa9SMUeBFuw3hA48b9l7G/DmrIX+Lb3WlZLJa7wPpIgIer yaKztEN6JWK+a6tC2qNSoNzckxV7j/lhQiqhGHdyfw/u4cddMiAoCgXDMUPE05sKXA+/2EHW95H 1xKzH2NRh3HZ4jeelBd6Idp0xa6TrSaAslGC06G+LA0UMbWE6lpkdS67DvEtKUghUGRqy65gQxh 7MPnY9mXhciFA9XdAtROQdDe8wGkwRHn6laXdD1qx+arkbCF1h57bC8CwRBtJagyvDNdGhxMqBe cQ78JN3L2eEDYB3qvyrzsh7cIhWiaiNg== X-Google-Smtp-Source: AGHT+IHajMtSeTIEyh6n8MyR6pgrCZEB1nqfEHOw6v3cOEm9Bb6+kEevt48OwTYU3ThjT8h4iDk1yw== X-Received: by 2002:a05:600c:1d18:b0:45f:2869:c3b2 with SMTP id 5b1f17b1804b1-46fa9b1834dmr84819305e9.33.1760103782247; Fri, 10 Oct 2025 06:43:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 06/16] hw/core/loader: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:15 +0200 Message-ID: <20251010134226.72221-7-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SUSPICIOUS_RECIPS=2.51, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104271362154100 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- hw/core/loader.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index 477661a0255..aef10cb3f2b 100644 --- a/hw/core/loader.c +++ b/hw/core/loader.c @@ -491,7 +491,9 @@ ssize_t load_elf_ram_sym(const char *filename, =20 static void bswap_uboot_header(uboot_image_header_t *hdr) { -#if !HOST_BIG_ENDIAN + if (HOST_BIG_ENDIAN) { + return; + } bswap32s(&hdr->ih_magic); bswap32s(&hdr->ih_hcrc); bswap32s(&hdr->ih_time); @@ -499,7 +501,6 @@ static void bswap_uboot_header(uboot_image_header_t *hd= r) bswap32s(&hdr->ih_load); bswap32s(&hdr->ih_ep); bswap32s(&hdr->ih_dcrc); -#endif } =20 =20 --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104074; cv=none; d=zohomail.com; s=zohoarc; b=mh/Yqh0C1ZLFaSMqhqbcTKh+Ygj6RX8Jn2vpycy+SQZ+nBPiTnX6MeiKuP0LrVnfvhm3ynyY9nPkcsuKUJaCHjNR+fOjaXwKIcr17ZrJ/uFhwou0oUv223VhcfHQRgGzJ3xUBFu58V3qhD3BbSMbcCmgF/tgihtOWEz9O0wZw44= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104074; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oW7ljjIx6q7XqiZM4nIHhftMogwFYcVf1dksbF3LOtw=; b=cJ4sOENpgg4cdCu+FcVqTdGhJPNOywmNp6c38CGOhvyvY82feQPbbDS0fUUl6LWULEvGn7vWPYqTHhiPaRNgQC48KhkqexHOOU/xeyfh1GqxObl1Bt5x3wGxLkZVhE4set6n9zFEKBcgV0IVvg0B0mu5xEBhOpw6LdZM6WQH8vk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17601040749421023.3439207753335; Fri, 10 Oct 2025 06:47:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DPm-0002Vu-Nn; Fri, 10 Oct 2025 09:44:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DPb-0002Rk-07 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:59 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DOt-0008AR-OV for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:43:58 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-42568669606so1508688f8f.2 for ; Fri, 10 Oct 2025 06:43:13 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5e0a03sm4251914f8f.37.2025.10.10.06.43.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103788; x=1760708588; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oW7ljjIx6q7XqiZM4nIHhftMogwFYcVf1dksbF3LOtw=; b=XFIEcUMiYaWph1hWEOxt1k8H5YPVjwmTtsi/HMfEx5rSs0zGpm8nKYuOIVBqTwnahd YMVMOhAW8NLSxMorvM3wkPYr0VubmG24z9ETWAodiofGYOD3NceQiR7yyzxe2Su+axIB 6+aaCsXbpsfj+SPyBurtwIGdKmD7+E3S8+C55WbV7gwfYkbv2d8yBPjBxlmsSvFy4PXp bJ+xtjVCTUJa2TB9J41TFA+/L+Hec+T3v0TCBnEDTy7F2soy2J1f0rlcRcWANPhckXW7 rvVTRDUQliXvzlBgxUbscEFLthUnoM0Dh2goqq8uvNeQzdQR5joxIGDqNPnwUcPbDhKK AgZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103788; x=1760708588; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oW7ljjIx6q7XqiZM4nIHhftMogwFYcVf1dksbF3LOtw=; b=CBM00YGCpky4boNRUDxukaBoLg40U+bPhaTa0dcz21KrgWYVbP9f+sTxX+kXNp0sLz 4NCHXDXbU9qrCtzVpyjk2E2uzW8+AJzhm51ZGR1a2N1DEvo6jpVvDGK7zsViDtFf//WB JlFjBq09k1Qo2TQYbgdRFhBJkmsdPR1v+NbK9d1FM/Lwvqc0NmFlzK85F4rZa4OIWEaZ V+WT6bHcjbzM+xEJ/LYl/m47CxX7P/sYnbvV6Kix5IM3x6glhel30uYrv6G7/D7ZnCLc cAL4rz4uioTJaCDDwlwQ0NrPoKu/MacPszSzi8T2BcmeA9fjcyz2P+DpgUPY9OSoClZ+ O26g== X-Gm-Message-State: AOJu0YwomiDp23M+2+QPWNtYiiNnBC1uQhGoMc7YhV1Sq3qnm/tDQmiZ hvbX7ugWciowf7JdE+qGSp/lg2BnMTGV4YvDONWwFMCJllekoDVvdVsIz+tr9ju5TFbNLihgj7F Aoiwli4HWzA== X-Gm-Gg: ASbGnctiosuMZo0I7ENhhgOblwt0Xy53KbBrLMjMem5iumnnllBoYDuXJLyFyTJohQv ZEBoDWwyinPOu2Hg9uXeg75BcUilivTmyCOToRl5CO9MVwwz8LXwV8BXL0O7phJz4cOhByWT2e1 SMy12jzJQgMmPYldVdwQ4K6/9r9DPKdGuNkQHTLgqU47tWyKqOoG/1CNDt5nnRX52FPz1MBSl02 LVZCrOzMWbw2GOCl6j82cSAlPIr4etJ7NmNH7EfEfeR3YvSFJDmlGmJWXzGU3VPH4qw4PcDP2T4 PT50lWTaJncQREPaIfMrGtEcZKZmqRzLY0orP5AMCWRmfzcaDQgstWXbx2XFGJuAAdj3drGb4M4 J9J9QIH/XwrHa0oHzAjLhvyZM25xdu5sMgdm6xjYE8EGmj3H4Jx8OLFMwMTAPxk2Be+SSvNV/sC hxQEo+zOp6JanNMocYpVY= X-Google-Smtp-Source: AGHT+IER+sO3KvNTLcD7naZf2cjwxuD5AfMcwMWeeCbkQGK5l5rY32mSt+FRAWoPj04hX800Z8y8Xg== X-Received: by 2002:a05:6000:2303:b0:3ec:dfe5:17d0 with SMTP id ffacd0b85a97d-42666ac42d9mr6674973f8f.9.1760103787601; Fri, 10 Oct 2025 06:43:07 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , Helge Deller , Gerd Hoffmann , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , "Michael S. Tsirkin" Subject: [PATCH 07/16] hw/display: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:16 +0200 Message-ID: <20251010134226.72221-8-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104077098158500 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Akihiko Odaki --- include/hw/virtio/virtio-gpu-bswap.h | 6 +++--- hw/display/artist.c | 12 ++++++------ hw/display/vga.c | 20 ++++++++------------ hw/display/virtio-gpu-gl.c | 8 ++++---- hw/display/virtio-gpu-rutabaga.c | 8 ++++---- 5 files changed, 25 insertions(+), 29 deletions(-) diff --git a/include/hw/virtio/virtio-gpu-bswap.h b/include/hw/virtio/virti= o-gpu-bswap.h index dd1975e2d40..279734231e2 100644 --- a/include/hw/virtio/virtio-gpu-bswap.h +++ b/include/hw/virtio/virtio-gpu-bswap.h @@ -29,7 +29,9 @@ virtio_gpu_ctrl_hdr_bswap(struct virtio_gpu_ctrl_hdr *hdr) static inline void virtio_gpu_bswap_32(void *ptr, size_t size) { -#if HOST_BIG_ENDIAN + if (!HOST_BIG_ENDIAN) { + return; + } =20 size_t i; struct virtio_gpu_ctrl_hdr *hdr =3D (struct virtio_gpu_ctrl_hdr *) ptr; @@ -41,8 +43,6 @@ virtio_gpu_bswap_32(void *ptr, size_t size) le32_to_cpus((uint32_t *)(ptr + i)); i =3D i + sizeof(uint32_t); } - -#endif } =20 static inline void diff --git a/hw/display/artist.c b/hw/display/artist.c index 3c884c92437..8d73f2d894d 100644 --- a/hw/display/artist.c +++ b/hw/display/artist.c @@ -738,9 +738,9 @@ static void combine_write_reg(hwaddr addr, uint64_t val= , int size, void *out) * FIXME: is there a qemu helper for this? */ =20 -#if !HOST_BIG_ENDIAN - addr ^=3D 3; -#endif + if (!HOST_BIG_ENDIAN) { + addr ^=3D 3; + } =20 switch (size) { case 1: @@ -1132,9 +1132,9 @@ static uint64_t combine_read_reg(hwaddr addr, int siz= e, void *in) * FIXME: is there a qemu helper for this? */ =20 -#if !HOST_BIG_ENDIAN - addr ^=3D 3; -#endif + if (!HOST_BIG_ENDIAN) { + addr ^=3D 3; + } =20 switch (size) { case 1: diff --git a/hw/display/vga.c b/hw/display/vga.c index 90b89cf4044..01b1cfa98d3 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @@ -1307,13 +1307,13 @@ static void vga_draw_text(VGACommonState *s, int fu= ll_update) if (cx > cx_max) cx_max =3D cx; *ch_attr_ptr =3D ch_attr; -#if HOST_BIG_ENDIAN - ch =3D ch_attr >> 8; - cattr =3D ch_attr & 0xff; -#else - ch =3D ch_attr & 0xff; - cattr =3D ch_attr >> 8; -#endif + if (HOST_BIG_ENDIAN) { + ch =3D ch_attr >> 8; + cattr =3D ch_attr & 0xff; + } else { + ch =3D ch_attr & 0xff; + cattr =3D ch_attr >> 8; + } font_ptr =3D font_base[(cattr >> 3) & 1]; font_ptr +=3D 32 * 4 * ch; bgcol =3D palette[cattr >> 4]; @@ -1489,11 +1489,7 @@ static void vga_draw_graphic(VGACommonState *s, int = full_update) vga_draw_line_func *vga_draw_line =3D NULL; bool allocate_surface, force_shadow =3D false; pixman_format_code_t format; -#if HOST_BIG_ENDIAN - bool byteswap =3D !s->big_endian_fb; -#else - bool byteswap =3D s->big_endian_fb; -#endif + bool byteswap =3D s->big_endian_fb ^ HOST_BIG_ENDIAN; =20 full_update |=3D update_basic_params(s); =20 diff --git a/hw/display/virtio-gpu-gl.c b/hw/display/virtio-gpu-gl.c index c06a078fb36..c29152a3c7a 100644 --- a/hw/display/virtio-gpu-gl.c +++ b/hw/display/virtio-gpu-gl.c @@ -123,10 +123,10 @@ static void virtio_gpu_gl_device_realize(DeviceState = *qdev, Error **errp) ERRP_GUARD(); VirtIOGPU *g =3D VIRTIO_GPU(qdev); =20 -#if HOST_BIG_ENDIAN - error_setg(errp, "virgl is not supported on bigendian platforms"); - return; -#endif + if (HOST_BIG_ENDIAN) { + error_setg(errp, "virgl is not supported on bigendian platforms"); + return; + } =20 if (!object_resolve_path_type("", TYPE_VIRTIO_GPU_GL, NULL)) { error_setg(errp, "at most one %s device is permitted", TYPE_VIRTIO= _GPU_GL); diff --git a/hw/display/virtio-gpu-rutabaga.c b/hw/display/virtio-gpu-rutab= aga.c index ed5ae52acbe..f82a84b53aa 100644 --- a/hw/display/virtio-gpu-rutabaga.c +++ b/hw/display/virtio-gpu-rutabaga.c @@ -1074,10 +1074,10 @@ static void virtio_gpu_rutabaga_realize(DeviceState= *qdev, Error **errp) VirtIOGPUBase *bdev =3D VIRTIO_GPU_BASE(qdev); VirtIOGPU *gpudev =3D VIRTIO_GPU(qdev); =20 -#if HOST_BIG_ENDIAN - error_setg(errp, "rutabaga is not supported on bigendian platforms"); - return; -#endif + if (HOST_BIG_ENDIAN) { + error_setg(errp, "rutabaga is not supported on bigendian platforms= "); + return; + } =20 if (!virtio_gpu_rutabaga_init(gpudev, errp)) { return; --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104207; cv=none; d=zohomail.com; s=zohoarc; b=XpOUlWNw/AITE36Y1/5MHT48iPG/WzhkqbV/y43isl/iX74Tmvsno/UdUIdp5XLBxsm1RxYO794tnh1IIme5Hfqj0Rvs24usa2Oi4rg3FA2KFQ1y85uUDbtBj1RpMOk+rONLwTbP9ZjNbcYczo0ygAjaapDxU4qyi9OmJryZ8G4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104207; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=PEHpoi3UcJ1d9mK9rygYrDQXxzIPGGRGzqCX4yQQSa0=; b=iS2sPXxlsu/SD5azQ1l4gxIuntLiywmvknDpLwM/DPcWFNd4xDXTE72RXA567IqPmFdlrFQQ3oyTwYulUXGEQFRcgxuI/Tyr8keO9tVstNMe9NZqbfIQ4IEIMOewVC0ABC7XOMvzvF+++HsWsf2uo33jmGh3HnmY4RDTbHIuD0U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104207955544.1130950634057; Fri, 10 Oct 2025 06:50:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DPz-0002eo-Vw; Fri, 10 Oct 2025 09:44:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DPp-0002X3-3o for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:13 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DOx-0008CY-6H for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:11 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-46e4f2696bdso22403795e9.0 for ; Fri, 10 Oct 2025 06:43:16 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce57d49bsm4549912f8f.10.2025.10.10.06.43.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103793; x=1760708593; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PEHpoi3UcJ1d9mK9rygYrDQXxzIPGGRGzqCX4yQQSa0=; b=dmeNUJ+9eo3l31jh8ljJPM2HNJ9PPcqFqI1JP08q8y01nYGHCkAo1mu8I0FBK7WTuP j7uI9AKrp5BULjVhfXngRWB0ly65GysS3jgWAu7QnWzpBkrXTxz8ToqKRxTkZ5l2Bmua IaJ8C/Qrp7QdOn/HUsGnsDS0DMlmr6BOIkzQgrZzl8rP2jU/d6KJ90gTXWHobITHEQ3h mlIgm4IiyLPGA68qDLZH0jcDH1m9UqJ2MlG74tmT2X8vidac7BgAlRz1LHL2CgQbh5Of nZyFDWUmEBItZqLr46YKNVf5PkWQhUXkyUuawaqoejnzeBl8ODx1/cqU5ggy4+TeI3fi vYXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103793; x=1760708593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PEHpoi3UcJ1d9mK9rygYrDQXxzIPGGRGzqCX4yQQSa0=; b=NTlRRM/FnkQCpZjDkE8CLSl/k5qS6D9YEh+iKiXqPeI8Y61XauTFGStGbbs9pZVR9d fCHdWZoB1aNxFPTYfUonxXeXVnVU2LwDFj53JmH8wRtNTT+vL+xyKiHssvZYsnDyyiVt N3gOYlBPbYmTU4aZ8m8VBZKKO5AXQHcMZAUmDSjA3N2tygZrmyoJ7DNU8gbzUEO9niIW BbbNeW8f5kzwgIIqgP6GIrDTqcOxGhHlc8UASb2x50/reLtAe6o6tuY+WxbdC+9dR9Iw MIAhES0yhHxhVGRPPcAp9hh2Vpj6MHnsuVb0WfO1d0X5BCwGhmMEeRvaqOHgifOXasVZ tgng== X-Gm-Message-State: AOJu0YwX4gfafXv7nTThR7Uff7ZEB0K/AKKEaWRU1zKVLVzLfrtOvOyC fUjxXIMd+GvqNE6u/PM9oZa9h2SFuNc2dvVfJCGmGhXTSA1Oc39zSySbHyN60pEUYJ3w7f0C/Hh 6RXvHIhhIpA== X-Gm-Gg: ASbGncuyRHFACHji412TnGkl1OEKIjLsWjsEcM4ZyoZS4Ib1pL7Ly0aVRLdSxJqk2Nv 0coATLkXLuYdwZQHqwRB+nNwk1MOO4/OXnhskWO32PaKbisVQAEXIxaaQhdxd8xmQqC6v1bl8jG pcE85ujEcDgztqSFQE51+ool2YkFi41gyODHGdVTc5XLCYIrtTjn/A7t68LAwYN63T356/U9gT4 oe9ZsdLYOPH3KTIcY/NKGLCeAqRDksLwT9x1OM+WvDNags3nt66Fqe+8kfebOEHixr57ZJHV58V jYc7BWjEhQGT0sA7Fx/ieCUQYU82WVfcLuols2H/8CYLCRtAQT1kO8Udl/ZwV6dWf/D+dg3w9rL bvhxKLP0lbzJg7H+mT6Lyxb8/tIWq9h+e4WiAVHkccvH3/xbkSZJCb96a+WqtIaXDuzg/PXo6XX 6ANCD5JlW0ZFxT6i7g3CM= X-Google-Smtp-Source: AGHT+IGMyuXiXr2hhS5RrEBqHmkNz7q+JdBDAhdMbSHh7UARDHiDg+5JVxi3RtV8WP/bCBvAXMkyAQ== X-Received: by 2002:a05:6000:2410:b0:401:a3d5:5687 with SMTP id ffacd0b85a97d-4267260e17emr7032365f8f.49.1760103792680; Fri, 10 Oct 2025 06:43:12 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Michael S. Tsirkin" , Stefano Garzarella Subject: [PATCH 08/16] hw/virtio: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:17 +0200 Message-ID: <20251010134226.72221-9-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104214248158500 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/hw/virtio/virtio-access.h | 6 +----- hw/virtio/vhost.c | 7 +++---- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/include/hw/virtio/virtio-access.h b/include/hw/virtio/virtio-a= ccess.h index 07aae69042a..80328912ad3 100644 --- a/include/hw/virtio/virtio-access.h +++ b/include/hw/virtio/virtio-access.h @@ -149,11 +149,7 @@ static inline uint64_t virtio_ldq_p(VirtIODevice *vdev= , const void *ptr) =20 static inline uint16_t virtio_tswap16(VirtIODevice *vdev, uint16_t s) { -#if HOST_BIG_ENDIAN - return virtio_access_is_big_endian(vdev) ? s : bswap16(s); -#else - return virtio_access_is_big_endian(vdev) ? bswap16(s) : s; -#endif + return HOST_BIG_ENDIAN ^ virtio_access_is_big_endian(vdev) ? s : bswap= 16(s); } =20 static inline uint16_t virtio_lduw_phys_cached(VirtIODevice *vdev, diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 266a11514a1..6343477b42f 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1168,11 +1168,10 @@ static inline bool vhost_needs_vring_endian(VirtIOD= evice *vdev) if (virtio_vdev_has_feature(vdev, VIRTIO_F_VERSION_1)) { return false; } -#if HOST_BIG_ENDIAN - return vdev->device_endian =3D=3D VIRTIO_DEVICE_ENDIAN_LITTLE; -#else + if (HOST_BIG_ENDIAN) { + return vdev->device_endian =3D=3D VIRTIO_DEVICE_ENDIAN_LITTLE; + } return vdev->device_endian =3D=3D VIRTIO_DEVICE_ENDIAN_BIG; -#endif } =20 static int vhost_virtqueue_set_vring_endian_legacy(struct vhost_dev *dev, --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760103918; cv=none; d=zohomail.com; s=zohoarc; b=NakZAb9xgHnuHeGmW9j3leAj10W0mUJPlZbwvXiShyvfELCadWoFgwywcOidXftdcqWg7T8M4uwLfCUXdTKZGjlonNgr5p7DOYtZ4lBJ6PC/tZYRAOZwpIankvxxgLvKEyFHp3njVNWKl5vIEe58tQ3fzDq/xVOXVsOL4E0tOR8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760103918; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fQ1xy8T+SXo1JHTBucWTk/aOP1Ac+xvM/ygDmheTPxE=; b=bT+vpkBk6S6Dub9lGdA6YY9HxY/DEnj03u6FXwfBGuEBczQGZC9p/qgM0Q4EOA1fUYybvfeV4aEjBsg4esQTwflkGCsB50jySVwyqz9V9ZQzDMsywhYepbmpKYk/zR8MQ5MEoCimM3LyciJY2CnBa1Rxvw9CioMaBxo4InQe6kI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760103918774802.3358529499016; Fri, 10 Oct 2025 06:45:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DQ9-0002nT-99; Fri, 10 Oct 2025 09:44:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DPx-0002fW-M1 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:22 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DP5-0008DO-5R for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:21 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-46e37d6c21eso12414385e9.0 for ; Fri, 10 Oct 2025 06:43:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb482ba41sm49073145e9.4.2025.10.10.06.43.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103798; x=1760708598; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fQ1xy8T+SXo1JHTBucWTk/aOP1Ac+xvM/ygDmheTPxE=; b=m5w//XjQlm2YmAwHdnjSLtZZfmwSjmFXltxEjVwfgPnIQT6t1sSdvSd0153IH4PbQZ p+pgGHBwvTHT191v2USp9WK78d/ObrCRCoGc34LXVSOn2ukW4BRhe+0ORKRmxYOxy60Q kdAFjCsICKQFjLqsCLY7E6wQQtTCnkGOjwrhH09CCIZkSirHQiU3ttRz+Ax5li4eXJ+i jLHtPvBqCvFrkYGTqBo7KDkPh/yVYWUSwq78cI1TW/dZPRQP4ZBrzq4a7FdW8vNUwT2H 0WWxix/q0b1e9zaZhOq7mvg+zNdX7RWiZTP3X+OtLMIH+eQrKf8ZGCb057un/SUeWkt2 ih9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103798; x=1760708598; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fQ1xy8T+SXo1JHTBucWTk/aOP1Ac+xvM/ygDmheTPxE=; b=G47x01Uwyn7p5USEcf8tuIZN7RhvDBXUQFoJWXgdOByINnJzrwML+Iw5CJnwNjU+NY jFtx2GX+BIYrsW9qEKYvWLoe1W7CFbW8/jWDesckoddhwjbcGpWzD38qnuN7h9gRQDic NneeXqWwUL2qoExLMz85rhuG7Ili+zUWrq0BtKjITffNsfqwFFGP1Daajbu4vnxvrUkC KDd/zJrIT7W6TTM5QrsvCcNQH3YffrVQKywAtvSZGcAMAmc9BCHYVYGy2gInf0prGDDu MkjVACU9dv3GitvIlw+lYFzcxPl9ri55GsaTfFRGQ/nlFECOkV9PoJxn87A0iFAEoIrK 4dFw== X-Gm-Message-State: AOJu0Yxrh3xJORMSyU/xI0UafidIE9QOsNSF2TzBglGOGJmEXfCaZChl bRgiTh6Mm99NZ0yjkhGzMei7C61gUjwhxSnBnMIcpZ4hQucc0cWLawO9KasvK988sDZdw/Uf1Jk qxUG2Yoz4JQ== X-Gm-Gg: ASbGncvy5ZJdFOH6PySxaOMsvPS8ySah8epTHSBgywNgkWO8Qes7oc1ASlBcIZUYJVR oMczuF+IqLe6eHUI5Rnpf6NmfReRCL+ZtacFGvjL01S6zrBdb7aZCy8I74b8ch3RwS9PshWqOyy 1KYl5iSpBqRuUeN/0jHuZ1tC+pR2GKRx9fpzc6RrZoIoYkqBkQ1V6JD4UVzVhBxjBZMY2+VMnLC MNOon/UlQVTAoGet98pXNUsf616GSb8Ng7rZ15zzjGGY8nEOTRgMyHYTQG6P+cIfOuH3FLFAbPL 6oDKealk87D1g+lvaUNmFOjqpV0O0cPS/O9bkYvbW44iJd9FLUN58k6kUWgWiplHthnsqyBaFQ1 KBjxpUexySVqvagd+kCw6SqgMDThyIRCJq6B4WyBeJlU+M7BXbrZfda6NNgQ7xU+MGS6v4s2PZp yesov05P8QoGe1D0+mra3x2K8phJXbSA== X-Google-Smtp-Source: AGHT+IFIPOzsMbnQa1BO9UiaMqXHUl6fRwbyBMETY9o6Uiq0UhksFIKSO4ECCTsdlFGZdCkYMwb9Ag== X-Received: by 2002:a05:600c:a43:b0:46f:b32e:5094 with SMTP id 5b1f17b1804b1-46fb32e50fcmr47908965e9.32.1760103797977; Fri, 10 Oct 2025 06:43:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson Subject: [PATCH 09/16] target/alpha: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:18 +0200 Message-ID: <20251010134226.72221-10-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760103921093154100 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/alpha/translate.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index a492520075e..b93cbe3b61f 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -235,11 +235,12 @@ static TCGv dest_fpr(DisasContext *ctx, unsigned reg) static int get_flag_ofs(unsigned shift) { int ofs =3D offsetof(CPUAlphaState, flags); -#if HOST_BIG_ENDIAN - ofs +=3D 3 - (shift / 8); -#else - ofs +=3D shift / 8; -#endif + + if (HOST_BIG_ENDIAN) { + ofs +=3D 3 - (shift / 8); + } else { + ofs +=3D shift / 8; + } return ofs; } =20 --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104494; cv=none; d=zohomail.com; s=zohoarc; b=Go78ugxggq+IP/Y0alNnO1Wzlngx65mrioPwztCcRpTFZzPlc5J5uawAUI/2vmhiurmF1ClYkExJqbevUAWxLZ+59efsNNdzsaFdoKvnq8rb8vpGUPuax4zA28fq3yKHFkDFUS6CG921WqlAoHvgZQB7HQ8x2yvkVr5uHsjSzlI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104494; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fZ70FBKY4+s0L/x7oUlvTRh2QaFbRkjPAeRTOspddlc=; b=Xfu+1dwBm8cmPHS47t1kr+fPg8w81gAIzbk+pycps/sSDTFmGhDsRmdTbxv2LBqS6ehbrBKx0oOqbkG0P9EhwxNUOzUGz6Nb5txzJzfb8iWPP5z0v/IG7FUAcfM+PaZmRbMS1GYsl1Xc5RGeBkp8EXgC45h8LDJPKoRq+WhyzaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104494316446.49923967224447; Fri, 10 Oct 2025 06:54:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DQH-0002tO-Eo; Fri, 10 Oct 2025 09:44:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DQ5-0002jh-Gs for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:30 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DP8-0008EF-Dn for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:27 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-46e326e4e99so15867145e9.1 for ; Fri, 10 Oct 2025 06:43:28 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb484c71csm49859345e9.8.2025.10.10.06.43.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103803; x=1760708603; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fZ70FBKY4+s0L/x7oUlvTRh2QaFbRkjPAeRTOspddlc=; b=MS0HcVCtPODZgk337AWLHzk+9tcLjl+KnG5zzpslXMkV6aIMxmSEZMT9/iW4YwspBG HlLcpItix+lOoZf74/AtFf77wPegmiLiTjRvWF9MZfXrHksJEidGnlKLxin6xGYhliPr SGUnm7RMwQBwOA0lWHZcFag9fMFJoxDshqzFIlfliOMrO+MhiHdvbYkrKq5DFSdUgE6T 6RNZe3Y0G3KU+kKHlriYaFbTsSpixmrhYaXaLGPq0xsdum2DUTu1ui0vtj+NIMRe4WW2 LvhzTZlw9ryDM6C3GGSJSJ+kyAtQUuRr5UOQ8pGxM7vPO4p5lzz73IR63YrBBA+DiR/L jguw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103803; x=1760708603; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fZ70FBKY4+s0L/x7oUlvTRh2QaFbRkjPAeRTOspddlc=; b=ChdsweYc8CeFEy7DJZzyE4Mpxu0zBESahT7kxktFzRDgrTYI/oD/CZsjN1zpl1YetL 0Ol/iMKLDwLwST6Z3wOTXIvRByxa/IV0iJDidPjwNQ9iBt4NcX7to6pCQwyz/4uFREPt +mhdJRoocH3C5QYx4uwlnOR1tO5pYY7qKBfoJXBHLztEDBd8GtvIpWyhtiU7BrvEtrFI PmxSbpLDZd+MAOgMrb7EgVqLvyy3Yb8MU3P7nRJVAGwJ/ETjTAd4u2zkUeQIPjSZYsy9 UnFcxi4wrI7wtzQBGJsAJwiDRkLicw30J9MC8Foeoa0mP3iSlAKOldPgk9C4Rqw9zPXS oACA== X-Gm-Message-State: AOJu0YyOPMl4VbTPbLTXRZ8BIZCLzs37HOuSBTihBk9jvFMHRdPtGhS9 NeIGtmzKmtXj+NXNS3EE0y6H5Qg5NWjZcqlUwMoWb4rbNpvgVPwGdvsazj+OLuB7viPR2TQS/OT ih+FFypQHxg== X-Gm-Gg: ASbGncvDSVJ66fL1PjKTkTANcQ+l0eFIpcV1UWtUhylHqOptpDMwR/wCpnN9VxBtIbN gH378KMAoREnI1tMGE/Uo5RXoQUb2aLTU/SfpTWiZ5U4QUvPpWchrUlhPsgQLB817aSNnic1Lqj rhPApwEql3zlYR2n9qbcbV0LrOVXgG6vp0BHVsv9+6/VdYnSubAnyGjAeKxNXhETRuFFt0XfAhk 3i6W8BQy+NggWEaricuR34jvx7viSVxNejBEFcSmAXJanOl0qQyhdceK3lLrBXd5ajSLlNQG6BX ix+k8Z5BandcOoo3iG2+H/44U5E8tUJC51w0yi1HqxBLVcGIeBVvKRsxANTR9pcYkYr/Nnyautw nW+L88e7b1NA7co8Orwagl0NQo/CJAxg0aC1IofXpp4s2m3elp0u3oU9Qku0hxBZtPijZUaGmPM 5+hmKU7vhQ0HnbXs1IpHY= X-Google-Smtp-Source: AGHT+IHXkvIW8LcdXop7DKGm566+eNPdoRKudLm9xlk71CiBM0ihcQ2zOWB9SdW91GD7n6+nMLU6dw== X-Received: by 2002:a05:600c:1d9e:b0:46e:2815:8568 with SMTP id 5b1f17b1804b1-46fa9ebe0dfmr75001985e9.10.1760103803215; Fri, 10 Oct 2025 06:43:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Maydell Subject: [PATCH 10/16] target/arm: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:19 +0200 Message-ID: <20251010134226.72221-11-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104497717158500 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/cpu.h | 8 ++++---- target/arm/tcg/translate-a64.h | 5 ++--- target/arm/tcg/sve_helper.c | 10 ++-------- target/arm/tcg/translate-sve.c | 22 +++++++++++----------- target/arm/tcg/translate-vfp.c | 8 +------- target/arm/tcg/translate.c | 6 +++--- 6 files changed, 23 insertions(+), 36 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 41414ac22b8..3f0a578a72a 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1249,17 +1249,17 @@ void aarch64_set_svcr(CPUARMState *env, uint64_t ne= w, uint64_t mask); */ static inline uint64_t *sve_bswap64(uint64_t *dst, uint64_t *src, int nr) { -#if HOST_BIG_ENDIAN int i; =20 + if (!HOST_BIG_ENDIAN) { + return src; + } + for (i =3D 0; i < nr; ++i) { dst[i] =3D bswap64(src[i]); } =20 return dst; -#else - return src; -#endif } =20 void aarch64_sync_32_to_64(CPUARMState *env); diff --git a/target/arm/tcg/translate-a64.h b/target/arm/tcg/translate-a64.h index 9c45f89305b..ce8303286ef 100644 --- a/target/arm/tcg/translate-a64.h +++ b/target/arm/tcg/translate-a64.h @@ -82,7 +82,7 @@ static inline int vec_reg_offset(DisasContext *s, int reg= no, { int element_size =3D 1 << size; int offs =3D element * element_size; -#if HOST_BIG_ENDIAN + /* This is complicated slightly because vfp.zregs[n].d[0] is * still the lowest and vfp.zregs[n].d[15] the highest of the * 256 byte vector, even on big endian systems. @@ -97,10 +97,9 @@ static inline int vec_reg_offset(DisasContext *s, int re= gno, * operations will have to special case loading and storing from * the zregs array. */ - if (element_size < 8) { + if (HOST_BIG_ENDIAN && element_size < 8) { offs ^=3D 8 - element_size; } -#endif offs +=3D offsetof(CPUARMState, vfp.zregs[regno]); assert_fp_access_checked(s); return offs; diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c index c442fcb540d..dd829666cc2 100644 --- a/target/arm/tcg/sve_helper.c +++ b/target/arm/tcg/sve_helper.c @@ -2861,12 +2861,9 @@ static void swap_memmove(void *vd, void *vs, size_t = n) { uintptr_t d =3D (uintptr_t)vd; uintptr_t s =3D (uintptr_t)vs; - uintptr_t o =3D (d | s | n) & 7; + uintptr_t o =3D HOST_BIG_ENDIAN ? (d | s | n) & 7 : 0; size_t i; =20 -#if !HOST_BIG_ENDIAN - o =3D 0; -#endif switch (o) { case 0: memmove(vd, vs, n); @@ -2918,7 +2915,7 @@ static void swap_memmove(void *vd, void *vs, size_t n) static void swap_memzero(void *vd, size_t n) { uintptr_t d =3D (uintptr_t)vd; - uintptr_t o =3D (d | n) & 7; + uintptr_t o =3D HOST_BIG_ENDIAN ? (d | n) & 7 : 0; size_t i; =20 /* Usually, the first bit of a predicate is set, so N is 0. */ @@ -2926,9 +2923,6 @@ static void swap_memzero(void *vd, size_t n) return; } =20 -#if !HOST_BIG_ENDIAN - o =3D 0; -#endif switch (o) { case 0: memset(vd, 0, n); diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index 07b827fa8e8..60a99fbe15e 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -2770,12 +2770,12 @@ static TCGv_i64 load_last_active(DisasContext *s, T= CGv_i32 last, * The final adjustment for the vector register base * is added via constant offset to the load. */ -#if HOST_BIG_ENDIAN - /* Adjust for element ordering. See vec_reg_offset. */ - if (esz < 3) { - tcg_gen_xori_i32(last, last, 8 - (1 << esz)); + if (HOST_BIG_ENDIAN) { + /* Adjust for element ordering. See vec_reg_offset. */ + if (esz < 3) { + tcg_gen_xori_i32(last, last, 8 - (1 << esz)); + } } -#endif tcg_gen_ext_i32_ptr(p, last); tcg_gen_add_ptr(p, p, tcg_env); =20 @@ -5394,9 +5394,9 @@ static void do_ldrq(DisasContext *s, int zt, int pg, = TCGv_i64 addr, int dtype) * for this load operation. */ TCGv_i64 tmp =3D tcg_temp_new_i64(); -#if HOST_BIG_ENDIAN - poff +=3D 6; -#endif + if (HOST_BIG_ENDIAN) { + poff +=3D 6; + } tcg_gen_ld16u_i64(tmp, tcg_env, poff); =20 poff =3D offsetof(CPUARMState, vfp.preg_tmp); @@ -5478,9 +5478,9 @@ static void do_ldro(DisasContext *s, int zt, int pg, = TCGv_i64 addr, int dtype) * for this load operation. */ TCGv_i64 tmp =3D tcg_temp_new_i64(); -#if HOST_BIG_ENDIAN - poff +=3D 4; -#endif + if (HOST_BIG_ENDIAN) { + poff +=3D 4; + } tcg_gen_ld32u_i64(tmp, tcg_env, poff); =20 poff =3D offsetof(CPUARMState, vfp.preg_tmp); diff --git a/target/arm/tcg/translate-vfp.c b/target/arm/tcg/translate-vfp.c index 8d9d1ab877a..cf3ca4b33c4 100644 --- a/target/arm/tcg/translate-vfp.c +++ b/target/arm/tcg/translate-vfp.c @@ -95,15 +95,9 @@ uint64_t vfp_expand_imm(int size, uint8_t imm8) static inline long vfp_f16_offset(unsigned reg, bool top) { long offs =3D vfp_reg_offset(false, reg); -#if HOST_BIG_ENDIAN - if (!top) { + if (top ^ HOST_BIG_ENDIAN) { offs +=3D 2; } -#else - if (top) { - offs +=3D 2; - } -#endif return offs; } =20 diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index 51654b0b91d..8ba0622489c 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -1148,15 +1148,15 @@ long neon_element_offset(int reg, int element, MemO= p memop) { int element_size =3D 1 << (memop & MO_SIZE); int ofs =3D element * element_size; -#if HOST_BIG_ENDIAN + /* * Calculate the offset assuming fully little-endian, * then XOR to account for the order of the 8-byte units. */ - if (element_size < 8) { + if (HOST_BIG_ENDIAN && element_size < 8) { ofs ^=3D 8 - element_size; } -#endif + return neon_full_reg_offset(reg) + ofs; } =20 --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104504; cv=none; d=zohomail.com; s=zohoarc; b=NLENkE5qdm65jgp9g6XaFfiCj4AxN7d9Dmz3lfJgsZl+aiVDJy81f5OFNIOeTQYeHcdTsdD/DcO4HS8K5ZveV/9S7Z8zYZf3Rvz02Em1WrCZB/yEohzL/d5QpVqjNlMy9UlzFw0DcX5uTYxdhI4pX5zeWOMaluP82U4Rq1f2ivA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104504; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=liEThv/wKJajj3nFHkBzaXuLPFXtT8t9IBEbSacuDCs=; b=IVOSPNoDi3CdWfvMqUjke2zy2dMZLvM3GLCgkeXsXVwgqcaEWhYrNnT/hensrWFdGEu4YoWRr2ruH3u1dO1OJ28JEh0qzRTvOXlctfVo0Yxz7f/c7j2COHuT8GY0TsZ9MjTR015d+Muua5GcjkiM5hUOhpVva/Z0g408YeVChIA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17601045045321.896176582150133; Fri, 10 Oct 2025 06:55:04 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DQL-0002xb-DC; Fri, 10 Oct 2025 09:44:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DQA-0002pc-24 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:35 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DPG-0008Es-Q3 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:32 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3ee12332f3dso704199f8f.2 for ; Fri, 10 Oct 2025 06:43:32 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce57cce5sm4474174f8f.1.2025.10.10.06.43.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103809; x=1760708609; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=liEThv/wKJajj3nFHkBzaXuLPFXtT8t9IBEbSacuDCs=; b=QCIU+pIYZ9VtRxF2rpLrqEzAusYML0G/xx8WnZr0YK1g5khL4ThOOEBa5GKU/nSZAh oIgR0EatgdGjFB0WoA1sJlnD8efeucXdR7veT9qxwkQR/Wb2G6BIlmhRvHmt09wwoE/O 0LJC4ZRm4SLyeKkHAJjzXA2lgzcegn9NWu9AbWCeXT1KbuZE4/fjejWV8CIEiQjAHCni UPqNP3iudEzZF2rQTTWs/B8HSzm2mnPzes/YEGwgftWHCtsY4B9oyiYpf684e0MvECHZ Ygt14gmzhJNWa/SpTX2wbu8UAE7D8iQksW9aSuVnTICbTNJOwUgBN9+MdW3LTTKPLpTp Sjtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103809; x=1760708609; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=liEThv/wKJajj3nFHkBzaXuLPFXtT8t9IBEbSacuDCs=; b=ni7RKP+Sjyy9qvsw2vTUmAR4jMIzh4hS7T+nNqFfLeYhrJhE7YlnNGeX4o4wSY4KkQ Q5XoohKvF+cwuxbvLh5ZwsMfG2Mue5tJV2NQbW5IQqNcBTFc+zJdVgvA1DJFSqFQ2Ta3 PP2bW+aIF1jqGSE/x/0LQZTprksXf+zK4JZrM483/HAqFaTeXMElwC3WNIhdiz46bsnw 7TmiLpu9qXShdo1Kh0JEJDSWxoY5ylqsaP3hnN+Ey1ldEu9WVFrldfOMtP4L5dd/QNly 6T3ZpeH3xDEyPCRAf7Gy/1ogrizergtnbRu6QGIZQsLuPmk9DQUtU2F4fjCrTs3ILjvH ZOCA== X-Gm-Message-State: AOJu0Ywbt9SbZiypu3zSXBDhT9YzdlHeYrd09L9eP4W8ngPxkYU2cA4o I5LLJk3pT7KsSIIjjBiJSulX2FmQa4vlrRYsypGqjZsATzLkUjk5VF7r2/VEs0eh4/LJ3eb4vQ9 GiNgpxAYFpA== X-Gm-Gg: ASbGncsrAnga38UF6grybUnYTDfLH85yQ1s+CAItj250RUnWitBShJuWX7rfIRUs0i8 0it370P7ADet5QN/1GusJuZ40HkohNO//aoaAqfBteOqO6ECvgfnptg501zB6B5a3kzITfnvsNh 9ZOrtJMeXa0uuGji/IigN1cRTia7AWSxHZA7cTw+zK/hpY7xnvEhyg/Nz5ttf4juXK4SkgQUkVS Q9Ljt/ZA+oXIQDHEkib7Ad1wB4nXhae30nZ9ovZhNlr/87PWBKx0dmwzaINu5LLRUpUoBhCupr/ 0M675QQxYr9FPQImnjo/mqOn+5F2FsQygmNHcoMJ2nTl9PsnIYDPaFdnxKa2gaR+yTjJNYgG4Vb HrKESW4ZeW+d6HKajb+XSo1TH2XzbIc4DnSjmWx/Pj84FPziBMa85Vy6DbPEYhV9Yy7SBvCqmvQ MWmgh93ubHEL9st2LkAZc= X-Google-Smtp-Source: AGHT+IGW6g3IRBwrgQ64LIPxMU+Cxf303nlsOYFSMp0KSf39t5vruwxMoX+O6e9XrwP6KHumAdOWVQ== X-Received: by 2002:a5d:64e8:0:b0:425:855c:5879 with SMTP id ffacd0b85a97d-4266e7d63f2mr7779098f8f.15.1760103808517; Fri, 10 Oct 2025 06:43:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo Subject: [PATCH 11/16] target/mips: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:20 +0200 Message-ID: <20251010134226.72221-12-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104506534154100 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tcg/msa_helper.c | 889 +++++++++++++++++------------------ 1 file changed, 444 insertions(+), 445 deletions(-) diff --git a/target/mips/tcg/msa_helper.c b/target/mips/tcg/msa_helper.c index f554b3d10ee..9f2d2bd6adc 100644 --- a/target/mips/tcg/msa_helper.c +++ b/target/mips/tcg/msa_helper.c @@ -4148,41 +4148,41 @@ void helper_msa_ilvev_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->b[8] =3D pws->b[9]; - pwd->b[9] =3D pwt->b[9]; - pwd->b[10] =3D pws->b[11]; - pwd->b[11] =3D pwt->b[11]; - pwd->b[12] =3D pws->b[13]; - pwd->b[13] =3D pwt->b[13]; - pwd->b[14] =3D pws->b[15]; - pwd->b[15] =3D pwt->b[15]; - pwd->b[0] =3D pws->b[1]; - pwd->b[1] =3D pwt->b[1]; - pwd->b[2] =3D pws->b[3]; - pwd->b[3] =3D pwt->b[3]; - pwd->b[4] =3D pws->b[5]; - pwd->b[5] =3D pwt->b[5]; - pwd->b[6] =3D pws->b[7]; - pwd->b[7] =3D pwt->b[7]; -#else - pwd->b[15] =3D pws->b[14]; - pwd->b[14] =3D pwt->b[14]; - pwd->b[13] =3D pws->b[12]; - pwd->b[12] =3D pwt->b[12]; - pwd->b[11] =3D pws->b[10]; - pwd->b[10] =3D pwt->b[10]; - pwd->b[9] =3D pws->b[8]; - pwd->b[8] =3D pwt->b[8]; - pwd->b[7] =3D pws->b[6]; - pwd->b[6] =3D pwt->b[6]; - pwd->b[5] =3D pws->b[4]; - pwd->b[4] =3D pwt->b[4]; - pwd->b[3] =3D pws->b[2]; - pwd->b[2] =3D pwt->b[2]; - pwd->b[1] =3D pws->b[0]; - pwd->b[0] =3D pwt->b[0]; -#endif +if (HOST_BIG_ENDIAN) { + pwd->b[8] =3D pws->b[9]; + pwd->b[9] =3D pwt->b[9]; + pwd->b[10] =3D pws->b[11]; + pwd->b[11] =3D pwt->b[11]; + pwd->b[12] =3D pws->b[13]; + pwd->b[13] =3D pwt->b[13]; + pwd->b[14] =3D pws->b[15]; + pwd->b[15] =3D pwt->b[15]; + pwd->b[0] =3D pws->b[1]; + pwd->b[1] =3D pwt->b[1]; + pwd->b[2] =3D pws->b[3]; + pwd->b[3] =3D pwt->b[3]; + pwd->b[4] =3D pws->b[5]; + pwd->b[5] =3D pwt->b[5]; + pwd->b[6] =3D pws->b[7]; + pwd->b[7] =3D pwt->b[7]; + } else { + pwd->b[15] =3D pws->b[14]; + pwd->b[14] =3D pwt->b[14]; + pwd->b[13] =3D pws->b[12]; + pwd->b[12] =3D pwt->b[12]; + pwd->b[11] =3D pws->b[10]; + pwd->b[10] =3D pwt->b[10]; + pwd->b[9] =3D pws->b[8]; + pwd->b[8] =3D pwt->b[8]; + pwd->b[7] =3D pws->b[6]; + pwd->b[6] =3D pwt->b[6]; + pwd->b[5] =3D pws->b[4]; + pwd->b[4] =3D pwt->b[4]; + pwd->b[3] =3D pws->b[2]; + pwd->b[2] =3D pwt->b[2]; + pwd->b[1] =3D pws->b[0]; + pwd->b[0] =3D pwt->b[0]; + } } =20 void helper_msa_ilvev_h(CPUMIPSState *env, @@ -4192,25 +4192,25 @@ void helper_msa_ilvev_h(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->h[4] =3D pws->h[5]; - pwd->h[5] =3D pwt->h[5]; - pwd->h[6] =3D pws->h[7]; - pwd->h[7] =3D pwt->h[7]; - pwd->h[0] =3D pws->h[1]; - pwd->h[1] =3D pwt->h[1]; - pwd->h[2] =3D pws->h[3]; - pwd->h[3] =3D pwt->h[3]; -#else - pwd->h[7] =3D pws->h[6]; - pwd->h[6] =3D pwt->h[6]; - pwd->h[5] =3D pws->h[4]; - pwd->h[4] =3D pwt->h[4]; - pwd->h[3] =3D pws->h[2]; - pwd->h[2] =3D pwt->h[2]; - pwd->h[1] =3D pws->h[0]; - pwd->h[0] =3D pwt->h[0]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->h[4] =3D pws->h[5]; + pwd->h[5] =3D pwt->h[5]; + pwd->h[6] =3D pws->h[7]; + pwd->h[7] =3D pwt->h[7]; + pwd->h[0] =3D pws->h[1]; + pwd->h[1] =3D pwt->h[1]; + pwd->h[2] =3D pws->h[3]; + pwd->h[3] =3D pwt->h[3]; + } else { + pwd->h[7] =3D pws->h[6]; + pwd->h[6] =3D pwt->h[6]; + pwd->h[5] =3D pws->h[4]; + pwd->h[4] =3D pwt->h[4]; + pwd->h[3] =3D pws->h[2]; + pwd->h[2] =3D pwt->h[2]; + pwd->h[1] =3D pws->h[0]; + pwd->h[0] =3D pwt->h[0]; + } } =20 void helper_msa_ilvev_w(CPUMIPSState *env, @@ -4220,17 +4220,17 @@ void helper_msa_ilvev_w(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->w[2] =3D pws->w[3]; - pwd->w[3] =3D pwt->w[3]; - pwd->w[0] =3D pws->w[1]; - pwd->w[1] =3D pwt->w[1]; -#else - pwd->w[3] =3D pws->w[2]; - pwd->w[2] =3D pwt->w[2]; - pwd->w[1] =3D pws->w[0]; - pwd->w[0] =3D pwt->w[0]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->w[2] =3D pws->w[3]; + pwd->w[3] =3D pwt->w[3]; + pwd->w[0] =3D pws->w[1]; + pwd->w[1] =3D pwt->w[1]; + } else { + pwd->w[3] =3D pws->w[2]; + pwd->w[2] =3D pwt->w[2]; + pwd->w[1] =3D pws->w[0]; + pwd->w[0] =3D pwt->w[0]; + } } =20 void helper_msa_ilvev_d(CPUMIPSState *env, @@ -4252,41 +4252,41 @@ void helper_msa_ilvod_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->b[7] =3D pwt->b[6]; - pwd->b[6] =3D pws->b[6]; - pwd->b[5] =3D pwt->b[4]; - pwd->b[4] =3D pws->b[4]; - pwd->b[3] =3D pwt->b[2]; - pwd->b[2] =3D pws->b[2]; - pwd->b[1] =3D pwt->b[0]; - pwd->b[0] =3D pws->b[0]; - pwd->b[15] =3D pwt->b[14]; - pwd->b[14] =3D pws->b[14]; - pwd->b[13] =3D pwt->b[12]; - pwd->b[12] =3D pws->b[12]; - pwd->b[11] =3D pwt->b[10]; - pwd->b[10] =3D pws->b[10]; - pwd->b[9] =3D pwt->b[8]; - pwd->b[8] =3D pws->b[8]; -#else - pwd->b[0] =3D pwt->b[1]; - pwd->b[1] =3D pws->b[1]; - pwd->b[2] =3D pwt->b[3]; - pwd->b[3] =3D pws->b[3]; - pwd->b[4] =3D pwt->b[5]; - pwd->b[5] =3D pws->b[5]; - pwd->b[6] =3D pwt->b[7]; - pwd->b[7] =3D pws->b[7]; - pwd->b[8] =3D pwt->b[9]; - pwd->b[9] =3D pws->b[9]; - pwd->b[10] =3D pwt->b[11]; - pwd->b[11] =3D pws->b[11]; - pwd->b[12] =3D pwt->b[13]; - pwd->b[13] =3D pws->b[13]; - pwd->b[14] =3D pwt->b[15]; - pwd->b[15] =3D pws->b[15]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->b[7] =3D pwt->b[6]; + pwd->b[6] =3D pws->b[6]; + pwd->b[5] =3D pwt->b[4]; + pwd->b[4] =3D pws->b[4]; + pwd->b[3] =3D pwt->b[2]; + pwd->b[2] =3D pws->b[2]; + pwd->b[1] =3D pwt->b[0]; + pwd->b[0] =3D pws->b[0]; + pwd->b[15] =3D pwt->b[14]; + pwd->b[14] =3D pws->b[14]; + pwd->b[13] =3D pwt->b[12]; + pwd->b[12] =3D pws->b[12]; + pwd->b[11] =3D pwt->b[10]; + pwd->b[10] =3D pws->b[10]; + pwd->b[9] =3D pwt->b[8]; + pwd->b[8] =3D pws->b[8]; + } else { + pwd->b[0] =3D pwt->b[1]; + pwd->b[1] =3D pws->b[1]; + pwd->b[2] =3D pwt->b[3]; + pwd->b[3] =3D pws->b[3]; + pwd->b[4] =3D pwt->b[5]; + pwd->b[5] =3D pws->b[5]; + pwd->b[6] =3D pwt->b[7]; + pwd->b[7] =3D pws->b[7]; + pwd->b[8] =3D pwt->b[9]; + pwd->b[9] =3D pws->b[9]; + pwd->b[10] =3D pwt->b[11]; + pwd->b[11] =3D pws->b[11]; + pwd->b[12] =3D pwt->b[13]; + pwd->b[13] =3D pws->b[13]; + pwd->b[14] =3D pwt->b[15]; + pwd->b[15] =3D pws->b[15]; + } } =20 void helper_msa_ilvod_h(CPUMIPSState *env, @@ -4296,25 +4296,25 @@ void helper_msa_ilvod_h(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->h[3] =3D pwt->h[2]; - pwd->h[2] =3D pws->h[2]; - pwd->h[1] =3D pwt->h[0]; - pwd->h[0] =3D pws->h[0]; - pwd->h[7] =3D pwt->h[6]; - pwd->h[6] =3D pws->h[6]; - pwd->h[5] =3D pwt->h[4]; - pwd->h[4] =3D pws->h[4]; -#else - pwd->h[0] =3D pwt->h[1]; - pwd->h[1] =3D pws->h[1]; - pwd->h[2] =3D pwt->h[3]; - pwd->h[3] =3D pws->h[3]; - pwd->h[4] =3D pwt->h[5]; - pwd->h[5] =3D pws->h[5]; - pwd->h[6] =3D pwt->h[7]; - pwd->h[7] =3D pws->h[7]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->h[3] =3D pwt->h[2]; + pwd->h[2] =3D pws->h[2]; + pwd->h[1] =3D pwt->h[0]; + pwd->h[0] =3D pws->h[0]; + pwd->h[7] =3D pwt->h[6]; + pwd->h[6] =3D pws->h[6]; + pwd->h[5] =3D pwt->h[4]; + pwd->h[4] =3D pws->h[4]; + } else { + pwd->h[0] =3D pwt->h[1]; + pwd->h[1] =3D pws->h[1]; + pwd->h[2] =3D pwt->h[3]; + pwd->h[3] =3D pws->h[3]; + pwd->h[4] =3D pwt->h[5]; + pwd->h[5] =3D pws->h[5]; + pwd->h[6] =3D pwt->h[7]; + pwd->h[7] =3D pws->h[7]; + } } =20 void helper_msa_ilvod_w(CPUMIPSState *env, @@ -4324,17 +4324,17 @@ void helper_msa_ilvod_w(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->w[1] =3D pwt->w[0]; - pwd->w[0] =3D pws->w[0]; - pwd->w[3] =3D pwt->w[2]; - pwd->w[2] =3D pws->w[2]; -#else - pwd->w[0] =3D pwt->w[1]; - pwd->w[1] =3D pws->w[1]; - pwd->w[2] =3D pwt->w[3]; - pwd->w[3] =3D pws->w[3]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->w[1] =3D pwt->w[0]; + pwd->w[0] =3D pws->w[0]; + pwd->w[3] =3D pwt->w[2]; + pwd->w[2] =3D pws->w[2]; + } else { + pwd->w[0] =3D pwt->w[1]; + pwd->w[1] =3D pws->w[1]; + pwd->w[2] =3D pwt->w[3]; + pwd->w[3] =3D pws->w[3]; + } } =20 void helper_msa_ilvod_d(CPUMIPSState *env, @@ -4356,41 +4356,41 @@ void helper_msa_ilvl_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->b[7] =3D pwt->b[15]; - pwd->b[6] =3D pws->b[15]; - pwd->b[5] =3D pwt->b[14]; - pwd->b[4] =3D pws->b[14]; - pwd->b[3] =3D pwt->b[13]; - pwd->b[2] =3D pws->b[13]; - pwd->b[1] =3D pwt->b[12]; - pwd->b[0] =3D pws->b[12]; - pwd->b[15] =3D pwt->b[11]; - pwd->b[14] =3D pws->b[11]; - pwd->b[13] =3D pwt->b[10]; - pwd->b[12] =3D pws->b[10]; - pwd->b[11] =3D pwt->b[9]; - pwd->b[10] =3D pws->b[9]; - pwd->b[9] =3D pwt->b[8]; - pwd->b[8] =3D pws->b[8]; -#else - pwd->b[0] =3D pwt->b[8]; - pwd->b[1] =3D pws->b[8]; - pwd->b[2] =3D pwt->b[9]; - pwd->b[3] =3D pws->b[9]; - pwd->b[4] =3D pwt->b[10]; - pwd->b[5] =3D pws->b[10]; - pwd->b[6] =3D pwt->b[11]; - pwd->b[7] =3D pws->b[11]; - pwd->b[8] =3D pwt->b[12]; - pwd->b[9] =3D pws->b[12]; - pwd->b[10] =3D pwt->b[13]; - pwd->b[11] =3D pws->b[13]; - pwd->b[12] =3D pwt->b[14]; - pwd->b[13] =3D pws->b[14]; - pwd->b[14] =3D pwt->b[15]; - pwd->b[15] =3D pws->b[15]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->b[7] =3D pwt->b[15]; + pwd->b[6] =3D pws->b[15]; + pwd->b[5] =3D pwt->b[14]; + pwd->b[4] =3D pws->b[14]; + pwd->b[3] =3D pwt->b[13]; + pwd->b[2] =3D pws->b[13]; + pwd->b[1] =3D pwt->b[12]; + pwd->b[0] =3D pws->b[12]; + pwd->b[15] =3D pwt->b[11]; + pwd->b[14] =3D pws->b[11]; + pwd->b[13] =3D pwt->b[10]; + pwd->b[12] =3D pws->b[10]; + pwd->b[11] =3D pwt->b[9]; + pwd->b[10] =3D pws->b[9]; + pwd->b[9] =3D pwt->b[8]; + pwd->b[8] =3D pws->b[8]; + } else { + pwd->b[0] =3D pwt->b[8]; + pwd->b[1] =3D pws->b[8]; + pwd->b[2] =3D pwt->b[9]; + pwd->b[3] =3D pws->b[9]; + pwd->b[4] =3D pwt->b[10]; + pwd->b[5] =3D pws->b[10]; + pwd->b[6] =3D pwt->b[11]; + pwd->b[7] =3D pws->b[11]; + pwd->b[8] =3D pwt->b[12]; + pwd->b[9] =3D pws->b[12]; + pwd->b[10] =3D pwt->b[13]; + pwd->b[11] =3D pws->b[13]; + pwd->b[12] =3D pwt->b[14]; + pwd->b[13] =3D pws->b[14]; + pwd->b[14] =3D pwt->b[15]; + pwd->b[15] =3D pws->b[15]; + } } =20 void helper_msa_ilvl_h(CPUMIPSState *env, @@ -4400,25 +4400,25 @@ void helper_msa_ilvl_h(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->h[3] =3D pwt->h[7]; - pwd->h[2] =3D pws->h[7]; - pwd->h[1] =3D pwt->h[6]; - pwd->h[0] =3D pws->h[6]; - pwd->h[7] =3D pwt->h[5]; - pwd->h[6] =3D pws->h[5]; - pwd->h[5] =3D pwt->h[4]; - pwd->h[4] =3D pws->h[4]; -#else - pwd->h[0] =3D pwt->h[4]; - pwd->h[1] =3D pws->h[4]; - pwd->h[2] =3D pwt->h[5]; - pwd->h[3] =3D pws->h[5]; - pwd->h[4] =3D pwt->h[6]; - pwd->h[5] =3D pws->h[6]; - pwd->h[6] =3D pwt->h[7]; - pwd->h[7] =3D pws->h[7]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->h[3] =3D pwt->h[7]; + pwd->h[2] =3D pws->h[7]; + pwd->h[1] =3D pwt->h[6]; + pwd->h[0] =3D pws->h[6]; + pwd->h[7] =3D pwt->h[5]; + pwd->h[6] =3D pws->h[5]; + pwd->h[5] =3D pwt->h[4]; + pwd->h[4] =3D pws->h[4]; + } else { + pwd->h[0] =3D pwt->h[4]; + pwd->h[1] =3D pws->h[4]; + pwd->h[2] =3D pwt->h[5]; + pwd->h[3] =3D pws->h[5]; + pwd->h[4] =3D pwt->h[6]; + pwd->h[5] =3D pws->h[6]; + pwd->h[6] =3D pwt->h[7]; + pwd->h[7] =3D pws->h[7]; + } } =20 void helper_msa_ilvl_w(CPUMIPSState *env, @@ -4428,17 +4428,17 @@ void helper_msa_ilvl_w(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->w[1] =3D pwt->w[3]; - pwd->w[0] =3D pws->w[3]; - pwd->w[3] =3D pwt->w[2]; - pwd->w[2] =3D pws->w[2]; -#else - pwd->w[0] =3D pwt->w[2]; - pwd->w[1] =3D pws->w[2]; - pwd->w[2] =3D pwt->w[3]; - pwd->w[3] =3D pws->w[3]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->w[1] =3D pwt->w[3]; + pwd->w[0] =3D pws->w[3]; + pwd->w[3] =3D pwt->w[2]; + pwd->w[2] =3D pws->w[2]; + } else { + pwd->w[0] =3D pwt->w[2]; + pwd->w[1] =3D pws->w[2]; + pwd->w[2] =3D pwt->w[3]; + pwd->w[3] =3D pws->w[3]; + } } =20 void helper_msa_ilvl_d(CPUMIPSState *env, @@ -4460,41 +4460,41 @@ void helper_msa_ilvr_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->b[8] =3D pws->b[0]; - pwd->b[9] =3D pwt->b[0]; - pwd->b[10] =3D pws->b[1]; - pwd->b[11] =3D pwt->b[1]; - pwd->b[12] =3D pws->b[2]; - pwd->b[13] =3D pwt->b[2]; - pwd->b[14] =3D pws->b[3]; - pwd->b[15] =3D pwt->b[3]; - pwd->b[0] =3D pws->b[4]; - pwd->b[1] =3D pwt->b[4]; - pwd->b[2] =3D pws->b[5]; - pwd->b[3] =3D pwt->b[5]; - pwd->b[4] =3D pws->b[6]; - pwd->b[5] =3D pwt->b[6]; - pwd->b[6] =3D pws->b[7]; - pwd->b[7] =3D pwt->b[7]; -#else - pwd->b[15] =3D pws->b[7]; - pwd->b[14] =3D pwt->b[7]; - pwd->b[13] =3D pws->b[6]; - pwd->b[12] =3D pwt->b[6]; - pwd->b[11] =3D pws->b[5]; - pwd->b[10] =3D pwt->b[5]; - pwd->b[9] =3D pws->b[4]; - pwd->b[8] =3D pwt->b[4]; - pwd->b[7] =3D pws->b[3]; - pwd->b[6] =3D pwt->b[3]; - pwd->b[5] =3D pws->b[2]; - pwd->b[4] =3D pwt->b[2]; - pwd->b[3] =3D pws->b[1]; - pwd->b[2] =3D pwt->b[1]; - pwd->b[1] =3D pws->b[0]; - pwd->b[0] =3D pwt->b[0]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->b[8] =3D pws->b[0]; + pwd->b[9] =3D pwt->b[0]; + pwd->b[10] =3D pws->b[1]; + pwd->b[11] =3D pwt->b[1]; + pwd->b[12] =3D pws->b[2]; + pwd->b[13] =3D pwt->b[2]; + pwd->b[14] =3D pws->b[3]; + pwd->b[15] =3D pwt->b[3]; + pwd->b[0] =3D pws->b[4]; + pwd->b[1] =3D pwt->b[4]; + pwd->b[2] =3D pws->b[5]; + pwd->b[3] =3D pwt->b[5]; + pwd->b[4] =3D pws->b[6]; + pwd->b[5] =3D pwt->b[6]; + pwd->b[6] =3D pws->b[7]; + pwd->b[7] =3D pwt->b[7]; + } else { + pwd->b[15] =3D pws->b[7]; + pwd->b[14] =3D pwt->b[7]; + pwd->b[13] =3D pws->b[6]; + pwd->b[12] =3D pwt->b[6]; + pwd->b[11] =3D pws->b[5]; + pwd->b[10] =3D pwt->b[5]; + pwd->b[9] =3D pws->b[4]; + pwd->b[8] =3D pwt->b[4]; + pwd->b[7] =3D pws->b[3]; + pwd->b[6] =3D pwt->b[3]; + pwd->b[5] =3D pws->b[2]; + pwd->b[4] =3D pwt->b[2]; + pwd->b[3] =3D pws->b[1]; + pwd->b[2] =3D pwt->b[1]; + pwd->b[1] =3D pws->b[0]; + pwd->b[0] =3D pwt->b[0]; + } } =20 void helper_msa_ilvr_h(CPUMIPSState *env, @@ -4504,25 +4504,25 @@ void helper_msa_ilvr_h(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->h[4] =3D pws->h[0]; - pwd->h[5] =3D pwt->h[0]; - pwd->h[6] =3D pws->h[1]; - pwd->h[7] =3D pwt->h[1]; - pwd->h[0] =3D pws->h[2]; - pwd->h[1] =3D pwt->h[2]; - pwd->h[2] =3D pws->h[3]; - pwd->h[3] =3D pwt->h[3]; -#else - pwd->h[7] =3D pws->h[3]; - pwd->h[6] =3D pwt->h[3]; - pwd->h[5] =3D pws->h[2]; - pwd->h[4] =3D pwt->h[2]; - pwd->h[3] =3D pws->h[1]; - pwd->h[2] =3D pwt->h[1]; - pwd->h[1] =3D pws->h[0]; - pwd->h[0] =3D pwt->h[0]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->h[4] =3D pws->h[0]; + pwd->h[5] =3D pwt->h[0]; + pwd->h[6] =3D pws->h[1]; + pwd->h[7] =3D pwt->h[1]; + pwd->h[0] =3D pws->h[2]; + pwd->h[1] =3D pwt->h[2]; + pwd->h[2] =3D pws->h[3]; + pwd->h[3] =3D pwt->h[3]; + } else { + pwd->h[7] =3D pws->h[3]; + pwd->h[6] =3D pwt->h[3]; + pwd->h[5] =3D pws->h[2]; + pwd->h[4] =3D pwt->h[2]; + pwd->h[3] =3D pws->h[1]; + pwd->h[2] =3D pwt->h[1]; + pwd->h[1] =3D pws->h[0]; + pwd->h[0] =3D pwt->h[0]; + } } =20 void helper_msa_ilvr_w(CPUMIPSState *env, @@ -4532,17 +4532,17 @@ void helper_msa_ilvr_w(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->w[2] =3D pws->w[0]; - pwd->w[3] =3D pwt->w[0]; - pwd->w[0] =3D pws->w[1]; - pwd->w[1] =3D pwt->w[1]; -#else - pwd->w[3] =3D pws->w[1]; - pwd->w[2] =3D pwt->w[1]; - pwd->w[1] =3D pws->w[0]; - pwd->w[0] =3D pwt->w[0]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->w[2] =3D pws->w[0]; + pwd->w[3] =3D pwt->w[0]; + pwd->w[0] =3D pws->w[1]; + pwd->w[1] =3D pwt->w[1]; + } else { + pwd->w[3] =3D pws->w[1]; + pwd->w[2] =3D pwt->w[1]; + pwd->w[1] =3D pws->w[0]; + pwd->w[0] =3D pwt->w[0]; + } } =20 void helper_msa_ilvr_d(CPUMIPSState *env, @@ -4663,41 +4663,41 @@ void helper_msa_pckev_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->b[8] =3D pws->b[9]; - pwd->b[10] =3D pws->b[13]; - pwd->b[12] =3D pws->b[1]; - pwd->b[14] =3D pws->b[5]; - pwd->b[0] =3D pwt->b[9]; - pwd->b[2] =3D pwt->b[13]; - pwd->b[4] =3D pwt->b[1]; - pwd->b[6] =3D pwt->b[5]; - pwd->b[9] =3D pws->b[11]; - pwd->b[13] =3D pws->b[3]; - pwd->b[1] =3D pwt->b[11]; - pwd->b[5] =3D pwt->b[3]; - pwd->b[11] =3D pws->b[15]; - pwd->b[3] =3D pwt->b[15]; - pwd->b[15] =3D pws->b[7]; - pwd->b[7] =3D pwt->b[7]; -#else - pwd->b[15] =3D pws->b[14]; - pwd->b[13] =3D pws->b[10]; - pwd->b[11] =3D pws->b[6]; - pwd->b[9] =3D pws->b[2]; - pwd->b[7] =3D pwt->b[14]; - pwd->b[5] =3D pwt->b[10]; - pwd->b[3] =3D pwt->b[6]; - pwd->b[1] =3D pwt->b[2]; - pwd->b[14] =3D pws->b[12]; - pwd->b[10] =3D pws->b[4]; - pwd->b[6] =3D pwt->b[12]; - pwd->b[2] =3D pwt->b[4]; - pwd->b[12] =3D pws->b[8]; - pwd->b[4] =3D pwt->b[8]; - pwd->b[8] =3D pws->b[0]; - pwd->b[0] =3D pwt->b[0]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->b[8] =3D pws->b[9]; + pwd->b[10] =3D pws->b[13]; + pwd->b[12] =3D pws->b[1]; + pwd->b[14] =3D pws->b[5]; + pwd->b[0] =3D pwt->b[9]; + pwd->b[2] =3D pwt->b[13]; + pwd->b[4] =3D pwt->b[1]; + pwd->b[6] =3D pwt->b[5]; + pwd->b[9] =3D pws->b[11]; + pwd->b[13] =3D pws->b[3]; + pwd->b[1] =3D pwt->b[11]; + pwd->b[5] =3D pwt->b[3]; + pwd->b[11] =3D pws->b[15]; + pwd->b[3] =3D pwt->b[15]; + pwd->b[15] =3D pws->b[7]; + pwd->b[7] =3D pwt->b[7]; + } else { + pwd->b[15] =3D pws->b[14]; + pwd->b[13] =3D pws->b[10]; + pwd->b[11] =3D pws->b[6]; + pwd->b[9] =3D pws->b[2]; + pwd->b[7] =3D pwt->b[14]; + pwd->b[5] =3D pwt->b[10]; + pwd->b[3] =3D pwt->b[6]; + pwd->b[1] =3D pwt->b[2]; + pwd->b[14] =3D pws->b[12]; + pwd->b[10] =3D pws->b[4]; + pwd->b[6] =3D pwt->b[12]; + pwd->b[2] =3D pwt->b[4]; + pwd->b[12] =3D pws->b[8]; + pwd->b[4] =3D pwt->b[8]; + pwd->b[8] =3D pws->b[0]; + pwd->b[0] =3D pwt->b[0]; + } } =20 void helper_msa_pckev_h(CPUMIPSState *env, @@ -4707,25 +4707,25 @@ void helper_msa_pckev_h(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->h[4] =3D pws->h[5]; - pwd->h[6] =3D pws->h[1]; - pwd->h[0] =3D pwt->h[5]; - pwd->h[2] =3D pwt->h[1]; - pwd->h[5] =3D pws->h[7]; - pwd->h[1] =3D pwt->h[7]; - pwd->h[7] =3D pws->h[3]; - pwd->h[3] =3D pwt->h[3]; -#else - pwd->h[7] =3D pws->h[6]; - pwd->h[5] =3D pws->h[2]; - pwd->h[3] =3D pwt->h[6]; - pwd->h[1] =3D pwt->h[2]; - pwd->h[6] =3D pws->h[4]; - pwd->h[2] =3D pwt->h[4]; - pwd->h[4] =3D pws->h[0]; - pwd->h[0] =3D pwt->h[0]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->h[4] =3D pws->h[5]; + pwd->h[6] =3D pws->h[1]; + pwd->h[0] =3D pwt->h[5]; + pwd->h[2] =3D pwt->h[1]; + pwd->h[5] =3D pws->h[7]; + pwd->h[1] =3D pwt->h[7]; + pwd->h[7] =3D pws->h[3]; + pwd->h[3] =3D pwt->h[3]; + } else { + pwd->h[7] =3D pws->h[6]; + pwd->h[5] =3D pws->h[2]; + pwd->h[3] =3D pwt->h[6]; + pwd->h[1] =3D pwt->h[2]; + pwd->h[6] =3D pws->h[4]; + pwd->h[2] =3D pwt->h[4]; + pwd->h[4] =3D pws->h[0]; + pwd->h[0] =3D pwt->h[0]; + } } =20 void helper_msa_pckev_w(CPUMIPSState *env, @@ -4735,17 +4735,17 @@ void helper_msa_pckev_w(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->w[2] =3D pws->w[3]; - pwd->w[0] =3D pwt->w[3]; - pwd->w[3] =3D pws->w[1]; - pwd->w[1] =3D pwt->w[1]; -#else - pwd->w[3] =3D pws->w[2]; - pwd->w[1] =3D pwt->w[2]; - pwd->w[2] =3D pws->w[0]; - pwd->w[0] =3D pwt->w[0]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->w[2] =3D pws->w[3]; + pwd->w[0] =3D pwt->w[3]; + pwd->w[3] =3D pws->w[1]; + pwd->w[1] =3D pwt->w[1]; + } else { + pwd->w[3] =3D pws->w[2]; + pwd->w[1] =3D pwt->w[2]; + pwd->w[2] =3D pws->w[0]; + pwd->w[0] =3D pwt->w[0]; + } } =20 void helper_msa_pckev_d(CPUMIPSState *env, @@ -4767,42 +4767,41 @@ void helper_msa_pckod_b(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->b[7] =3D pwt->b[6]; - pwd->b[5] =3D pwt->b[2]; - pwd->b[3] =3D pwt->b[14]; - pwd->b[1] =3D pwt->b[10]; - pwd->b[15] =3D pws->b[6]; - pwd->b[13] =3D pws->b[2]; - pwd->b[11] =3D pws->b[14]; - pwd->b[9] =3D pws->b[10]; - pwd->b[6] =3D pwt->b[4]; - pwd->b[2] =3D pwt->b[12]; - pwd->b[14] =3D pws->b[4]; - pwd->b[10] =3D pws->b[12]; - pwd->b[4] =3D pwt->b[0]; - pwd->b[12] =3D pws->b[0]; - pwd->b[0] =3D pwt->b[8]; - pwd->b[8] =3D pws->b[8]; -#else - pwd->b[0] =3D pwt->b[1]; - pwd->b[2] =3D pwt->b[5]; - pwd->b[4] =3D pwt->b[9]; - pwd->b[6] =3D pwt->b[13]; - pwd->b[8] =3D pws->b[1]; - pwd->b[10] =3D pws->b[5]; - pwd->b[12] =3D pws->b[9]; - pwd->b[14] =3D pws->b[13]; - pwd->b[1] =3D pwt->b[3]; - pwd->b[5] =3D pwt->b[11]; - pwd->b[9] =3D pws->b[3]; - pwd->b[13] =3D pws->b[11]; - pwd->b[3] =3D pwt->b[7]; - pwd->b[11] =3D pws->b[7]; - pwd->b[7] =3D pwt->b[15]; - pwd->b[15] =3D pws->b[15]; -#endif - + if (HOST_BIG_ENDIAN) { + pwd->b[7] =3D pwt->b[6]; + pwd->b[5] =3D pwt->b[2]; + pwd->b[3] =3D pwt->b[14]; + pwd->b[1] =3D pwt->b[10]; + pwd->b[15] =3D pws->b[6]; + pwd->b[13] =3D pws->b[2]; + pwd->b[11] =3D pws->b[14]; + pwd->b[9] =3D pws->b[10]; + pwd->b[6] =3D pwt->b[4]; + pwd->b[2] =3D pwt->b[12]; + pwd->b[14] =3D pws->b[4]; + pwd->b[10] =3D pws->b[12]; + pwd->b[4] =3D pwt->b[0]; + pwd->b[12] =3D pws->b[0]; + pwd->b[0] =3D pwt->b[8]; + pwd->b[8] =3D pws->b[8]; + } else { + pwd->b[0] =3D pwt->b[1]; + pwd->b[2] =3D pwt->b[5]; + pwd->b[4] =3D pwt->b[9]; + pwd->b[6] =3D pwt->b[13]; + pwd->b[8] =3D pws->b[1]; + pwd->b[10] =3D pws->b[5]; + pwd->b[12] =3D pws->b[9]; + pwd->b[14] =3D pws->b[13]; + pwd->b[1] =3D pwt->b[3]; + pwd->b[5] =3D pwt->b[11]; + pwd->b[9] =3D pws->b[3]; + pwd->b[13] =3D pws->b[11]; + pwd->b[3] =3D pwt->b[7]; + pwd->b[11] =3D pws->b[7]; + pwd->b[7] =3D pwt->b[15]; + pwd->b[15] =3D pws->b[15]; + } } =20 void helper_msa_pckod_h(CPUMIPSState *env, @@ -4812,25 +4811,25 @@ void helper_msa_pckod_h(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->h[3] =3D pwt->h[2]; - pwd->h[1] =3D pwt->h[6]; - pwd->h[7] =3D pws->h[2]; - pwd->h[5] =3D pws->h[6]; - pwd->h[2] =3D pwt->h[0]; - pwd->h[6] =3D pws->h[0]; - pwd->h[0] =3D pwt->h[4]; - pwd->h[4] =3D pws->h[4]; -#else - pwd->h[0] =3D pwt->h[1]; - pwd->h[2] =3D pwt->h[5]; - pwd->h[4] =3D pws->h[1]; - pwd->h[6] =3D pws->h[5]; - pwd->h[1] =3D pwt->h[3]; - pwd->h[5] =3D pws->h[3]; - pwd->h[3] =3D pwt->h[7]; - pwd->h[7] =3D pws->h[7]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->h[3] =3D pwt->h[2]; + pwd->h[1] =3D pwt->h[6]; + pwd->h[7] =3D pws->h[2]; + pwd->h[5] =3D pws->h[6]; + pwd->h[2] =3D pwt->h[0]; + pwd->h[6] =3D pws->h[0]; + pwd->h[0] =3D pwt->h[4]; + pwd->h[4] =3D pws->h[4]; + } else { + pwd->h[0] =3D pwt->h[1]; + pwd->h[2] =3D pwt->h[5]; + pwd->h[4] =3D pws->h[1]; + pwd->h[6] =3D pws->h[5]; + pwd->h[1] =3D pwt->h[3]; + pwd->h[5] =3D pws->h[3]; + pwd->h[3] =3D pwt->h[7]; + pwd->h[7] =3D pws->h[7]; + } } =20 void helper_msa_pckod_w(CPUMIPSState *env, @@ -4840,17 +4839,17 @@ void helper_msa_pckod_w(CPUMIPSState *env, wr_t *pws =3D &(env->active_fpu.fpr[ws].wr); wr_t *pwt =3D &(env->active_fpu.fpr[wt].wr); =20 -#if HOST_BIG_ENDIAN - pwd->w[1] =3D pwt->w[0]; - pwd->w[3] =3D pws->w[0]; - pwd->w[0] =3D pwt->w[2]; - pwd->w[2] =3D pws->w[2]; -#else - pwd->w[0] =3D pwt->w[1]; - pwd->w[2] =3D pws->w[1]; - pwd->w[1] =3D pwt->w[3]; - pwd->w[3] =3D pws->w[3]; -#endif + if (HOST_BIG_ENDIAN) { + pwd->w[1] =3D pwt->w[0]; + pwd->w[3] =3D pws->w[0]; + pwd->w[0] =3D pwt->w[2]; + pwd->w[2] =3D pws->w[2]; + } else { + pwd->w[0] =3D pwt->w[1]; + pwd->w[2] =3D pws->w[1]; + pwd->w[1] =3D pwt->w[3]; + pwd->w[3] =3D pws->w[3]; + } } =20 void helper_msa_pckod_d(CPUMIPSState *env, @@ -5928,13 +5927,13 @@ void helper_msa_copy_s_b(CPUMIPSState *env, uint32_= t rd, uint32_t ws, uint32_t n) { n %=3D 16; -#if HOST_BIG_ENDIAN - if (n < 8) { - n =3D 8 - n - 1; - } else { - n =3D 24 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 8) { + n =3D 8 - n - 1; + } else { + n =3D 24 - n - 1; + } } -#endif env->active_tc.gpr[rd] =3D (int8_t)env->active_fpu.fpr[ws].wr.b[n]; } =20 @@ -5942,13 +5941,13 @@ void helper_msa_copy_s_h(CPUMIPSState *env, uint32_= t rd, uint32_t ws, uint32_t n) { n %=3D 8; -#if HOST_BIG_ENDIAN - if (n < 4) { - n =3D 4 - n - 1; - } else { - n =3D 12 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 4) { + n =3D 4 - n - 1; + } else { + n =3D 12 - n - 1; + } } -#endif env->active_tc.gpr[rd] =3D (int16_t)env->active_fpu.fpr[ws].wr.h[n]; } =20 @@ -5956,13 +5955,13 @@ void helper_msa_copy_s_w(CPUMIPSState *env, uint32_= t rd, uint32_t ws, uint32_t n) { n %=3D 4; -#if HOST_BIG_ENDIAN - if (n < 2) { - n =3D 2 - n - 1; - } else { - n =3D 6 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 2) { + n =3D 2 - n - 1; + } else { + n =3D 6 - n - 1; + } } -#endif env->active_tc.gpr[rd] =3D (int32_t)env->active_fpu.fpr[ws].wr.w[n]; } =20 @@ -5977,13 +5976,13 @@ void helper_msa_copy_u_b(CPUMIPSState *env, uint32_= t rd, uint32_t ws, uint32_t n) { n %=3D 16; -#if HOST_BIG_ENDIAN - if (n < 8) { - n =3D 8 - n - 1; - } else { - n =3D 24 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 8) { + n =3D 8 - n - 1; + } else { + n =3D 24 - n - 1; + } } -#endif env->active_tc.gpr[rd] =3D (uint8_t)env->active_fpu.fpr[ws].wr.b[n]; } =20 @@ -5991,13 +5990,13 @@ void helper_msa_copy_u_h(CPUMIPSState *env, uint32_= t rd, uint32_t ws, uint32_t n) { n %=3D 8; -#if HOST_BIG_ENDIAN - if (n < 4) { - n =3D 4 - n - 1; - } else { - n =3D 12 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 4) { + n =3D 4 - n - 1; + } else { + n =3D 12 - n - 1; + } } -#endif env->active_tc.gpr[rd] =3D (uint16_t)env->active_fpu.fpr[ws].wr.h[n]; } =20 @@ -6005,13 +6004,13 @@ void helper_msa_copy_u_w(CPUMIPSState *env, uint32_= t rd, uint32_t ws, uint32_t n) { n %=3D 4; -#if HOST_BIG_ENDIAN - if (n < 2) { - n =3D 2 - n - 1; - } else { - n =3D 6 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 2) { + n =3D 2 - n - 1; + } else { + n =3D 6 - n - 1; + } } -#endif env->active_tc.gpr[rd] =3D (uint32_t)env->active_fpu.fpr[ws].wr.w[n]; } =20 @@ -6021,13 +6020,13 @@ void helper_msa_insert_b(CPUMIPSState *env, uint32_= t wd, wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); target_ulong rs =3D env->active_tc.gpr[rs_num]; n %=3D 16; -#if HOST_BIG_ENDIAN - if (n < 8) { - n =3D 8 - n - 1; - } else { - n =3D 24 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 8) { + n =3D 8 - n - 1; + } else { + n =3D 24 - n - 1; + } } -#endif pwd->b[n] =3D (int8_t)rs; } =20 @@ -6037,13 +6036,13 @@ void helper_msa_insert_h(CPUMIPSState *env, uint32_= t wd, wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); target_ulong rs =3D env->active_tc.gpr[rs_num]; n %=3D 8; -#if HOST_BIG_ENDIAN - if (n < 4) { - n =3D 4 - n - 1; - } else { - n =3D 12 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 4) { + n =3D 4 - n - 1; + } else { + n =3D 12 - n - 1; + } } -#endif pwd->h[n] =3D (int16_t)rs; } =20 @@ -6053,13 +6052,13 @@ void helper_msa_insert_w(CPUMIPSState *env, uint32_= t wd, wr_t *pwd =3D &(env->active_fpu.fpr[wd].wr); target_ulong rs =3D env->active_tc.gpr[rs_num]; n %=3D 4; -#if HOST_BIG_ENDIAN - if (n < 2) { - n =3D 2 - n - 1; - } else { - n =3D 6 - n - 1; + if (HOST_BIG_ENDIAN) { + if (n < 2) { + n =3D 2 - n - 1; + } else { + n =3D 6 - n - 1; + } } -#endif pwd->w[n] =3D (int32_t)rs; } =20 --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104045; cv=none; d=zohomail.com; s=zohoarc; b=Ur54DMN+dKmbtJj9AeucabZ1YTMf3ydHkjdfdl1FRmtMTy9CQh3c7wB9a2tCrjxmybeTBUn9jvTsumV3fZnF3eWUWkppaaxMBq+doREkDosCe8xYjtRMeuy5a1omLMzvuS2kYtEf3Mgg4RbGQ8g8e+V8ypBhhJXkfdesSTgwfWo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104045; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=sslmAmFx5Cxrr/elCIaZt4ybkrnljBL49HYxD0V3YF0=; b=H4VEubqng6hkCadvBeOE/oFpWi12Xcvh9YnWSEJsrPBO0iMJhEXnC57ooTt2cnPR958H6O8GDcvXh4AtcfoIWTEoYYzHoa8eqyr5UyYoO+qOjK/oCQxLY1QRCPWPPTusHyWMr/hejm5q6/a4qU6iIk2pCjuAhmR1bN8yvPKHOC0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104045371615.4751462728469; Fri, 10 Oct 2025 06:47:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DQS-00039o-5D; Fri, 10 Oct 2025 09:44:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DQ9-0002pN-JQ for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:34 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DPI-0008FQ-Fy for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:33 -0400 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-46e42fa08e4so20768935e9.3 for ; Fri, 10 Oct 2025 06:43:37 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fab3cd658sm62396535e9.1.2025.10.10.06.43.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103814; x=1760708614; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sslmAmFx5Cxrr/elCIaZt4ybkrnljBL49HYxD0V3YF0=; b=b5IKHz2fhYGFR5V+3HM5k3w4Tvaa4FVLVfGYQ9F7dUhBkGD5V+pbMcB8gMr14iVQPn 06MXvUSkGnorJMC3XPHFzWzWE13+9al2p9/zV7vRakbMae20878f89U2Pt3wQ4CHYNZM EhDZQxzq3BhJIdxBN0i6jzPmAWN9WMIKk4ih9jHwdGHMV0VZbnmF8Vm+zJ0kcAtEDYjY Of14SZ1KkrNIXnL5E6Cwn54kKvZJE7FzwdOhfP7uAjJMFvQq3lY08beTJtmU89ufa6mq HB+ksh3rEyTMccSRz9Xa9SuiqkLSS9edl/QcK05i3zQZ73UERF+Z8pqg9bjsGzdK22jW /BdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103814; x=1760708614; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sslmAmFx5Cxrr/elCIaZt4ybkrnljBL49HYxD0V3YF0=; b=d1DJ89htUv92ZvOAUtxGp4fgov8/NvVwJ7IPYoqpc1paiB/mH7F2pP6NQde20i+Ize pD2Zy/xQHxqFO9eCup3gF4w2etk16EJb49fk4he3ExDLJ/7eacHBLe7g710jya+mUi9Z y4o1fqeGkoL+XU9rQ6WEw2zkizTIvEP6DImk+wncLoHQK1jNXANyqD38kd95tYmz1hgS Bn1+SS83uzWJ3+CVQOigi3S0HDUjrb45nm95Pa5g9aihbJPQdSY1UJejhMI0dTOFAqxe J8ZwQFmrZRbq4AHq4DvtfDoeZZIPmB6OE4R1UuXkAkg1kVT5RAjhSltaPBKj0VkWqWBA wXBA== X-Gm-Message-State: AOJu0YyuNM9FbcEJNubR5/VM9sHaah41jJ1rgYvx3GdYcs0rdC+ANvmO MdeSTRnhvJmfcSdZcYyVZTSDhbe0J0ltYHqLdQBBmwPFrZboxxCDzREWlyhkoYHgvsI5UiYbrwq /MFlAM8uT84dl X-Gm-Gg: ASbGnct7WbMNgb2cndeOHxvrqXeUbhr7iWE6pV0fuxIRryHQcurrQrtCyTKVndhX/wb 1oxsNiQTjmz8G5c+rwmu1+C5gWUxxOya+vXsylvO1a72TD/JQjLpkxA38slXP3J5sDXYqA5W5YW e4eKYUQ29jjO5rLaB+H+H09iVMLdUaCDgE192ftUU+OPFVze8XaB5y32WHZ50hY8FapC8C/MROY 3LjCpoNMU8KZ7gh4gd02WzHNi3cteGJD1R+zN+PFNrZ1K5bkkQxUA9JlJQLuhXFXKie9swDAlaK waoD8RZCjk+tyU67v1+g+P5gE3t7vUXoev+/EFfxjLXLUJpMf50vRXrWRktKAKNY/QI/5YUqE90 jAXtOee5Ip7h3edQQq1KF9zEyNCBT+fRzKtnPzdLygewT7wOTzjIuTmQm2vCe/6/+ks/WBKNmHq xtorOTfFbF3fTe6/Zh07M= X-Google-Smtp-Source: AGHT+IEq7PwzNWupra1NG1OBtrWiBM/xZ8ZbE2ssL1sNC/gPpkHqvpUEmnX8rktwHeIqbswn441T9g== X-Received: by 2002:a05:600c:a341:b0:46e:39da:1195 with SMTP id 5b1f17b1804b1-46fa9a8b3a9mr84537105e9.3.1760103813909; Fri, 10 Oct 2025 06:43:33 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Nicholas Piggin , Chinmay Rath , Harsh Prateek Bora , Paolo Bonzini , Richard Henderson , kvm@vger.kernel.org Subject: [PATCH 12/16] target/ppc: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:21 +0200 Message-ID: <20251010134226.72221-13-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=philmd@linaro.org; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104050351158500 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Harsh Prateek Bora --- target/ppc/arch_dump.c | 9 ++------- target/ppc/int_helper.c | 28 ++++++++++++++-------------- target/ppc/kvm.c | 25 +++++++++---------------- target/ppc/translate/vmx-impl.c.inc | 14 +++++++------- target/ppc/translate/vsx-impl.c.inc | 6 +++--- tcg/ppc/tcg-target.c.inc | 24 ++++++++++++------------ 6 files changed, 47 insertions(+), 59 deletions(-) diff --git a/target/ppc/arch_dump.c b/target/ppc/arch_dump.c index 80ac6c3e320..5cb8dbe9a6a 100644 --- a/target/ppc/arch_dump.c +++ b/target/ppc/arch_dump.c @@ -158,21 +158,16 @@ static void ppc_write_elf_vmxregset(NoteFuncArg *arg,= PowerPCCPU *cpu, int id) struct PPCElfVmxregset *vmxregset; Note *note =3D &arg->note; DumpState *s =3D arg->state; + const int host_data_order =3D HOST_BIG_ENDIAN ? ELFDATA2MSB : ELFDATA2= LSB; + const bool needs_byteswap =3D s->dump_info.d_endian =3D=3D host_data_o= rder; =20 note->hdr.n_type =3D cpu_to_dump32(s, NT_PPC_VMX); vmxregset =3D ¬e->contents.vmxregset; memset(vmxregset, 0, sizeof(*vmxregset)); =20 for (i =3D 0; i < 32; i++) { - bool needs_byteswap; ppc_avr_t *avr =3D cpu_avr_ptr(&cpu->env, i); =20 -#if HOST_BIG_ENDIAN - needs_byteswap =3D s->dump_info.d_endian =3D=3D ELFDATA2LSB; -#else - needs_byteswap =3D s->dump_info.d_endian =3D=3D ELFDATA2MSB; -#endif - if (needs_byteswap) { vmxregset->avr[i].u64[0] =3D bswap64(avr->u64[1]); vmxregset->avr[i].u64[1] =3D bswap64(avr->u64[0]); diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c index ef4b2e75d60..0c6f5b2e519 100644 --- a/target/ppc/int_helper.c +++ b/target/ppc/int_helper.c @@ -1678,13 +1678,13 @@ void helper_vslo(ppc_avr_t *r, ppc_avr_t *a, ppc_av= r_t *b) { int sh =3D (b->VsrB(0xf) >> 3) & 0xf; =20 -#if HOST_BIG_ENDIAN - memmove(&r->u8[0], &a->u8[sh], 16 - sh); - memset(&r->u8[16 - sh], 0, sh); -#else - memmove(&r->u8[sh], &a->u8[0], 16 - sh); - memset(&r->u8[0], 0, sh); -#endif + if (HOST_BIG_ENDIAN) { + memmove(&r->u8[0], &a->u8[sh], 16 - sh); + memset(&r->u8[16 - sh], 0, sh); + } else { + memmove(&r->u8[sh], &a->u8[0], 16 - sh); + memset(&r->u8[0], 0, sh); + } } =20 #if HOST_BIG_ENDIAN @@ -1898,13 +1898,13 @@ void helper_vsro(ppc_avr_t *r, ppc_avr_t *a, ppc_av= r_t *b) { int sh =3D (b->VsrB(0xf) >> 3) & 0xf; =20 -#if HOST_BIG_ENDIAN - memmove(&r->u8[sh], &a->u8[0], 16 - sh); - memset(&r->u8[0], 0, sh); -#else - memmove(&r->u8[0], &a->u8[sh], 16 - sh); - memset(&r->u8[16 - sh], 0, sh); -#endif + if (HOST_BIG_ENDIAN) { + memmove(&r->u8[sh], &a->u8[0], 16 - sh); + memset(&r->u8[0], 0, sh); + } else { + memmove(&r->u8[0], &a->u8[sh], 16 - sh); + memset(&r->u8[16 - sh], 0, sh); + } } =20 void helper_vsumsws(CPUPPCState *env, ppc_avr_t *r, ppc_avr_t *a, ppc_avr_= t *b) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 2521ff65c6c..c00d29ce2c8 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -651,13 +651,13 @@ static int kvm_put_fp(CPUState *cs) uint64_t *fpr =3D cpu_fpr_ptr(env, i); uint64_t *vsrl =3D cpu_vsrl_ptr(env, i); =20 -#if HOST_BIG_ENDIAN - vsr[0] =3D float64_val(*fpr); - vsr[1] =3D *vsrl; -#else - vsr[0] =3D *vsrl; - vsr[1] =3D float64_val(*fpr); -#endif + if (HOST_BIG_ENDIAN) { + vsr[0] =3D float64_val(*fpr); + vsr[1] =3D *vsrl; + } else { + vsr[0] =3D *vsrl; + vsr[1] =3D float64_val(*fpr); + } reg.addr =3D (uintptr_t) &vsr; reg.id =3D vsx ? KVM_REG_PPC_VSR(i) : KVM_REG_PPC_FPR(i); =20 @@ -728,17 +728,10 @@ static int kvm_get_fp(CPUState *cs) strerror(errno)); return ret; } else { -#if HOST_BIG_ENDIAN - *fpr =3D vsr[0]; + *fpr =3D vsr[!HOST_BIG_ENDIAN]; if (vsx) { - *vsrl =3D vsr[1]; + *vsrl =3D vsr[HOST_BIG_ENDIAN]; } -#else - *fpr =3D vsr[1]; - if (vsx) { - *vsrl =3D vsr[0]; - } -#endif } } } diff --git a/target/ppc/translate/vmx-impl.c.inc b/target/ppc/translate/vmx= -impl.c.inc index 92d6e8c6032..ca9cf1823d4 100644 --- a/target/ppc/translate/vmx-impl.c.inc +++ b/target/ppc/translate/vmx-impl.c.inc @@ -134,9 +134,9 @@ static void gen_mtvscr(DisasContext *ctx) =20 val =3D tcg_temp_new_i32(); bofs =3D avr_full_offset(rB(ctx->opcode)); -#if HOST_BIG_ENDIAN - bofs +=3D 3 * 4; -#endif + if (HOST_BIG_ENDIAN) { + bofs +=3D 3 * 4; + } =20 tcg_gen_ld_i32(val, tcg_env, bofs); gen_helper_mtvscr(tcg_env, val); @@ -1528,10 +1528,10 @@ static void gen_vsplt(DisasContext *ctx, int vece) =20 /* Experimental testing shows that hardware masks the immediate. */ bofs +=3D (uimm << vece) & 15; -#if !HOST_BIG_ENDIAN - bofs ^=3D 15; - bofs &=3D ~((1 << vece) - 1); -#endif + if (!HOST_BIG_ENDIAN) { + bofs ^=3D 15; + bofs &=3D ~((1 << vece) - 1); + } =20 tcg_gen_gvec_dup_mem(vece, dofs, bofs, 16, 16); } diff --git a/target/ppc/translate/vsx-impl.c.inc b/target/ppc/translate/vsx= -impl.c.inc index 00ad57c6282..8e5c75961f4 100644 --- a/target/ppc/translate/vsx-impl.c.inc +++ b/target/ppc/translate/vsx-impl.c.inc @@ -1642,9 +1642,9 @@ static bool trans_XXSPLTW(DisasContext *ctx, arg_XX2_= uim *a) tofs =3D vsr_full_offset(a->xt); bofs =3D vsr_full_offset(a->xb); bofs +=3D a->uim << MO_32; -#if !HOST_BIG_ENDIAN - bofs ^=3D 8 | 4; -#endif + if (!HOST_BIG_ENDIAN) { + bofs ^=3D 8 | 4; + } =20 tcg_gen_gvec_dup_mem(MO_32, tofs, bofs, 16, 16); return true; diff --git a/tcg/ppc/tcg-target.c.inc b/tcg/ppc/tcg-target.c.inc index b8b23d44d5e..61aa77f5454 100644 --- a/tcg/ppc/tcg-target.c.inc +++ b/tcg/ppc/tcg-target.c.inc @@ -3951,9 +3951,9 @@ static bool tcg_out_dupm_vec(TCGContext *s, TCGType t= ype, unsigned vece, tcg_out_mem_long(s, 0, LVEBX, out, base, offset); } elt =3D extract32(offset, 0, 4); -#if !HOST_BIG_ENDIAN - elt ^=3D 15; -#endif + if (!HOST_BIG_ENDIAN) { + elt ^=3D 15; + } tcg_out32(s, VSPLTB | VRT(out) | VRB(out) | (elt << 16)); break; case MO_16: @@ -3964,9 +3964,9 @@ static bool tcg_out_dupm_vec(TCGContext *s, TCGType t= ype, unsigned vece, tcg_out_mem_long(s, 0, LVEHX, out, base, offset); } elt =3D extract32(offset, 1, 3); -#if !HOST_BIG_ENDIAN - elt ^=3D 7; -#endif + if (!HOST_BIG_ENDIAN) { + elt ^=3D 7; + } tcg_out32(s, VSPLTH | VRT(out) | VRB(out) | (elt << 16)); break; case MO_32: @@ -3977,9 +3977,9 @@ static bool tcg_out_dupm_vec(TCGContext *s, TCGType t= ype, unsigned vece, tcg_debug_assert((offset & 3) =3D=3D 0); tcg_out_mem_long(s, 0, LVEWX, out, base, offset); elt =3D extract32(offset, 2, 2); -#if !HOST_BIG_ENDIAN - elt ^=3D 3; -#endif + if (!HOST_BIG_ENDIAN) { + elt ^=3D 3; + } tcg_out32(s, VSPLTW | VRT(out) | VRB(out) | (elt << 16)); break; case MO_64: @@ -3991,9 +3991,9 @@ static bool tcg_out_dupm_vec(TCGContext *s, TCGType t= ype, unsigned vece, tcg_out_mem_long(s, 0, LVX, out, base, offset & -16); tcg_out_vsldoi(s, TCG_VEC_TMP1, out, out, 8); elt =3D extract32(offset, 3, 1); -#if !HOST_BIG_ENDIAN - elt =3D !elt; -#endif + if (!HOST_BIG_ENDIAN) { + elt =3D !elt; + } if (elt) { tcg_out_vsldoi(s, out, out, TCG_VEC_TMP1, 8); } else { --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104436; cv=none; d=zohomail.com; s=zohoarc; b=a84IDJZYIgUxKNPOxvI9w4R/1+M3tacrkRk9zLE/UJp2qWSGsP6lXEtrGrPKYMV0fvKuYCXnHkQlZsF0gThT39cTy+xc5YpSQpoVTYW9D78JBCSmKUwehqdVhCD/XyJo0IfG+Z5MacGN2AoNzhP1tz1//z+s+7XGesl45+4pm08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104436; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EuUb8cn58HWVtKNyssgaxuYdK0xTqPivt2V1+X+pEac=; b=MpO6GSK9LiOFKcFH8PJDCRb5cy/XinEqN2bD/2mfA36mxbjMqDK5LgtLQDkVS/YZ3sKChlvEZYHdHeya2lMtZbXsacxsil+ksrBQyCr6I88+LHGVo2wkhUGSSTLouW2x3Hqh0zh45S+fBXmgV41o3Rgbk4JRvlClvutPHgd8kSM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104436272520.2130559692359; Fri, 10 Oct 2025 06:53:56 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DQd-0003Jv-Vz; Fri, 10 Oct 2025 09:45:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DQO-00033q-2P for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:48 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DPO-0008Gv-W7 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:46 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-46e48d6b95fso19516685e9.3 for ; Fri, 10 Oct 2025 06:43:43 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fb4982c10sm46420565e9.5.2025.10.10.06.43.37 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103819; x=1760708619; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EuUb8cn58HWVtKNyssgaxuYdK0xTqPivt2V1+X+pEac=; b=xvmIFupFujeneJyse9PGtOHV8dZ6UxYEWcD7PS5AElySDofzoxDQLhhSQn2bf4uKRe kb3tsDLOQ2MRftE8UyNkyrca2hRImDi91g69/TvYXLZp8diOGhwLz/QDDJvO5fQBpzgl pvNmHnrqKOI32tSSkjmeLpMIk7D6lKWLqmtHPgBiEjB08uktZswHtNd4Im+JueWeVPL4 jba8hOSg1tTn6wlr8W7SBZaCuirrpycNpQYaA7ZFOrfBRQjeYYhYnefzlv1GtX/6923G ozyrT/KYxH3xvkX10eoCpSQImfdh/emrpZkZi0ZPMeECR9sRpSa+m5is99HoYFTvOtlV wWKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103819; x=1760708619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EuUb8cn58HWVtKNyssgaxuYdK0xTqPivt2V1+X+pEac=; b=rILJ1dFPZA15OixTev3rHxukhv2G0v0c0izHGVzXP8Jxu1ebYwzMjEjqL6m2VjCMGR iCXHd7L7sY9oQ1YWEGWftt7gkj6vwbymWLfUui/kEQxLL8Ryr1dUYbqERXmkfGdHSBTq jPltK2AggM3Wboc44iE48KcrluRRfSTSejwnXZn9WCkv3hsrAxpGLiBq5+a609yMQKk9 HJc5QntCdodcl00IGY05lhv/C2kvogZr+OAqIEA07sVS4PeBv6JSLUloooDRcIiTX4zH f8LLuMlWCga9I0S8tcfNmS4Ld/BYESKKDFv2w+LdlJA5iMe3d8/RCF2d1oPZpIXLrSJt GTJw== X-Gm-Message-State: AOJu0Ywq4ZXDb56sZIZDmMxP+J1ws+CYYS8Lyw5O5AMtHion89L2JvTm 57uJYVDcQnJMIlytQRcCP/3OsjHjEead+2+iHfHbLEoGgJYv7ks8ay6hlj1cttvtnTlHWo36ORS v0v4j14iylw== X-Gm-Gg: ASbGnct2ReobWyg7WtwoiCYLBCDOy9I6+rl+3lKd18cpTn0YzHvPNi7Z4ROv4f2n/q7 Y4eI3e+N3O5KyU7VZDQX/ifs36C0W8jaYIGVEKdYMvAc/bAJxpHHuOxvQE1ouchqRL8YSGWlaDt dADGte2kB7M/0VVnFXruLdURRvEFVCmDn9cuploZcqxf1ipQPUhokyRcla6uMUN0DnK8d7lBUZd UqMtU2lEFTFMcDxbLh0g0MiJW2BDBvuMaOee4KBO/6i0zBL1xwcnReX3Wa0OMptSC3n9kD50CZD c7c/YlSeKtdFKfFyhkZjRNmnd8r4Sr0xRRz/SaowNq/tctI0z57AmBvk0i1mz55Hnk1qZq9hoju uGi4VF3fZV4KbtIsYFC9C9U1w0VBVAgFfmpElnebu9QuG0LMaZMbDfb7rquIfjQsQBLL+bGAAQw O95eOGiIWe/arnFK6JncJSK949tFq8Jw== X-Google-Smtp-Source: AGHT+IG2f+UkzzWYMAjb5o1vVGqqVrZhp9VC56WJ4cu5v9kbb+AuRk8E9AXNb8UfRlWn3J5xiLsnGw== X-Received: by 2002:a05:600c:4586:b0:46e:45d3:82fd with SMTP id 5b1f17b1804b1-46fa9b086e1mr91925145e9.31.1760103819195; Fri, 10 Oct 2025 06:43:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Palmer Dabbelt , Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei Subject: [PATCH 13/16] target/riscv: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:22 +0200 Message-ID: <20251010134226.72221-14-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104437445154100 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis --- target/riscv/vector_helper.c | 32 ++++++++++++------------- target/riscv/insn_trans/trans_rvv.c.inc | 16 ++++++------- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 41ea2231067..2de3358ee86 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -235,26 +235,26 @@ vext_continuous_ldst_host(CPURISCVState *env, vext_ld= st_elem_fn_host *ldst_host, void *vd, uint32_t evl, uint32_t reg_start, void *= host, uint32_t esz, bool is_load) { -#if HOST_BIG_ENDIAN - for (; reg_start < evl; reg_start++, host +=3D esz) { - ldst_host(vd, reg_start, host); - } -#else - if (esz =3D=3D 1) { - uint32_t byte_offset =3D reg_start * esz; - uint32_t size =3D (evl - reg_start) * esz; - - if (is_load) { - memcpy(vd + byte_offset, host, size); - } else { - memcpy(host, vd + byte_offset, size); - } - } else { + if (HOST_BIG_ENDIAN) { for (; reg_start < evl; reg_start++, host +=3D esz) { ldst_host(vd, reg_start, host); } + } else { + if (esz =3D=3D 1) { + uint32_t byte_offset =3D reg_start * esz; + uint32_t size =3D (evl - reg_start) * esz; + + if (is_load) { + memcpy(vd + byte_offset, host, size); + } else { + memcpy(host, vd + byte_offset, size); + } + } else { + for (; reg_start < evl; reg_start++, host +=3D esz) { + ldst_host(vd, reg_start, host); + } + } } -#endif } =20 static void vext_set_tail_elems_1s(target_ulong vl, void *vd, diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_tr= ans/trans_rvv.c.inc index f4b5460340e..2a487179f63 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -3351,19 +3351,19 @@ static void load_element(TCGv_i64 dest, TCGv_ptr ba= se, /* offset of the idx element with base register r */ static uint32_t endian_ofs(DisasContext *s, int r, int idx) { -#if HOST_BIG_ENDIAN - return vreg_ofs(s, r) + ((idx ^ (7 >> s->sew)) << s->sew); -#else - return vreg_ofs(s, r) + (idx << s->sew); -#endif + if (HOST_BIG_ENDIAN) { + return vreg_ofs(s, r) + ((idx ^ (7 >> s->sew)) << s->sew); + } else { + return vreg_ofs(s, r) + (idx << s->sew); + } } =20 /* adjust the index according to the endian */ static void endian_adjust(TCGv_i32 ofs, int sew) { -#if HOST_BIG_ENDIAN - tcg_gen_xori_i32(ofs, ofs, 7 >> sew); -#endif + if (HOST_BIG_ENDIAN) { + tcg_gen_xori_i32(ofs, ofs, 7 >> sew); + } } =20 /* Load idx >=3D VLMAX ? 0 : vreg[idx] */ --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104192; cv=none; d=zohomail.com; s=zohoarc; b=G6Z74BS7kT4NZDSQNN4IsNHLJdg2KUPeWma9hN++Y9o8QdefbbMdVUJndG85UH7sp08QUoOBXcDZC6KvqFfdT8SUhtGp0mCLdf7Jzt4iPl9MrjcEHKfw5QR43al5qUajSxFNZ6kP04PrJEYUQ7ATxLcAODoSDh2tzXNPvMp7xvI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104192; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=r4HGgiMv15db038MKi02IiRG5N36n+u7KrBeSKqnYB8=; b=MfM2+Ju9OUx8FWYTkEI2fn0UWHweev9zW7d+M24UdwTV5sX/JYL3g4sO8gg4HuKlWkXlz8CgmLR+sHGMGp5sK0CuSvDrAlXNqKzTAHBcOVhTC7cHvOPqHIWnk0OiLiWnd8OWSre3S+ndiCh0qPj6wgUFRJfDbTTUlXzAyiP7KIU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104192623783.7022012167087; Fri, 10 Oct 2025 06:49:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DQS-0003Aw-Jt; Fri, 10 Oct 2025 09:44:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DQQ-00037r-Iw for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:50 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DPR-0008Hd-4d for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:44:49 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3f0ae439b56so1356028f8f.3 for ; Fri, 10 Oct 2025 06:43:47 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce583424sm4269124f8f.21.2025.10.10.06.43.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103824; x=1760708624; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r4HGgiMv15db038MKi02IiRG5N36n+u7KrBeSKqnYB8=; b=Wud4NyLONgRfkVQ11XqFFCRUIi2lgEX73SFrzObShxW2rBbxZoA6O0BUqstKGzBLit dwa3aLJHCt4WDNCV36IrZCgWnnsTM6P09EmmAkK1iT9+pxXgE9d871YvZ/LSiMR799ND LzLAhGhC1Eiw2ysv1ej52nrty1Bbgr4fKz36vQX0kbny8BDq99mfKhGdvZlJCUjamxfF lo3JQXuuRkrpCcPJdVG+CR3XFfx7BPF2OVKtq+Fcz/uGueZ1sJPf2mIsEGSfCJEk3XQ1 CqWLDpCqLVv2yGVbjmklKZzWdMnELepJnJ2MgPCREk6EFS2XrL3h89AXOELYy5rzhJJb XkIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103824; x=1760708624; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r4HGgiMv15db038MKi02IiRG5N36n+u7KrBeSKqnYB8=; b=ZisMjtmnZhx328TJbQcI9Vvt0hkfef2f+yvd/UlBk45VY2dwmVgIRdUHVS/oX40YKY J5+YMPbEVy7hcPysHyVVBqciCB9LPLyTvNCFxtJtimKFSEl4Tu/l/gVhwlikmwvidE+x fUbEBvOrzIQKjavum7p24e2QFtSBxHRWPGm0Oh780Q+/H4oh8TizflsSLlpIZ24YQrOZ pC1bfMBULc6s8VtZ3JaUbSZc8pf+nOdmtJG8kUd8Lu2ZGaGG4fOK7ZFMNe0DH8wt+5N1 LQh6U9ECsuqmo5U4l05NZWkJmLDj8TCEc3DNGthPh1b1xSSJlAs5ARg6he3x1owNmnjo XaTw== X-Gm-Message-State: AOJu0YwGAJnQNaxOtaCetYzXlBS31st6uHgBP7YIVIC0vzaGyvUVDiIa j+tpEHeEJO1WKPacCs0YJ22V0CW2eJ+CF9UVbz14Byt50bXVqWyWqpg8plYqHaRY6mbOSr8gTpM ojuV8U3Z2gA== X-Gm-Gg: ASbGnctLsD7W03vfcc0FveHM1xErjtZSJanvzHnNjoH8hXylNjm4LonywTQUSpDbaCo jbOKf2r5GoPm7bc+PnhYwCFxBwunSQXqpCXVWxCG9UhPG/3xQ7qTDr3ZjuyI8o+iOiqLomoCczs 5qI1kyqYAhX2McYVyLiInCWuy45rlK0wePu0WuMVs376gp8clrD3Zc18ZiCExdm2mWrLdphD5RB +z5Tt6kb9xd6pWStab7vf3EX0fgbE6gG7b0RgixocO6lwgYfPDy8zI6uWKVkicTX7+uCAqs9PDM HDB0e/UDV6bfw8FykSXCZBtaYTcCbhVrLKwepbaJCFPJWwrysafjLJ1VmDM5SfH3+MHyt6jkpI6 2YYekCsKk9vEnyrwuK7at9fUJsTP3hUnXawTqf8leV04QftTQCBqhZmfZExg4ljENT/w4clGUWJ RBfn/L8HqLr0lb2l/mPwc= X-Google-Smtp-Source: AGHT+IHEvlUtvA1b47Zvxo/zoUXjFDcn/NFvuh+N6pNi1JzgwJ6dpmrR/Ll2gcdeH1ymCCVWKFtYgQ== X-Received: by 2002:a05:6000:1ac8:b0:3f7:b7ac:f3d4 with SMTP id ffacd0b85a97d-42666abbbc1mr9120199f8f.5.1760103824459; Fri, 10 Oct 2025 06:43:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Richard Henderson , David Hildenbrand , Ilya Leoshkevich , Thomas Huth Subject: [PATCH 14/16] target/s390x: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:23 +0200 Message-ID: <20251010134226.72221-15-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104194440154100 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: David Hildenbrand --- target/s390x/tcg/translate.c | 6 +++--- target/s390x/tcg/translate_vx.c.inc | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index c7e8574438c..ec9e5a07516 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/translate.c @@ -258,9 +258,9 @@ static inline int vec_reg_offset(uint8_t reg, uint8_t e= nr, MemOp es) * 16 byte operations to handle it in a special way. */ g_assert(es <=3D MO_64); -#if !HOST_BIG_ENDIAN - offs ^=3D (8 - bytes); -#endif + if (!HOST_BIG_ENDIAN) { + offs ^=3D (8 - bytes); + } return offs + vec_full_reg_offset(reg); } =20 diff --git a/target/s390x/tcg/translate_vx.c.inc b/target/s390x/tcg/transla= te_vx.c.inc index e073e5ad3aa..f3b4b48ab7b 100644 --- a/target/s390x/tcg/translate_vx.c.inc +++ b/target/s390x/tcg/translate_vx.c.inc @@ -175,9 +175,9 @@ static void get_vec_element_ptr_i64(TCGv_ptr ptr, uint8= _t reg, TCGv_i64 enr, =20 /* convert it to an element offset relative to tcg_env (vec_reg_offset= () */ tcg_gen_shli_i64(tmp, tmp, es); -#if !HOST_BIG_ENDIAN - tcg_gen_xori_i64(tmp, tmp, 8 - NUM_VEC_ELEMENT_BYTES(es)); -#endif + if (!HOST_BIG_ENDIAN) { + tcg_gen_xori_i64(tmp, tmp, 8 - NUM_VEC_ELEMENT_BYTES(es)); + } tcg_gen_addi_i64(tmp, tmp, vec_full_reg_offset(reg)); =20 /* generate the final ptr by adding tcg_env */ --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104199; cv=none; d=zohomail.com; s=zohoarc; b=b42ueQld+e4kuRgNXK4gs8koUWz+blR4FSuZKpAZM1lphUVGCGz7gfH4zy0V2SyvnI9QK3TrzcmTexfNmSABnEK0fgu9qOob2mgDDIPc7eThvuKm9dPQxkoXd6ToyDVybqp53+oMKnvwOTbIyCH/BM0Idg2AGSJKfnh9OwRv9D4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104199; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=SVmBpopuxGyBeEyWAig0HXJ3MlnyOWpUsG2v3Vq569c=; b=elS/5nq42Vg7Y1IyPiRWf8NfgGnwTosTsvzwoDWhiAAOPMdk4vcj53kMmU3hz+mqYpEZ7fxGhoCYn4cMKJh2wAmozrRtWCdAxOjYbsUt/YkECVaJwXOIvG8YfJfmEJbgtF1y2V0bggxMtV5pTq8bmFVjSwmmokmhhSci35RcLls= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104199354676.1775382337346; Fri, 10 Oct 2025 06:49:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DR7-00040w-4S; Fri, 10 Oct 2025 09:45:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DQj-0003WY-I4 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:45:18 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DPi-0008Ij-FS for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:45:09 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-42420c7de22so982534f8f.1 for ; Fri, 10 Oct 2025 06:43:54 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce583424sm4269500f8f.21.2025.10.10.06.43.48 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103830; x=1760708630; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SVmBpopuxGyBeEyWAig0HXJ3MlnyOWpUsG2v3Vq569c=; b=gaJB9s+nCe3ffbsl8FdewdVjXtIqPMDVnOl9p6pL/4O/YhK7rCUa65hjSP4inONDj9 Lo4FRXU/AiR7g1LN8zpUoGAL+tNPK3aVDJ9Ig14yd+m1V+58qMLHD9XnR+rgP8sZQ/p+ OGjfeXnLe3QIB2jm13NJBqkgOcS8RRhVGZsCuWAoEK/MH3Y/iBel3TSOyejGN0nIkkB2 rwoNnOb6+jk7957gwePfo7erz/IYnwEnrL+SGYeDwMEAZOHNF+nH5kGToFYFiUKrP11k lGH73AgAN6xi39gFzPyQSQD22nqxgU0oCvyx16NcKj2poBOmD2ospRZWRo4AXshfWX+n TUzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103830; x=1760708630; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SVmBpopuxGyBeEyWAig0HXJ3MlnyOWpUsG2v3Vq569c=; b=FbfOj1OirAOl4t0RcYxwcyq8zXeHXE1F/k2o5omioN0DCQahWApWfQ75pASDrFxrgK JVDrZq+EMfAj6J5Cgyr90UUEvx8lwvueFk5I3JVD2bcRMRdZoCZ6HsPhRkiVbSevMQkW Uo6w2ExnHRXxJGET5wDigY7CIfREDzgO+makwJ6hN9kAHRLjnlhpiYjPhr6qHXwAza+T K+JpItFZKiQQQCZC2ydBj4cmPnK5T6oSvpshxupt6TzTjtTztoOaXcdLRApjYCbful01 rwDCVMbIUY5osUa90yxdJPMNAz11NGW38tDHS0x20Pp2zbWP/djjJ3maYAtkTvSNQcA3 EkGQ== X-Gm-Message-State: AOJu0YxQj98EVnMMJY1th/+iYG2cUzBU9ujAABmPAm18ydg2Lg+Yz4R2 kfKDT+LZoYC0Om+6BSFIZsUihErhjNDUXvh8z5ymfFUG9dZ8fweNWZYUiej2mM1TLrAmBhSImJZ 8TJVWnGWJIw== X-Gm-Gg: ASbGnculqNZiNCQ1PquEBk+u6JfaGZKyXewcrsm4f8V3hP/4yWkaeqCpcG7foA4FeTQ JuG5wKpSjKob+DYlM2yql5rj9swJmdyugtoJNF4uL2Oe4uVPXelxvhs7isZ6xpSnr0qMIoghTZA S3ooWCGC5ZlF/hWyIlSHG0m67ChBU2VqU0GCQYR+0fwA/gyeyPUilrsi0AiZXNN961Wl5BJZwub RARkTp0Sa9fsB2ZdJNi1IgzbJRizLg+q9eC66BEsWj6Yegxs0AZM9Rvgqp0c09PCcD8iaT/ieUO gUiLxuLUwsAoEe8i/99F+5j1cOGaZOUPQiu2XrTGY8fQvd5FcclJxldN6siGLnaB+mIwbYc/CB1 F6iaOV71dakPeFNBhw8e7abwojRw6TW9ZnQoc2UaJN9hJchho1/BeyjdRTuL4E0p5WomZxh3XOJ lo06Ved+PNm3efla5AeeA= X-Google-Smtp-Source: AGHT+IHpCh4NsTCTnU+KcZ3zDYHCjGYLR69f+unQkVBekBH2DU9Q4LQ9CuvU8MrK4gEZpOyYtcSTdg== X-Received: by 2002:a5d:588b:0:b0:3ee:1368:a8e9 with SMTP id ffacd0b85a97d-4266e7befe4mr7573305f8f.17.1760103830283; Fri, 10 Oct 2025 06:43:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland , Artyom Tarasenko Subject: [PATCH 15/16] target/sparc: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:24 +0200 Message-ID: <20251010134226.72221-16-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104202540154102 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/sparc/vis_helper.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/target/sparc/vis_helper.c b/target/sparc/vis_helper.c index 371f5445a1f..72926dfb7b0 100644 --- a/target/sparc/vis_helper.c +++ b/target/sparc/vis_helper.c @@ -462,15 +462,15 @@ uint64_t helper_bshuffle(uint64_t gsr, uint64_t src1,= uint64_t src2) uint32_t i, mask, host; =20 /* Set up S such that we can index across all of the bytes. */ -#if HOST_BIG_ENDIAN - s.ll[0] =3D src1; - s.ll[1] =3D src2; - host =3D 0; -#else - s.ll[1] =3D src1; - s.ll[0] =3D src2; - host =3D 15; -#endif + if (HOST_BIG_ENDIAN) { + s.ll[0] =3D src1; + s.ll[1] =3D src2; + host =3D 0; + } else { + s.ll[1] =3D src1; + s.ll[0] =3D src2; + host =3D 15; + } mask =3D gsr >> 32; =20 for (i =3D 0; i < 8; ++i) { --=20 2.51.0 From nobody Fri Nov 14 18:17:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1760104096; cv=none; d=zohomail.com; s=zohoarc; b=L0zyl3M8Ocs9drECe0yvYxddOmYqN0nEMVeBam8WDQRRSLlduFeOIz0fXJMJsKmdjv8atVrbeE60VC8aaqDaw/PS2p844m+BNq9uCjDFmY5IRSZwotZRvkltlf0ffqk56YyU8JK5cOsoMV3Ew/EqBCn/efrLKsVlrdkh+LX6m54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1760104096; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vkc03exu55eBo9yCSXwIrehmGU4C40E+gstJ6ZsPFco=; b=j5dLcoO1nHhd7ck6qO2oVXnUKweCDA9bj4YhoWMhZzJEf+8b4ITZ1w5VOQpw2HMVUfzpFNyqwYNtd1TLMigJnA174Y4ZrxOkFwyHkX0nm2y9C0kMi43dwnC702lJbz5dnPX4atDXaZIThmi6qGx9OfcOGXxBsG1AcE1jSkHvu+I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1760104096260604.7847813749529; Fri, 10 Oct 2025 06:48:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v7DQy-0003pG-VJ; Fri, 10 Oct 2025 09:45:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v7DQt-0003ch-Jt for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:45:22 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v7DPj-0008JV-C4 for qemu-devel@nongnu.org; Fri, 10 Oct 2025 09:45:18 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-46e37d6c21eso12417525e9.0 for ; Fri, 10 Oct 2025 06:44:00 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce57d4bbsm4347777f8f.2.2025.10.10.06.43.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 10 Oct 2025 06:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760103835; x=1760708635; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vkc03exu55eBo9yCSXwIrehmGU4C40E+gstJ6ZsPFco=; b=ViYQxAlXIuHm+peN7hK2vZC/MQLY3/HG7I1eqO0yvqYFbe8XPmcozGImxLScoZ9ADy LaJUPH6Mv4MnuPWw+WZXzJQsEj1y3ucvLUTQoFBTUSjGFtFAkIniQXGx2ZEtsRqKUXjr 2Ncj3r41G+KecIaAX8ZFMdoXyMb+PdHSX/ufmibc4TMg+PpPER1xNCtkJnToLUMkf0aq R+UY47vauQzk9vnJPr+LWPPRG2Z0FRvuiY/aqhQ9feMaeed8XIOBoFgY3GysdCQl5hRA JCOJktpe0LTfXACmV5Dx98z2DMCeweV1dJH5bJZyGBLB0qMkbO8vEwNYmdGBSxLhgR/B tj+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760103835; x=1760708635; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vkc03exu55eBo9yCSXwIrehmGU4C40E+gstJ6ZsPFco=; b=ZDtLBzqXNXXNvIU1WU1FOooZGs53hYG3BD2Ehh1uw/1dQ/OqNHxvGAOpXiPPz9VzQY vHsROtcOikOMqG92msRPe1hj4ipXxbdhA4VsRKA/hUYxTWxIPSczlM2dAFPoogSJ0UWJ /zR8ajKg3yHGC1VdxdLQFvq8Me1g3MIRNUGe28BLROmXDQ6ZT/Ve0j/jqu9zD/YlRd44 or7lL9BwUTOYob2NDvqGJOfk7G+VWSDksXlM2O9C/GukHZr3Qn/vF2E15yv5U2gihvhJ Xz/dxb+dIw0vi5CTfZWq61fctzbnGFsnptMYtF9EgWzeIS9n8W+r8Uju26To4Z2AS7BD CPQQ== X-Gm-Message-State: AOJu0YwO0wl+QKafC9DwncLMniHP0Xp3NXpBiE1Aex+iC3l1LBinSFkP Fx1RmWwxNgWO4v9YRWbKfO7VuoelKO7zfH28zL1k5IbaIjZ7SbXXFVVXSQDTChoqRz6Q9cdWlYh NNqDY6C8ulw== X-Gm-Gg: ASbGncvJuZreLI1znG66UI1z9oP+DW7NL36jwTmU/WQJH3J+x+f+aCDWBm8csy/7R7o 4uGC8eJpzhav6EtLFN6ExvVXSjp5NMc8Cn6rHvHCoh++iIw/Qzq2KNDaJo0LunxA4i8vJ9Q2tRX IB9WzYfIn5LyAaPmVZNJg5w7yC3j4JWpQvzK9KAPmHcKmAefzbBbSxrvOvd5iBUzKFzJUnmAnPy Ttm1WOKqoDWLGjQQREEuCGHRHGKUMtoyWEjwdgd6L4iaK9ALLHTZNpbCAJvy/xL2tai/rkFoGL5 hpzwqE5YKmUMePVpAFNNOl4X4RKnFkCXfYCilbAwDLM939a0PWpjZS0XIgUycrgc33AM0AVT4Us ZmisqN0rVd73OZXfg/YD2LJ3i0nYAYgtzTK30CJKCgKVIKcaQnVrn1JqqU/uLOxivjhJF44GdkR 4xMpvciAhdQaGfZKRBdnTXezU/5c1L8w== X-Google-Smtp-Source: AGHT+IE6LY1k+UfqIuVIOh4wE/dwJvXWsQQBI7D27IlvBg6zUbG4pRugCrmKqq6Tynirh0fqhPm1NQ== X-Received: by 2002:a05:600c:37c9:b0:46e:477a:f3dd with SMTP id 5b1f17b1804b1-46fa9b1b18emr83406515e9.36.1760103835401; Fri, 10 Oct 2025 06:43:55 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-arm@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 16/16] util/bitmap: Replace HOST_BIG_ENDIAN #ifdef with runtime if() check Date: Fri, 10 Oct 2025 15:42:25 +0200 Message-ID: <20251010134226.72221-17-philmd@linaro.org> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251010134226.72221-1-philmd@linaro.org> References: <20251010134226.72221-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: 4 X-Spam_score: 0.4 X-Spam_bar: / X-Spam_report: (0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SUSPICIOUS_RECIPS=2.51, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1760104099497154100 Replace compile-time #ifdef with a runtime check to ensure all code paths are built and tested. This reduces build-time configuration complexity and improves maintainability. No functional change intended. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- util/bitmap.c | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/util/bitmap.c b/util/bitmap.c index 8d12e90a5a4..2346159116e 100644 --- a/util/bitmap.c +++ b/util/bitmap.c @@ -421,19 +421,14 @@ static void bitmap_to_from_le(unsigned long *dst, { long len =3D BITS_TO_LONGS(nbits); =20 -#if HOST_BIG_ENDIAN - long index; - - for (index =3D 0; index < len; index++) { -# if HOST_LONG_BITS =3D=3D 64 - dst[index] =3D bswap64(src[index]); -# else - dst[index] =3D bswap32(src[index]); -# endif + if (HOST_BIG_ENDIAN) { + for (long index =3D 0; index < len; index++) { + dst[index] =3D (HOST_LONG_BITS =3D=3D 64) ? bswap64(src[index]) + : bswap32(src[index]); + } + } else { + memcpy(dst, src, len * sizeof(unsigned long)); } -#else - memcpy(dst, src, len * sizeof(unsigned long)); -#endif } =20 void bitmap_from_le(unsigned long *dst, const unsigned long *src, --=20 2.51.0