From nobody Fri Nov 14 23:29:39 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759996514; cv=none; d=zohomail.com; s=zohoarc; b=mJr7ZDKgkDu5lZAG6nEKZXhDZVBlWlmL4h8ER77tUA/3nEa/xBlmOScdSly9yU9+9tqmX9LhKqh/e/6Fy5DlshtTp0zH+R/rmKL7CZKco4IKUOGoXiKcA3gMHwc5VId8H1lzGOzZXjKC5t9LWHeInhuJbnKLZnTUrbDp56f7HDw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759996514; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=F7AoqxUKObbMsXJjOBehknEDHvdGEyjdVUlJubkLvsI=; b=DVItmiommHZYQIjC8/nyUApOw4Zgsl/muUZzqV3KNZIufgn2LrYFOy8j1Ci1hx68JW+wXets/eSYb5dhn0N762ll6GhTonHmeC/n4Mcxi1e4F/BWbRRcu+5gqeDZ0Bh6wSKSyqrGJs1f/bLM1tk8aO6H1arPBWbTJh5iJ8s5wmM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759996514961827.4247435861744; Thu, 9 Oct 2025 00:55:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v6lR5-000053-Or; Thu, 09 Oct 2025 03:51:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6lR1-0008Vj-GP for qemu-devel@nongnu.org; Thu, 09 Oct 2025 03:51:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6lQy-0004SY-JM for qemu-devel@nongnu.org; Thu, 09 Oct 2025 03:51:35 -0400 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-271-TnboVIKqMKyV5Dz06kcjfw-1; Thu, 09 Oct 2025 03:51:28 -0400 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3ee1365964cso632245f8f.2 for ; Thu, 09 Oct 2025 00:51:28 -0700 (PDT) Received: from [192.168.10.48] ([151.95.36.217]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46fab3d2c1asm30928305e9.1.2025.10.09.00.51.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Oct 2025 00:51:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759996289; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F7AoqxUKObbMsXJjOBehknEDHvdGEyjdVUlJubkLvsI=; b=HvSzER380fi8qRycl3XU4ngNv0gMudOHzO/uL4gsoskSFaTyTf230tJDy8p5RCQ8S19p+o hpJL0HqrYVGo/u7t0fqq7UhEqgzX+V7vc2iF1qdxp2MCgI2KhKiVHetpk9BHXB/2Amj12+ jvoZy1pkKjQcTRmKYtqatrnBaijtD0o= X-MC-Unique: TnboVIKqMKyV5Dz06kcjfw-1 X-Mimecast-MFC-AGG-ID: TnboVIKqMKyV5Dz06kcjfw_1759996287 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759996286; x=1760601086; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F7AoqxUKObbMsXJjOBehknEDHvdGEyjdVUlJubkLvsI=; b=QgkY0If3+UhCcbXDrI9Umeqt7Gj2SkPaaOkYqSulv96XHC5Yn4bj296jIeeLp4XXGT krLRj1L2t9IfIbSv8ODW8yu7f0jonSstkJTFlb1nWjWzoJa3/LMN+UYvYipxr3NUeBzk ABSia/pzr7Fw1mNwYcXtMWVERIgGBQpBYcY07AuDvdYBmpJvpF3GKle2HCL06J2Y8eif uFR322DSTupf1/Buk9qV4nraQ08QHpXfqnr6cELT20RL1noT1YJBObXALZR36smg+FWX Y3z0mEeZUCQJDVMTdjPgibwRTpGZ88kZTMGkbeDJl7FVY3RKPNgm8ewBHuWWEwcS+e4/ o4uw== X-Gm-Message-State: AOJu0YzLkI5BtgXCX+fcKBrPP3OLUmKKBcVNe/A9IWIRXEg3OLpWH3ef pYCDjOwJjegHDCWYtDPzD5UPL/Cfu5YadhWyKoW9ALt1q/c+1uJPb8PE3GPjSnzB0YKks9sJ+pU cKrEe5DUoGAW1nVkPs8tVPF9jgJjI1dugaL7auApNSYadYgAKvJGQ7Yu19lfLfdHpo1OiIwU2a9 5/5HZD55LjJ0I1sParSAeykXAcBLykNooivVbGmVspSMU= X-Gm-Gg: ASbGncuEc3S0fCtwHC+Z2/94WbKNDsmnhj1l9hQG1372kGk+ziB5FNHNSde2Nff26Kc g/D/uNDMfr48yxNc2zlqgEoGhx+0lKsw5hGEBIEpluZFB7GlYbuOe2mpp4c4r4qsQa1JrAWD7Ea kQIss3tDXM2syrlyE3dpV3ALDoqua0xse6LuLPyo1wYgzNkQQjhdwUtYwNAMb8i1fgmBGMJIkZH B5dpr+nBNdjkUqJR22x0YnWN18VvIr+bJw3whzWUPWc+qSU39qq9adWyXPr4mccpk0P9SCT5k4b dGevR0sDDsRe/AHr34xPZIdXfDtM8V1pmBGcWt4+9y6c5iFI7DQ299g4YottZOqpeVjiGCi1Weo 8yqkp2DXeZmhZ2s/weQnVd4CWkMQLbvAj1uVRl3wa+ZSmW127 X-Received: by 2002:a05:6000:186a:b0:425:72cd:835e with SMTP id ffacd0b85a97d-4266e7e140amr3544137f8f.37.1759996286387; Thu, 09 Oct 2025 00:51:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJm6sGFZUx8Q+UmW9VWNxeKb8Bi2e6s13YaR4A4Hyq5qiCyvwdC9X7WAl/u8ge5ov0KGoD3Q== X-Received: by 2002:a05:6000:186a:b0:425:72cd:835e with SMTP id ffacd0b85a97d-4266e7e140amr3544117f8f.37.1759996285842; Thu, 09 Oct 2025 00:51:25 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Magnus Kulke Subject: [PULL 26/35] target/i386/mshv: Integrate x86 instruction decoder/emulator Date: Thu, 9 Oct 2025 09:50:16 +0200 Message-ID: <20251009075026.505715-27-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251009075026.505715-1-pbonzini@redhat.com> References: <20251009075026.505715-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759996517911154100 Content-Type: text/plain; charset="utf-8" From: Magnus Kulke Connect the x86 instruction decoder and emulator to the MSHV backend to handle intercepted instructions. This enables software emulation of MMIO operations in MSHV guests. MSHV has a translate_gva hypercall that is used to accessing the physical guest memory. A guest might read from unmapped memory regions (e.g. OVMF will probe 0xfed40000 for a vTPM). In those cases 0xFF bytes is returned instead of aborting the execution. Signed-off-by: Magnus Kulke Link: https://lore.kernel.org/r/20250916164847.77883-21-magnuskulke@linux.m= icrosoft.com [mshv.h/mshv_int.h split. - Paolo] Signed-off-by: Paolo Bonzini --- include/system/mshv_int.h | 4 ++ accel/mshv/mem.c | 65 +++++++++++++++++ target/i386/mshv/mshv-cpu.c | 135 ++++++++++++++++++++++++++++++++++++ 3 files changed, 204 insertions(+) diff --git a/include/system/mshv_int.h b/include/system/mshv_int.h index 66494383134..b29d39911db 100644 --- a/include/system/mshv_int.h +++ b/include/system/mshv_int.h @@ -101,6 +101,10 @@ typedef struct MshvMemoryRegion { bool readonly; } MshvMemoryRegion; =20 +int mshv_guest_mem_read(uint64_t gpa, uint8_t *data, uintptr_t size, + bool is_secure_mode, bool instruction_fetch); +int mshv_guest_mem_write(uint64_t gpa, const uint8_t *data, uintptr_t size, + bool is_secure_mode); void mshv_set_phys_mem(MshvMemoryListener *mml, MemoryRegionSection *secti= on, bool add); =20 diff --git a/accel/mshv/mem.c b/accel/mshv/mem.c index a0a40eb3333..e55c38d4db9 100644 --- a/accel/mshv/mem.c +++ b/accel/mshv/mem.c @@ -59,6 +59,71 @@ static int map_or_unmap(int vm_fd, const MshvMemoryRegio= n *mr, bool map) return set_guest_memory(vm_fd, ®ion); } =20 +static int handle_unmapped_mmio_region_read(uint64_t gpa, uint64_t size, + uint8_t *data) +{ + warn_report("read from unmapped mmio region gpa=3D0x%lx size=3D%lu", g= pa, size); + + if (size =3D=3D 0 || size > 8) { + error_report("invalid size %lu for reading from unmapped mmio regi= on", + size); + return -1; + } + + memset(data, 0xFF, size); + + return 0; +} + +int mshv_guest_mem_read(uint64_t gpa, uint8_t *data, uintptr_t size, + bool is_secure_mode, bool instruction_fetch) +{ + int ret; + MemTxAttrs memattr =3D { .secure =3D is_secure_mode }; + + if (instruction_fetch) { + trace_mshv_insn_fetch(gpa, size); + } else { + trace_mshv_mem_read(gpa, size); + } + + ret =3D address_space_rw(&address_space_memory, gpa, memattr, (void *)= data, + size, false); + if (ret =3D=3D MEMTX_OK) { + return 0; + } + + if (ret =3D=3D MEMTX_DECODE_ERROR) { + return handle_unmapped_mmio_region_read(gpa, size, data); + } + + error_report("failed to read guest memory at 0x%lx", gpa); + return -1; +} + +int mshv_guest_mem_write(uint64_t gpa, const uint8_t *data, uintptr_t size, + bool is_secure_mode) +{ + int ret; + MemTxAttrs memattr =3D { .secure =3D is_secure_mode }; + + trace_mshv_mem_write(gpa, size); + ret =3D address_space_rw(&address_space_memory, gpa, memattr, (void *)= data, + size, true); + if (ret =3D=3D MEMTX_OK) { + return 0; + } + + if (ret =3D=3D MEMTX_DECODE_ERROR) { + warn_report("write to unmapped mmio region gpa=3D0x%lx size=3D%lu"= , gpa, + size); + return 0; + } + + error_report("Failed to write guest memory"); + return -1; +} + static int set_memory(const MshvMemoryRegion *mshv_mr, bool add) { int ret =3D 0; diff --git a/target/i386/mshv/mshv-cpu.c b/target/i386/mshv/mshv-cpu.c index 1f43dfc58ac..424ebdb1228 100644 --- a/target/i386/mshv/mshv-cpu.c +++ b/target/i386/mshv/mshv-cpu.c @@ -104,6 +104,47 @@ static enum hv_register_name FPU_REGISTER_NAMES[26] = =3D { HV_X64_REGISTER_XMM_CONTROL_STATUS, }; =20 +static int translate_gva(const CPUState *cpu, uint64_t gva, uint64_t *gpa, + uint64_t flags) +{ + int ret; + int cpu_fd =3D mshv_vcpufd(cpu); + int vp_index =3D cpu->cpu_index; + + hv_input_translate_virtual_address in =3D { 0 }; + hv_output_translate_virtual_address out =3D { 0 }; + struct mshv_root_hvcall args =3D {0}; + uint64_t gva_page =3D gva >> HV_HYP_PAGE_SHIFT; + + in.vp_index =3D vp_index; + in.control_flags =3D flags; + in.gva_page =3D gva_page; + + /* create the hvcall envelope */ + args.code =3D HVCALL_TRANSLATE_VIRTUAL_ADDRESS; + args.in_sz =3D sizeof(in); + args.in_ptr =3D (uint64_t) ∈ + args.out_sz =3D sizeof(out); + args.out_ptr =3D (uint64_t) &out; + + /* perform the call */ + ret =3D mshv_hvcall(cpu_fd, &args); + if (ret < 0) { + error_report("Failed to invoke gva->gpa translation"); + return -errno; + } + + if (out.translation_result.result_code !=3D HV_TRANSLATE_GVA_SUCCESS) { + error_report("Failed to translate gva (" TARGET_FMT_lx ") to gpa",= gva); + return -1; + } + + *gpa =3D ((out.gpa_page << HV_HYP_PAGE_SHIFT) + | (gva & ~(uint64_t)HV_HYP_PAGE_MASK)); + + return 0; +} + int mshv_set_generic_regs(const CPUState *cpu, const hv_register_assoc *as= socs, size_t n_regs) { @@ -1006,8 +1047,102 @@ int mshv_create_vcpu(int vm_fd, uint8_t vp_index, i= nt *cpu_fd) return 0; } =20 +static int guest_mem_read_with_gva(const CPUState *cpu, uint64_t gva, + uint8_t *data, uintptr_t size, + bool fetch_instruction) +{ + int ret; + uint64_t gpa, flags; + + flags =3D HV_TRANSLATE_GVA_VALIDATE_READ; + ret =3D translate_gva(cpu, gva, &gpa, flags); + if (ret < 0) { + error_report("failed to translate gva to gpa"); + return -1; + } + + ret =3D mshv_guest_mem_read(gpa, data, size, false, fetch_instruction); + if (ret < 0) { + error_report("failed to read from guest memory"); + return -1; + } + + return 0; +} + +static int guest_mem_write_with_gva(const CPUState *cpu, uint64_t gva, + const uint8_t *data, uintptr_t size) +{ + int ret; + uint64_t gpa, flags; + + flags =3D HV_TRANSLATE_GVA_VALIDATE_WRITE; + ret =3D translate_gva(cpu, gva, &gpa, flags); + if (ret < 0) { + error_report("failed to translate gva to gpa"); + return -1; + } + ret =3D mshv_guest_mem_write(gpa, data, size, false); + if (ret < 0) { + error_report("failed to write to guest memory"); + return -1; + } + return 0; +} + +static void write_mem(CPUState *cpu, void *data, target_ulong addr, int by= tes) +{ + if (guest_mem_write_with_gva(cpu, addr, data, bytes) < 0) { + error_report("failed to write memory"); + abort(); + } +} + +static void fetch_instruction(CPUState *cpu, void *data, + target_ulong addr, int bytes) +{ + if (guest_mem_read_with_gva(cpu, addr, data, bytes, true) < 0) { + error_report("failed to fetch instruction"); + abort(); + } +} + +static void read_mem(CPUState *cpu, void *data, target_ulong addr, int byt= es) +{ + if (guest_mem_read_with_gva(cpu, addr, data, bytes, false) < 0) { + error_report("failed to read memory"); + abort(); + } +} + +static void read_segment_descriptor(CPUState *cpu, + struct x86_segment_descriptor *desc, + enum X86Seg seg_idx) +{ + bool ret; + X86CPU *x86_cpu =3D X86_CPU(cpu); + CPUX86State *env =3D &x86_cpu->env; + SegmentCache *seg =3D &env->segs[seg_idx]; + x86_segment_selector sel =3D { .sel =3D seg->selector & 0xFFFF }; + + ret =3D x86_read_segment_descriptor(cpu, desc, sel); + if (ret =3D=3D false) { + error_report("failed to read segment descriptor"); + abort(); + } +} + +static const struct x86_emul_ops mshv_x86_emul_ops =3D { + .fetch_instruction =3D fetch_instruction, + .read_mem =3D read_mem, + .write_mem =3D write_mem, + .read_segment_descriptor =3D read_segment_descriptor, +}; + void mshv_init_mmio_emu(void) { + init_decoder(); + init_emu(&mshv_x86_emul_ops); } =20 void mshv_arch_init_vcpu(CPUState *cpu) --=20 2.51.0