From nobody Fri Nov 14 22:18:07 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759937330; cv=none; d=zohomail.com; s=zohoarc; b=LJv2Mw8SZMMtKJ+Hj7KYYycqmbWrHNCfuF0Q/7PhhIG9GC8mRhYmbF3l/K61t2NdgfyWNj7u3wA9vtCln5G2P2jguLhXqhr5KlcRXJx8WfSHMCtnnsTHvGIi4ywR4GTERyCaU1/kH7pypyvj8oCPJtMoiyiZMfpyGWyrGCxFr88= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759937330; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=lPTPz7XtOk86T3MaOEJikScfofStaNctO3EOk3cjOVY=; b=Bp/iLeb0J2mEksgSVLrj3ICtiUg6IkucV3Ib6hRkCjgKKYQIfcHexsw/VJk2ak6cUPmnmo2NZiaxL9OnJbkAHdkpSCN44MpmFsxG5AIC6vE/nHB4IydKfA9P319jwkSYk2N3rjanhBIxQiqV+Jw6YQAD6m0E6XshPc5xBlDGCAY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759937330619775.8882936394775; Wed, 8 Oct 2025 08:28:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v6W4l-0002PB-64; Wed, 08 Oct 2025 11:27:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6W4i-0002P3-4T for qemu-devel@nongnu.org; Wed, 08 Oct 2025 11:27:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6W4Z-00067u-SN for qemu-devel@nongnu.org; Wed, 08 Oct 2025 11:27:31 -0400 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-EGZpufmUMMOSfFD5HOmdrw-1; Wed, 08 Oct 2025 11:27:05 -0400 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-632c9a9ceb1so8420500a12.0 for ; Wed, 08 Oct 2025 08:27:05 -0700 (PDT) Received: from [192.168.10.48] ([151.95.36.217]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-639f30ad2f3sm220122a12.9.2025.10.08.08.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Oct 2025 08:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759937233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lPTPz7XtOk86T3MaOEJikScfofStaNctO3EOk3cjOVY=; b=Ikpv04KFcmQpAsO8dNTZMvraeJQIvz5RfUIUrvQsmM4HZ06nmTPs44vWMabfusaWcMAa3e tDAaWvsZloUeVAMa9DM+HwXkOsFAV+lSzdTP+S/Q6vS1G71xKKplA8S1EFr4jV6yzmCOCY hrU3Sytq2YlTMurFXD5cYBqddnVWeJs= X-MC-Unique: EGZpufmUMMOSfFD5HOmdrw-1 X-Mimecast-MFC-AGG-ID: EGZpufmUMMOSfFD5HOmdrw_1759937225 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759937224; x=1760542024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lPTPz7XtOk86T3MaOEJikScfofStaNctO3EOk3cjOVY=; b=ZjEvv8IsHnFYmOQ7LKVLSh+Xd7iXAcRULDuKUg9LBXreG2z4U+aaL4GFJ+4v9cZ36z vAVz8H6KGcgWKpvNIP+oaftTawOMqikdyu8P8qd6KBqJ1XNPaaIzBsYscmsoSIT8msM1 AO57XBbhzH+ys3syedx84WvRhfSLCC33Rp2x30NZvDeAeddvfXhwR6JSpceu/uq+8+g5 RDjdW+wWw57CjnbFpzMV7x+mumENmFNMPJxD1m6DIna0qnoTZk+Nx0KopU/GJupBbu7f L7+QHw8DMcaHHOQasagaLcwLiP6+RQ5RCknqE4rG7FgACbxleM6oPp25WR9Da9yE4d2N IZUA== X-Gm-Message-State: AOJu0YxtsdOUlHCgRQNGUnNHh2LpZVlTIMlQMDkbMxLQmO8f/SyL6fqk 6h9ufH0qKh8+NtpF0OMZl56BZpLFAnx2nUOVcXnVmGv5KbUmsURMmV/C1tPI5niyyiJwdZvxSCo LrF2MODyarYuXTquwydlA10spBMeNBbgU+v+4w40jpcqOy9EsA1TB/ibWHP2EYVfepMrE6wuOge ehziQSLoG42+/tU2vt5i4Knz+tAhRdwDyPGi1UlXu4k2o= X-Gm-Gg: ASbGnctwaHQ8BS/yifVfjv/vItauruDMdXKh88CbTtqZyZneTSPQ1JZXlVCa3x4WjCq 23ylyVWZ3YxPi9eMXCYlhr3C9mqXuLBNGmDpBFGqbw6W5o6UwIoWen43fAnHdu6LnXLlr4nePA3 FzZBy1FSM3TjrH6HbhemK9+cSTVLPJnPv7V8PfjUFbgH1S6ihXuGed9yI8vPovY4SlWRZpjO5Qo EA7V/MpGnXz7FAFjruFyLRjIXBTgROX9fC19Pi2LEW3vJ6ehtE9zih4px9711Ck/hE4gI9q/nRD mTP5vh3mI2dkr+0NgO2YFZAZ67PL3S3Embn7MzyeNcW4fN8U/xe6hFho6bvoNfi6/3m+NMF5Nkn iwK4z7DsipYCtUTKqsO+MsHFxNZaDpUIMmV2gLHoJgovlEXIc X-Received: by 2002:a05:6402:b22:b0:634:4d7a:4d94 with SMTP id 4fb4d7f45d1cf-639d5c75dcamr2714935a12.34.1759937223918; Wed, 08 Oct 2025 08:27:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFZWbmRNzJDZFJBTlkb3g22EZWO2wvnt+H2x2GjLXJX43DMgIPEGk5IRF6SUiPapVKnpQucGw== X-Received: by 2002:a05:6402:b22:b0:634:4d7a:4d94 with SMTP id 4fb4d7f45d1cf-639d5c75dcamr2714913a12.34.1759937223559; Wed, 08 Oct 2025 08:27:03 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: armbru@redhat.com Subject: [PATCH] qobject: make refcount atomic Date: Wed, 8 Oct 2025 17:27:01 +0200 Message-ID: <20251008152701.411964-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759937332467154100 Content-Type: text/plain; charset="utf-8" The Rust bindings for QObject will only operate on complete objects, treating them as immutable as long as the Rust QObject is live. With that constraint, it is trivial for Rust code to treat QObjects as thread-safe; all that's needed is to make reference count operations atomic. Do the same when the C code adds or removes references, since we don't really know what the Rust code is up to; of course C code will have to agree with not making changes to the QObjects after they've been passed to Rust code. Signed-off-by: Paolo Bonzini Reviewed-by: Richard Henderson --- include/qobject/qobject.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/qobject/qobject.h b/include/qobject/qobject.h index a6244d0ce00..02f4c6a6eb2 100644 --- a/include/qobject/qobject.h +++ b/include/qobject/qobject.h @@ -32,6 +32,7 @@ #ifndef QOBJECT_H #define QOBJECT_H =20 +#include "qemu/atomic.h" #include "qapi/qapi-builtin-types.h" =20 /* Not for use outside include/qobject/ */ @@ -73,7 +74,7 @@ QEMU_BUILD_BUG_MSG(QTYPE__MAX !=3D 7, static inline void qobject_ref_impl(QObject *obj) { if (obj) { - obj->base.refcnt++; + qatomic_inc(&obj->base.refcnt); } } =20 @@ -95,7 +96,7 @@ void qobject_destroy(QObject *obj); static inline void qobject_unref_impl(QObject *obj) { assert(!obj || obj->base.refcnt); - if (obj && --obj->base.refcnt =3D=3D 0) { + if (obj && qatomic_fetch_dec(&obj->base.refcnt) =3D=3D 1) { qobject_destroy(obj); } } --=20 2.51.0