From nobody Fri Nov 14 22:21:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759847570; cv=none; d=zohomail.com; s=zohoarc; b=c2kQ/oWVZ0Q8kyqpMJrhLMNHm5oePY9LJxbszL9kihO9APKDlWcDKHbk/gMJPzwPC/JrpVuyp0G/ladA+vBaiwVuPT9eEWPyfpl1/xrbRpbMt/qdQ1yebvAU6lYpNMVuuvwLhHrpbq3BtZ5qM7HN5Dy8wjaM/9a5ZK6tuUYH8gE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759847570; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JqmAxJcwf6pRKKSUnF4GWDas5WBlnsLAsYEj/OIjsBc=; b=Hzty2pXC8h9QXTRm4snrO1iqULJKOmTF5JPS6SkBWjSa99d7teypDMo7+xfgIQpuwOW1RwBbU7AoKOd0Wp9Fc4+/bsoMgI0s4ktyR9hj6yhBet2Ut9DWzkaDeESeYFUwKvgCZXC5jl5Fo1swy05teYZsgua7F1KuMDK0ipbXB8Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759847570212541.5447711203009; Tue, 7 Oct 2025 07:32:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v68WL-0003lC-HY; Tue, 07 Oct 2025 10:18:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v68WA-0003c5-0b for qemu-devel@nongnu.org; Tue, 07 Oct 2025 10:18:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v68W0-0003dG-9f for qemu-devel@nongnu.org; Tue, 07 Oct 2025 10:18:11 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-jDjr9vXGNaS-CNTpPZW39w-1; Tue, 07 Oct 2025 10:18:04 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7DBC31872B0C; Tue, 7 Oct 2025 14:17:05 +0000 (UTC) Received: from localhost (unknown [10.2.16.229]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8774B1800452; Tue, 7 Oct 2025 14:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759846685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JqmAxJcwf6pRKKSUnF4GWDas5WBlnsLAsYEj/OIjsBc=; b=BFZfmd/G6DTZvG0jdb3KuXxTNHr/JsJcISD5Rcum8jyHq2GeRBp9b2D0sqNa5mmCFCPlr3 cT3ojl1NVUoikdPayegKPqK0/+PobCSOISY8vJoG+zB3kFGOmHa3+4EdTXfBj8dG2LPRRs OsxfNacgob+TlaqRQgz9hOrEjZjVO/M= X-MC-Unique: jDjr9vXGNaS-CNTpPZW39w-1 X-Mimecast-MFC-AGG-ID: jDjr9vXGNaS-CNTpPZW39w_1759846683 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Jean-Louis Dupond , Vladimir Sementsov-Ogievskiy , Hanna Reitz , Stefan Hajnoczi Subject: [PATCH v2 1/3] file-posix: populate pwrite_zeroes_alignment Date: Tue, 7 Oct 2025 10:16:58 -0400 Message-ID: <20251007141700.71891-2-stefanha@redhat.com> In-Reply-To: <20251007141700.71891-1-stefanha@redhat.com> References: <20251007141700.71891-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.422, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759847571424154100 Content-Type: text/plain; charset="utf-8" Linux block devices require write zeroes alignment whereas files do not. It may come as a surprise that block devices opened in buffered I/O mode require the alignment for write zeroes requests although normal read/write requests do not. Therefore it is necessary to populate the pwrite_zeroes_alignment field. Signed-off-by: Stefan Hajnoczi Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/file-posix.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index 8c738674ce..827ffa77a5 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -1602,6 +1602,22 @@ static void raw_refresh_limits(BlockDriverState *bs,= Error **errp) =20 bs->bl.pdiscard_alignment =3D dalign; } + +#ifdef __linux__ + /* + * Linux requires logical block size alignment for write zeroes ev= en + * when normal reads/writes do not require alignment. + */ + if (!s->needs_alignment) { + ret =3D probe_logical_blocksize(s->fd, + &bs->bl.pwrite_zeroes_alignment); + if (ret < 0) { + error_setg_errno(errp, -ret, + "Failed to probe logical block size"); + return; + } + } +#endif /* __linux__ */ } =20 raw_refresh_zoned_limits(bs, &st, errp); --=20 2.51.0 From nobody Fri Nov 14 22:21:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759846996; cv=none; d=zohomail.com; s=zohoarc; b=eeJdlB2XwMN5s3skrZSvIeSGT3tm4198iJRs+RGUS6uxs0EAiYg0lKpq9uyAfYMm1iS4BssB6aKKODcv4s0MC4e63ddaWhJ679FJYZY9CoAU3bpWm7cz5GTk9NTDmCKoxTVroZ+JBab0ZQOfIC8dpoHm9RPor+sF9z5VQgXKeYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759846996; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ENlFcRQgNbls4QxNgPIhoAoPPfSEdRpUnvkCRsps668=; b=CMSMREUF9QszSe75JKIb1+pVUVWtcmq7Eheqpgs0UjZl/uUF39uV6hFtTX+WZP26sa8qD3JxZ73cPo9afhGnlQrRDU9S2pvI7FxNQePVjCN2wp1Vu61xg1etFEeP7wGOGsTRcc7mctRdTZqIqm+cL4oJQu9s/vLwjMoTut9ZMyo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759846996155121.72443588181443; Tue, 7 Oct 2025 07:23:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v68WS-0004Xr-E2; Tue, 07 Oct 2025 10:18:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v68VX-000368-AD for qemu-devel@nongnu.org; Tue, 07 Oct 2025 10:17:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v68VO-0003Y4-EK for qemu-devel@nongnu.org; Tue, 07 Oct 2025 10:17:39 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-CtRjM73NM02AIF3eIcpRtw-1; Tue, 07 Oct 2025 10:17:20 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 34B9F195AEF1; Tue, 7 Oct 2025 14:17:09 +0000 (UTC) Received: from localhost (unknown [10.2.16.229]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8D30B1955F3E; Tue, 7 Oct 2025 14:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759846648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ENlFcRQgNbls4QxNgPIhoAoPPfSEdRpUnvkCRsps668=; b=Ba+JCI3esRw3FJhwpBgt/RBshXYsfPE2oFIlIUavtW+5daZ0urYIgvjKJSQ6h3GPmx+ShE YVvX9sLk85F+rnbRWe8ul8wrYW+QsZA+01tbre0hS3yJ4W+kCyXcFf5Q2i9hfGqNj+zM3Z mun9Tom7BoEqEXGQnf6tFcPQ5TaLzhE= X-MC-Unique: CtRjM73NM02AIF3eIcpRtw-1 X-Mimecast-MFC-AGG-ID: CtRjM73NM02AIF3eIcpRtw_1759846637 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Jean-Louis Dupond , Vladimir Sementsov-Ogievskiy , Hanna Reitz , Stefan Hajnoczi Subject: [PATCH v2 2/3] block: use pwrite_zeroes_alignment when writing first sector Date: Tue, 7 Oct 2025 10:16:59 -0400 Message-ID: <20251007141700.71891-3-stefanha@redhat.com> In-Reply-To: <20251007141700.71891-1-stefanha@redhat.com> References: <20251007141700.71891-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.422, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759846998768154100 Content-Type: text/plain; charset="utf-8" Since commit 5634622bcb33 ("file-posix: allow BLKZEROOUT with -t writeback"), qemu-img create errors out on a Linux loop block device with a 4 KB sector size: # dd if=3D/dev/zero of=3Dblockfile bs=3D1M count=3D1024 # losetup --sector-size 4096 /dev/loop0 blockfile # qemu-img create -f raw /dev/loop0 1G Formatting '/dev/loop0', fmt=3Draw size=3D1073741824 qemu-img: /dev/loop0: Failed to clear the new image's first sector: Inval= id argument Use the pwrite_zeroes_alignment block limit to avoid misaligned fallocate(2) or ioctl(BLKZEROOUT) in the block/file-posix.c block driver. Fixes: 5634622bcb33 ("file-posix: allow BLKZEROOUT with -t writeback") Reported-by: Jean-Louis Dupond Buglink: https://gitlab.com/qemu-project/qemu/-/issues/3127 Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi --- include/system/block-backend-io.h | 1 + block.c | 3 ++- block/block-backend.c | 11 +++++++++++ 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/include/system/block-backend-io.h b/include/system/block-backe= nd-io.h index ba8dfcc7d0..6d5ac476fc 100644 --- a/include/system/block-backend-io.h +++ b/include/system/block-backend-io.h @@ -116,6 +116,7 @@ BlockAIOCB *blk_abort_aio_request(BlockBackend *blk, void *opaque, int ret); =20 uint32_t blk_get_request_alignment(BlockBackend *blk); +uint32_t blk_get_pwrite_zeroes_alignment(BlockBackend *blk); uint32_t blk_get_max_transfer(BlockBackend *blk); uint64_t blk_get_max_hw_transfer(BlockBackend *blk); =20 diff --git a/block.c b/block.c index 8848e9a7ed..be77e03904 100644 --- a/block.c +++ b/block.c @@ -606,12 +606,13 @@ create_file_fallback_zero_first_sector(BlockBackend *= blk, int64_t current_size, Error **errp) { + uint32_t alignment =3D blk_get_pwrite_zeroes_alignment(blk); int64_t bytes_to_clear; int ret; =20 GLOBAL_STATE_CODE(); =20 - bytes_to_clear =3D MIN(current_size, BDRV_SECTOR_SIZE); + bytes_to_clear =3D MIN(current_size, MAX(BDRV_SECTOR_SIZE, alignment)); if (bytes_to_clear) { ret =3D blk_co_pwrite_zeroes(blk, 0, bytes_to_clear, BDRV_REQ_MAY_= UNMAP); if (ret < 0) { diff --git a/block/block-backend.c b/block/block-backend.c index f8d6ba65c1..239d6eca37 100644 --- a/block/block-backend.c +++ b/block/block-backend.c @@ -2305,6 +2305,17 @@ uint32_t blk_get_request_alignment(BlockBackend *blk) return bs ? bs->bl.request_alignment : BDRV_SECTOR_SIZE; } =20 +/* Returns the optimal write zeroes alignment, in bytes; guaranteed nonzer= o */ +uint32_t blk_get_pwrite_zeroes_alignment(BlockBackend *blk) +{ + BlockDriverState *bs =3D blk_bs(blk); + IO_CODE(); + if (!bs) { + return BDRV_SECTOR_SIZE; + } + return bs->bl.pwrite_zeroes_alignment ?: bs->bl.request_alignment; +} + /* Returns the maximum hardware transfer length, in bytes; guaranteed nonz= ero */ uint64_t blk_get_max_hw_transfer(BlockBackend *blk) { --=20 2.51.0 From nobody Fri Nov 14 22:21:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759847642; cv=none; d=zohomail.com; s=zohoarc; b=n/9yG3PIQ+n3QAvwrXLPidBdw2hMQ4ORrGS38pAOK6CEI+ewyxlC/wbJ+jKxGVCv2vLrjswupQdfEfzigwVlLooNGyT3ZMBCQaNGwo4nuXQXH2RJ59AcPyTRcAfTp4Q370OHcwr8VntoOEfC/h10hOAO6MLsYse5A7Aw/yxiMWw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759847642; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vkj8Y8HGC5BdazHkziF8Ypl9wP8rIPQNT0W0slOVMZw=; b=TTjhW/z5h/cyBcaxmDCFEWLH18WND4rvm4S1+JtKE2mw6ETisC11noWMEfA2Tlv2PHvd2cKGHVjQ7sbjvQ857TeXZaKovqmwIB70d7hBRaaJswtw6PWHRajZkMlme7N11arXuiphdlOITsx9yfhJGRHaBLyeNRIpmG3Cbm+NZ54= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759847642593113.05445904590749; Tue, 7 Oct 2025 07:34:02 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v68WX-0004yH-6q; Tue, 07 Oct 2025 10:18:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v68Vc-00039j-2X for qemu-devel@nongnu.org; Tue, 07 Oct 2025 10:17:45 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v68VP-0003Xl-BE for qemu-devel@nongnu.org; Tue, 07 Oct 2025 10:17:42 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-oy-KKaMNPneE7D7lrM2SdA-1; Tue, 07 Oct 2025 10:17:22 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5695A1955D99; Tue, 7 Oct 2025 14:17:11 +0000 (UTC) Received: from localhost (unknown [10.2.16.229]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A91A43001FF6; Tue, 7 Oct 2025 14:17:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759846646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vkj8Y8HGC5BdazHkziF8Ypl9wP8rIPQNT0W0slOVMZw=; b=X3nqkiRcE1biNhyVcysf6a47rc2TfusgtBj2beC7Vo+fGugOtjQ31Ozkb3i+Ke1DlvywRH 6fvjb0jBLtknX0s+aBFYaOyQI1iFFMiRJLB64stciO20NFjrj3gJ4ACoLm9LPNSD5IrUEP I7pcmBfls6nZHe0idDfp1fifAf/+FNA= X-MC-Unique: oy-KKaMNPneE7D7lrM2SdA-1 X-Mimecast-MFC-AGG-ID: oy-KKaMNPneE7D7lrM2SdA_1759846640 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, Kevin Wolf , Jean-Louis Dupond , Vladimir Sementsov-Ogievskiy , Hanna Reitz , Stefan Hajnoczi Subject: [PATCH v2 3/3] iotests: add Linux loop device image creation test Date: Tue, 7 Oct 2025 10:17:00 -0400 Message-ID: <20251007141700.71891-4-stefanha@redhat.com> In-Reply-To: <20251007141700.71891-1-stefanha@redhat.com> References: <20251007141700.71891-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.422, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759847643963154100 Content-Type: text/plain; charset="utf-8" This qemu-iotests test case is based on the reproducer that Jean-Louis Dupond shared in https://gitlab.com/qemu-project/qemu/-/issues/3127. Signed-off-by: Stefan Hajnoczi Reviewed-by: Vladimir Sementsov-Ogievskiy Tested-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/loop-create-file | 59 +++++++++++++++++++ tests/qemu-iotests/tests/loop-create-file.out | 8 +++ 2 files changed, 67 insertions(+) create mode 100755 tests/qemu-iotests/tests/loop-create-file create mode 100644 tests/qemu-iotests/tests/loop-create-file.out diff --git a/tests/qemu-iotests/tests/loop-create-file b/tests/qemu-iotests= /tests/loop-create-file new file mode 100755 index 0000000000..5ec75b046b --- /dev/null +++ b/tests/qemu-iotests/tests/loop-create-file @@ -0,0 +1,59 @@ +#!/usr/bin/env bash +# group: quick +# +# SPDX-License-Identifier: GPL-2.0-or-later +# +# Copyright Red Hat, Inc. +# +# Test Linux loop device image creation +# +# This test verifies #3127 "qemu-img create fails on loop device with sect= or size 4096" +# https://gitlab.com/qemu-project/qemu/-/issues/3127 + +seq=3D"$(basename $0)" +echo "QA output created by $seq" + +status=3D1 # failure is the default! + +_cleanup() { + if [ -n "$loopdev" ]; then + sudo losetup --detach "$loopdev" + fi + + _cleanup_test_img +} + +trap "_cleanup; exit \$status" 0 1 2 3 15 + +# get standard environment, filters and checks +cd .. +. ./common.rc +. ./common.filter + +_supported_fmt raw +_supported_proto file +_supported_os Linux + +if ! sudo -n losetup &>/dev/null; then + _notrun "sudo losetup not available" +fi + +echo +echo "=3D=3D=3D Create image on a 4 KB sector size loop device =3D=3D=3D" +echo + +_make_test_img -f $IMGFMT 1M + +loopdev=3D$(sudo losetup --sector-size 4096 --find --show "$TEST_IMG") +if [ -z "$loopdev" ]; then + _fail +fi + +sudo $QEMU_IMG_PROG create -f raw "$loopdev" 1M | \ + sed -e "s#/dev/loop[0-9]\\+#LOOPDEV#g" + +# success, all done +echo +echo '*** done' +rm -f $seq.full +status=3D0 diff --git a/tests/qemu-iotests/tests/loop-create-file.out b/tests/qemu-iot= ests/tests/loop-create-file.out new file mode 100644 index 0000000000..32d4155695 --- /dev/null +++ b/tests/qemu-iotests/tests/loop-create-file.out @@ -0,0 +1,8 @@ +QA output created by loop-create-file + +=3D=3D=3D Create image on a 4 KB sector size loop device =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +Formatting 'LOOPDEV', fmt=3Draw size=3D1048576 + +*** done --=20 2.51.0