From nobody Mon Oct 27 01:08:13 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1759462209; cv=none; d=zohomail.com; s=zohoarc; b=OvoKNTFpln09kqSZ5iwbors6z92A4X+DyhkNG+uhbkhj0zseZCs/N2JnpVtfL7tRlNyHTNp+mjMPJbNIj+ghLqIDLV6Fb93NuvhZLLvBxvzk9XXpiu/39EF/m36ekIbAwhHVMROL+ZuVsL/jQChJI/ZtjnDs377x/lm1kuFDsYc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759462209; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bzgt9NMsG+zsoSzpM68SGiuLVbfJh0cCb3ctQE5Gzr8=; b=iAqdx4XGzQQM1oU9mGFdmPES3nuwAu2F6iRYh3YSo1cFc3ADiPGRJG4Zq0jAkCmFgyOQDAkkg9SqTFHskINqo6+lVDxhyC/FS0jc3zm4OMkseSbYrypI5fXG3GourEhvbSvfzgpmt3ol/AqUT5l4FdPIm41oBlC3fKDOiy593R0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759462209905940.745937476776; Thu, 2 Oct 2025 20:30:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4WT7-00073a-La; Thu, 02 Oct 2025 23:28:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4WSz-00072H-EL for qemu-devel@nongnu.org; Thu, 02 Oct 2025 23:28:21 -0400 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1v4WSq-0001Cn-NB for qemu-devel@nongnu.org; Thu, 02 Oct 2025 23:28:20 -0400 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-33274fcf5c1so1847646a91.1 for ; Thu, 02 Oct 2025 20:28:07 -0700 (PDT) Received: from toolbx.alistair23.me (2403-580b-97e8-0-82ce-f179-8a79-69f4.ip6.aussiebb.net. [2403:580b:97e8:0:82ce:f179:8a79:69f4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b62ce55205csm844202a12.18.2025.10.02.20.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Oct 2025 20:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759462084; x=1760066884; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bzgt9NMsG+zsoSzpM68SGiuLVbfJh0cCb3ctQE5Gzr8=; b=Elop+4vRmKKo5jiYsQ+2pe4h1d2yK47qZgskTX9WFygz3Tk0/gmyswHKuDb1GytUfb pbkjcKx9FW7gymPZUc5fMsMuhqChyH614zqCgsWzsAnuXYiMjG9GVPmWN6S2Rgb5JoDw URaxvdeqexBTFZEiJlfTW1x3j/1SpNsZDV62Rqk/oRC2Zwe8fzCKeZUoXHbdC7qnzaLm u1/pFOyMHrzyqUxfzlXTzklkuNJH5vpGRiKe/dwe4i9KpZtOmswppT9WClkoZXXmwR2l /wx4YV+WUxV2h36Z5TAOFAnB/gYW4jrBSSJf8fgad52oHsrr82/peX+P9+BOMc5i1pKc 5obg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759462084; x=1760066884; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bzgt9NMsG+zsoSzpM68SGiuLVbfJh0cCb3ctQE5Gzr8=; b=vMyWSvCzKqZtfC4/ANTAAXuKOgi+xVdNpKxbU4N9ztEbcZSFHbO42QzLNHozhOpT4a K5q1R1i/jAP/uYM3M/Nt/1q87wOL6DqMQJXqdliwi+OPQVoaXWbU3uXs9wtAb1J4TB1Z ewjAVmhRkohmF+v4NLLpE63Jin+cC8W/ItwR/Ib/S/9DFvcmVT6qPvmJvAMlP+iO8u9c Tj6yfJS2EwmRSiYBTFUC7D+4OEvLMJunPBjEGFAGcc/6TGudUAc45afAnJyfMtMA1FMd X5gSZlG1uUc1h9m7hNsTwKRmoDYm2M8Q1pZ+vVCncUxF3jpjMP6nO8JavOfEk3NP2gdh Vt0A== X-Gm-Message-State: AOJu0YyrrmjXuQAO7q3g8N1FRnj9qUtSdSGI3opVTuv+lW+79Sm4IR1H +KUVUPphskjqoLC9bwO7bHCxiikG3C2XPSLL0bp8AyLBmKXASxHrznbqWgaU7g== X-Gm-Gg: ASbGncs9Jut4hrDYrNlvH8DcBL6PkgCZqeGUWrPxRqBVSLuhXw8WOWhD8Pwu5A8pYLT J0JGPpimYLGDJ98vJbCB5JH2BGXW//HYk7xMtd76eW9cR8C0Cml+zIuc5FKZsByyuRHyIubMaeL //aK40e2WLeLZflz3ij91xGYJ0Qf2WjkYzk71xMG/VNOdwvd/PVNjRiwgUSzuwewNvBZ6Ayrt/D sIsOxsT73HIuYhT7SWgRU2h2uhC1f37VCXOuztOB3M0qTTwnrkx3BNCeDFt8ALqo7Le5F8gmkob Mx4pG9CU6YRZ1EdFOGYOV/9F7O1jufTD18SAvlrfMecpdSbXnMte62s3JtecyD8X987yc8qtYff 64jZoZXa2gxtRh9twwy9XQ0QFP21HNu948zbxj4moO2ZHZyjL3Xylc/YtEiDRNNVFg6ycKhRw8T kbhgNe0oeuu53yym8OpGZnHYBH9o0eWkkN+7I4dJgv/9K1SPQsZwZi X-Google-Smtp-Source: AGHT+IFCrhFlfX0dY5qYuBN2wY9afvbdyT2wTJ7F9eqcIYjm2SXNVsbY+5VMtg4Nq6ldX9sByQpr1g== X-Received: by 2002:a17:90b:3509:b0:32e:7270:94a1 with SMTP id 98e67ed59e1d1-339c278e605mr1887820a91.17.1759462084133; Thu, 02 Oct 2025 20:28:04 -0700 (PDT) From: alistair23@gmail.com X-Google-Original-From: alistair.francis@wdc.com To: qemu-devel@nongnu.org Cc: alistair23@gmail.com, Frank Chang , Alistair Francis Subject: [PULL 08/26] hw/char: sifive_uart: Remove outdated comment about Tx FIFO Date: Fri, 3 Oct 2025 13:27:00 +1000 Message-ID: <20251003032718.1324734-9-alistair.francis@wdc.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20251003032718.1324734-1-alistair.francis@wdc.com> References: <20251003032718.1324734-1-alistair.francis@wdc.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::1032; envelope-from=alistair23@gmail.com; helo=mail-pj1-x1032.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1759462211359116600 Content-Type: text/plain; charset="utf-8" From: Frank Chang Since Tx FIFO is now implemented using "qemu/fifo8.h", remove the comment that no longer reflects the current implementation. Signed-off-by: Frank Chang Reviewed-by: Alistair Francis Message-ID: <20250911160647.5710-4-frank.chang@sifive.com> Signed-off-by: Alistair Francis --- hw/char/sifive_uart.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/char/sifive_uart.c b/hw/char/sifive_uart.c index 401f869680..baef0bd9c2 100644 --- a/hw/char/sifive_uart.c +++ b/hw/char/sifive_uart.c @@ -28,12 +28,6 @@ =20 #define TX_INTERRUPT_TRIGGER_DELAY_NS 100 =20 -/* - * Not yet implemented: - * - * Transmit FIFO using "qemu/fifo8.h" - */ - /* Returns the state of the IP (interrupt pending) register */ static uint32_t sifive_uart_ip(SiFiveUARTState *s) { --=20 2.51.0