From nobody Fri Nov 14 22:21:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759242406; cv=none; d=zohomail.com; s=zohoarc; b=Jqe4+M/rt/ad0hO0yUSsEhGTigxBni2tkGk3QV2IOk+wlbyYqpKFc0n7xLSCQ8zHf9S3NhfXfaexNyFBkGpXA/+xeleL5k52TaTKIkvxIuS9w5ho2pqYxjKdtg76R0CCUALkw7NXoIplER0M2kiHit82CEoCC+A5zxNmPUuVcro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759242406; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tZ5Ysy5aelVtvjkhbK4uZaQ/sQIniAcLB7CInUkiE84=; b=hn/QAvHR7CdTiRdnvzqk62vF3ms+Z/X7VmJr/bOAlDp8Dlvv6lDPSTkKcuGOihQCI0PHJU2ZP+sv2bNgOVaVkwxgRp+m2YfQu2KJRuzxcfuusPPHpSrJzMGPx/QuDuFGkY1h6p/nU1yHmc4YY5RdPO4Nwmkhpvx7vOaj/Ly/hF0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759242406320696.3566981261423; Tue, 30 Sep 2025 07:26:46 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3bIE-0003WH-Kp; Tue, 30 Sep 2025 10:25:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3bIC-0003Vm-If for qemu-devel@nongnu.org; Tue, 30 Sep 2025 10:25:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3bHx-0003Ba-S7 for qemu-devel@nongnu.org; Tue, 30 Sep 2025 10:25:24 -0400 Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-154-SZHfD-14PdOscC5W_VoyaA-1; Tue, 30 Sep 2025 10:24:57 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4BF62195605B; Tue, 30 Sep 2025 14:24:55 +0000 (UTC) Received: from corto.redhat.com (unknown [10.44.32.27]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 00B581801420; Tue, 30 Sep 2025 14:24:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759242303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tZ5Ysy5aelVtvjkhbK4uZaQ/sQIniAcLB7CInUkiE84=; b=XHdGasTka0q5wR+4G6P0dxSWKElMhVSJRkXYQo5LeXpigWGICCgJBMqrZEkY5dhIpq2KJu o1Hs9YUZakrQcaLQVgF9WN68tDZCOVUbd3keZ/a8GGi/ROlAYsq2tyC16XuIhHWgkP4PJ0 FlEwU3l9TDeEzldtDPYFvE5344DmSGQ= X-MC-Unique: SZHfD-14PdOscC5W_VoyaA-1 X-Mimecast-MFC-AGG-ID: SZHfD-14PdOscC5W_VoyaA_1759242296 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org, qemu-arm@nongnu.org Cc: Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH] aspeed: Set 'auto_create_sdcard' to false Date: Tue, 30 Sep 2025 16:24:48 +0200 Message-ID: <20250930142448.1030476-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759242408594116600 Don't create a default SD card device at init time. Cc: Philippe Mathieu-Daud=C3=A9 Fixes: cdc8d7cadaac ("hw/boards: Rename no_sdcard -> auto_create_sdcard") Signed-off-by: C=C3=A9dric Le Goater --- hw/arm/aspeed.c | 44 ++++++++++++++++++++++---------------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index a3659ffea475..0d1f043ac214 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -1450,7 +1450,7 @@ static void aspeed_machine_palmetto_class_init(Object= Class *oc, amc->spi_model =3D "mx25l25635f"; amc->num_cs =3D 1; amc->i2c_init =3D palmetto_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 256 * MiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1468,7 +1468,7 @@ static void aspeed_machine_quanta_q71l_class_init(Obj= ectClass *oc, amc->spi_model =3D "mx25l25635e"; amc->num_cs =3D 1; amc->i2c_init =3D quanta_q71l_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 128 * MiB; aspeed_machine_class_init_cpus_defaults(mc); } @@ -1487,7 +1487,7 @@ static void aspeed_machine_supermicrox11_bmc_class_in= it(ObjectClass *oc, amc->num_cs =3D 1; amc->macs_mask =3D ASPEED_MAC0_ON | ASPEED_MAC1_ON; amc->i2c_init =3D palmetto_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 256 * MiB; aspeed_machine_class_init_cpus_defaults(mc); } @@ -1506,7 +1506,7 @@ static void aspeed_machine_supermicro_x11spi_bmc_clas= s_init(ObjectClass *oc, amc->num_cs =3D 1; amc->macs_mask =3D ASPEED_MAC0_ON | ASPEED_MAC1_ON; amc->i2c_init =3D palmetto_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 512 * MiB; aspeed_machine_class_init_cpus_defaults(mc); } @@ -1524,7 +1524,7 @@ static void aspeed_machine_ast2500_evb_class_init(Obj= ectClass *oc, amc->spi_model =3D "mx25l25635f"; amc->num_cs =3D 1; amc->i2c_init =3D ast2500_evb_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 512 * MiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1543,7 +1543,7 @@ static void aspeed_machine_yosemitev2_class_init(Obje= ctClass *oc, amc->spi_model =3D "mx25l25635e"; amc->num_cs =3D 2; amc->i2c_init =3D yosemitev2_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 512 * MiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1561,7 +1561,7 @@ static void aspeed_machine_romulus_class_init(ObjectC= lass *oc, amc->spi_model =3D "mx66l1g45g"; amc->num_cs =3D 2; amc->i2c_init =3D romulus_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 512 * MiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1580,7 +1580,7 @@ static void aspeed_machine_tiogapass_class_init(Objec= tClass *oc, amc->spi_model =3D "mx25l25635e"; amc->num_cs =3D 2; amc->i2c_init =3D tiogapass_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 1 * GiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1598,7 +1598,7 @@ static void aspeed_machine_sonorapass_class_init(Obje= ctClass *oc, amc->spi_model =3D "mx66l1g45g"; amc->num_cs =3D 2; amc->i2c_init =3D sonorapass_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 512 * MiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1616,7 +1616,7 @@ static void aspeed_machine_witherspoon_class_init(Obj= ectClass *oc, amc->spi_model =3D "mx66l1g45g"; amc->num_cs =3D 2; amc->i2c_init =3D witherspoon_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 512 * MiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1638,7 +1638,7 @@ static void aspeed_machine_ast2600_evb_class_init(Obj= ectClass *oc, ASPEED_MAC3_ON; amc->sdhci_wp_inverted =3D true; amc->i2c_init =3D ast2600_evb_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 1 * GiB; aspeed_machine_class_init_cpus_defaults(mc); aspeed_machine_ast2600_class_emmc_init(oc); @@ -1657,7 +1657,7 @@ static void aspeed_machine_g220a_class_init(ObjectCla= ss *oc, const void *data) amc->num_cs =3D 2; amc->macs_mask =3D ASPEED_MAC0_ON | ASPEED_MAC1_ON; amc->i2c_init =3D g220a_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 1024 * MiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1676,7 +1676,7 @@ static void aspeed_machine_fp5280g2_class_init(Object= Class *oc, amc->num_cs =3D 2; amc->macs_mask =3D ASPEED_MAC0_ON | ASPEED_MAC1_ON; amc->i2c_init =3D fp5280g2_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 512 * MiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1695,7 +1695,7 @@ static void aspeed_machine_rainier_class_init(ObjectC= lass *oc, const void *data) amc->num_cs =3D 2; amc->macs_mask =3D ASPEED_MAC2_ON | ASPEED_MAC3_ON; amc->i2c_init =3D rainier_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 1 * GiB; aspeed_machine_class_init_cpus_defaults(mc); aspeed_machine_ast2600_class_emmc_init(oc); @@ -1718,7 +1718,7 @@ static void aspeed_machine_fuji_class_init(ObjectClas= s *oc, const void *data) amc->macs_mask =3D ASPEED_MAC3_ON; amc->i2c_init =3D fuji_bmc_i2c_init; amc->uart_default =3D ASPEED_DEV_UART1; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D FUJI_BMC_RAM_SIZE; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -1740,7 +1740,7 @@ static void aspeed_machine_bletchley_class_init(Objec= tClass *oc, amc->num_cs =3D 2; amc->macs_mask =3D ASPEED_MAC2_ON; amc->i2c_init =3D bletchley_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D BLETCHLEY_BMC_RAM_SIZE; aspeed_machine_class_init_cpus_defaults(mc); } @@ -1760,7 +1760,7 @@ static void aspeed_machine_catalina_class_init(Object= Class *oc, amc->num_cs =3D 2; amc->macs_mask =3D ASPEED_MAC2_ON; amc->i2c_init =3D catalina_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D CATALINA_BMC_RAM_SIZE; aspeed_machine_class_init_cpus_defaults(mc); aspeed_machine_ast2600_class_emmc_init(oc); @@ -1828,7 +1828,7 @@ static void aspeed_machine_fby35_class_init(ObjectCla= ss *oc, const void *data) amc->num_cs =3D 2; amc->macs_mask =3D ASPEED_MAC3_ON; amc->i2c_init =3D fby35_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; /* FIXME: Replace this macro with something more general */ mc->default_ram_size =3D FUJI_BMC_RAM_SIZE; aspeed_machine_class_init_cpus_defaults(mc); @@ -1941,7 +1941,7 @@ static void aspeed_machine_ast2700a0_evb_class_init(O= bjectClass *oc, amc->uart_default =3D ASPEED_DEV_UART12; amc->i2c_init =3D ast2700_evb_i2c_init; amc->vbootrom =3D true; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 1 * GiB; aspeed_machine_class_init_cpus_defaults(mc); } @@ -1964,7 +1964,7 @@ static void aspeed_machine_ast2700a1_evb_class_init(O= bjectClass *oc, amc->uart_default =3D ASPEED_DEV_UART12; amc->i2c_init =3D ast2700_evb_i2c_init; amc->vbootrom =3D true; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 1 * GiB; aspeed_machine_class_init_cpus_defaults(mc); } @@ -1985,7 +1985,7 @@ static void aspeed_machine_qcom_dc_scm_v1_class_init(= ObjectClass *oc, amc->num_cs =3D 2; amc->macs_mask =3D ASPEED_MAC2_ON | ASPEED_MAC3_ON; amc->i2c_init =3D qcom_dc_scm_bmc_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 1 * GiB; aspeed_machine_class_init_cpus_defaults(mc); }; @@ -2005,7 +2005,7 @@ static void aspeed_machine_qcom_firework_class_init(O= bjectClass *oc, amc->num_cs =3D 2; amc->macs_mask =3D ASPEED_MAC2_ON | ASPEED_MAC3_ON; amc->i2c_init =3D qcom_dc_scm_firework_i2c_init; - mc->auto_create_sdcard =3D true; + mc->auto_create_sdcard =3D false; mc->default_ram_size =3D 1 * GiB; aspeed_machine_class_init_cpus_defaults(mc); }; --=20 2.51.0