From nobody Sat Nov 15 00:06:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759236573; cv=none; d=zohomail.com; s=zohoarc; b=BXNZBldrrwyYT3nLutUTkPKIccyaReRTGZ8UbBKohySXNg5lvyN1QYlgKlKDhvh3v4sV8SF91KH5Mlb3nMnGdSBAfE209PRhdsLyxNRfXpMjacSvjAUXH5gJpvT3hEcQGE+m3athz+0ycdPqh/KzW8Ll1tQnNM4SMxsA6Q77/tY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759236573; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NxQ7HlL/3+0kOgFzKID2/HGphiQ5jOudD6XyhN5FxqI=; b=M/6UX4M1/Mda67LrY2V4U2822+zaQOB4nCC+9gy2QAIUbImn51XZ/D7QPEruHzzypRCc6Hry77viqs44krw+Nf4t1IkFj/8UVDjci2t/5PaXpyHtV6kxdcGQV0Wqs5bGnSsMUxhol01cVSR+audKs5hx7HQBF2UQY2DVvDHnt2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759236573271921.9271812210765; Tue, 30 Sep 2025 05:49:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3ZlX-00086O-0c; Tue, 30 Sep 2025 08:47:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3ZlV-00085y-Pg for qemu-devel@nongnu.org; Tue, 30 Sep 2025 08:47:33 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3ZlH-0002QF-K3 for qemu-devel@nongnu.org; Tue, 30 Sep 2025 08:47:33 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-639-Vi9WFDiiOKqfJwJbtriwfQ-1; Tue, 30 Sep 2025 08:47:11 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 848661800630; Tue, 30 Sep 2025 12:47:00 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.45.242.14]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3AF9419560B4; Tue, 30 Sep 2025 12:47:00 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 79F4821E677A; Tue, 30 Sep 2025 14:46:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759236435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NxQ7HlL/3+0kOgFzKID2/HGphiQ5jOudD6XyhN5FxqI=; b=RdXlO9iLMBFflH9i5/aIwSjfQbXsqshQ1bTFBin9SZyWs68WgGc6ryAEi4viGcxvY3CMdE cgby1fcoXONWaFf3uisBkPYxuC8csPOK1xD1oJEAS50HU7Go+f5UHdIhdep91wJFmomOoc XeyWNX9Jg3pEpuWvy1sRsb8tmTgACqc= X-MC-Unique: Vi9WFDiiOKqfJwJbtriwfQ-1 X-Mimecast-MFC-AGG-ID: Vi9WFDiiOKqfJwJbtriwfQ_1759236431 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: richard.henderson@linaro.org, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Akihiko Odaki Subject: [PULL 07/13] ui/spice-core: Clean up error reporting Date: Tue, 30 Sep 2025 14:46:47 +0200 Message-ID: <20250930124653.321609-8-armbru@redhat.com> In-Reply-To: <20250930124653.321609-1-armbru@redhat.com> References: <20250930124653.321609-1-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759236575480116600 watch_add() reports _open_osfhandle() failure with error_setg(&error_warn, ...). error_setg_win32(&error_warn, ...) is undesirable just like error_setg(&error_fatal, ...) and error_setg(&error_abort, ...) are. Replace by warn_report(). The failure should probably be an error, but this function implements a callback that doesn't take Error **. I believe the failure will make spice_server_init() fail in qemu_spice_init(), which is treated as a fatal error. The warning here provides more detail than the error message there. Cc: Marc-Andr=C3=A9 Lureau Signed-off-by: Markus Armbruster Reviewed-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Richard Henderson Message-ID: <20250923091000.3180122-8-armbru@redhat.com> Reviewed-by: Akihiko Odaki --- ui/spice-core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 5992f9daec..7836202664 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -128,11 +128,13 @@ static void watch_update_mask(SpiceWatch *watch, int = event_mask) static SpiceWatch *watch_add(int fd, int event_mask, SpiceWatchFunc func, = void *opaque) { SpiceWatch *watch; - #ifdef WIN32 + g_autofree char *msg =3D NULL; + fd =3D _open_osfhandle(fd, _O_BINARY); if (fd < 0) { - error_setg_win32(&error_warn, WSAGetLastError(), "Couldn't associa= te a FD with the SOCKET"); + msg =3D g_win32_error_message(WSAGetLastError()); + warn_report("Couldn't associate a FD with the SOCKET: %s", msg); return NULL; } #endif --=20 2.49.0