From nobody Sat Nov 15 00:06:32 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759219051; cv=none; d=zohomail.com; s=zohoarc; b=kfLqaYiDS/XHDX+/jBVc8oQEZlb5sxXWq3LhrnCfW4SPsxVMLM5jpQhqLidZP4zK9zHtdidJvSVMqU6x8wNnEMX7M8NOdQT2wsgc2DlyyCPrNPsTA3x+D15X7KGQt61AeLgtjNCL9EK4dCl3LKh8vMvyUxSzRC88UgZqU+etE1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759219051; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wgP5cNBnnT5cOOTVWD7cI42jGEXjOTZ4hnatAD0qlOc=; b=mIvPqgini1WayJTtozw4/xkAKL1MH499/K3S+fQfpbT2UFRdGUtdytKI1gZbjmCrEscAetvKEk3ieYNvz1ZhZAB5tlChvaYetXh/gPG45QS71k9YiQn8BAb0+v7HVQslUy0V8A66S8bs7nx03RSBK3pEZ3GtQL/8yt+MnvHoA/c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175921905130821.535334000514922; Tue, 30 Sep 2025 00:57:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VDw-0001PL-SH; Tue, 30 Sep 2025 03:56:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDv-0001Oy-4G for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDp-0008UG-Lq for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:34 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-MSmP930OM-KP78tdYWHHgA-1; Tue, 30 Sep 2025 03:56:22 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 12ED7180058B; Tue, 30 Sep 2025 07:56:22 +0000 (UTC) Received: from localhost (unknown [10.45.242.7]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B12F91800577; Tue, 30 Sep 2025 07:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759218986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wgP5cNBnnT5cOOTVWD7cI42jGEXjOTZ4hnatAD0qlOc=; b=BsyEF0ZmK7gBtZfA+x4Eg/vSrS3Fk9K9xRSHQsiFw54hjs3lFRq7+KR7l144L17Tcef9fU JYn6THoq96IOorpchR5CvotgBe5dN0Tw/nRcOyLs0EVLgaMS3sAaUyDb1l/0rTgpVfuZDd fXztDQoRsNts2L9Yp8SeyWJtrIhfrgU= X-MC-Unique: MSmP930OM-KP78tdYWHHgA-1 X-Mimecast-MFC-AGG-ID: MSmP930OM-KP78tdYWHHgA_1759218982 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , richard.henderson@linaro.org Subject: [PULL 3/5] ui/spice: fix crash when disabling GL scanout on Date: Tue, 30 Sep 2025 11:55:57 +0400 Message-ID: <20250930075559.133650-4-marcandre.lureau@redhat.com> In-Reply-To: <20250930075559.133650-1-marcandre.lureau@redhat.com> References: <20250930075559.133650-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759219053090116600 From: Marc-Andr=C3=A9 Lureau When spice_qxl_gl_scanout2() isn't available, the fallback code incorrectly handles NULL arguments to disable the scanout, leading to: Program terminated with signal SIGSEGV, Segmentation fault. #0 spice_server_gl_scanout (qxl=3D0x55a25ce57ae8, fd=3D0x0, width=3D0, hei= ght=3D0, offset=3D0x0, stride=3D0x0, num_planes=3D0, format=3D0, modifier= =3D72057594037927935, y_0_top=3D0) at ../ui/spice-display.c:983 983 if (num_planes <=3D 1) { Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D2391334 Fixes: 98a050ca93afd8 ("ui/spice: support multi plane dmabuf scanout") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michael Tokarev Message-Id: <20250903193818.2460914-1-marcandre.lureau@redhat.com> --- ui/spice-display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 669832c561..db71e866f8 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -980,7 +980,9 @@ static void spice_server_gl_scanout(QXLInstance *qxl, spice_qxl_gl_scanout2(qxl, fd, width, height, offset, stride, num_planes, format, modifier, y_0_top); #else - if (num_planes <=3D 1) { + if (fd =3D=3D NULL) { + spice_qxl_gl_scanout(qxl, -1, 0, 0, 0, 0, false); + } else if (num_planes <=3D 1) { spice_qxl_gl_scanout(qxl, fd[0], width, height, stride[0], format,= y_0_top); } else { error_report("SPICE server does not support multi plane GL scanout= "); --=20 2.51.0