From nobody Sat Nov 15 00:06:32 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759219041; cv=none; d=zohomail.com; s=zohoarc; b=bGA8BzvJH2Erkx6D0xiWWoJIOSCeQ3gjeefNqb31npsF6WfvGcC9VaarQI292yMkFohvDKSMnq2LNUQR1kET8shF5+oevc4zsBY8q2PxnOhF6cGO6cRqq5xqXxLmJG16vgL8KLVr2454I+jMt6rSEtWG2vSHiYOBOeuZa/0b9vQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759219041; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LjkB89PWVX1IC7C3fDUEfInLrfYkRQWd2iLqemEojOs=; b=Ohs9tnv5EGvmsL2McyteJZpjn4nbQNEUtJIow581xqd9o4GqjUnU1XkjLxEBEwJWSKTatDhdOdg2bmQ4101v5Ud8rZeazLopJfsUSfoi/oy7AOhY18cRnY2ekcTURh+b7Si3CGp6eRGUhugZB0F3t961De4TIy0S0gCliB9GDVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759219041059104.63738702288254; Tue, 30 Sep 2025 00:57:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VDs-0001Of-AI; Tue, 30 Sep 2025 03:56:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDp-0001O5-Lk for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDl-0008Ry-Pq for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:29 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-zkwWLMMeOXKEFYazmJSH5w-1; Tue, 30 Sep 2025 03:56:17 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 236F3180057C; Tue, 30 Sep 2025 07:56:16 +0000 (UTC) Received: from localhost (unknown [10.45.242.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CFC95195608E; Tue, 30 Sep 2025 07:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759218979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LjkB89PWVX1IC7C3fDUEfInLrfYkRQWd2iLqemEojOs=; b=WdRv+Z/yNfNZm/QebvXMMXmqaIGImxZoSrBIOAkGbnfdhM/t9JuFiXnAh9w03DlwFzB4lr vRRiUnB6qVpIgZh0yXehaD3+20UZzSk8l4/jXD6UT87RS57GxMVFcux8WVzErOEUoZpYfW qmzZPAugf1KaDh3fPukxu3ifnQnfXRM= X-MC-Unique: zkwWLMMeOXKEFYazmJSH5w-1 X-Mimecast-MFC-AGG-ID: zkwWLMMeOXKEFYazmJSH5w_1759218976 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , richard.henderson@linaro.org, Mohamed Akram Subject: [PULL 2/5] ui/spice: Fix abort on macOS Date: Tue, 30 Sep 2025 11:55:56 +0400 Message-ID: <20250930075559.133650-3-marcandre.lureau@redhat.com> In-Reply-To: <20250930075559.133650-1-marcandre.lureau@redhat.com> References: <20250930075559.133650-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.513, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759219042770116600 From: Mohamed Akram The check is faulty because the thread variable was assigned in the main thread while the main loop runs in a different thread on macOS. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3070 Signed-off-by: Mohamed Akram Acked-by: Marc-Andr=C3=A9 Lureau Message-ID: --- ui/spice-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 5992f9daec..2645e96ef6 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -50,8 +50,6 @@ static int spice_migration_completed; static int spice_display_is_running; static int spice_have_target_host; =20 -static QemuThread me; - struct SpiceTimer { QEMUTimer *timer; }; @@ -222,7 +220,7 @@ static void channel_event(int event, SpiceChannelEventI= nfo *info) * thread and grab the BQL if so before calling qemu * functions. */ - bool need_lock =3D !qemu_thread_is_self(&me); + bool need_lock =3D !bql_locked(); if (need_lock) { bql_lock(); } @@ -675,8 +673,6 @@ static void qemu_spice_init(void) spice_wan_compression_t wan_compr; bool seamless_migration; =20 - qemu_thread_get_self(&me); - if (!opts) { return; } --=20 2.51.0