From nobody Fri Nov 14 23:29:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759219108; cv=none; d=zohomail.com; s=zohoarc; b=jh4xfpUPsbCNGpW8phsKZJdblC50UZ6IRsy2JBqBbFuOkBVvvbkDJVWtDsN8J1m8Xh3WlllbdfRlYOr3f93+WpeaJSExryuvpaIAdecWZXyKXsAcnd8XfBzH8rYHEeUzCjJa972Gb++opEE9f7lHAPAy6iZqsP5eNLOo9aeqq1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759219108; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QUCZhYT7Ut50WGVttLzCo+1dLTCeRLI0V8KhJgddVEU=; b=P0QuefSSAgQ2z8U7ZOYqtmOYvZpugi3x+GLFMDbtglPDdP9ijkZXR81zoSXdVO3puGMyL409YfDFCoEUl0ZIAB6MxDmND+yBKwumtvV4VzQXWMUQnJiULWXyZviGvw+oEmC2j+/X+LMXtqpSzUupF+IVeYiapRHSMUMwf3lBeEU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759219108797368.2817313870586; Tue, 30 Sep 2025 00:58:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VDs-0001OM-1O; Tue, 30 Sep 2025 03:56:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDp-0001O3-EW for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDf-0008R6-Rs for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:28 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-1X55XWbZMoe4VMsN2mvnWw-1; Tue, 30 Sep 2025 03:56:12 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6404D180057D; Tue, 30 Sep 2025 07:56:10 +0000 (UTC) Received: from localhost (unknown [10.45.242.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E82D2195608E; Tue, 30 Sep 2025 07:56:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759218976; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QUCZhYT7Ut50WGVttLzCo+1dLTCeRLI0V8KhJgddVEU=; b=DdbuPpWJfmzSFwKVIx71MAbW/oFNbB3DqX3u9r+unxiIvZdhcEN1PY44NQzReRGqTAU/fH bR6/fwUBpeb7xLDg9QAmkjqzUzOsyZHhR978AScC1rFHKhlId5L6RvYNIRv9h6/+eGVlfC CVFKsgGcjkeI5xgOmC3NPqxvoOZQ8N4= X-MC-Unique: 1X55XWbZMoe4VMsN2mvnWw-1 X-Mimecast-MFC-AGG-ID: 1X55XWbZMoe4VMsN2mvnWw_1759218970 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , richard.henderson@linaro.org, Weifeng Liu Subject: [PULL 1/5] gtk: Skip drawing if console surface is NULL Date: Tue, 30 Sep 2025 11:55:55 +0400 Message-ID: <20250930075559.133650-2-marcandre.lureau@redhat.com> In-Reply-To: <20250930075559.133650-1-marcandre.lureau@redhat.com> References: <20250930075559.133650-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759219109810116600 From: Weifeng Liu In gtk draw/render callbacks, add an early NULL check for the console surface and skip drawing if it's NULL. Otherwise, attempting to fetch its width and height crash. This change fixes Coverity CID 1610328. In practice, this case wouldn't happen at all because we always install a placeholder surface to the console when there is nothing to display. Resolves: Coverity CID 1610328 Signed-off-by: Weifeng Liu Reviewed-by: Akihiko Odaki Reviewed-by: Marc-Andr=C3=A9 Lureau Message-ID: <20250714141758.10062-1-weifeng.liu.z@gmail.com> --- ui/gtk-egl.c | 5 +---- ui/gtk-gl-area.c | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c index 0b787bea25..ae9239999c 100644 --- a/ui/gtk-egl.c +++ b/ui/gtk-egl.c @@ -72,7 +72,7 @@ void gd_egl_draw(VirtualConsole *vc) #endif int ww, wh, pw, ph, gs; =20 - if (!vc->gfx.gls) { + if (!vc->gfx.gls || !vc->gfx.ds) { return; } =20 @@ -112,9 +112,6 @@ void gd_egl_draw(VirtualConsole *vc) } #endif } else { - if (!vc->gfx.ds) { - return; - } eglMakeCurrent(qemu_egl_display, vc->gfx.esurface, vc->gfx.esurface, vc->gfx.ectx); =20 diff --git a/ui/gtk-gl-area.c b/ui/gtk-gl-area.c index 8151cc413c..05fc38096e 100644 --- a/ui/gtk-gl-area.c +++ b/ui/gtk-gl-area.c @@ -48,7 +48,7 @@ void gd_gl_area_draw(VirtualConsole *vc) int fbw, fbh; int wx_offset, wy_offset; =20 - if (!vc->gfx.gls) { + if (!vc->gfx.gls || !vc->gfx.ds) { return; } =20 @@ -135,9 +135,6 @@ void gd_gl_area_draw(VirtualConsole *vc) } #endif } else { - if (!vc->gfx.ds) { - return; - } gtk_gl_area_make_current(GTK_GL_AREA(vc->gfx.drawing_area)); =20 surface_gl_setup_viewport(vc->gfx.gls, vc->gfx.ds, pw, ph); --=20 2.51.0 From nobody Fri Nov 14 23:29:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759219041; cv=none; d=zohomail.com; s=zohoarc; b=bGA8BzvJH2Erkx6D0xiWWoJIOSCeQ3gjeefNqb31npsF6WfvGcC9VaarQI292yMkFohvDKSMnq2LNUQR1kET8shF5+oevc4zsBY8q2PxnOhF6cGO6cRqq5xqXxLmJG16vgL8KLVr2454I+jMt6rSEtWG2vSHiYOBOeuZa/0b9vQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759219041; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=LjkB89PWVX1IC7C3fDUEfInLrfYkRQWd2iLqemEojOs=; b=Ohs9tnv5EGvmsL2McyteJZpjn4nbQNEUtJIow581xqd9o4GqjUnU1XkjLxEBEwJWSKTatDhdOdg2bmQ4101v5Ud8rZeazLopJfsUSfoi/oy7AOhY18cRnY2ekcTURh+b7Si3CGp6eRGUhugZB0F3t961De4TIy0S0gCliB9GDVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759219041059104.63738702288254; Tue, 30 Sep 2025 00:57:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VDs-0001Of-AI; Tue, 30 Sep 2025 03:56:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDp-0001O5-Lk for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDl-0008Ry-Pq for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:29 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-zkwWLMMeOXKEFYazmJSH5w-1; Tue, 30 Sep 2025 03:56:17 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 236F3180057C; Tue, 30 Sep 2025 07:56:16 +0000 (UTC) Received: from localhost (unknown [10.45.242.7]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CFC95195608E; Tue, 30 Sep 2025 07:56:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759218979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LjkB89PWVX1IC7C3fDUEfInLrfYkRQWd2iLqemEojOs=; b=WdRv+Z/yNfNZm/QebvXMMXmqaIGImxZoSrBIOAkGbnfdhM/t9JuFiXnAh9w03DlwFzB4lr vRRiUnB6qVpIgZh0yXehaD3+20UZzSk8l4/jXD6UT87RS57GxMVFcux8WVzErOEUoZpYfW qmzZPAugf1KaDh3fPukxu3ifnQnfXRM= X-MC-Unique: zkwWLMMeOXKEFYazmJSH5w-1 X-Mimecast-MFC-AGG-ID: zkwWLMMeOXKEFYazmJSH5w_1759218976 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , richard.henderson@linaro.org, Mohamed Akram Subject: [PULL 2/5] ui/spice: Fix abort on macOS Date: Tue, 30 Sep 2025 11:55:56 +0400 Message-ID: <20250930075559.133650-3-marcandre.lureau@redhat.com> In-Reply-To: <20250930075559.133650-1-marcandre.lureau@redhat.com> References: <20250930075559.133650-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.513, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759219042770116600 From: Mohamed Akram The check is faulty because the thread variable was assigned in the main thread while the main loop runs in a different thread on macOS. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3070 Signed-off-by: Mohamed Akram Acked-by: Marc-Andr=C3=A9 Lureau Message-ID: --- ui/spice-core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 5992f9daec..2645e96ef6 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -50,8 +50,6 @@ static int spice_migration_completed; static int spice_display_is_running; static int spice_have_target_host; =20 -static QemuThread me; - struct SpiceTimer { QEMUTimer *timer; }; @@ -222,7 +220,7 @@ static void channel_event(int event, SpiceChannelEventI= nfo *info) * thread and grab the BQL if so before calling qemu * functions. */ - bool need_lock =3D !qemu_thread_is_self(&me); + bool need_lock =3D !bql_locked(); if (need_lock) { bql_lock(); } @@ -675,8 +673,6 @@ static void qemu_spice_init(void) spice_wan_compression_t wan_compr; bool seamless_migration; =20 - qemu_thread_get_self(&me); - if (!opts) { return; } --=20 2.51.0 From nobody Fri Nov 14 23:29:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759219051; cv=none; d=zohomail.com; s=zohoarc; b=kfLqaYiDS/XHDX+/jBVc8oQEZlb5sxXWq3LhrnCfW4SPsxVMLM5jpQhqLidZP4zK9zHtdidJvSVMqU6x8wNnEMX7M8NOdQT2wsgc2DlyyCPrNPsTA3x+D15X7KGQt61AeLgtjNCL9EK4dCl3LKh8vMvyUxSzRC88UgZqU+etE1w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759219051; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=wgP5cNBnnT5cOOTVWD7cI42jGEXjOTZ4hnatAD0qlOc=; b=mIvPqgini1WayJTtozw4/xkAKL1MH499/K3S+fQfpbT2UFRdGUtdytKI1gZbjmCrEscAetvKEk3ieYNvz1ZhZAB5tlChvaYetXh/gPG45QS71k9YiQn8BAb0+v7HVQslUy0V8A66S8bs7nx03RSBK3pEZ3GtQL/8yt+MnvHoA/c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175921905130821.535334000514922; Tue, 30 Sep 2025 00:57:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VDw-0001PL-SH; Tue, 30 Sep 2025 03:56:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDv-0001Oy-4G for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDp-0008UG-Lq for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:34 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-643-MSmP930OM-KP78tdYWHHgA-1; Tue, 30 Sep 2025 03:56:22 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 12ED7180058B; Tue, 30 Sep 2025 07:56:22 +0000 (UTC) Received: from localhost (unknown [10.45.242.7]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id B12F91800577; Tue, 30 Sep 2025 07:56:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759218986; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wgP5cNBnnT5cOOTVWD7cI42jGEXjOTZ4hnatAD0qlOc=; b=BsyEF0ZmK7gBtZfA+x4Eg/vSrS3Fk9K9xRSHQsiFw54hjs3lFRq7+KR7l144L17Tcef9fU JYn6THoq96IOorpchR5CvotgBe5dN0Tw/nRcOyLs0EVLgaMS3sAaUyDb1l/0rTgpVfuZDd fXztDQoRsNts2L9Yp8SeyWJtrIhfrgU= X-MC-Unique: MSmP930OM-KP78tdYWHHgA-1 X-Mimecast-MFC-AGG-ID: MSmP930OM-KP78tdYWHHgA_1759218982 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , richard.henderson@linaro.org Subject: [PULL 3/5] ui/spice: fix crash when disabling GL scanout on Date: Tue, 30 Sep 2025 11:55:57 +0400 Message-ID: <20250930075559.133650-4-marcandre.lureau@redhat.com> In-Reply-To: <20250930075559.133650-1-marcandre.lureau@redhat.com> References: <20250930075559.133650-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759219053090116600 From: Marc-Andr=C3=A9 Lureau When spice_qxl_gl_scanout2() isn't available, the fallback code incorrectly handles NULL arguments to disable the scanout, leading to: Program terminated with signal SIGSEGV, Segmentation fault. #0 spice_server_gl_scanout (qxl=3D0x55a25ce57ae8, fd=3D0x0, width=3D0, hei= ght=3D0, offset=3D0x0, stride=3D0x0, num_planes=3D0, format=3D0, modifier= =3D72057594037927935, y_0_top=3D0) at ../ui/spice-display.c:983 983 if (num_planes <=3D 1) { Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=3D2391334 Fixes: 98a050ca93afd8 ("ui/spice: support multi plane dmabuf scanout") Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michael Tokarev Message-Id: <20250903193818.2460914-1-marcandre.lureau@redhat.com> --- ui/spice-display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ui/spice-display.c b/ui/spice-display.c index 669832c561..db71e866f8 100644 --- a/ui/spice-display.c +++ b/ui/spice-display.c @@ -980,7 +980,9 @@ static void spice_server_gl_scanout(QXLInstance *qxl, spice_qxl_gl_scanout2(qxl, fd, width, height, offset, stride, num_planes, format, modifier, y_0_top); #else - if (num_planes <=3D 1) { + if (fd =3D=3D NULL) { + spice_qxl_gl_scanout(qxl, -1, 0, 0, 0, 0, false); + } else if (num_planes <=3D 1) { spice_qxl_gl_scanout(qxl, fd[0], width, height, stride[0], format,= y_0_top); } else { error_report("SPICE server does not support multi plane GL scanout= "); --=20 2.51.0 From nobody Fri Nov 14 23:29:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759219117; cv=none; d=zohomail.com; s=zohoarc; b=TkfNv2jl3/0y5+MnOpH0Sz8tjV3JDlPOkt5cu1DnVeXooZerPPEqlJz5VpND50OoIY0N+YMlf0vt6JI2DspeX5H2clYjW7Z0GYJnWPZHOzIRNCGOj5KrxBgITPkiwqIl1fJ07mx/MtXOeV9BTWDtQxKruD5bVjLf0OeMiosUZB8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759219117; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Isu/INN+YNWgCJKU+nP4Q4M9LPuirsvX7/Ia8V7mpAs=; b=hA2VZN3MNT++EgND/lTtMPxxKpFq4IDqPMpJ5TxozxpaVF30u2NeBM0ydQBIDhZpqlmWepTd3kbfzruQQiHUh8lc8Ge9ZMgCT5VNvU6PQFQdWhT0UZv3JgTNfDt5wS37ZXLDMd7knXayxogAHk+9mkQJgEKHSxUDTGK7YbFtAEg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759219117807693.4573566324426; Tue, 30 Sep 2025 00:58:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VE2-0001QN-RF; Tue, 30 Sep 2025 03:56:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VE1-0001Pj-DT for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VDu-00005X-2I for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:41 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-Z-EUGq8WPNeaY_8I7bIfew-1; Tue, 30 Sep 2025 03:56:28 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C52E31800290; Tue, 30 Sep 2025 07:56:27 +0000 (UTC) Received: from localhost (unknown [10.45.242.7]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5F9A219560B4; Tue, 30 Sep 2025 07:56:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759218992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Isu/INN+YNWgCJKU+nP4Q4M9LPuirsvX7/Ia8V7mpAs=; b=jKy2bihh+31hhEQDAmgkW3FlEkjjBWmXJnFuTIdPX78pMnpHbUtNTY22F5MAovbYcbAM/g OXYIdgmC39v8iq5i1U8CJmRLEZL6ID1orU4G4ns6/qbq2oSZyg4zfAdCVwekjTwtOjPWkn 5ISrluahcqYjv4PeGj0wcQymdMTZM0s= X-MC-Unique: Z-EUGq8WPNeaY_8I7bIfew-1 X-Mimecast-MFC-AGG-ID: Z-EUGq8WPNeaY_8I7bIfew_1759218988 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , richard.henderson@linaro.org, Nir Lichtman Subject: [PULL 4/5] ui/sdl2: fix reset scaling binding to be consistent with gtk Date: Tue, 30 Sep 2025 11:55:58 +0400 Message-ID: <20250930075559.133650-5-marcandre.lureau@redhat.com> In-Reply-To: <20250930075559.133650-1-marcandre.lureau@redhat.com> References: <20250930075559.133650-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759219120005116601 Content-Type: text/plain; charset="utf-8" From: Nir Lichtman Problem: Currently the reset scaling hotkey is inconsistent between SDL and GTK graphics modes. Solution: Fix SDL to use MOD+0 instead of MOD+u which is in line with GTK and generally more consistent with other apps. This is also related to my previously sent patch fixing the docs. Suggested-by: Gerd Hoffmann Signed-off-by: Nir Lichtman Reviewed-by: Thomas Huth Message-ID: <20250910114929.GA1783677@lichtman.org> --- ui/sdl2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/sdl2.c b/ui/sdl2.c index b00e421f7f..032dc14bc3 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -421,7 +421,7 @@ static void handle_keydown(SDL_Event *ev) sdl_grab_end(scon); } break; - case SDL_SCANCODE_U: + case SDL_SCANCODE_0: sdl2_window_resize(scon); if (!scon->opengl) { /* re-create scon->texture */ --=20 2.51.0 From nobody Fri Nov 14 23:29:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1759219064; cv=none; d=zohomail.com; s=zohoarc; b=NmTlLkujKqANWTSAjuNRj1Izk5Avh+Pb/pV6YHLca4zGFtwnvBGO2gFamCRjRjxFteTQ5St5jzKwcFBq/dQWrlqgJASNr4H6QA8ttqH4Kkxs15P2fjfrzcrdVFVRHJjLlhmhlgfcYTHoQ057FtnGcClD8rAQkYOFbnUoc+8lVsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1759219064; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=akIrrgqDU+mkq0aTbrDzlvUN4d+gVlBPTqawu7KagZQ=; b=jeqRlwZ4feCG8iduhIy4PCEGbDeMDxWeYg2sYD63ZIZ4funyXm/z4i46OCHqRu3eMthZjFFcJRBrIT6XvKhyVXNtWTt+RhMIby1XNCnbPzX+1s53hLmE07L0VT8R8zrxdUVGXHhnUvqQ4RZMPkM0UJTQaYhTRGALoB2t7+4ubss= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1759219064402229.8336989306856; Tue, 30 Sep 2025 00:57:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v3VEB-0001R3-Jc; Tue, 30 Sep 2025 03:56:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VE7-0001Qm-PC for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v3VE1-00007J-LW for qemu-devel@nongnu.org; Tue, 30 Sep 2025 03:56:46 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-DRS6hBcxMu6gCbm3HXXa9g-1; Tue, 30 Sep 2025 03:56:33 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E8EFB1956064; Tue, 30 Sep 2025 07:56:32 +0000 (UTC) Received: from localhost (unknown [10.45.242.7]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id ED68D1800446; Tue, 30 Sep 2025 07:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759218998; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=akIrrgqDU+mkq0aTbrDzlvUN4d+gVlBPTqawu7KagZQ=; b=Aw13ah3o2g6R+AwhNzq3c63s1gCuKucBvhk0NU3rp3fC7nV/o40mEX20Cw/YIGwVkV2aCJ aFoJ1JtUtdEmpSF1Zj36j9RVN7Dh2ooqfDKgc5D3Qmo+shjN4RDppa/We4Sv447t+vjiBV TKimXCzrIcYmR52Jm3TGeOnlPNGi7uo= X-MC-Unique: DRS6hBcxMu6gCbm3HXXa9g-1 X-Mimecast-MFC-AGG-ID: DRS6hBcxMu6gCbm3HXXa9g_1759218993 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , richard.henderson@linaro.org, Thomas Huth Subject: [PULL 5/5] ui/icons/qemu.svg: Add metadata information (author, license) to the logo Date: Tue, 30 Sep 2025 11:55:59 +0400 Message-ID: <20250930075559.133650-6-marcandre.lureau@redhat.com> In-Reply-To: <20250930075559.133650-1-marcandre.lureau@redhat.com> References: <20250930075559.133650-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.513, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1759219065244116600 From: Thomas Huth We've got two versions of the QEMU logo in the repository, one with the whole word "QEMU" (pc-bios/qemu_logo.svg) and one that only contains the letter "Q" (ui/icons/qemu.svg). While qemu_logo.svg contains the proper metadata with license and author information, this is missing from the ui/icons/qemu.svg file. Copy the meta data there so that people have a chance to know the license of the file if they only look at the qemu.svg file. Closes: https://gitlab.com/qemu-project/qemu/-/issues/3139 Signed-off-by: Thomas Huth Reviewed-by: Marc-Andr=C3=A9 Lureau Message-ID: <20250930071419.117592-1-thuth@redhat.com> --- ui/icons/qemu.svg | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/ui/icons/qemu.svg b/ui/icons/qemu.svg index 24ca23a1e9..f2500de339 100644 --- a/ui/icons/qemu.svg +++ b/ui/icons/qemu.svg @@ -918,7 +918,26 @@ image/svg+xml - + Kew the Angry Emu + + + Beno=C3=AEt Canet + + + + + CC BY 3.0 + + + + + QEMU Community + + + 2012-02-15 + + https://lists.gnu.org/archive/html/qemu-devel/2012-02/m= sg02865.html --=20 2.51.0